[GitHub] [commons-crypto] aremily commented on issue #94: Crypto 137 windows compile

aremily commented on issue #94: Crypto 137 windows compile URL: https://github.com/apache/commons-crypto/pull/94#issuecomment-525085354 I checked in my edits. I think I caught everything. I added the console output from the test runs in the different environments to assist with your

[GitHub] [commons-crypto] aremily commented on issue #94: Crypto 137 windows compile

aremily commented on issue #94: Crypto 137 windows compile URL: https://github.com/apache/commons-crypto/pull/94#issuecomment-522283013 Thanks for taking the time to review my PR. I think I addressed all the points you made, although I opted to leave the inline definition comment alone

[GitHub] [commons-crypto] aremily commented on issue #94: Crypto 137 windows compile

aremily commented on issue #94: Crypto 137 windows compile URL: https://github.com/apache/commons-crypto/pull/94#issuecomment-481932191 As you can see from the build history, the testGcmTamperedData() test, which expects an AEADBadTagException, fails intermittently on the Travis Linux