[GitHub] [commons-io] kinow commented on a change in pull request #301: IOUtils use TaggedInputStream instead of ProxyInputStream

[GitBox]

kinow commented on a change in pull request #301:
URL: https://github.com/apache/commons-io/pull/301#discussion_r747903081



##########
File path: src/main/java/org/apache/commons/io/input/AutoCloseInputStream.java
##########
@@ -76,7 +76,7 @@ protected void afterRead(final int n) throws IOException {
      */
     @Override
     public void close() throws IOException {
-        in.close();
+        super.close();

Review comment:
       Right, had a look at the source code, and I think:
   
   - before: `in.close()` (removed above) could throw any `IOException` directly
   - after: `super.close()` will call `ProxyInputStream#close()` which will 
then call `TaggedInputStream#handleIOException` (instead of 
`ProxyInputStream#handleIOException`)
   
   So all good here :+1: 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org