[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance

2021-02-21 Thread GitBox
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-782882822 @garydgregory rebased. please find some time to review. thanks. This is an automated message from the

[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-13 Thread GitBox
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here. I will try to retrigger it. This is an automated

[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-05 Thread GitBox
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-639538491 result json: ``` [ { "jmhVersion" : "1.21", "benchmark" : "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New",

[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-05 Thread GitBox
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-639537791 I refined the test source, and give it a retest. **result:** ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal

[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective

[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to 72 Hour Lazy Consensus rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more functions

[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance

2020-05-31 Thread GitBox
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636539583 also want to split StringUtils.startswith, endwith, prependIfMissing... now the call flow is like this: 1. user call startsWith(final CharSequence str, final