[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-13 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here(for several days already). I will try to retrigger it, using some force-push things.

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-13 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here(for several days already). I will try to retrigger it, using some force-push things. `--` done.

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory **Conclusion:** after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING:

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to `72 Hour Lazy Consensus` rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-05-31 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636539583 also want to split StringUtils.startswith, endwith, prependIfMissing... now the call flow is like this: 1. user call startsWith(final CharSequence str, final