[GitHub] [commons-numbers] aherbert commented on pull request #138: NUMBERS-205: Introduces isZero() to Addition and isOne() to Multiplication

2023-10-01 Thread via GitHub
aherbert commented on PR #138: URL: https://github.com/apache/commons-numbers/pull/138#issuecomment-1742167478 You can get a local coverage report using: ``` mvn test jacoco:report open target/site/jacoco/index.html ``` -- This is an automated message from the Apache Git

[GitHub] [commons-numbers] aherbert commented on pull request #138: NUMBERS-205: Introduces isZero() to Addition and isOne() to Multiplication

2023-09-30 Thread via GitHub
aherbert commented on PR #138: URL: https://github.com/apache/commons-numbers/pull/138#issuecomment-1741858647 Some of the classes should be tested for assertFalse for these new methods. Currently you only test for true so the code coverage is not complete. -- This is an automated

[GitHub] [commons-numbers] aherbert commented on pull request #138: NUMBERS-205: Introduces isZero() to Addition and isOne() to Multiplication

2023-09-30 Thread via GitHub
aherbert commented on PR #138: URL: https://github.com/apache/commons-numbers/pull/138#issuecomment-1741789073 Editing the PR title to include the Jira ticket number usually links automatically. I did this but the link did not create itself immediately (perhaps because the ticket was