[GitHub] [commons-text] XenoAmess commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

XenoAmess commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-848846227 Also, this pr worth a jira ticket. https://issues.apache.org/jira/projects/IO/issues/ -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-text] XenoAmess commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

XenoAmess commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-848835856 There also be some very small problems. But I want you run some performance tests to see if it worthy to refine. see the review. -- This is an automated message

[GitHub] [commons-text] XenoAmess commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

XenoAmess commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-848815825 Hi. Thanks for your pr. The thought is correct, it can save memory from n*m to 2* Math.min(n,m) in this way. As you refined this function, you can refine