Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/285
Thank you for updating the pull request.
Tested locally. Using the changes in the pull request I get the same result
as we get when the settings are in the Maven settings.
Github user osiegmar commented on the issue:
https://github.com/apache/commons-lang/pull/285
> Could you update the pull request with your original change duplicated in
that portion, please?
Done. Thanks for pointing that out!
---
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/285
[](https://coveralls.io/builds/13196430)
Coverage remained the same at 95.201% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/285
[](https://coveralls.io/builds/13196392)
Coverage decreased (-0.001%) to 95.2% when pulling
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/285
>Does it really generates a site for the current branch?
It should. That is one step in the release process. Probably due to the
site using another configuration (under the reporting
Github user osiegmar commented on the issue:
https://github.com/apache/commons-lang/pull/285
I haven't checked the configuration of the maven site plugin in detail.
Does it really generates a site for the current branch? I doubt that, as I've
seen subversion commands in the config...
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/285
Not sure. Here's what I just tried.
```
$ git reset --hard
$ git status
On branch pr/285
$ vim checkstyle.xml
$ # removed line
$ mvn clean site
Github user osiegmar commented on the issue:
https://github.com/apache/commons-lang/pull/285
Removing the SuppressionFilter results in thousands of errors. Maybe you
have a stale checkstyle cache file `target/cachefile`?
---
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/285
Checked out pull request branch, built with the change, got no checkstyle
errors. Then removed the suppression (without re-adding the previous value in
pom.xml) and also got the same result,
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/285
[](https://coveralls.io/builds/13181719)
Coverage remained the same at 95.194% when pulling
10 matches
Mail list logo
