Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99912803
Your placeholder Jira issue is
https://issues.apache.org/jira/browse/LANG-1135. Please create a Jira for
bigger contributions as documented in CONTRIBUTING.md.
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99921440
Hello @eduardomartins-luizalabs,
the following will fail:
```java
assertFalse(WordUtils.containsAllWords(lorem ipsum null dolor sit amet,
Github user eduardomartins-luizalabs commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99940742
Sorry about the JIRA card.
I think it's a great improvement, i will do that.
---
If your project is set up for it, you can reply to this email
GitHub user eduardomartins-luizalabs opened a pull request:
https://github.com/apache/commons-lang/pull/81
DOC: StringUtils.containsAny. ADD: containsAllWords to StringUtils
Checks if the String contains all words.
```java
StringUtils.containsAllWords(lorem ipsum dolor sit
Github user eduardomartins-luizalabs commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99185054
@britter i didn't saw this class, my bad.
Should I send another commit or amend this?
---
If your project is set up for it, you can reply to
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99186498
Usually we make additional commit so that the development of a feature can
be tracked afterwards. Since in this case the commit would change the whole PR,
I think
Github user eduardomartins-luizalabs commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99187699
Ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eduardomartins-luizalabs commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/81#discussion_r29704041
--- Diff:
src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java ---
@@ -16,21 +16,16 @@
*/
package
Github user eduardomartins-luizalabs commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99198225
@britter updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99202424
[](https://coveralls.io/builds/2493010)
Coverage increased (+0.01%) to 93.36% when
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99207396
[](https://coveralls.io/builds/2493019)
Coverage increased (+0.01%) to 93.36% when
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99201966
[](https://coveralls.io/builds/2492985)
Coverage increased (+0.0%) to 93.35% when
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99202623
[](https://coveralls.io/builds/2493014)
Coverage decreased (-0.0%) to 93.35% when
Github user agrava-luizalabs commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/81#discussion_r29700273
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -1685,7 +1685,7 @@ public static boolean containsAny(final CharSequence
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99181116
This would better fit into ```org.apache.commons.lang3.text.WordUtils```,
because it deals with words. I could imagine having a
15 matches
Mail list logo
