[GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...

2015-05-07 Thread coveralls
Github user coveralls commented on the pull request: https://github.com/apache/commons-lang/pull/76#issuecomment-5716 [![Coverage Status](https://coveralls.io/builds/2512304/badge)](https://coveralls.io/builds/2512304) Coverage decreased (-0.04%) to 93.27% when

[GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...

2015-05-07 Thread chonton
Github user chonton commented on the pull request: https://github.com/apache/commons-lang/pull/76#issuecomment-12112 Iterate fast and often. Go forward with it. Chas On May 7, 2015, at 12:17 PM, Benedikt Ritter notificati...@github.com wrote:

[GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...

2015-05-07 Thread britter
Github user britter commented on the pull request: https://github.com/apache/commons-lang/pull/76#issuecomment-99986739 @chonton I've worked some more on this. Renamed the Rule to SystemDefaultsSwitch and wrote a unit test. What do you think about integrating this now and create a

[GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...

2015-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...

2015-05-05 Thread coveralls
Github user coveralls commented on the pull request: https://github.com/apache/commons-lang/pull/76#issuecomment-99328066 [![Coverage Status](https://coveralls.io/builds/2496885/badge)](https://coveralls.io/builds/2496885) Coverage increased (+0.06%) to 93.37% when

[GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...

2015-05-04 Thread chonton
Github user chonton commented on the pull request: https://github.com/apache/commons-lang/pull/76#issuecomment-9878 Overall, I like this approach better than explicit classes. Two items I would like to see: 1. Allow tests to run in parallel. This will probably requires some

[GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...

2015-05-04 Thread britter
Github user britter commented on the pull request: https://github.com/apache/commons-lang/pull/76#issuecomment-98803478 Hello @chonton, very good feedback, thank you! 1. Allow tests to run in parallel. This will probably requires some sort of synchronization to

[GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...

2015-05-03 Thread coveralls
Github user coveralls commented on the pull request: https://github.com/apache/commons-lang/pull/76#issuecomment-98475017 [![Coverage Status](https://coveralls.io/builds/2475426/badge)](https://coveralls.io/builds/2475426) Coverage decreased (-0.01%) to 93.3% when

[GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...

2015-05-03 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/commons-lang/pull/76 LANG-1127: Use JUnit rules to set and reset the default Locale and TimeZone Alternative proposal to fix [LANG-1127](https://issues.apache.org/jira/browse/LANG-1127) using JUnit TestRules.