Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/87
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Lady-Stardust commented on the pull request:
https://github.com/apache/commons-lang/pull/87#issuecomment-103178381
I don't want to be listed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/87#issuecomment-102938770
@Lady-Stardust, what is the name you want to be listed with in
[changes.xml](https://github.com/apache/commons-lang/blob/master/src/changes/changes.xml)?
---
If yo
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/87#issuecomment-102938179
Very nice, I'll have a look later this week!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/87#issuecomment-102210032
[](https://coveralls.io/builds/2568427)
Coverage increased (+0.05%) to 93.32% when pulli
Github user Lady-Stardust commented on the pull request:
https://github.com/apache/commons-lang/pull/87#issuecomment-102209312
Ok I pushes the changes to my fork. I made the changes you said, except for
removing the "Obj" suffix because it wouldn't compile anymore.
---
If your projec
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30207724
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input, fina
Github user Lady-Stardust commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30192062
--- Diff: src/test/java/org/apache/commons/lang3/ValidateTest.java ---
@@ -1015,6 +1708,9 @@ public void testExclusiveBetweenDouble_withMessage()
Github user Lady-Stardust commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30191959
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input
Github user Lady-Stardust commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30191803
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input
Github user Lady-Stardust commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30191540
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30062704
--- Diff: src/test/java/org/apache/commons/lang3/ValidateTest.java ---
@@ -1015,6 +1708,9 @@ public void testExclusiveBetweenDouble_withMessage()
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30062633
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input, fina
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30061992
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input, fina
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30061886
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input, fina
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30061829
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input, fina
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30061767
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input, fina
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30061627
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input, fina
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/87#issuecomment-100986809
Very nice, please see my comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/87#issuecomment-100571794
[](https://coveralls.io/builds/2527183)
Coverage increased (+0.03%) to 93.31% when pulli
GitHub user Lady-Stardust opened a pull request:
https://github.com/apache/commons-lang/pull/87
Lang 1134
LANG-1134
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Lady-Stardust/commons-lang LANG-1134
Alternatively you can review
21 matches
Mail list logo
