[GitHub] commons-lang pull request: ReflectionToStringBuilder doesn't throw...

2015-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-lang pull request: ReflectionToStringBuilder doesn't throw...

2015-05-07 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/85#discussion_r29882172 --- Diff: src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java --- @@ -1041,7 +1041,7 @@ public void test_setUpToClass_invalid() {

[GitHub] commons-lang pull request: ReflectionToStringBuilder doesn't throw...

2015-05-05 Thread coveralls
Github user coveralls commented on the pull request: https://github.com/apache/commons-lang/pull/85#issuecomment-99330681 [![Coverage Status](https://coveralls.io/builds/2496945/badge)](https://coveralls.io/builds/2496945) Coverage increased (+0.0%) to 93.35% when pulling

[GitHub] commons-lang pull request: ReflectionToStringBuilder doesn't throw...

2015-05-05 Thread jacktan1991
Github user jacktan1991 commented on the pull request: https://github.com/apache/commons-lang/pull/85#issuecomment-99330648 Have fixed it. But `ToStringBuilderTest.testReflectionNull` is desigined like ```java @Test(expected=IllegalArgumentException.class) public v

[GitHub] commons-lang pull request: ReflectionToStringBuilder doesn't throw...

2015-05-05 Thread britter
Github user britter commented on the pull request: https://github.com/apache/commons-lang/pull/85#issuecomment-99327946 Please fix test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] commons-lang pull request: ReflectionToStringBuilder doesn't throw...

2015-05-05 Thread jacktan1991
GitHub user jacktan1991 opened a pull request: https://github.com/apache/commons-lang/pull/85 ReflectionToStringBuilder doesn't throw IllegalArgumentException when the constructor's object param is null As described in it's [javadoc](http://commons.apache.org/proper/commons-lang/ja