Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kaiyuanw commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80388060
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user kaiyuanw commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80388061
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user kaiyuanw commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80388046
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user kaiyuanw commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80388001
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user kaiyuanw commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387976
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387226
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387208
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387206
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387223
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387200
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387175
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar() {
//
Github user kaiyuanw commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80362430
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,43 @@ public void testToCalendar() {
//
Github user kaiyuanw commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80362427
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,43 @@ public void testToCalendar() {
//
Github user kaiyuanw commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80362422
--- Diff: src/main/java/org/apache/commons/lang3/time/DateUtils.java ---
@@ -668,6 +668,19 @@ public static Calendar toCalendar(final Date date) {
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80358050
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,43 @@ public void testToCalendar() {
//
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80357986
--- Diff: src/main/java/org/apache/commons/lang3/time/DateUtils.java ---
@@ -668,6 +668,19 @@ public static Calendar toCalendar(final Date date) {
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80358033
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,43 @@ public void testToCalendar() {
//
GitHub user kaiyuanw opened a pull request:
https://github.com/apache/commons-lang/pull/192
Lang 1255: Add DateUtils.toCalendar(Date, TimeZone) and 3 unit tests
Added new toCalendar method in DateUtils with 3 unit tests as proposed in
LANG-1255.
You can merge this pull request
19 matches
Mail list logo
