[ https://issues.apache.org/jira/browse/DBCP-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz closed DBCP-319. ---------------------------- > Make private fields final where possible > ---------------------------------------- > > Key: DBCP-319 > URL: https://issues.apache.org/jira/browse/DBCP-319 > Project: Commons Dbcp > Issue Type: Improvement > Reporter: Sebb > Fix For: 2.0 > > Attachments: DBCP-319-private-final.patch > > > Several private fields could be made final: > AbandonedTrace.config > AbandonedTrace.AbandonedObjectException._createdTime > cpdsadapter.PooledConnectionImpl: > * connection > * delegatingConnection > * eventListeners > * statementEventListeners > * pstmtPool is protected, but could probably be made final if it were not for > the API change that would imply > cpdsadapter.PooledConnectionImpl.PStmtKey (nested class, variables are > protected, but might as well be private) > * all of its fields could be made final > datasources.[Keyed]CPDSConnectionFactory.validatingMap > datasources.[Keyed]CPDSConnectionFactory.pcMap > managed.PoolableManagedConnection.transactionRegistry > managed.PoolableManagedConnectionFactory.transactionRegistry > managed.TransactionRegistry.transactionManager|caches|xaResources > .AbandonedObjectPool.config|trace -- This message was sent by Atlassian JIRA (v6.2#6252)