[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938541#comment-16938541
]
Matt Juntunen commented on GEOMETRY-46:
---
Sounds good to me!
> Additional UnitVect
[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938520#comment-16938520
]
Gilles Sadowski commented on GEOMETRY-46:
-
{quote}Can we merge [...]?
{quote}
Ye
[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938173#comment-16938173
]
Matt Juntunen commented on GEOMETRY-46:
---
{quote}How?
{quote}
The [original VALJO
[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938138#comment-16938138
]
Gilles Sadowski commented on GEOMETRY-46:
-
{quote}breaks ValJO specification
{qu
[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937996#comment-16937996
]
Matt Juntunen commented on GEOMETRY-46:
---
I commented on the usage of {{super}} as
[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937584#comment-16937584
]
Gilles commented on GEOMETRY-46:
Surprised by this use of {{super}}, I couldn't find any
[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937556#comment-16937556
]
Gilles commented on GEOMETRY-46:
In the unit tests, the tolerance should be set to 0 (si
[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937286#comment-16937286
]
Matt Juntunen commented on GEOMETRY-46:
---
This PR is ready to go.
> Additional Uni
[
https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937269#comment-16937269
]
Matt Juntunen commented on GEOMETRY-46:
---
I added some small comments in github on
