[jira] [Commented] (IO-811) Files.walk() direct and indirect callers fail to close the returned Stream

2023-10-02 Thread Adam Rauch (Jira)
[ https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771257#comment-17771257 ] Adam Rauch commented on IO-811: --- Everything looks good to me. Thanks for making the changes!  FWIW: I think

[jira] [Commented] (IO-811) Files.walk() direct and indirect callers fail to close the returned Stream

2023-10-02 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771073#comment-17771073 ] Gary D. Gregory commented on IO-811: Thank you for your update [~a...@labkey.com] Issue fixed and PR

[jira] [Commented] (IO-811) Files.walk() direct and indirect callers fail to close the returned Stream

2023-10-01 Thread Adam Rauch (Jira)
[ https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770927#comment-17770927 ] Adam Rauch commented on IO-811: --- Also note that the StreamIterator JavaDoc is a bit misleading in that callers

[jira] [Commented] (IO-811) Files.walk() direct and indirect callers fail to close the returned Stream

2023-10-01 Thread Adam Rauch (Jira)
[ https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770926#comment-17770926 ] Adam Rauch commented on IO-811: --- [StreamIterator test PR|https://github.com/apache/commons-io/pull/490]

[jira] [Commented] (IO-811) Files.walk() direct and indirect callers fail to close the returned Stream

2023-10-01 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770924#comment-17770924 ] Gary D. Gregory commented on IO-811: Just a mistake, the whole class is meant to be package private. You

[jira] [Commented] (IO-811) Files.walk() direct and indirect callers fail to close the returned Stream

2023-09-30 Thread Adam Rauch (Jira)
[ https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770741#comment-17770741 ] Adam Rauch commented on IO-811: --- JavaDoc and test changes look good to me. PR that attempts to close the

[jira] [Commented] (IO-811) Files.walk() direct and indirect callers fail to close the returned Stream

2023-09-29 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770631#comment-17770631 ] Gary D. Gregory commented on IO-811: [~a...@labkey.com]  Thank you for your report. Feel free to

[jira] [Commented] (IO-811) Files.walk() direct and indirect callers fail to close the returned Stream

2023-09-29 Thread Adam Rauch (Jira)
[ https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770621#comment-17770621 ] Adam Rauch commented on IO-811: --- Also Files.newDirectoryStream() - both variants > Files.walk() direct and

[jira] [Commented] (IO-811) Files.walk() direct and indirect callers fail to close the returned Stream

2023-09-29 Thread Adam Rauch (Jira)
[ https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770616#comment-17770616 ] Adam Rauch commented on IO-811: --- Turns out there are additional stream-returning methods in the JDK Files class