[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304231#comment-15304231
]
Pascal Schumacher commented on LANG-901:
Patch applied. Thanks!
It would be nice if somebody could
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304230#comment-15304230
]
ASF GitHub Bot commented on LANG-901:
-
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986503#comment-14986503
]
Matthew Bartenschlag commented on LANG-901:
---
Team, sorry to resurrect this ticket, but I think
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13904549#comment-13904549
]
Duncan Jones commented on LANG-901:
---
I would be in favour of an IAE as [~s...@apache.org]
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805264#comment-13805264
]
Benedikt Ritter commented on LANG-901:
--
I've reviewed the patch. I agree with sebb, the
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805309#comment-13805309
]
Sebb commented on LANG-901:
---
Would it not be simpler to always return false if the first parameter
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805349#comment-13805349
]
Benedikt Ritter commented on LANG-901:
--
Sure we could do that. But then again the
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805373#comment-13805373
]
Sebb commented on LANG-901:
---
I meant that all methods should treat null as not starting or ending
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690077#comment-13690077
]
Benedikt Ritter commented on LANG-901:
--
Makes sense to me. Do you want to contribute a
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690643#comment-13690643
]
Sebb commented on LANG-901:
---
Not sure why two valid lower-case tests were dropped from the
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689224#comment-13689224
]
Matthew Bartenschlag commented on LANG-901:
---
It appears that the implementation of
[
https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688059#comment-13688059
]
Benedikt Ritter commented on LANG-901:
--
I'll have a look this week. {{endsWithAny()}}
12 matches
Mail list logo