[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132803#comment-14132803
]
Thomas Neidhart commented on MATH-1131:
---
Code looks good.
The original problem is
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082369#comment-14082369
]
Schalk W. Cronjé commented on MATH-1131:
Befoer closing, it would be good to have a
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082719#comment-14082719
]
Phil Steitz commented on MATH-1131:
---
@Schaik: have you tested with the latest code in
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082789#comment-14082789
]
Schalk W. Cronjé commented on MATH-1131:
[~p...@steitz.com] Not yet. But I can try
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080883#comment-14080883
]
Phil Steitz commented on MATH-1131:
---
OK to resolve this?
Kolmogorov-Smirnov Tests takes
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075491#comment-14075491
]
Phil Steitz commented on MATH-1131:
---
Pelz-Good implemented in r1613723.
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052472#comment-14052472
]
Thomas Neidhart commented on MATH-1131:
---
The implementation of R is a 1:1 copy of the
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052477#comment-14052477
]
Thomas Neidhart commented on MATH-1131:
---
Committed patch in r1607864.
Need to decide
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052648#comment-14052648
]
Phil Steitz commented on MATH-1131:
---
Thomas
bq.
The implementation of R is a 1:1 copy of
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052662#comment-14052662
]
Thomas Neidhart commented on MATH-1131:
---
Ok great and thanks for the info, as I did
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046973#comment-14046973
]
Phil Steitz commented on MATH-1131:
---
I think the patch definitely improves things, so +1
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046995#comment-14046995
]
Phil Steitz commented on MATH-1131:
---
A few of comments not directly related to the
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044641#comment-14044641
]
Thomas Neidhart commented on MATH-1131:
---
My previous comment wrt performance of
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043247#comment-14043247
]
Schalk W. Cronjé commented on MATH-1131:
See the code examples for the specific
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043712#comment-14043712
]
Phil Steitz commented on MATH-1131:
---
Thanks for reporting this and providing the code and
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043857#comment-14043857
]
Thomas Neidhart commented on MATH-1131:
---
I did briefly debug the example and indeed
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043902#comment-14043902
]
Schalk W. Cronjé commented on MATH-1131:
This section of code in createH might be
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044019#comment-14044019
]
Schalk W. Cronjé commented on MATH-1131:
[~p...@steitz.com]said on the ML:
bq.
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044029#comment-14044029
]
Thomas Neidhart commented on MATH-1131:
---
Yes, I did the same test, and the unit test
[
https://issues.apache.org/jira/browse/MATH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044036#comment-14044036
]
Thomas Neidhart commented on MATH-1131:
---
Ah ok, the paper at
20 matches
Mail list logo