[ 
https://issues.apache.org/jira/browse/TEXT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruno P. Kinoshita resolved TEXT-149.
-------------------------------------
    Resolution: Fixed

> StringEscapeUtils.unescapeCsv doesn't remove quotes at begin and end of string
> ------------------------------------------------------------------------------
>
>                 Key: TEXT-149
>                 URL: https://issues.apache.org/jira/browse/TEXT-149
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.6
>            Reporter: Krzysztof Szalast
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 1.8.1
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> org.apache.commons.text.translate.CsvTranslators:
> {code:java}
> void translateWhole(CharSequence input, Writer out) throws IOException {
>     if (input.charAt(0) == '"' && input.charAt(input.length() - 1) == '"') {
>         String quoteless = input.subSequence(1, input.length() - 
> 1).toString();
>         if (StringUtils.containsAny(quoteless, 
> CsvTranslators.CSV_SEARCH_CHARS)) {
>             out.write(StringUtils.replace(quoteless, 
> CsvTranslators.CSV_ESCAPED_QUOTE_STR, CsvTranslators.CSV_QUOTE_STR));
>         } else {
>             out.write(input.toString());
>         }
>     } else {
>         out.write(input.toString());
>     }
> }{code}
>  
> In my opinion first occurence "out.write(input.toString());" should be 
> replaced with:
> {code:java}
> out.write(quoteless.toString());{code}
> Because '"' quotes around "input" will be never removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to