[jira] [Reopened] (POOL-356) deadlock if borrowObject gets called to fast and maxIdle is 0

2019-09-20 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz reopened POOL-356: -- I am not sure this issue is really valid, but assuming there is a real use case to have maxIdle set to 0,

[jira] [Comment Edited] (POOL-356) deadlock if borrowObject gets called to fast and maxIdle is 0

2019-09-20 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934737#comment-16934737 ] Phil Steitz edited comment on POOL-356 at 9/20/19 8:44 PM: --- I am not sure this

[jira] [Comment Edited] (POOL-356) deadlock if borrowObject gets called to fast and maxIdle is 0

2019-09-20 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934737#comment-16934737 ] Phil Steitz edited comment on POOL-356 at 9/20/19 8:27 PM: --- I am not sure this

[GitHub] [commons-lang] coveralls edited a comment on issue #458: [LANG-1426] Corrected usage examples in Javadocs

2019-09-20 Thread GitBox
coveralls edited a comment on issue #458: [LANG-1426] Corrected usage examples in Javadocs URL: https://github.com/apache/commons-lang/pull/458#issuecomment-531573214 [![Coverage Status](https://coveralls.io/builds/25837031/badge)](https://coveralls.io/builds/25837031) Coverage

[jira] [Work logged] (LANG-1426) JavaDoc issue on StringUtils.truncate

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1426?focusedWorklogId=315827=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-315827 ] ASF GitHub Bot logged work on LANG-1426: Author: ASF GitHub Bot

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

2019-09-20 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934868#comment-16934868 ] Matt Juntunen commented on GEOMETRY-32: --- {quote}Really? This is actually a question: I don't know

[GitHub] [commons-collections] dota17 commented on issue #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils

2019-09-20 Thread GitBox
dota17 commented on issue #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils URL: https://github.com/apache/commons-collections/pull/84#issuecomment-533467751 > 我认为你缺少输入上的null集合的测试用例。请运行网站构建并检查新代码是否获得100%的代码覆盖率`mvn clean site -P jacoco`。 > ...谢谢! Sorry, this is the

[GitHub] [commons-collections] dota17 removed a comment on issue #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils

2019-09-20 Thread GitBox
dota17 removed a comment on issue #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils URL: https://github.com/apache/commons-collections/pull/84#issuecomment-533467751 > 我认为你缺少输入上的null集合的测试用例。请运行网站构建并检查新代码是否获得100%的代码覆盖率`mvn clean site -P jacoco`。 > ...谢谢! Sorry, this

[GitHub] [commons-collections] dota17 commented on issue #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils

2019-09-20 Thread GitBox
dota17 commented on issue #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils URL: https://github.com/apache/commons-collections/pull/84#issuecomment-533467975 > I think you are missing a test case for a null collection on input. Please run the site build and check that the new

[GitHub] [commons-fileupload] codecracker2014 opened a new pull request #21: Adding capability to take max upload size per request.

2019-09-20 Thread GitBox
codecracker2014 opened a new pull request #21: Adding capability to take max upload size per request. URL: https://github.com/apache/commons-fileupload/pull/21 As of now FileUploadBase has sizeMax which is global for all uploads, in many cases it is required to calculate this limit based

[GitHub] [commons-fileupload] codecracker2014 closed pull request #21: Adding capability to take max upload size per request.

2019-09-20 Thread GitBox
codecracker2014 closed pull request #21: Adding capability to take max upload size per request. URL: https://github.com/apache/commons-fileupload/pull/21 This is an automated message from the Apache Git Service. To respond

[GitHub] [commons-fileupload] Stzx commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-20 Thread GitBox
Stzx commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326707673 ## File path: src/main/java/org/apache/commons/fileupload/FileUploadBase.java

[GitHub] [commons-fileupload] codecracker2014 opened a new pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-20 Thread GitBox
codecracker2014 opened a new pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22 As of now FileUploadBase has sizeMax which is global for all uploads, in many cases it is required to calculate

[GitHub] [commons-fileupload] garydgregory commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-20 Thread GitBox
garydgregory commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326683095 ## File path: pom.xml ## @@ -26,7 +26,7 @@

[GitHub] [commons-fileupload] garydgregory commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-20 Thread GitBox
garydgregory commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326683484 ## File path:

[GitHub] [commons-fileupload] garydgregory commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-20 Thread GitBox
garydgregory commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326683768 ## File path:

[GitHub] [commons-fileupload] garydgregory commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-20 Thread GitBox
garydgregory commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326683363 ## File path: