[jira] [Commented] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"
[
https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035032#comment-17035032
]
Matt Juntunen commented on NUMBERS-40:
--
Any issues with this PR?
> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Labels: exception
> Fix For: 1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs
> {{IllegalArgumentException}}).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CSV-253) Handle absent values in input (null)
[
https://issues.apache.org/jira/browse/CSV-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034248#comment-17034248
]
Lars Bruun-Hansen commented on CSV-253:
---
Gentle reminder. :)
> Handle absent values in input (null)
>
>
> Key: CSV-253
> URL: https://issues.apache.org/jira/browse/CSV-253
> Project: Commons CSV
> Issue Type: Improvement
> Components: Parser
>Reporter: Lars Bruun-Hansen
>Priority: Major
> Attachments: 2019-10-30 20_31_39-Apache Commons CSV 1.8-SNAPSHOT
> API.png, Parser-setting-absentIsNull-Javadoc.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The parser must be able to handle absent values in input and translate that
> into {{null}} as required. I see several tickets on this matter in the
> history, but none seem to have addressed the issue, at least not for parsing.
> For this problem, I see a need to introduce a new term:
> Definition: _Absent value_ is when there are zero characters between field
> delimiters.
> Specifically the aim is to be able to parse the following:
> {noformat}
> "John",,"Doe"// 2nd element is absent
> ,"AA",123// 1st element is absent
> "John",90, // 3rd element is absent
> "",,90 // 2nd element is absent (1st element isn't)
> {noformat}
>
> See also CSV-93 which I think never addressed the issue, probably because the
> reporter was happy with having the issue fixed for CSV output, not for
> parsing.
> A PR is coming...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (COLLECTIONS-747) MultiKey.getKeys class cast exception
[
https://issues.apache.org/jira/browse/COLLECTIONS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034241#comment-17034241
]
Walter Laan edited comment on COLLECTIONS-747 at 2/11/20 8:34 AM:
--
No, you will need the actual array Class to make a copy. See
java.util.ArrayList#toArray() which return Object[] and toArray(T[]) which
creates a copy. Or you could use the class from a key value, but that won't
work if all of them are null, which is not forbidden as far as I checked.
For example, if want to keep the minimum of two keys, you have to do:
{code:java}
@SafeVarargs
public MultiKey(K key1, K key2, K... keys) {
int length = keys.length + 2;
@SuppressWarnings("unchecked") // cast is correct because
K[].getClass() is passed
K[] tmpKeys = (K[]) Arrays.copyOf(keys, keys.length + 2,
keys.getClass());
for(int i = length - 1; i > 1; i--) {
tmpKeys[i] = tmpKeys[i - 2];
}
tmpKeys[0] = key1;
tmpKeys[1] = key2;
this.keys = tmpKeys;
}
// which then allows null keys, though need to specify type instead of just
diamond (<>)
MultiKeyClassCastException[] keys = new MultiKey<>(key1, key2).getKeys();
MultiKeyClassCastException[] keys2 = new MultiKey<>(key1, key2, key3).getKeys();
MultiKeyClassCastException[] keys3 = new
MultiKey(null, null).getKeys();
{code}
[https://stackoverflow.com/questions/529085/how-to-create-a-generic-array-in-java]
[https://softwareengineering.stackexchange.com/a/331109]
was (Author: wlaan):
No, you will need the actual array Class to make a copy. See
java.util.ArrayList#toArray() which return Object[] and toArray(T[]) which
creates a copy. Or you could use the class from a key value, but that won't
work if all of them are null, which is not forbidden as far as I checked.
For example, if want to keep the minimum of two keys, you have to do:
{code:java}
@SafeVarargs
public MultiKey(K key1, K key2, K... keys) {
int length = keys.length + 2;
@SuppressWarnings("unchecked") // cast is correct because
K[].getClass() is passed
K[] tmpKeys = (K[]) Arrays.copyOf(keys, keys.length + 2,
keys.getClass());
for(int i = length - 1; i > 1; i--) {
tmpKeys[i] = tmpKeys[i - 2];
}
tmpKeys[0] = key1;
tmpKeys[1] = key2;
this.keys = tmpKeys;
}
// which then allows null keys, though need to specify type instead of just
diamond (<>)
MultiKeyClassCastException[] keys = new MultiKey<>(key1,
key2).getKeys();
MultiKeyClassCastException[] keys2 = new MultiKey<>(key1, key2,
key3).getKeys();
MultiKeyClassCastException[] keys3 = new
MultiKey(null, null).getKeys();
{code}
[https://stackoverflow.com/questions/529085/how-to-create-a-generic-array-in-java]
[https://softwareengineering.stackexchange.com/a/331109]
> MultiKey.getKeys class cast exception
> -
>
> Key: COLLECTIONS-747
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-747
> Project: Commons Collections
> Issue Type: Bug
> Components: KeyValue
>Affects Versions: 4.4
>Reporter: Walter Laan
>Priority: Major
>
> When using an non-array constructor of MultiKey, an Object[] is created,
> which cannot be cast to a K[]
> {code}
> import org.apache.commons.collections4.keyvalue.MultiKey;
> public class MultiKeyClassCastException {
> public static void main(String[] args) {
> MultiKeyClassCastException key1 = new MultiKeyClassCastException();
> MultiKeyClassCastException key2 = new MultiKeyClassCastException();
> MultiKeyClassCastException[] keys = new MultiKey<>(key1,
> key2).getKeys();
> }
> }
> // running gives (same error if in module):
> Exception in thread "main" java.lang.ClassCastException: class
> [Ljava.lang.Object; cannot be cast to class [LMultiKeyClassCastException;
> ([Ljava.lang.Object; is in module java.base of loader 'bootstrap';
> [LMultiKeyClassCastException; is in unnamed module of loader 'app')
> at MultiKeyClassCastException.main(MultiKeyClassCastException.java:8)
> {code}
> AFAIK, the only way to fix this (with source compatibility), is to only have
> a varargs constructors. but I think this breaks binary compatibility though
> and cannot be used with the existing constructors.
> {code}
> @SafeVarargs
> public MultiKey(K... keys) {
> this.keys = keys;
> }
> {code}
> Workaround is to use array constructor with correct typed array or
> {code}Object[] keys = multiKey.getKeys();{code} explicitly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (COLLECTIONS-747) MultiKey.getKeys class cast exception
[
https://issues.apache.org/jira/browse/COLLECTIONS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034241#comment-17034241
]
Walter Laan commented on COLLECTIONS-747:
-
No, you will need the actual array Class to make a copy. See
java.util.ArrayList#toArray() which return Object[] and toArray(T[]) which
creates a copy. Or you could use the class from a key value, but that won't
work if all of them are null, which is not forbidden as far as I checked.
For example, if want to keep the minimum of two keys, you have to do:
{code:java}
@SafeVarargs
public MultiKey(K key1, K key2, K... keys) {
int length = keys.length + 2;
@SuppressWarnings("unchecked") // cast is correct because
K[].getClass() is passed
K[] tmpKeys = (K[]) Arrays.copyOf(keys, keys.length + 2,
keys.getClass());
for(int i = length - 1; i > 1; i--) {
tmpKeys[i] = tmpKeys[i - 2];
}
tmpKeys[0] = key1;
tmpKeys[1] = key2;
this.keys = tmpKeys;
}
// which then allows null keys, though need to specify type instead of just
diamond (<>)
MultiKeyClassCastException[] keys = new MultiKey<>(key1,
key2).getKeys();
MultiKeyClassCastException[] keys2 = new MultiKey<>(key1, key2,
key3).getKeys();
MultiKeyClassCastException[] keys3 = new
MultiKey(null, null).getKeys();
{code}
[https://stackoverflow.com/questions/529085/how-to-create-a-generic-array-in-java]
[https://softwareengineering.stackexchange.com/a/331109]
> MultiKey.getKeys class cast exception
> -
>
> Key: COLLECTIONS-747
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-747
> Project: Commons Collections
> Issue Type: Bug
> Components: KeyValue
>Affects Versions: 4.4
>Reporter: Walter Laan
>Priority: Major
>
> When using an non-array constructor of MultiKey, an Object[] is created,
> which cannot be cast to a K[]
> {code}
> import org.apache.commons.collections4.keyvalue.MultiKey;
> public class MultiKeyClassCastException {
> public static void main(String[] args) {
> MultiKeyClassCastException key1 = new MultiKeyClassCastException();
> MultiKeyClassCastException key2 = new MultiKeyClassCastException();
> MultiKeyClassCastException[] keys = new MultiKey<>(key1,
> key2).getKeys();
> }
> }
> // running gives (same error if in module):
> Exception in thread "main" java.lang.ClassCastException: class
> [Ljava.lang.Object; cannot be cast to class [LMultiKeyClassCastException;
> ([Ljava.lang.Object; is in module java.base of loader 'bootstrap';
> [LMultiKeyClassCastException; is in unnamed module of loader 'app')
> at MultiKeyClassCastException.main(MultiKeyClassCastException.java:8)
> {code}
> AFAIK, the only way to fix this (with source compatibility), is to only have
> a varargs constructors. but I think this breaks binary compatibility though
> and cannot be used with the existing constructors.
> {code}
> @SafeVarargs
> public MultiKey(K... keys) {
> this.keys = keys;
> }
> {code}
> Workaround is to use array constructor with correct typed array or
> {code}Object[] keys = multiKey.getKeys();{code} explicitly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-dbutils] ameyjadiye commented on issue #10: Correction of coverage badge
ameyjadiye commented on issue #10: Correction of coverage badge URL: https://github.com/apache/commons-dbutils/pull/10#issuecomment-584650986 Hi @thecarlhall , can you please take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-csv] ameyjadiye commented on issue #56: Replace findbugs with spotbugs
ameyjadiye commented on issue #56: Replace findbugs with spotbugs URL: https://github.com/apache/commons-csv/pull/56#issuecomment-584651839 Hi @garydgregory, can you please take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (JEXL-302) JexlScript.getVariables returns strange values for array access
[
https://issues.apache.org/jira/browse/JEXL-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034586#comment-17034586
]
Henri Biestro edited comment on JEXL-302 at 2/11/20 4:39 PM:
-
That subject is moot if you use a JexBuilder(). collectAll(false) as in:
{code:java}
JexlEngine jexld = new JexlBuilder().collectAll(false).create();
e = jexld.createScript("x.y[{'z': 't'}]");
vars = e.getVariables();
Assert.assertEquals(1, vars.size());
Assert.assertTrue(eq(mkref(new String[][]{{"x", "y"}}), vars));}
{code}
In the collectAll(true) case, the logic is in the actual intent of getVariables
; statically capture the elements that will potentially influence the script
execution flow, ie all variables. Since one can configure JEXL so that a.b is
equivalent to a['b'], it stands to reason that a a[['b', 'c’]] can be
interpreted as [a.b, a.c]. , thus the a, ['b', 'c'] resulting of getVariables.
The same logic can be applied to constant sets and maps.
For instance:
{code:java}
script = JEXL.createScript("moon.landing[['', 'MM', 'dd']]");
result = (List) script.execute(ctxt);
Assert.assertEquals(Arrays.asList("1969", "7", "20"), result);
{code}
In this example, the script
{code:java}
moon.landing[['', 'MM', 'dd']]{code}
is equivalent to
{code:java}
[ moon.landing., moon.landing.MM, moon.landing.dd ]
{code}
With a bit of added parsing, it becomes possible to determine those from
getVariables.
I'm adding a test case to illustrate, [JEXL-302: added a test for
JexBuilder.captureAll() and
JexlScript.get…|https://github.com/apache/commons-jexl/commit/09db242b8cffbf63ad4a59d4e62f3ac358d4be24]
was (Author: henrib):
That subject is moot if you use a JexBuilder().captureAll(false) as in:
{code:java}
JexlEngine jexld = new JexlBuilder().collectAll(false).create();
e = jexld.createScript("x.y[{'z': 't'}]");
vars = e.getVariables();
Assert.assertEquals(1, vars.size());
Assert.assertTrue(eq(mkref(new String[][]{{"x", "y"}}), vars));}
{code}
In the captureAll(true) case, the logic is in the actual intent of getVariables
; statically capture the elements that will potentially influence the script
execution flow, ie all variables. Since one can configure JEXL so that a.b is
equivalent to a['b'], it stands to reason that a a[['b', 'c’]] can be
interpreted as [a.b, a.c]. , thus the a, ['b', 'c'] resulting of getVariables.
The same logic can be applied to constant sets and maps.
For instance:
{code:java}
script = JEXL.createScript("moon.landing[['', 'MM', 'dd']]");
result = (List) script.execute(ctxt);
Assert.assertEquals(Arrays.asList("1969", "7", "20"), result);
{code}
In this example, the script
{code:java}
moon.landing[['', 'MM', 'dd']]{code}
is equivalent to
{code:java}
[ moon.landing., moon.landing.MM, moon.landing.dd ]
{code}
With a bit of added parsing, it becomes possible to determine those from
getVariables.
I'm adding a test case to illustrate, [JEXL-302: added a test for
JexBuilder.captureAll() and
JexlScript.get…|https://github.com/apache/commons-jexl/commit/09db242b8cffbf63ad4a59d4e62f3ac358d4be24]
> JexlScript.getVariables returns strange values for array access
> ---
>
> Key: JEXL-302
> URL: https://issues.apache.org/jira/browse/JEXL-302
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Assignee: Henri Biestro
>Priority: Minor
> Fix For: 3.2
>
>
> I can not understand the logic behind the current implementation of
> {{JexlScript.getVariables()}} method. From the documentation we know that the
> result should be the set of script variables. For the code
> {code:java}
> a[b][c]{code}
> it gives three variables {{a}}, {{b}}, {{c}}. So far so good. But for the code
> {code:java}
> a[b]['c']{code}
> it returns {{a}} and {{b c}}, where second variable has two fragments {{b}}
> and {{c}}. The documentation states that variables with multiple fragments
> are ant-ish variables, but I don't have any of ant-ish variables in the
> example, and {{'c'}} is not a variable, but a constant. I expect to get {{a}}
> and {{b}} as a result.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JEXL-302) JexlScript.getVariables returns strange values for array access
[
https://issues.apache.org/jira/browse/JEXL-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034586#comment-17034586
]
Henri Biestro commented on JEXL-302:
That subject is moot if you use a JexBuilder().captureAll(false) as in:
{code:java}
JexlEngine jexld = new JexlBuilder().collectAll(false).create();
e = jexld.createScript("x.y[{'z': 't'}]");
vars = e.getVariables();
Assert.assertEquals(1, vars.size());
Assert.assertTrue(eq(mkref(new String[][]{{"x", "y"}}), vars));}
{code}
In the captureAll(true) case, the logic is in the actual intent of getVariables
; statically capture the elements that will potentially influence the script
execution flow, ie all variables. Since one can configure JEXL so that a.b is
equivalent to a['b'], it stands to reason that a a[['b', 'c’]] can be
interpreted as [a.b, a.c]. , thus the a, ['b', 'c'] resulting of getVariables.
The same logic can be applied to constant sets and maps.
For instance:
{code:java}
script = JEXL.createScript("moon.landing[['', 'MM', 'dd']]");
result = (List) script.execute(ctxt);
Assert.assertEquals(Arrays.asList("1969", "7", "20"), result);
{code}
In this example, the script
{code:java}
moon.landing[['', 'MM', 'dd']]{code}
is equivalent to
{code:java}
[ moon.landing., moon.landing.MM, moon.landing.dd ]
{code}
With a bit of added parsing, it becomes possible to determine those from
getVariables.
I'm adding a test case to illustrate, [JEXL-302: added a test for
JexBuilder.captureAll() and
JexlScript.get…|https://github.com/apache/commons-jexl/commit/09db242b8cffbf63ad4a59d4e62f3ac358d4be24]
> JexlScript.getVariables returns strange values for array access
> ---
>
> Key: JEXL-302
> URL: https://issues.apache.org/jira/browse/JEXL-302
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Assignee: Henri Biestro
>Priority: Minor
> Fix For: 3.2
>
>
> I can not understand the logic behind the current implementation of
> {{JexlScript.getVariables()}} method. From the documentation we know that the
> result should be the set of script variables. For the code
> {code:java}
> a[b][c]{code}
> it gives three variables {{a}}, {{b}}, {{c}}. So far so good. But for the code
> {code:java}
> a[b]['c']{code}
> it returns {{a}} and {{b c}}, where second variable has two fragments {{b}}
> and {{c}}. The documentation states that variables with multiple fragments
> are ant-ish variables, but I don't have any of ant-ish variables in the
> example, and {{'c'}} is not a variable, but a constant. I expect to get {{a}}
> and {{b}} as a result.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (LANG-1517) a spelling issue in ArrayUtils method removeALlOccurences
[ https://issues.apache.org/jira/browse/LANG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034577#comment-17034577 ] Karvannan Rajasekaran commented on LANG-1517: - Looks like new version of this class has this typo corrected. [https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/ArrayUtils.java] Should the user has to upgrade their jar version or what is the expectation in this ticket? Thanks, Karvannan > a spelling issue in ArrayUtils method removeALlOccurences > - > > Key: LANG-1517 > URL: https://issues.apache.org/jira/browse/LANG-1517 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Affects Versions: 3.9 >Reporter: bill-liuwenbin >Priority: Major > Labels: easyfix > Fix For: 3.9 > > > a spelling issue in ArrayUtils method removeALlOccurences, the problem is > where is a typo in it. should be removeAllOccurrences. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1513) Additional Statistics To be toggled to Display with Linear Regression
Fawaz Alhenaki created MATH-1513: Summary: Additional Statistics To be toggled to Display with Linear Regression Key: MATH-1513 URL: https://issues.apache.org/jira/browse/MATH-1513 Project: Commons Math Issue Type: Improvement Affects Versions: 3.6.1 Reporter: Fawaz Alhenaki As part of apache.commons.math3.stat.regression does not provide some important statistics that are typically associated with linear regression calculations (i.e. should be a possible addition to OLSMultipleLinearRegression to view these stats). I propose adding the following statistics: * The standard error values for the coefficients m1,m2,...,mn. * The standard error value for the constant b * The coefficient of determination * The standard error for the y estimate. * The F statistic, or the F-observed value. * The degrees of freedom * The regression sum of squares. * The residual sum of squares Further information about these stats can be found here: [https://support.office.com/en-us/article/linest-function-84d7d0d9-6e50-4101-977a-fa7abf772b6d] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1514) IRR NaN When it should give back a value
Fawaz Alhenaki created MATH-1514: Summary: IRR NaN When it should give back a value Key: MATH-1514 URL: https://issues.apache.org/jira/browse/MATH-1514 Project: Commons Math Issue Type: Bug Affects Versions: 3.6 Reporter: Fawaz Alhenaki Attachments: TestIrr.java I have created a sample of when the issue occurs. IRR in apache documentation says that covers "20 tries" as shown here [https://poi.apache.org/apidocs/dev/org/apache/poi/ss/formula/functions/Irr.html] which is identical to Microsoft Excel [https://support.office.com/en-us/article/irr-function-64925eaa-9988-495b-b290-3ad0c163c1bc] This indicate that the result is the same between the two; however, in the case of apache poi, it seems that the result is returned as NaN (while excel returns the actual result). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1514) IRR NaN When it should give back a value
[ https://issues.apache.org/jira/browse/MATH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034793#comment-17034793 ] Gilles Sadowski commented on MATH-1514: --- I'm not sure I undrestand: Do you report an issue with code from https://poi.apache.org/ ? If so, this is not the appropriate issue-tracking project. > IRR NaN When it should give back a value > > > Key: MATH-1514 > URL: https://issues.apache.org/jira/browse/MATH-1514 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6 >Reporter: Fawaz Alhenaki >Priority: Minor > > I have created a sample of when the issue occurs. IRR in apache documentation > says that covers "20 tries" as shown here > [https://poi.apache.org/apidocs/dev/org/apache/poi/ss/formula/functions/Irr.html] > > which is identical to Microsoft Excel > [https://support.office.com/en-us/article/irr-function-64925eaa-9988-495b-b290-3ad0c163c1bc] > This indicate that the result is the same between the two; however, in the > case of apache poi, it seems that the result is returned as NaN (while excel > returns the actual result). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1514) IRR NaN When it should give back a value
[ https://issues.apache.org/jira/browse/MATH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fawaz Alhenaki updated MATH-1514: - Attachment: (was: TestIrr.java) > IRR NaN When it should give back a value > > > Key: MATH-1514 > URL: https://issues.apache.org/jira/browse/MATH-1514 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6 >Reporter: Fawaz Alhenaki >Priority: Minor > > I have created a sample of when the issue occurs. IRR in apache documentation > says that covers "20 tries" as shown here > [https://poi.apache.org/apidocs/dev/org/apache/poi/ss/formula/functions/Irr.html] > > which is identical to Microsoft Excel > [https://support.office.com/en-us/article/irr-function-64925eaa-9988-495b-b290-3ad0c163c1bc] > This indicate that the result is the same between the two; however, in the > case of apache poi, it seems that the result is returned as NaN (while excel > returns the actual result). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1513) Additional Statistics To be toggled to Display with Linear Regression
[ https://issues.apache.org/jira/browse/MATH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034812#comment-17034812 ] Phil Steitz commented on MATH-1513: --- Most of these statistics are directly available in the AbstractLinearRegression interface implemented by this class. Have a look at the methods inherited from that interface. > Additional Statistics To be toggled to Display with Linear Regression > - > > Key: MATH-1513 > URL: https://issues.apache.org/jira/browse/MATH-1513 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 3.6.1 >Reporter: Fawaz Alhenaki >Priority: Major > > As part of apache.commons.math3.stat.regression does not provide some > important statistics that are typically associated with linear regression > calculations (i.e. should be a possible addition to > OLSMultipleLinearRegression to view these stats). > I propose adding the following statistics: > * The standard error values for the coefficients m1,m2,...,mn. > * The standard error value for the constant b > * The coefficient of determination > * The standard error for the y estimate. > * The F statistic, or the F-observed value. > * The degrees of freedom > * The regression sum of squares. > * The residual sum of squares > > Further information about these stats can be found here: > [https://support.office.com/en-us/article/linest-function-84d7d0d9-6e50-4101-977a-fa7abf772b6d] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-70) Userguide and reports
[ https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034783#comment-17034783 ] Gilles Sadowski commented on NUMBERS-70: I suggest that you post on the "dev" mailing list (you have to [subscribe|http://commons.apache.org/mail-lists.html]). There is a [discussion thread|https://markmail.org/message/m76fqra53ijev2mx] about such initiatives, but not much participation from the project developers up to now... > Userguide and reports > - > > Key: NUMBERS-70 > URL: https://issues.apache.org/jira/browse/NUMBERS-70 > Project: Commons Numbers > Issue Type: Wish >Reporter: Gilles Sadowski >Priority: Minor > Labels: benchmark, documentation, gsoc2020 > Attachments: 0001-Angles-xdoc-is-added.patch, > 0001-Prime-xdoc-file-is-added.patch, 0001-Primes-xdoc-is-added.patch > > > Review contents of the component towards providing an up-to-date userguide > and write benchmarking code for generating performance reports > ([JMH|http://openjdk.java.net/projects/code-tools/jmh/]). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1514) IRR NaN When it should give back a value
[ https://issues.apache.org/jira/browse/MATH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fawaz Alhenaki updated MATH-1514: - Attachment: TestIrr.java > IRR NaN When it should give back a value > > > Key: MATH-1514 > URL: https://issues.apache.org/jira/browse/MATH-1514 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6 >Reporter: Fawaz Alhenaki >Priority: Minor > Attachments: TestIrr.java > > > I have created a sample of when the issue occurs. IRR in apache documentation > says that covers "20 tries" as shown here > [https://poi.apache.org/apidocs/dev/org/apache/poi/ss/formula/functions/Irr.html] > > which is identical to Microsoft Excel > [https://support.office.com/en-us/article/irr-function-64925eaa-9988-495b-b290-3ad0c163c1bc] > This indicate that the result is the same between the two; however, in the > case of apache poi, it seems that the result is returned as NaN (while excel > returns the actual result). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1513) Additional Statistics To be toggled to Display with Linear Regression
[ https://issues.apache.org/jira/browse/MATH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034917#comment-17034917 ] Phil Steitz commented on MATH-1513: --- Yes, sorry I left out the "Multiple". The coefficient of determination usually means RSquare, which is available in the main class. Total sum of squares and residual sum of squares are available in the OLS class itself. df is a simple computation from the dimensions of the design matrix (X) and whether or not an intercept is estimated. That would be a nice add. F would also be a nice add. The data to do the test is available in the OLS class, but the test itself would require using the F distribution from the distributions package. > Additional Statistics To be toggled to Display with Linear Regression > - > > Key: MATH-1513 > URL: https://issues.apache.org/jira/browse/MATH-1513 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 3.6.1 >Reporter: Fawaz Alhenaki >Priority: Major > > As part of apache.commons.math3.stat.regression does not provide some > important statistics that are typically associated with linear regression > calculations (i.e. should be a possible addition to > OLSMultipleLinearRegression to view these stats). > I propose adding the following statistics: > * The standard error values for the coefficients m1,m2,...,mn. > * The standard error value for the constant b > * The coefficient of determination > * The standard error for the y estimate. > * The F statistic, or the F-observed value. > * The degrees of freedom > * The regression sum of squares. > * The residual sum of squares > > Further information about these stats can be found here: > [https://support.office.com/en-us/article/linest-function-84d7d0d9-6e50-4101-977a-fa7abf772b6d] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MATH-1514) IRR NaN When it should give back a value
[ https://issues.apache.org/jira/browse/MATH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fawaz Alhenaki closed MATH-1514. Resolution: Invalid Wrong forum. > IRR NaN When it should give back a value > > > Key: MATH-1514 > URL: https://issues.apache.org/jira/browse/MATH-1514 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6 >Reporter: Fawaz Alhenaki >Priority: Minor > Attachments: TestIrr.java > > > I have created a sample of when the issue occurs. IRR in apache documentation > says that covers "20 tries" as shown here > [https://poi.apache.org/apidocs/dev/org/apache/poi/ss/formula/functions/Irr.html] > > which is identical to Microsoft Excel > [https://support.office.com/en-us/article/irr-function-64925eaa-9988-495b-b290-3ad0c163c1bc] > This indicate that the result is the same between the two; however, in the > case of apache poi, it seems that the result is returned as NaN (while excel > returns the actual result). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1513) Additional Statistics To be toggled to Display with Linear Regression
[ https://issues.apache.org/jira/browse/MATH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034852#comment-17034852 ] Fawaz Alhenaki commented on MATH-1513: -- I believe you are referring to AbstractMultipleLinearRegression. [https://commons.apache.org/proper/commons-math/javadocs/api-3.0/org/apache/commons/math3/stat/regression/AbstractMultipleLinearRegression.html] I believe you are correct in that the standard error values are available. However, the coefficient of determination, degrees of freedom, sum of squares etc. are not > Additional Statistics To be toggled to Display with Linear Regression > - > > Key: MATH-1513 > URL: https://issues.apache.org/jira/browse/MATH-1513 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 3.6.1 >Reporter: Fawaz Alhenaki >Priority: Major > > As part of apache.commons.math3.stat.regression does not provide some > important statistics that are typically associated with linear regression > calculations (i.e. should be a possible addition to > OLSMultipleLinearRegression to view these stats). > I propose adding the following statistics: > * The standard error values for the coefficients m1,m2,...,mn. > * The standard error value for the constant b > * The coefficient of determination > * The standard error for the y estimate. > * The F statistic, or the F-observed value. > * The degrees of freedom > * The regression sum of squares. > * The residual sum of squares > > Further information about these stats can be found here: > [https://support.office.com/en-us/article/linest-function-84d7d0d9-6e50-4101-977a-fa7abf772b6d] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
