[GitHub] [commons-lang] theshoeshiner commented on pull request #1062: Syntax for optional tokens in DurationFormatUtils

2023-06-28 Thread via GitHub
theshoeshiner commented on PR #1062: URL: https://github.com/apache/commons-lang/pull/1062#issuecomment-1611667733 I will add tests for `formatPeriod` as well, and check on my end for other library methods invoking these. In regards to the javadocs, the method level `formatDuration`

[GitHub] [commons-lang] orionlibs commented on pull request #1068: calculate the left-difference between 2 arrays

2023-06-28 Thread via GitHub
orionlibs commented on PR #1068: URL: https://github.com/apache/commons-lang/pull/1068#issuecomment-1611642769 @aherbert you are right. It was supposed to be an array operation and not a set operation. But it is OK. I closed this PR. I will implement set theory and vector stuff in commons

[GitHub] [commons-lang] aherbert commented on pull request #1062: Syntax for optional tokens in DurationFormatUtils

2023-06-28 Thread via GitHub
aherbert commented on PR #1062: URL: https://github.com/apache/commons-lang/pull/1062#issuecomment-1611607319 I think this is useful. It requires an update to the Javadoc to describe that you can use optional tokens, with some examples. Otherwise it is a hidden feature. IIUC

[GitHub] [commons-lang] aherbert commented on pull request #1068: calculate the left-difference between 2 arrays

2023-06-28 Thread via GitHub
aherbert commented on PR #1068: URL: https://github.com/apache/commons-lang/pull/1068#issuecomment-1611626296 Note that this is not returning distinct elements from array 1 so is not a strict set operation. E.g. The provided code will compute: ``` {1, 2, 3, 4, 4} - {1, 6, 8, 3} = {2,

[GitHub] [commons-lang] orionlibs commented on pull request #1068: calculate the left-difference between 2 arrays

2023-06-28 Thread via GitHub
orionlibs commented on PR #1068: URL: https://github.com/apache/commons-lang/pull/1068#issuecomment-1611617905 @garydgregory you spotted it immediately. That is exactly what I was planning. I have a list of about 60 array-related operations. This one I just did for this PR was just the

[GitHub] [commons-lang] orionlibs commented on pull request #1068: calculate the left-difference between 2 arrays

2023-06-28 Thread via GitHub
orionlibs commented on PR #1068: URL: https://github.com/apache/commons-lang/pull/1068#issuecomment-1611618358 @garydgregory you spotted it immediately. That is exactly what I was planning. I have a list of about 60 array-related operations. This one I just did for this PR was just the

[GitHub] [commons-lang] orionlibs closed pull request #1068: calculate the left-difference between 2 arrays

2023-06-28 Thread via GitHub
orionlibs closed pull request #1068: calculate the left-difference between 2 arrays URL: https://github.com/apache/commons-lang/pull/1068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (DBCP-591) Avoid synchronized in PoolableConnection.close

2023-06-28 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738305#comment-17738305 ] Phil Steitz commented on DBCP-591: -- Acknowledged.  It is strange that intrinsic locks work differently,

[jira] [Updated] (CONFIGURATION-833) PropertiesConfiguration: Possibility to distinguish between "serious" and "non-serious" exceptions for optional configurations

2023-06-28 Thread Matthias Hanisch (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Hanisch updated CONFIGURATION-833: --- Description: With Properties files as configuration sources there not

[jira] [Created] (CONFIGURATION-833) PropertiesConfiguration: Possibility to distinguish between "serious" and non-serious exceptions for optional configurations

2023-06-28 Thread Matthias Hanisch (Jira)
Matthias Hanisch created CONFIGURATION-833: -- Summary: PropertiesConfiguration: Possibility to distinguish between "serious" and non-serious exceptions for optional configurations Key: CONFIGURATION-833

[jira] [Updated] (CONFIGURATION-833) PropertiesConfiguration: Possibility to distinguish between "serious" and "non-serious" exceptions for optional configurations

2023-06-28 Thread Matthias Hanisch (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Hanisch updated CONFIGURATION-833: --- Summary: PropertiesConfiguration: Possibility to distinguish between

[jira] [Updated] (CONFIGURATION-833) PropertiesConfiguration: Possibility to distinguish between "serious" and "non-serious" exceptions for optional configurations

2023-06-28 Thread Matthias Hanisch (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Hanisch updated CONFIGURATION-833: --- Description: With Properties files as configuration sources there not

[jira] [Updated] (CONFIGURATION-833) PropertiesConfiguration: Possibility to distinguish between "serious" and "non-serious" exceptions for optional configurations

2023-06-28 Thread Matthias Hanisch (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Hanisch updated CONFIGURATION-833: --- Description: With Properties files as configuration sources there not

[jira] [Commented] (IO-778) FileUtils.copyFile(File srcFile, File destFile): Missing IllegalArgumentException in Javadoc

2023-06-28 Thread Rainer Hochreiter (Jira)
[ https://issues.apache.org/jira/browse/IO-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738099#comment-17738099 ] Rainer Hochreiter commented on IO-778: -- I can't see any IllegalArgumentException in the docs for

[jira] [Commented] (MATH-1658) ConvergenceChecker should implement OptimizationData

2023-06-28 Thread Jira
[ https://issues.apache.org/jira/browse/MATH-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738108#comment-17738108 ] François Laferrière commented on MATH-1658: --- OK it is good for me. Could you please commit and

[jira] [Commented] (IO-778) FileUtils.copyFile(File srcFile, File destFile): Missing IllegalArgumentException in Javadoc

2023-06-28 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738112#comment-17738112 ] Gary D. Gregory commented on IO-778: Hi [~rhochreiter]  Thank you for the pointer. Keeping Javadoc

[GitHub] [commons-lang] orionlibs opened a new pull request, #1068: calculate the left-difference between 2 arrays

2023-06-28 Thread via GitHub
orionlibs opened a new pull request, #1068: URL: https://github.com/apache/commons-lang/pull/1068 Created methods that calculate the left-difference between 2 arrays. For example for {1, 2, 3, 4}-{1, 6, 8, 3}={2, 4}. These methods could be useful in several scenarios: 1--Data

[GitHub] [commons-lang] garydgregory commented on pull request #1062: Syntax for optional tokens in DurationFormatUtils

2023-06-28 Thread via GitHub
garydgregory commented on PR #1062: URL: https://github.com/apache/commons-lang/pull/1062#issuecomment-1611496832 I'm looking for community feedback. CC: @kinow @aherbert @chtompki ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to