[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740943#comment-17740943 ] Sebb commented on POOL-411: --- To simplify testing, it might be worth temporarily adding a sleep where you think

[GitHub] [commons-compress] garydgregory merged pull request #399: Bump github/codeql-action from 2.20.1 to 2.20.3

garydgregory merged PR #399: URL: https://github.com/apache/commons-compress/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1255448741 ## src/main/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilter.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740941#comment-17740941 ] Sebb commented on POOL-411: --- Surely it should not be possible to obtain a write lock whilst others are holding

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1255444851 ## src/main/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilter.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (JEXL-399) Needs support more javascript syntax

[ https://issues.apache.org/jira/browse/JEXL-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741004#comment-17741004 ] Henri Biestro commented on JEXL-399: JEXL is not JavaScript and does not try to be as feature-rich. You

[GitHub] [commons-dbcp] garydgregory merged pull request #287: Bump h2 from 2.1.214 to 2.2.220

garydgregory merged PR #287: URL: https://github.com/apache/commons-dbcp/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-dbcp] garydgregory commented on pull request #281: Bump mockito-core from 4.11.0 to 5.4.0

garydgregory commented on PR #281: URL: https://github.com/apache/commons-dbcp/pull/281#issuecomment-1625179769 Closing, requires Java 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-collections] Claudenw commented on pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on PR #402: URL: https://github.com/apache/commons-collections/pull/402#issuecomment-1625178843 I have made a mess of the formatting. I am working at cleaning it up now. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [commons-csv] garydgregory merged pull request #333: Bump h2 from 2.1.214 to 2.2.220

garydgregory merged PR #333: URL: https://github.com/apache/commons-csv/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-parent] garydgregory merged pull request #287: Bump github/codeql-action from 2.20.1 to 2.20.3

garydgregory merged PR #287: URL: https://github.com/apache/commons-parent/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411 ] Phil Steitz deleted comment on POOL-411: -- was (Author: psteitz): The added test case has failed at least once now.  I think there is a problem with register/deregister protection of pools.  Very

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256018727 ## src/main/java/org/apache/commons/collections4/bloomfilter/Shape.java: ## @@ -227,6 +227,15 @@ public double estimateN(final int cardinality) {

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256041156 ## src/main/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilter.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[jira] [Comment Edited] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741106#comment-17741106 ] Phil Steitz edited comment on POOL-411 at 7/7/23 3:50 PM: -- [~sebb] - thanks for

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256026172 ## src/test/java/org/apache/commons/collections4/bloomfilter/LayerManagerTest.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741106#comment-17741106 ] Phil Steitz commented on POOL-411: -- [~sebb] - thanks for looking at this.  You are right - the scenario I

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256043841 ## src/main/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilter.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256022467 ## src/main/java/org/apache/commons/collections4/bloomfilter/WrappedBloomFilter.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256027853 ## src/test/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilterTest.java: ## @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256028611 ## src/test/java/org/apache/commons/collections4/bloomfilter/TestingHashers.java: ## @@ -88,4 +90,18 @@ public static T populateRange(T filter, int

[GitHub] [commons-statistics] ani5rudh opened a new pull request, #46: [STATISTICS-71]: Add base interfaces for all statistic implementations.

ani5rudh opened a new pull request, #46: URL: https://github.com/apache/commons-statistics/pull/46 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-exec] garydgregory merged pull request #110: Bump github/codeql-action from 2.20.1 to 2.20.3

garydgregory merged PR #110: URL: https://github.com/apache/commons-exec/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-imaging] garydgregory merged pull request #300: Bump github/codeql-action from 2.20.1 to 2.20.3

garydgregory merged PR #300: URL: https://github.com/apache/commons-imaging/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-daemon] garydgregory merged pull request #98: Bump github/codeql-action from 2.20.1 to 2.20.3

garydgregory merged PR #98: URL: https://github.com/apache/commons-daemon/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741156#comment-17741156 ] Phil Steitz commented on POOL-411: -- If I make the following changes to testConcurrentBorrowAnd clear, the

[GitHub] [commons-collections] garydgregory merged pull request #405: Bump guava-testlib from 32.1.0-jre to 32.1.1-jre

garydgregory merged PR #405: URL: https://github.com/apache/commons-collections/pull/405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-ognl] garydgregory merged pull request #129: Bump h2 from 2.1.214 to 2.2.220

garydgregory merged PR #129: URL: https://github.com/apache/commons-ognl/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256479009 ## src/main/java/org/apache/commons/collections4/bloomfilter/LayerManager.java: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Comment Edited] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741196#comment-17741196 ] Gary D. Gregory edited comment on POOL-411 at 7/7/23 9:24 PM: -- I refactored

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741196#comment-17741196 ] Gary D. Gregory commented on POOL-411: -- I refactored the test and added

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256480417 ## src/main/java/org/apache/commons/collections4/bloomfilter/LayerManager.java: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1256480780 ## src/main/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilter.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[jira] [Comment Edited] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741196#comment-17741196 ] Gary D. Gregory edited comment on POOL-411 at 7/7/23 9:25 PM: -- I refactored

[jira] [Comment Edited] (JEXL-399) Needs support more javascript syntax

[ https://issues.apache.org/jira/browse/JEXL-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741235#comment-17741235 ] Xu Pengcheng edited comment on JEXL-399 at 7/8/23 3:39 AM: --- Thanks for your

[jira] [Commented] (JEXL-399) Needs support more javascript syntax

[ https://issues.apache.org/jira/browse/JEXL-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741235#comment-17741235 ] Xu Pengcheng commented on JEXL-399: --- Thanks for your explaination. > Needs support more javascript

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741220#comment-17741220 ] Phil Steitz commented on POOL-411: -- [~ggregory]  - looks great.  Great idea to use computeIfAbsent and to

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741221#comment-17741221 ] Gary D. Gregory commented on POOL-411: -- Committed to master. Because allocate is accessed in and out

[jira] [Comment Edited] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741221#comment-17741221 ] Gary D. Gregory edited comment on POOL-411 at 7/8/23 12:27 AM: --- Committed to

[GitHub] [commons-statistics] kinow commented on a diff in pull request #46: [STATISTICS-71]: Add base interfaces for all statistic implementations.

kinow commented on code in PR #46: URL: https://github.com/apache/commons-statistics/pull/46#discussion_r1256568342 ## commons-statistics-descriptive/src/main/java/org/apache/commons/statistics/descriptive/Statistic.java: ## @@ -0,0 +1,28 @@ +package

[jira] [Comment Edited] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741210#comment-17741210 ] Gary D. Gregory edited comment on POOL-411 at 7/7/23 10:53 PM: --- The following

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741210#comment-17741210 ] Gary D. Gregory commented on POOL-411: -- The following allows the test to pass locally for me in

[jira] [Commented] (IMAGING-355) Large animated GIF takes too much heap memory in getMetadata

[ https://issues.apache.org/jira/browse/IMAGING-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741211#comment-17741211 ] Andrew Khoury commented on IMAGING-355: --- Hi [~ggregory], yes I tested against master as well and

[jira] [Comment Edited] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741210#comment-17741210 ] Gary D. Gregory edited comment on POOL-411 at 7/7/23 11:09 PM: --- The following

[jira] [Comment Edited] (POOL-411) NPE when deregistering key at end of borrow

[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741210#comment-17741210 ] Gary D. Gregory edited comment on POOL-411 at 7/7/23 11:12 PM: --- The following

[GitHub] [commons-email] garydgregory merged pull request #151: Bump github/codeql-action from 2.20.1 to 2.20.3

garydgregory merged PR #151: URL: https://github.com/apache/commons-email/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-text] garydgregory merged pull request #441: Bump github/codeql-action from 2.20.1 to 2.20.3

garydgregory merged PR #441: URL: https://github.com/apache/commons-text/pull/441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: