[jira] [Work logged] (LANG-1410) StringsUtil.isBlank check null first

2018-12-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?focusedWorklogId=176789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176789 ] ASF GitHub Bot logged work on LANG-1410: Author: ASF GitHub Bot

[GitHub] rosti-il commented on issue #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-18 Thread GitBox
rosti-il commented on issue #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#issuecomment-448407328 Force-pushed twice from 27b1742 to 9d8ac06 and then back from 9d8ac06 to 27b1742 because of a confusion a

[jira] [Work logged] (LANG-1410) StringsUtil.isBlank check null first

2018-12-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?focusedWorklogId=176765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176765 ] ASF GitHub Bot logged work on LANG-1410: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1410) StringsUtil.isBlank check null first

2018-12-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?focusedWorklogId=176766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176766 ] ASF GitHub Bot logged work on LANG-1410: Author: ASF GitHub Bot

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-18 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242720230 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsEmptyBlankTest.

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-18 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242720230 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsEmptyBlankTest.

[jira] [Commented] (TEXT-149) StringEscapeUtils.unescapeCsv doesn't remove quotes at begin and end of string

2018-12-18 Thread Krzysztof Szalast (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724485#comment-16724485 ] Krzysztof Szalast commented on TEXT-149: After my fix, I have test failure: {code:j

[jira] [Work logged] (LANG-1410) StringsUtil.isBlank check null first

2018-12-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?focusedWorklogId=176695&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176695 ] ASF GitHub Bot logged work on LANG-1410: Author: ASF GitHub Bot

[GitHub] MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-18 Thread GitBox
MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242667471 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsEmptyBlankTest

[jira] [Updated] (JEXL-284) Break down recursive expressions- Handy print

2018-12-18 Thread Osy (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Osy updated JEXL-284: - Summary: Break down recursive expressions- Handy print (was: Break down recursive expressions) > Break down recursive exp

[jira] [Created] (JEXL-284) Break down recursive expressions

2018-12-18 Thread Osy (JIRA)
Osy created JEXL-284: Summary: Break down recursive expressions Key: JEXL-284 URL: https://issues.apache.org/jira/browse/JEXL-284 Project: Commons JEXL Issue Type: New Feature Affects Versions: 3.1

[jira] [Resolved] (JEXL-283) JexlEngine parse an expression in wrong way.It seems like create a SimpleNode in the ASTJexlScript

2018-12-18 Thread Henri Biestro (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-283. Resolution: Cannot Reproduce I'm sorry but as is, this is not a bug report. You need at least a repro

[jira] [Resolved] (JEXL-280) break/continue statements outside of the loop

2018-12-18 Thread Henri Biestro (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-280. Resolution: Fixed Assignee: Henri Biestro Fix Version/s: 3.2 Added stack of loop coun

[GitHub] chtompki commented on issue #391: Adding junits for JsonToStringStyle

2018-12-18 Thread GitBox
chtompki commented on issue #391: Adding junits for JsonToStringStyle URL: https://github.com/apache/commons-lang/pull/391#issuecomment-448221818 I'll try to get to this today. This is an automated message from the Apache Git

[GitHub] chtompki commented on issue #391: Adding junits for JsonToStringStyle

2018-12-18 Thread GitBox
chtompki commented on issue #391: Adding junits for JsonToStringStyle URL: https://github.com/apache/commons-lang/pull/391#issuecomment-448218634 I'm fairly indifferent about how the strings are declared as they are tests. The concatenation is a tad odd to me because it seems to be unnecess

[jira] [Comment Edited] (JEXL-281) MethodExecutor incorrectly tests for empty parameters list

2018-12-18 Thread Henri Biestro (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723093#comment-16723093 ] Henri Biestro edited comment on JEXL-281 at 12/18/18 10:18 AM: --

[jira] [Comment Edited] (JEXL-282) Pragmas with antish names are broken

2018-12-18 Thread Henri Biestro (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723895#comment-16723895 ] Henri Biestro edited comment on JEXL-282 at 12/18/18 10:17 AM: --

[jira] [Resolved] (JEXL-282) Pragmas with antish names are broken

2018-12-18 Thread Henri Biestro (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-282. Resolution: Fixed Assignee: Henri Biestro Fix Version/s: 3.2 Fixed grammar and test r

[jira] [Updated] (JEXL-283) JexlEngine parse an expression in wrong way.It seems like create a SimpleNode in the ASTJexlScript

2018-12-18 Thread Henri Biestro (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-283: --- Affects Version/s: 2.0.1 > JexlEngine parse an expression in wrong way.It seems like create a SimpleNod