[GitHub] [commons-csv] dota17 commented on issue #57: fix typo from let's you to let you

2020-02-12 Thread GitBox 
dota17 commented on issue #57: fix typo from let's you to let you
URL: https://github.com/apache/commons-csv/pull/57#issuecomment-585592416
 
 
   @garydgregory so sorry, I have re-commited it


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] coveralls edited a comment on issue #57: fix typo from let's you to let you

2020-02-12 Thread GitBox 
coveralls edited a comment on issue #57: fix typo from let's you to let you
URL: https://github.com/apache/commons-csv/pull/57#issuecomment-583985998
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/28704852/badge)](https://coveralls.io/builds/28704852)
   
   Coverage remained the same at 93.227% when pulling 
**e754863d1304e213e5611a402782134e4456d8e1 on dota17:fix_typolet** into 
**e60777139fa7e93cf8fac5511c54334f9f36c775 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (NUMBERS-144) Rat check fails on examples module files

2020-02-12 Thread Alex Herbert (Jira) 


[ 
https://issues.apache.org/jira/browse/NUMBERS-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035974#comment-17035974
 ] 

Alex Herbert commented on NUMBERS-144:
--

This is strange. The rat check should ignore items in the main project 
.gitignore file. This contains:
{noformat}
.classpath
.project
.settings
target
{noformat}

What build environment are you using?


> Rat check fails on examples module files
> 
>
> Key: NUMBERS-144
> URL: https://issues.apache.org/jira/browse/NUMBERS-144
> Project: Commons Numbers
>  Issue Type: Task
>Reporter: Matt Juntunen
>Priority: Trivial
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The rat check can fail due to the presence of generated files from the 
> examples module. For example, the following files caused the rat check to 
> fail on my machine:
> {noformat}
>   commons-numbers-examples/examples-jmh/target/rat.txt
>   commons-numbers-examples/examples-jmh/target/osgi/MANIFEST.MF
>   commons-numbers-examples/examples-jmh/.classpath
>   commons-numbers-examples/examples-jmh/.settings/org.eclipse.m2e.core.prefs
>   commons-numbers-examples/examples-jmh/.settings/org.eclipse.jdt.core.prefs
>   
> commons-numbers-examples/examples-jmh/.settings/org.eclipse.core.resources.prefs
>   commons-numbers-examples/examples-jmh/.project
>   commons-numbers-examples/.settings/org.eclipse.m2e.core.prefs
>   commons-numbers-examples/.settings/org.eclipse.core.resources.prefs
>   commons-numbers-examples/.project
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (NUMBERS-144) Rat check fails on examples module files

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/NUMBERS-144?focusedWorklogId=386366=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386366
 ]

ASF GitHub Bot logged work on NUMBERS-144:
--

Author: ASF GitHub Bot
Created on: 13/Feb/20 02:59
Start Date: 13/Feb/20 02:59
Worklog Time Spent: 10m 
  Work Description: coveralls commented on issue #75: NUMBERS-144: Fixing 
rat check failures from examples module
URL: https://github.com/apache/commons-numbers/pull/75#issuecomment-585525596
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/28701553/badge)](https://coveralls.io/builds/28701553)
   
   Coverage remained the same at 98.391% when pulling 
**29d531975be3b9d282d8b9c9b2381589c2efe2a9 on darkma773r:numbers-144** into 
**b7925803fda67fe27fbb2175c0773e6efba435ba on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 386366)
Time Spent: 20m  (was: 10m)

> Rat check fails on examples module files
> 
>
> Key: NUMBERS-144
> URL: https://issues.apache.org/jira/browse/NUMBERS-144
> Project: Commons Numbers
>  Issue Type: Task
>Reporter: Matt Juntunen
>Priority: Trivial
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The rat check can fail due to the presence of generated files from the 
> examples module. For example, the following files caused the rat check to 
> fail on my machine:
> {noformat}
>   commons-numbers-examples/examples-jmh/target/rat.txt
>   commons-numbers-examples/examples-jmh/target/osgi/MANIFEST.MF
>   commons-numbers-examples/examples-jmh/.classpath
>   commons-numbers-examples/examples-jmh/.settings/org.eclipse.m2e.core.prefs
>   commons-numbers-examples/examples-jmh/.settings/org.eclipse.jdt.core.prefs
>   
> commons-numbers-examples/examples-jmh/.settings/org.eclipse.core.resources.prefs
>   commons-numbers-examples/examples-jmh/.project
>   commons-numbers-examples/.settings/org.eclipse.m2e.core.prefs
>   commons-numbers-examples/.settings/org.eclipse.core.resources.prefs
>   commons-numbers-examples/.project
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-numbers] coveralls commented on issue #75: NUMBERS-144: Fixing rat check failures from examples module

2020-02-12 Thread GitBox 
coveralls commented on issue #75: NUMBERS-144: Fixing rat check failures from 
examples module
URL: https://github.com/apache/commons-numbers/pull/75#issuecomment-585525596
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/28701553/badge)](https://coveralls.io/builds/28701553)
   
   Coverage remained the same at 98.391% when pulling 
**29d531975be3b9d282d8b9c9b2381589c2efe2a9 on darkma773r:numbers-144** into 
**b7925803fda67fe27fbb2175c0773e6efba435ba on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Work logged] (NUMBERS-144) Rat check fails on examples module files

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/NUMBERS-144?focusedWorklogId=386365=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386365
 ]

ASF GitHub Bot logged work on NUMBERS-144:
--

Author: ASF GitHub Bot
Created on: 13/Feb/20 02:53
Start Date: 13/Feb/20 02:53
Worklog Time Spent: 10m 
  Work Description: darkma773r commented on pull request #75: NUMBERS-144: 
Fixing rat check failures from examples module
URL: https://github.com/apache/commons-numbers/pull/75
 
 
   Adding standard rat exclusions to prevent failures from files in the 
examples module.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 386365)
Remaining Estimate: 0h
Time Spent: 10m

> Rat check fails on examples module files
> 
>
> Key: NUMBERS-144
> URL: https://issues.apache.org/jira/browse/NUMBERS-144
> Project: Commons Numbers
>  Issue Type: Task
>Reporter: Matt Juntunen
>Priority: Trivial
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The rat check can fail due to the presence of generated files from the 
> examples module. For example, the following files caused the rat check to 
> fail on my machine:
> {noformat}
>   commons-numbers-examples/examples-jmh/target/rat.txt
>   commons-numbers-examples/examples-jmh/target/osgi/MANIFEST.MF
>   commons-numbers-examples/examples-jmh/.classpath
>   commons-numbers-examples/examples-jmh/.settings/org.eclipse.m2e.core.prefs
>   commons-numbers-examples/examples-jmh/.settings/org.eclipse.jdt.core.prefs
>   
> commons-numbers-examples/examples-jmh/.settings/org.eclipse.core.resources.prefs
>   commons-numbers-examples/examples-jmh/.project
>   commons-numbers-examples/.settings/org.eclipse.m2e.core.prefs
>   commons-numbers-examples/.settings/org.eclipse.core.resources.prefs
>   commons-numbers-examples/.project
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-numbers] darkma773r opened a new pull request #75: NUMBERS-144: Fixing rat check failures from examples module

2020-02-12 Thread GitBox 
darkma773r opened a new pull request #75: NUMBERS-144: Fixing rat check 
failures from examples module
URL: https://github.com/apache/commons-numbers/pull/75
 
 
   Adding standard rat exclusions to prevent failures from files in the 
examples module.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (NUMBERS-144) Rat check fails on examples module files

2020-02-12 Thread Matt Juntunen (Jira) 
Matt Juntunen created NUMBERS-144:
-

 Summary: Rat check fails on examples module files
 Key: NUMBERS-144
 URL: https://issues.apache.org/jira/browse/NUMBERS-144
 Project: Commons Numbers
  Issue Type: Task
Reporter: Matt Juntunen


The rat check can fail due to the presence of generated files from the examples 
module. For example, the following files caused the rat check to fail on my 
machine:

{noformat}
  commons-numbers-examples/examples-jmh/target/rat.txt
  commons-numbers-examples/examples-jmh/target/osgi/MANIFEST.MF
  commons-numbers-examples/examples-jmh/.classpath
  commons-numbers-examples/examples-jmh/.settings/org.eclipse.m2e.core.prefs
  commons-numbers-examples/examples-jmh/.settings/org.eclipse.jdt.core.prefs
  
commons-numbers-examples/examples-jmh/.settings/org.eclipse.core.resources.prefs
  commons-numbers-examples/examples-jmh/.project
  commons-numbers-examples/.settings/org.eclipse.m2e.core.prefs
  commons-numbers-examples/.settings/org.eclipse.core.resources.prefs
  commons-numbers-examples/.project
{noformat}




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (DBCP-561) NullPointerException occurs

2020-02-12 Thread Gary D. Gregory (Jira) 


[ 
https://issues.apache.org/jira/browse/DBCP-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035862#comment-17035862
 ] 

Gary D. Gregory commented on DBCP-561:
--

[~hayashiy]

Please update to the current version 2.7.0; 1.x line is very old and quite 
unlikely to have a new release.

 

> NullPointerException occurs
> ---
>
> Key: DBCP-561
> URL: https://issues.apache.org/jira/browse/DBCP-561
> Project: Commons DBCP
>  Issue Type: Bug
>Affects Versions: 1.4
>Reporter: Yasufumi Hayashi
>Priority: Major
> Attachments: PoolingTest2.java
>
>
> The following error sometimes occurs with the attached program.
>  * java.lang.NullPointerExceptionjava.lang.NullPointerException
> at 
> org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl.prepareStatement(PooledConnectionImpl.java:243)
> at 
> org.apache.commons.dbcp.cpdsadapter.ConnectionImpl.prepareStatement(ConnectionImpl.java:95)
>  at PoolingThread2.selectSysdate(PoolingTest2.java:173)
> at PoolingThread2.run(PoolingTest2.java:147)
>  * java.sql.SQLRecoverableException: クローズされた接続です。
> at 
> oracle.jdbc.driver.PhysicalConnection.prepareStatementInternal(PhysicalConnection.java:1994)
> at 
> oracle.jdbc.driver.PhysicalConnection.prepareStatement(PhysicalConnection.java:1960)
>  at 
> oracle.jdbc.driver.PhysicalConnection.prepareStatement(PhysicalConnection.java:1866)
>  at 
> org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl.prepareStatement(PooledConnectionImpl.java:243)
>  
> at 
> org.apache.commons.dbcp.cpdsadapter.ConnectionImpl.prepareStatement(ConnectionImpl.java:95)
>  
> at PoolingThread2.selectSysdate(PoolingTest2.java:173) 
> at PoolingThread2.run(PoolingTest2.java:147)
>  
> Does not occur with dbcp 1.2.2, but occurs with dbcp 1.4.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CSV-93) Allow the handling of NULL values

2020-02-12 Thread Chen (Jira) 


[ 
https://issues.apache.org/jira/browse/CSV-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035850#comment-17035850
 ] 

Chen commented on CSV-93:
-

I think this issue is related with 
[csv-253|https://issues.apache.org/jira/browse/CSV-253]

> Allow the handling of NULL values
> -
>
> Key: CSV-93
> URL: https://issues.apache.org/jira/browse/CSV-93
> Project: Commons CSV
>  Issue Type: Improvement
>  Components: Documentation, Parser, Printer
>Affects Versions: 1.0
>Reporter: Georg Tsakumagos
>Priority: Major
> Fix For: 1.0
>
> Attachments: CSV-93.diff, patch.txt
>
>
> h5. Requirement
> To use the CSV parser and printer for SQL Dumps it would be nice if they 
> could handle *null* values. 
> h5. Specification
> To distinguish between an *empty* or *null* value empty values always gets 
> quoted to denote an empty string. The absence of an quote denotes a *null* 
> value
> h5. Configuration
> To activate the behavior call the method _withNullObjectPatternEnabled_ of 
> the _CSVFormat_ with parameter _true_.
> h5. Modifications
> See attached patch.
> h5. Example
> This example using as base the _DEFAULT_ _CSVFormat_ modified by the 
> NullObjectPattern behavior.
> || Array-Data || CSV-Data ||
> | \{null,"","A"," "\}; |,"A",""," " |
> | \{"",null,"A"," "\} |"",,"A"," " |
> | \{"","A",null\} |"","A", |
> h5. NULL in DBMS proprietary CSV formats
> || Product || Strategy || Documentation / Link ||
> | PostgreSQL | If NULL should be preserved all non NULL values gets quoted | 
> [PostgreSQL 8.1 
> Manual|http://www.postgresql.org/docs/8.1/static/sql-copy.html] |
> | MySQL | NULL Values will be replaced by the letters NULL or escaped by \n | 
> not found, verified with MySQL Workbench | 
> | MS SQL | NULL values will be exported as empty strings (no quotes). Strings 
> will be quoted if needed. Import can interpret them as null | 
> [MSDN|http://msdn.microsoft.com/en-us//library/ms187887] | 
> | Oracle | NULL Values will be replaced by the letters NULL | 
> [Manual|http://docs.oracle.com/cd/B25329_01/doc/admin.102/b25107/impexp.htm] |



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (LANG-1517) a spelling issue in ArrayUtils method removeALlOccurences

2020-02-12 Thread bill-liuwenbin (Jira) 


[ 
https://issues.apache.org/jira/browse/LANG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035845#comment-17035845
 ] 

bill-liuwenbin commented on LANG-1517:
--

the word is correct but still using removeAllOccurences not remove all 
*occu{color:#FF}rr{color}ences. there is no need to upgrade their jar 
version, with the new version coming we get the correct type is just fan* 

> a spelling issue in ArrayUtils method removeALlOccurences
> -
>
> Key: LANG-1517
> URL: https://issues.apache.org/jira/browse/LANG-1517
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.9
>Reporter: bill-liuwenbin
>Priority: Major
>  Labels: easyfix
> Fix For: 3.9
>
>
> a spelling issue in ArrayUtils method removeALlOccurences, the problem is 
> where is a typo in it. should be removeAllOccurrences.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-csv] garydgregory merged pull request #56: Replace findbugs with spotbugs

2020-02-12 Thread GitBox 
garydgregory merged pull request #56: Replace findbugs with spotbugs
URL: https://github.com/apache/commons-csv/pull/56
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] garydgregory commented on issue #57: fix typo from let's you to let you

2020-02-12 Thread GitBox 
garydgregory commented on issue #57: fix typo from let's you to let you
URL: https://github.com/apache/commons-csv/pull/57#issuecomment-585417490
 
 
   Neither are correct, it should be "lets".


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2020-02-12 Thread Gilles Sadowski (Jira) 


 [ 
https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gilles Sadowski resolved NUMBERS-40.

Resolution: Done

Commit b7925803fda67fe27fbb2175c0773e6efba435ba ("master" branch).
Sorry for the delay.

> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
>  Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
>  Labels: exception
> Fix For: 1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs 
> {{IllegalArgumentException}}).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/NUMBERS-40?focusedWorklogId=386185=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386185
 ]

ASF GitHub Bot logged work on NUMBERS-40:
-

Author: ASF GitHub Bot
Created on: 12/Feb/20 19:59
Start Date: 12/Feb/20 19:59
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #74: NUMBERS-40: 
Fixing inconsistent exception behavior
URL: https://github.com/apache/commons-numbers/pull/74
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 386185)
Time Spent: 40m  (was: 0.5h)

> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
>  Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
>  Labels: exception
> Fix For: 1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs 
> {{IllegalArgumentException}}).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/NUMBERS-40?focusedWorklogId=386184=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386184
 ]

ASF GitHub Bot logged work on NUMBERS-40:
-

Author: ASF GitHub Bot
Created on: 12/Feb/20 19:59
Start Date: 12/Feb/20 19:59
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #74: NUMBERS-40: 
Fixing inconsistent exception behavior
URL: https://github.com/apache/commons-numbers/pull/74
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 386184)
Time Spent: 0.5h  (was: 20m)

> Review exception usage in package "o.a.c.numbers.gamma"
> ---
>
> Key: NUMBERS-40
> URL: https://issues.apache.org/jira/browse/NUMBERS-40
> Project: Commons Numbers
>  Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
>  Labels: exception
> Fix For: 1.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs 
> {{IllegalArgumentException}}).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-numbers] asfgit closed pull request #74: NUMBERS-40: Fixing inconsistent exception behavior

2020-02-12 Thread GitBox 
asfgit closed pull request #74: NUMBERS-40: Fixing inconsistent exception 
behavior
URL: https://github.com/apache/commons-numbers/pull/74
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-numbers] asfgit merged pull request #74: NUMBERS-40: Fixing inconsistent exception behavior

2020-02-12 Thread GitBox 
asfgit merged pull request #74: NUMBERS-40: Fixing inconsistent exception 
behavior
URL: https://github.com/apache/commons-numbers/pull/74
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (IO-651) Provide method to retrieve data from DeferredFileOutputStream as InputStream

2020-02-12 Thread John Mark (Jira) 
John Mark created IO-651:


 Summary: Provide method to retrieve data from 
DeferredFileOutputStream as InputStream
 Key: IO-651
 URL: https://issues.apache.org/jira/browse/IO-651
 Project: Commons IO
  Issue Type: Improvement
  Components: Streams/Writers
Affects Versions: 2.6
Reporter: John Mark


It would be very helpful to have to {{toInputStream()}} method on the 
{{DeferredFileOutputStream}} class. Besides for convenience, it would allow for 
improved efficiency since in the case of in-memory data the byte buffer would 
not need to be copied (as opposed to the current {{getData()}} method). 

The implementation is pretty simple and can be something like the following 
(based on the current {{writeTo(OutputStream)}} method):
{code:java}
public InputStream toInputStream() throws IOException {
if (!closed) {
throw new IOException("Stream not closed");
}

if (isInMemory()) {
return memoryOutputStream.toInputStream();
} else {
return Files.newInputStream(outputFile.toPath());
}
}
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JEXL-302) JexlScript.getVariables returns strange values for array access

2020-02-12 Thread Dmitri Blinov (Jira) 


[ 
https://issues.apache.org/jira/browse/JEXL-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035185#comment-17035185
 ] 

Dmitri Blinov commented on JEXL-302:


Thanks for the clarification, it was the transion from {{a[['b', 'c']]}} to 
{{[a.b, a.c]}} that I wasn't able to figure out. This is not obvious because 
getting list of properties via array access is not supported anywhere in the 
basic implementation. Not sure whether it's worth adding such a feature though. 
But one thing that I think is strange here is that \{{getVariables()}}  in fact 
*relies* on the hypotesis that one should implement array access to support 
sets and arrays in such a way.

> JexlScript.getVariables returns strange values for array access
> ---
>
> Key: JEXL-302
> URL: https://issues.apache.org/jira/browse/JEXL-302
> Project: Commons JEXL
>  Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Assignee: Henri Biestro
>Priority: Minor
> Fix For: 3.2
>
>
> I can not understand the logic behind the current implementation of 
> {{JexlScript.getVariables()}} method. From the documentation we know that the 
> result should be the set of script variables. For the code
> {code:java}
> a[b][c]{code}
> it gives three variables {{a}}, {{b}}, {{c}}. So far so good. But for the code
> {code:java}
> a[b]['c']{code}
> it returns {{a}} and {{b c}}, where second variable has two fragments {{b}} 
> and {{c}}. The documentation states that variables with multiple fragments 
> are ant-ish variables, but I don't have any of ant-ish variables in the 
> example, and {{'c'}} is not a variable, but a constant. I expect to get {{a}} 
> and {{b}} as a result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)