[jira] [Closed] (VALIDATOR-466) An update is needed of generic TLDS in DomainValidator

2020-06-02 Thread Chengzhen Pan (Jira)
[ https://issues.apache.org/jira/browse/VALIDATOR-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengzhen Pan closed VALIDATOR-466. --- Resolution: Fixed I fixed the problem by making an extension.  > An update is needed of g

[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440591 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub B

[GitHub] [commons-compress] bodewig commented on pull request #104: [COMPRESS-533] Refine javadoc and fix typos

2020-06-02 Thread GitBox
bodewig commented on pull request #104: URL: https://github.com/apache/commons-compress/pull/104#issuecomment-637943848 I'm not sure we've got an agreed upon language at all :-) In this particular case it may depend on the context. `archiveName` would be the file name of an archive, `arc

[GitHub] [commons-compress] bodewig merged pull request #104: [COMPRESS-533] Refine javadoc and fix typos

2020-06-02 Thread GitBox
bodewig merged pull request #104: URL: https://github.com/apache/commons-compress/pull/104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440590 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub B

[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440579 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot

[GitHub] [commons-math] coveralls commented on pull request #139: [MATH-1537] fix_typos

2020-06-02 Thread GitBox
coveralls commented on pull request #139: URL: https://github.com/apache/commons-math/pull/139#issuecomment-637927612 [![Coverage Status](https://coveralls.io/builds/31201660/badge)](https://coveralls.io/builds/31201660) Coverage increased (+0.008%) to 90.56% when pulling **9ae1

[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440576 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot

[GitHub] [commons-math] coveralls commented on pull request #137: [MATH-1537] refine javadoc

2020-06-02 Thread GitBox
coveralls commented on pull request #137: URL: https://github.com/apache/commons-math/pull/137#issuecomment-637925201 [![Coverage Status](https://coveralls.io/builds/31201574/badge)](https://coveralls.io/builds/31201574) Coverage remained the same at 90.552% when pulling **84f08

[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440567&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440567 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot

[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440566 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot

[jira] [Commented] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread JIN XU (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124533#comment-17124533 ] JIN XU commented on MATH-1537: -- [~erans] Hi. This pr is splited into 3 prs now. [https://g

[GitHub] [commons-math] XenoAmess closed pull request #136: [MATH-1537] Refine jafvadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess closed pull request #136: URL: https://github.com/apache/commons-math/pull/136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [commons-math] XenoAmess commented on pull request #136: [MATH-1537] Refine jafvadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on pull request #136: URL: https://github.com/apache/commons-math/pull/136#issuecomment-637917495 This pr is splited into 3 prs now. https://github.com/apache/commons-math/pull/137 https://github.com/apache/commons-math/pull/138 https://github.com/apa

[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440563 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot

[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440560&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440560 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot

[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440561 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot

[GitHub] [commons-math] XenoAmess opened a new pull request #139: [MATH-1537] fix_typos

2020-06-02 Thread GitBox
XenoAmess opened a new pull request #139: URL: https://github.com/apache/commons-math/pull/139 fix typos This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [commons-math] XenoAmess opened a new pull request #138: [MATH-1537] delete unused imports

2020-06-02 Thread GitBox
XenoAmess opened a new pull request #138: URL: https://github.com/apache/commons-math/pull/138 delete unused imports This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [commons-math] XenoAmess opened a new pull request #137: [MATH-1537] refine javadoc

2020-06-02 Thread GitBox
XenoAmess opened a new pull request #137: URL: https://github.com/apache/commons-math/pull/137 refine javadoc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [commons-imaging] changbaishan commented on pull request #50: Need *.webp type images reader and writer

2020-06-02 Thread GitBox
changbaishan commented on pull request #50: URL: https://github.com/apache/commons-imaging/pull/50#issuecomment-637899612 Thanks very much! I really appreciate you and your work. Just that I don't know enough to handle the work. Sorry again. Looking forward to use your new release. -

[jira] [Commented] (IMAGING-57) Support for WEBP Image Format

2020-06-02 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124467#comment-17124467 ] Bruno P. Kinoshita commented on IMAGING-57: --- There was some user interest on Gi

[jira] [Updated] (IMAGING-57) Support for WEBP Image Format

2020-06-02 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-57: -- Affects Version/s: 1.0-alpha1 > Support for WEBP Image Format > ---

[jira] [Reopened] (IMAGING-57) Support for WEBP Image Format

2020-06-02 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita reopened IMAGING-57: --- > Support for WEBP Image Format > - > > Key:

[GitHub] [commons-imaging] kinow commented on pull request #50: Need *.webp type images reader and writer

2020-06-02 Thread GitBox
kinow commented on pull request #50: URL: https://github.com/apache/commons-imaging/pull/50#issuecomment-637876984 FYI https://issues.apache.org/jira/browse/IMAGING-57 This is an automated message from the Apache Git Service.

[GitHub] [commons-imaging] kinow commented on pull request #50: Need *.webp type images reader and writer

2020-06-02 Thread GitBox
kinow commented on pull request #50: URL: https://github.com/apache/commons-imaging/pull/50#issuecomment-637876186 > Is there way I can release myself from this PR? I witnessed wonderful works you did. However, I opened it just to suggest a useful feature. I had no idea of what it actually

[jira] [Commented] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124347#comment-17124347 ] Gilles Sadowski commented on MATH-1537: --- Thanks for trying to help! However there a

[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440416 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot

[GitHub] [commons-math] coveralls commented on pull request #136: [MATH-1537] Refine jafvadoc and fix typos

2020-06-02 Thread GitBox
coveralls commented on pull request #136: URL: https://github.com/apache/commons-math/pull/136#issuecomment-637776924 [![Coverage Status](https://coveralls.io/builds/31195244/badge)](https://coveralls.io/builds/31195244) Coverage remained the same at 90.552% when pulling **91ae0

[jira] [Commented] (BCEL-340) Make AnnotationEntry methods public

2020-06-02 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/BCEL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124223#comment-17124223 ] Gary D. Gregory commented on BCEL-340: -- [~markro] You're welcome. Note that the build

[jira] [Created] (MATH-1537) refine javadoc and fix typos.

2020-06-02 Thread JIN XU (Jira)
JIN XU created MATH-1537: Summary: refine javadoc and fix typos. Key: MATH-1537 URL: https://issues.apache.org/jira/browse/MATH-1537 Project: Commons Math Issue Type: Improvement Reporter

[jira] [Commented] (BCEL-340) Make AnnotationEntry methods public

2020-06-02 Thread Mark Roberts (Jira)
[ https://issues.apache.org/jira/browse/BCEL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124216#comment-17124216 ] Mark Roberts commented on BCEL-340: --- Thank you for your understanding and prompt response

[GitHub] [commons-math] XenoAmess opened a new pull request #136: Refine jafvadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess opened a new pull request #136: URL: https://github.com/apache/commons-math/pull/136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Resolved] (BCEL-340) Make AnnotationEntry methods public

2020-06-02 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/BCEL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved BCEL-340. -- Fix Version/s: 6.5.0 Resolution: Fixed Thanks [~markro] > Make AnnotationEntry methods pu

[GitHub] [commons-bcel] garydgregory merged pull request #45: Make some annotation methods public

2020-06-02 Thread GitBox
garydgregory merged pull request #45: URL: https://github.com/apache/commons-bcel/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (IMAGING-258) TiffReader.readDirectories() fails on EXIF data

2020-06-02 Thread Gary Lucas (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124128#comment-17124128 ] Gary Lucas commented on IMAGING-258: If anyone has a small TIFF file that exhibits t

[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440270 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub B

[GitHub] [commons-compress] XenoAmess commented on a change in pull request #104: [COMPRESS-533] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #104: URL: https://github.com/apache/commons-compress/pull/104#discussion_r434015443 ## File path: src/main/java/org/apache/commons/compress/compressors/lzma/LZMAUtils.java ## @@ -146,7 +146,7 @@ public static String getCompresse

[GitHub] [commons-compress] coveralls edited a comment on pull request #104: [COMPRESS-533] Refine javadoc and fix typos

2020-06-02 Thread GitBox
coveralls edited a comment on pull request #104: URL: https://github.com/apache/commons-compress/pull/104#issuecomment-637555662 [![Coverage Status](https://coveralls.io/builds/31190148/badge)](https://coveralls.io/builds/31190148) Coverage increased (+0.01%) to 87.242% when pull

[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440267 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub B

[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440268 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub B

[GitHub] [commons-compress] XenoAmess commented on a change in pull request #104: [COMPRESS-533] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #104: URL: https://github.com/apache/commons-compress/pull/104#discussion_r434015189 ## File path: src/main/java/org/apache/commons/compress/compressors/brotli/BrotliUtils.java ## @@ -72,7 +72,7 @@ private static boolean internal

[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440262 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub B

[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440260 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub B

[GitHub] [commons-compress] XenoAmess commented on a change in pull request #104: [COMPRESS-533] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #104: URL: https://github.com/apache/commons-compress/pull/104#discussion_r434014704 ## File path: src/main/java/org/apache/commons/compress/compressors/zstandard/ZstdUtils.java ## @@ -85,7 +85,7 @@ private static boolean interna

[GitHub] [commons-compress] XenoAmess commented on a change in pull request #104: [COMPRESS-533] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #104: URL: https://github.com/apache/commons-compress/pull/104#discussion_r434014481 ## File path: src/main/java/org/apache/commons/compress/compressors/xz/XZUtils.java ## @@ -163,7 +163,7 @@ public static String getCompressedFile

[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440258&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440258 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub B

[GitHub] [commons-compress] XenoAmess commented on pull request #104: [COMPRESS-533] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on pull request #104: URL: https://github.com/apache/commons-compress/pull/104#issuecomment-637665602 @bodewig done. I also have a question. Do `archiveName` and `archiverName` means one same thing in this repo? If so, should we consider uniform them to `arch

[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440193 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub B

[GitHub] [commons-compress] bodewig commented on a change in pull request #104: [COMPRESS-533] Refine javadoc and fix typos

2020-06-02 Thread GitBox
bodewig commented on a change in pull request #104: URL: https://github.com/apache/commons-compress/pull/104#discussion_r433958060 ## File path: src/main/java/org/apache/commons/compress/compressors/lzma/LZMAUtils.java ## @@ -146,7 +146,7 @@ public static String getCompressedF

[jira] [Commented] (BCEL-340) Make AnnotationEntry methods public

2020-06-02 Thread Mark Roberts (Jira)
[ https://issues.apache.org/jira/browse/BCEL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123920#comment-17123920 ] Mark Roberts commented on BCEL-340: --- will look into improving test coverage as time allow

[jira] [Commented] (BCEL-340) Make AnnotationEntry methods public

2020-06-02 Thread Mark Roberts (Jira)
[ https://issues.apache.org/jira/browse/BCEL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123918#comment-17123918 ] Mark Roberts commented on BCEL-340: --- [https://github.com/apache/commons-bcel/pull/45] >

[GitHub] [commons-bcel] markro49 opened a new pull request #45: make some annotation methods public

2020-06-02 Thread GitBox
markro49 opened a new pull request #45: URL: https://github.com/apache/commons-bcel/pull/45 make some Annotation methods public - note that the matching Attribute methods already are public. This is an automated message from

[jira] [Commented] (BCEL-340) Make AnnotationEntry methods public

2020-06-02 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/BCEL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123858#comment-17123858 ] Gary D. Gregory commented on BCEL-340: -- [~markro] I'll watch for the PR... will this i

[jira] [Created] (BCEL-340) Make AnnotationEntry methods public

2020-06-02 Thread Mark Roberts (Jira)
Mark Roberts created BCEL-340: - Summary: Make AnnotationEntry methods public Key: BCEL-340 URL: https://issues.apache.org/jira/browse/BCEL-340 Project: Commons BCEL Issue Type: Improvement

[jira] [Created] (COMPRESS-533) Refine javadoc and fix typos

2020-06-02 Thread JIN XU (Jira)
JIN XU created COMPRESS-533: --- Summary: Refine javadoc and fix typos Key: COMPRESS-533 URL: https://issues.apache.org/jira/browse/COMPRESS-533 Project: Commons Compress Issue Type: Improvement

[GitHub] [commons-compress] coveralls commented on pull request #104: Refine javadoc and fix typos

2020-06-02 Thread GitBox
coveralls commented on pull request #104: URL: https://github.com/apache/commons-compress/pull/104#issuecomment-637555662 [![Coverage Status](https://coveralls.io/builds/31186025/badge)](https://coveralls.io/builds/31186025) Coverage increased (+0.01%) to 87.242% when pulling **

[GitHub] [commons-compress] XenoAmess opened a new pull request #104: Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess opened a new pull request #104: URL: https://github.com/apache/commons-compress/pull/104 Refine javadoc and fix typos This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [commons-collections] coveralls edited a comment on pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
coveralls edited a comment on pull request #165: URL: https://github.com/apache/commons-collections/pull/165#issuecomment-637488425 [![Coverage Status](https://coveralls.io/builds/31185352/badge)](https://coveralls.io/builds/31185352) Coverage remained the same at 90.123% when p

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440129 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440109&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440109 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-collections] XenoAmess commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433847044 ## File path: src/main/java/org/apache/commons/collections4/trie/PatriciaTrie.java ## @@ -29,7 +29,7 @@ * all data at the edges of the {@li

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440107 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-collections] XenoAmess commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433846044 ## File path: src/main/java/org/apache/commons/collections4/trie/PatriciaTrie.java ## @@ -29,7 +29,7 @@ * all data at the edges of the {@li

[GitHub] [commons-collections] XenoAmess commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433841232 ## File path: src/main/java/org/apache/commons/collections4/list/CursorableLinkedList.java ## @@ -279,7 +279,7 @@ protected void registerCur

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440105 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-collections] XenoAmess commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433841232 ## File path: src/main/java/org/apache/commons/collections4/list/CursorableLinkedList.java ## @@ -279,7 +279,7 @@ protected void registerCur

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440104&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440104 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-beanutils] XenoAmess commented on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
XenoAmess commented on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637512569 result json: ``` [ { "jmhVersion" : "1.21", "benchmark" : "org.apache.commons.beanutils2.performance.MethodUtilsTest.test1Old",

[GitHub] [commons-beanutils] XenoAmess commented on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
XenoAmess commented on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637510839 **conclusion:** very slightly faster when using `==`. the differences are too small to tell whether it be meaningful. So I don't think it worth a try. I will r

[GitHub] [commons-collections] dota17 commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
dota17 commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433834707 ## File path: src/main/java/org/apache/commons/collections4/trie/PatriciaTrie.java ## @@ -29,7 +29,7 @@ * all data at the edges of the {@link

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440100 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-collections] dota17 commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
dota17 commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433830911 ## File path: src/main/java/org/apache/commons/collections4/list/CursorableLinkedList.java ## @@ -279,7 +279,7 @@ protected void registerCursor

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440096 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-collections] coveralls commented on pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
coveralls commented on pull request #165: URL: https://github.com/apache/commons-collections/pull/165#issuecomment-637488425 [![Coverage Status](https://coveralls.io/builds/31183231/badge)](https://coveralls.io/builds/31183231) Coverage decreased (-0.03%) to 90.094% when pulling

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440081&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440081 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-collections] kinow commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
kinow commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433816020 ## File path: src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java ## @@ -341,10 +341,6 @@ public V selectValue(final K

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440079 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-beanutils] melloware commented on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
melloware commented on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637487780 I never think its a bad idea to add unit tests to an open source library if they are quality tests and help prove a point. -

[GitHub] [commons-beanutils] XenoAmess commented on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
XenoAmess commented on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637485487 > I agree adding the unit test is a good addition. Also I can't tell did changing it from `equals` to `==` really improve performance? I just delayed it because I

[GitHub] [commons-beanutils] melloware commented on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
melloware commented on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637480797 I agree adding the unit test is a good addition. Also I can't tell did changing it from `equals` to `==` really improve performance? --

[GitHub] [commons-collections] XenoAmess commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433795336 ## File path: src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java ## @@ -341,10 +341,6 @@ public V selectValue(fina

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440062&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440062 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-collections] XenoAmess commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433795336 ## File path: src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java ## @@ -341,10 +341,6 @@ public V selectValue(fina

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440061 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440059 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-collections] XenoAmess commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433795336 ## File path: src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java ## @@ -341,10 +341,6 @@ public V selectValue(fina

[GitHub] [commons-collections] kinow commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
kinow commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433788010 ## File path: src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java ## @@ -341,10 +341,6 @@ public V selectValue(final K

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440056&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440056 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[jira] [Work logged] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440054 ] ASF GitHub Bot logged work on COLLECTIONS-764: -- Author: ASF

[GitHub] [commons-collections] XenoAmess commented on pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess commented on pull request #165: URL: https://github.com/apache/commons-collections/pull/165#issuecomment-637457648 Several people suggested me not to put everything in one single pr, but split them. So I listened to their advice, and let things done one by one. -

[jira] [Created] (COLLECTIONS-764) Refine javadoc and fix typos

2020-06-02 Thread JIN XU (Jira)
JIN XU created COLLECTIONS-764: -- Summary: Refine javadoc and fix typos Key: COLLECTIONS-764 URL: https://issues.apache.org/jira/browse/COLLECTIONS-764 Project: Commons Collections Issue Type: Im

[GitHub] [commons-collections] XenoAmess opened a new pull request #165: Refine javadoc and fix typos

2020-06-02 Thread GitBox
XenoAmess opened a new pull request #165: URL: https://github.com/apache/commons-collections/pull/165 1. refine javadocs. 2. fix typos. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [commons-beanutils] XenoAmess edited a comment on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
XenoAmess edited a comment on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637414367 maybe at least we can change the `.equals` here to `==`, as `Class.equals` is actually `==` This

[GitHub] [commons-beanutils] XenoAmess commented on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
XenoAmess commented on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637414367 maybe at least we can change the .equals here to ==, as Class.equals is actually == This is an automate

[GitHub] [commons-beanutils] XenoAmess commented on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
XenoAmess commented on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637403248 result json ``` [ { "jmhVersion" : "1.21", "benchmark" : "org.apache.commons.beanutils2.performance.MethodUtilsTest.test1Old",

[GitHub] [commons-beanutils] XenoAmess commented on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
XenoAmess commented on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637401253 **conclusion:** The original functin is amazingly fastest (at least in the test I made) So I will revert what I changed in source. But, I will not close this pr,

[jira] [Work logged] (TEXT-126) Dice's Coefficient Algorithm in String similarity

2020-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TEXT-126?focusedWorklogId=439987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439987 ] ASF GitHub Bot logged work on TEXT-126: --- Author: ASF GitHub Bot

[GitHub] [commons-text] kinow commented on pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2020-06-02 Thread GitBox
kinow commented on pull request #103: URL: https://github.com/apache/commons-text/pull/103#issuecomment-637386737 Brilliant @ameyjadiye , but if you are busy having fun with commons-graph, we can leave this one for later. Whenever you have time :+1: --

[GitHub] [commons-beanutils] XenoAmess commented on pull request #26: [BEANUTILS-538] refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType

2020-06-02 Thread GitBox
XenoAmess commented on pull request #26: URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-637351922 Hi. I found another way in org.apache.commons.jexl3.internal.ArrayBuilder, in commons-jexl. And I will start a performance test for each of them.

  1   2   >