[
https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz closed POOL-411.
> NPE when deregistering key at end of borrow
> ---
>
>
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342196281
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunkVp8x.java:
##
@@ -42,76 +45,105 @@
* }
*
* @see
Glavo commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342195072
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunkVp8x.java:
##
@@ -42,76 +45,105 @@
* }
*
* @see
Glavo commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342194529
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunkVp8x.java:
##
@@ -42,76 +45,105 @@
* }
*
* @see
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342193272
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunk.java:
##
@@ -29,30 +30,50 @@
* used by the parser.
*
* @see
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342193216
##
src/main/java/org/apache/commons/imaging/formats/webp/WebPImageParser.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342193049
##
src/main/java/org/apache/commons/imaging/formats/webp/WebPImageParser.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192794
##
src/main/java/org/apache/commons/imaging/formats/webp/WebPImageParser.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/POOL-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz closed POOL-408.
> A typo of KeyedPooledObjectFactory on the site and Javadoc
>
[
https://issues.apache.org/jira/browse/POOL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz closed POOL-409.
> BasicDataSource should support GenericObjectPool->getStatsString()
>
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192726
##
src/main/java/org/apache/commons/imaging/formats/webp/WebPImageParser.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Glavo commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192570
##
src/main/java/org/apache/commons/imaging/internal/SafeOperations.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/POOL-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz closed POOL-402.
> Check blockWhenExhausted in hasBorrowWaiters
>
>
>
Glavo commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192570
##
src/main/java/org/apache/commons/imaging/internal/SafeOperations.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/POOL-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz closed POOL-394.
> GenericKeyedObjectPool doesn't have getKeys() implemented
>
[
https://issues.apache.org/jira/browse/POOL-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz closed POOL-405.
> NullPointerException at
>
[
https://issues.apache.org/jira/browse/POOL-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz closed POOL-393.
> BaseGenericObjectPool.jmxRegister may cost too much time
>
[
https://issues.apache.org/jira/browse/POOL-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz closed POOL-391.
> GenericKeyedObjectPool is not thread safe when invoke method `borrowObject`
> and `destroy` simultaneously
>
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192494
##
src/main/java/org/apache/commons/imaging/formats/webp/WebPImageMetadata.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192476
##
src/main/java/org/apache/commons/imaging/formats/webp/WebPImageParser.java:
##
@@ -0,0 +1,326 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Glavo commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192400
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunk.java:
##
@@ -29,30 +30,50 @@
* used by the parser.
*
* @see
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192363
##
src/test/java/org/apache/commons/imaging/formats/webp/WebPBaseTest.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192287
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunkVP8X.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192216
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunkVP8X.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192170
##
src/main/java/org/apache/commons/imaging/internal/SafeOperations.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342192003
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunk.java:
##
@@ -61,22 +74,41 @@ public String getTypeDescription() {
(byte)
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342191581
##
src/main/java/org/apache/commons/imaging/formats/webp/WebPImageParser.java:
##
@@ -277,13 +279,14 @@ public void close() throws IOException {
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342191274
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunkVp8x.java:
##
@@ -42,76 +44,105 @@
* }
*
* @see
[
https://issues.apache.org/jira/browse/IO-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770928#comment-17770928
]
Elliotte Rusty Harold edited comment on IO-813 at 10/1/23 9:30 PM:
---
[
https://issues.apache.org/jira/browse/IO-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770928#comment-17770928
]
Elliotte Rusty Harold commented on IO-813:
--
Throwing an exception is not a problem. Throwing an
[
https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770927#comment-17770927
]
Adam Rauch commented on IO-811:
---
Also note that the StreamIterator JavaDoc is a bit misleading in that callers
Glavo commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342188466
##
src/main/java/org/apache/commons/imaging/formats/webp/WebPImageParser.java:
##
@@ -277,13 +279,14 @@ public void close() throws IOException {
[
https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770926#comment-17770926
]
Adam Rauch commented on IO-811:
---
[StreamIterator test PR|https://github.com/apache/commons-io/pull/490]
labkey-adam opened a new pull request, #490:
URL: https://github.com/apache/commons-io/pull/490
Note: This test will fail until `StreamIterator.iterator()` is fixed to
return the wrapper class
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Glavo commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342187578
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunkVp8x.java:
##
@@ -42,76 +44,105 @@
* }
*
* @see
[
https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770924#comment-17770924
]
Gary D. Gregory commented on IO-811:
Just a mistake, the whole class is meant to be package private. You
[
https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Rauch reopened IO-811:
---
FileUtils.listFiles() is now correctly closing the stream. Thanks!
FileUtils.iterateFiles(), however, does not
aherbert commented on PR #138:
URL: https://github.com/apache/commons-numbers/pull/138#issuecomment-1742167478
You can get a local coverage report using:
```
mvn test jacoco:report
open target/site/jacoco/index.html
```
--
This is an automated message from the Apache Git
kinow commented on PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1742114767
> I probably just named them arbitrarily, so feel free to rename them if
necessary.
Thanks @Glavo !
--
This is an automated message from the Apache Git Service.
To respond
Glavo commented on PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1742114264
I probably just named them arbitrarily, so feel free to rename them if
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/IO-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770878#comment-17770878
]
Gary D. Gregory commented on IO-813:
Here is an unrelated example (in the abstract for IO) of why
garydgregory closed pull request #489: IO-811: Files.walk() direct and indirect
callers fail to close the re…
URL: https://github.com/apache/commons-io/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
garydgregory commented on PR #489:
URL: https://github.com/apache/commons-io/pull/489#issuecomment-1742082626
Closing, see above. Jira ticket resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1742082133
Let's make sure we let GitHub squash the commits once this is approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/IO-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved IO-811.
Fix Version/s: 2.14.1
Resolution: Fixed
[~a...@labkey.com]
Thank you for your PR.
Please
garydgregory commented on code in PR #489:
URL: https://github.com/apache/commons-io/pull/489#discussion_r1342131817
##
src/main/java/org/apache/commons/io/FileUtils.java:
##
@@ -1996,7 +1996,29 @@ public static Iterator iterateFiles(final File
directory, final IOFileFilt
sebbASF closed pull request #36: Bump commons-parent from 53 to 56
URL: https://github.com/apache/commons-functor/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sebbASF closed pull request #37: Bump wagon-ssh from 3.5.2 to 3.5.3
URL: https://github.com/apache/commons-functor/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sebbASF closed pull request #38: Bump maven-shade-plugin from 3.4.0 to 3.4.1
URL: https://github.com/apache/commons-functor/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sebbASF closed pull request #143: Bump org.slf4j:slf4j-api from 2.0.7 to 2.0.9
URL: https://github.com/apache/commons-ognl/pull/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
HaraldKi commented on PR #138:
URL: https://github.com/apache/commons-numbers/pull/138#issuecomment-1742024204
Is it possible to get this codecov report out locally with a maven call?
Otherwise I would push an update and hope for the best.
--
This is an automated message from the
Claudenw commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1741991305
@aherbert thank you for your review. Changes have been made to the base
code. One of these days I will figure out how you see all those things that I
seem to miss.
--
52 matches
Mail list logo
