Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-validator]

2024-02-09 Thread via GitHub


garydgregory merged PR #184:
URL: https://github.com/apache/commons-validator/pull/184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-beanutils]

2024-02-09 Thread via GitHub


garydgregory merged PR #212:
URL: https://github.com/apache/commons-beanutils/pull/212


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [IO-405] handle zero and negative thresholds [commons-io]

2024-02-09 Thread via GitHub


garydgregory merged PR #587:
URL: https://github.com/apache/commons-io/pull/587


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-09 Thread via GitHub


garydgregory commented on code in PR #480:
URL: https://github.com/apache/commons-compress/pull/480#discussion_r1484812539


##
src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java:
##
@@ -379,11 +382,28 @@ public ZipExtraField onUnparseableExtraField(final byte[] 
data, final int off, f
  * 
  *
  * @param c the class to register
+ *
+ * todo: "at_deprecated this registration is global and shared by all 
consumers.", find a way to make it specific.

Review Comment:
   Hi @rmannibucau 
   Thank you for your PR. Was this meant to be a draft PR? I don't think we 
should leave TODO's behind.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.assertj:assertj-core from 3.25.2 to 3.25.3 [commons-text]

2024-02-09 Thread via GitHub


garydgregory merged PR #502:
URL: https://github.com/apache/commons-text/pull/502


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.commons:commons-parent from 65 to 66 [commons-email]

2024-02-09 Thread via GitHub


garydgregory commented on PR #212:
URL: https://github.com/apache/commons-email/pull/212#issuecomment-1936602284

   Closing: Done manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.commons:commons-parent from 65 to 66 [commons-email]

2024-02-09 Thread via GitHub


garydgregory closed pull request #212: Bump org.apache.commons:commons-parent 
from 65 to 66
URL: https://github.com/apache/commons-email/pull/212


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump jakarta.mail from 1.6.5 to 2.0.1 [commons-email]

2024-02-09 Thread via GitHub


garydgregory commented on PR #43:
URL: https://github.com/apache/commons-email/pull/43#issuecomment-1936603015

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.slf4j:slf4j-jdk14 from 2.0.11 to 2.0.12 [commons-email]

2024-02-09 Thread via GitHub


garydgregory merged PR #214:
URL: https://github.com/apache/commons-email/pull/214


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-email]

2024-02-09 Thread via GitHub


garydgregory merged PR #213:
URL: https://github.com/apache/commons-email/pull/213


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-text]

2024-02-09 Thread via GitHub


garydgregory merged PR #503:
URL: https://github.com/apache/commons-text/pull/503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-bcel]

2024-02-09 Thread via GitHub


garydgregory merged PR #273:
URL: https://github.com/apache/commons-bcel/pull/273


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-rdf]

2024-02-09 Thread via GitHub


garydgregory merged PR #194:
URL: https://github.com/apache/commons-rdf/pull/194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Drop reflection from ExtraFieldUtils [commons-compress]

2024-02-09 Thread via GitHub


rmannibucau opened a new pull request, #480:
URL: https://github.com/apache/commons-compress/pull/480

   As of today to make [compress] run on native-image (GraalVM) you must 
reister all classes in IMPLEMENTATIONS map. With this PR this is no more needed 
and [compress] zip support comes OOTB.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.assertj:assertj-core from 3.25.2 to 3.25.3 [commons-bcel]

2024-02-09 Thread via GitHub


garydgregory merged PR #272:
URL: https://github.com/apache/commons-bcel/pull/272


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-jxpath]

2024-02-09 Thread via GitHub


garydgregory merged PR #113:
URL: https://github.com/apache/commons-jxpath/pull/113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-fileupload]

2024-02-09 Thread via GitHub


garydgregory merged PR #275:
URL: https://github.com/apache/commons-fileupload/pull/275


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-fileupload]

2024-02-09 Thread via GitHub


garydgregory merged PR #274:
URL: https://github.com/apache/commons-fileupload/pull/274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-exec]

2024-02-09 Thread via GitHub


garydgregory merged PR #157:
URL: https://github.com/apache/commons-exec/pull/157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-exec]

2024-02-09 Thread via GitHub


garydgregory merged PR #158:
URL: https://github.com/apache/commons-exec/pull/158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-imaging]

2024-02-09 Thread via GitHub


garydgregory merged PR #361:
URL: https://github.com/apache/commons-imaging/pull/361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-imaging]

2024-02-09 Thread via GitHub


garydgregory merged PR #360:
URL: https://github.com/apache/commons-imaging/pull/360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.commons:commons-parent from 64 to 66 [commons-pool]

2024-02-09 Thread via GitHub


garydgregory commented on PR #278:
URL: https://github.com/apache/commons-pool/pull/278#issuecomment-1936309708

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-daemon]

2024-02-09 Thread via GitHub


garydgregory merged PR #140:
URL: https://github.com/apache/commons-daemon/pull/140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-daemon]

2024-02-09 Thread via GitHub


garydgregory merged PR #139:
URL: https://github.com/apache/commons-daemon/pull/139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-configuration]

2024-02-09 Thread via GitHub


garydgregory merged PR #361:
URL: https://github.com/apache/commons-configuration/pull/361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-configuration]

2024-02-09 Thread via GitHub


garydgregory merged PR #360:
URL: https://github.com/apache/commons-configuration/pull/360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-codec]

2024-02-09 Thread via GitHub


garydgregory merged PR #242:
URL: https://github.com/apache/commons-codec/pull/242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-codec]

2024-02-09 Thread via GitHub


garydgregory merged PR #241:
URL: https://github.com/apache/commons-codec/pull/241


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-lang]

2024-02-09 Thread via GitHub


garydgregory merged PR #1172:
URL: https://github.com/apache/commons-lang/pull/1172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-lang]

2024-02-09 Thread via GitHub


garydgregory merged PR #1171:
URL: https://github.com/apache/commons-lang/pull/1171


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.commons:commons-parent from 64 to 66 [commons-pool]

2024-02-09 Thread via GitHub


garydgregory commented on PR #278:
URL: https://github.com/apache/commons-pool/pull/278#issuecomment-1935972093

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-pool]

2024-02-09 Thread via GitHub


garydgregory merged PR #280:
URL: https://github.com/apache/commons-pool/pull/280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-pool]

2024-02-09 Thread via GitHub


garydgregory merged PR #279:
URL: https://github.com/apache/commons-pool/pull/279


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 [commons-vfs]

2024-02-09 Thread via GitHub


garydgregory merged PR #480:
URL: https://github.com/apache/commons-vfs/pull/480


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (IO-847) Deprecate public static boolean contentEqualsIgnoreEOL(final File file1, final File file2, final String charsetName)

2024-02-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/IO-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold closed IO-847.


> Deprecate public static boolean contentEqualsIgnoreEOL(final File file1, 
> final File file2, final String charsetName)
> 
>
> Key: IO-847
> URL: https://issues.apache.org/jira/browse/IO-847
> Project: Commons IO
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> Files can be compared byte per byte and we have a method to do that. I can't 
> see a reason to convert two files to the same character set and then compare 
> them. This gives the same answer in all cases where the character encoding is 
> recognized. If the character set isn't available, it might or mght not fail 
> in a new but unhelpful way.
> Arguably there is a use case for comparing two files with two different 
> character sets, but that's not what this method does. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (IO-847) Deprecate public static boolean contentEqualsIgnoreEOL(final File file1, final File file2, final String charsetName)

2024-02-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/IO-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold resolved IO-847.
--
Resolution: Not A Problem

NVM, the charset is needed for the EOL characters

> Deprecate public static boolean contentEqualsIgnoreEOL(final File file1, 
> final File file2, final String charsetName)
> 
>
> Key: IO-847
> URL: https://issues.apache.org/jira/browse/IO-847
> Project: Commons IO
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> Files can be compared byte per byte and we have a method to do that. I can't 
> see a reason to convert two files to the same character set and then compare 
> them. This gives the same answer in all cases where the character encoding is 
> recognized. If the character set isn't available, it might or mght not fail 
> in a new but unhelpful way.
> Arguably there is a use case for comparing two files with two different 
> character sets, but that's not what this method does. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-csv]

2024-02-09 Thread via GitHub


garydgregory merged PR #393:
URL: https://github.com/apache/commons-csv/pull/393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-csv]

2024-02-09 Thread via GitHub


garydgregory merged PR #392:
URL: https://github.com/apache/commons-csv/pull/392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-jexl]

2024-02-09 Thread via GitHub


garydgregory merged PR #226:
URL: https://github.com/apache/commons-jexl/pull/226


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-jexl]

2024-02-09 Thread via GitHub


garydgregory merged PR #225:
URL: https://github.com/apache/commons-jexl/pull/225


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-collections]

2024-02-09 Thread via GitHub


garydgregory merged PR #453:
URL: https://github.com/apache/commons-collections/pull/453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-collections]

2024-02-09 Thread via GitHub


garydgregory merged PR #452:
URL: https://github.com/apache/commons-collections/pull/452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-bsf]

2024-02-09 Thread via GitHub


garydgregory merged PR #122:
URL: https://github.com/apache/commons-bsf/pull/122


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-bsf]

2024-02-09 Thread via GitHub


garydgregory merged PR #121:
URL: https://github.com/apache/commons-bsf/pull/121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-parent]

2024-02-09 Thread via GitHub


garydgregory merged PR #364:
URL: https://github.com/apache/commons-parent/pull/364


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-parent]

2024-02-09 Thread via GitHub


garydgregory merged PR #363:
URL: https://github.com/apache/commons-parent/pull/363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-skin]

2024-02-09 Thread via GitHub


garydgregory merged PR #107:
URL: https://github.com/apache/commons-skin/pull/107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-crypto]

2024-02-09 Thread via GitHub


garydgregory merged PR #300:
URL: https://github.com/apache/commons-crypto/pull/300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-crypto]

2024-02-09 Thread via GitHub


garydgregory merged PR #299:
URL: https://github.com/apache/commons-crypto/pull/299


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-vfs]

2024-02-09 Thread via GitHub


garydgregory merged PR #483:
URL: https://github.com/apache/commons-vfs/pull/483


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-vfs]

2024-02-09 Thread via GitHub


garydgregory merged PR #482:
URL: https://github.com/apache/commons-vfs/pull/482


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-logging]

2024-02-09 Thread via GitHub


garydgregory merged PR #208:
URL: https://github.com/apache/commons-logging/pull/208


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-logging]

2024-02-09 Thread via GitHub


garydgregory merged PR #209:
URL: https://github.com/apache/commons-logging/pull/209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.commons:commons-parent from 64 to 66 [commons-dbcp]

2024-02-09 Thread via GitHub


garydgregory commented on PR #343:
URL: https://github.com/apache/commons-dbcp/pull/343#issuecomment-1935690270

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] DBCP-595: Connection pool can be exhausted when connections are killed on the DB side [commons-dbcp]

2024-02-09 Thread via GitHub


garydgregory commented on PR #348:
URL: https://github.com/apache/commons-dbcp/pull/348#issuecomment-1935689131

   Hello @dionusos 
   Thank you for your PR.
   You'll need a test to show what this attempts to fix or change. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-jcs]

2024-02-09 Thread via GitHub


garydgregory merged PR #211:
URL: https://github.com/apache/commons-jcs/pull/211


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-jcs]

2024-02-09 Thread via GitHub


garydgregory merged PR #210:
URL: https://github.com/apache/commons-jcs/pull/210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-build-plugin]

2024-02-09 Thread via GitHub


garydgregory merged PR #223:
URL: https://github.com/apache/commons-build-plugin/pull/223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-build-plugin]

2024-02-09 Thread via GitHub


garydgregory merged PR #222:
URL: https://github.com/apache/commons-build-plugin/pull/222


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-digester]

2024-02-09 Thread via GitHub


garydgregory merged PR #127:
URL: https://github.com/apache/commons-digester/pull/127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-digester]

2024-02-09 Thread via GitHub


garydgregory merged PR #128:
URL: https://github.com/apache/commons-digester/pull/128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-dbcp]

2024-02-09 Thread via GitHub


garydgregory merged PR #347:
URL: https://github.com/apache/commons-dbcp/pull/347


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-dbcp]

2024-02-09 Thread via GitHub


garydgregory merged PR #346:
URL: https://github.com/apache/commons-dbcp/pull/346


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-compress]

2024-02-09 Thread via GitHub


garydgregory merged PR #478:
URL: https://github.com/apache/commons-compress/pull/478


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-compress]

2024-02-09 Thread via GitHub


garydgregory merged PR #479:
URL: https://github.com/apache/commons-compress/pull/479


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-jci]

2024-02-09 Thread via GitHub


garydgregory merged PR #89:
URL: https://github.com/apache/commons-jci/pull/89


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-jci]

2024-02-09 Thread via GitHub


garydgregory merged PR #90:
URL: https://github.com/apache/commons-jci/pull/90


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] DBCP-592: Support request boundaries [commons-dbcp]

2024-02-09 Thread via GitHub


jeandelavarene commented on PR #324:
URL: https://github.com/apache/commons-dbcp/pull/324#issuecomment-193513

   With JDBC 4.2, the driver doesn't know when a connection is borrowed from 
connection cache or when a connection is returned to the cache. It is, however, 
a very useful piece of information. For example, when a connection is returned, 
the driver may decide to flush temporary resources or let the database know so 
that it can compute statistics, or even replace the connection with another one 
during a planned maintenance event of the Database. When a connection is 
borrowed from the cache, the driver may start recording calls in its replay 
queue in case of an unplanned outage so that it can transparently replay a 
request. This is the reason why these APIs beginRequest and endRequest were 
added to the JDBC 4.3 specification.
   
   There are endless possibilities.
   
   But this relies on connection pools such as DBCP to call these APIs. The 
features that rely on request boundaries can only be activated with connection 
pools that make these calls. This is why we (at Oracle) think that this is a 
very desirable feature to add to DBCP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-cli]

2024-02-09 Thread via GitHub


garydgregory merged PR #231:
URL: https://github.com/apache/commons-cli/pull/231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-cli]

2024-02-09 Thread via GitHub


garydgregory merged PR #232:
URL: https://github.com/apache/commons-cli/pull/232


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-release-plugin]

2024-02-09 Thread via GitHub


garydgregory merged PR #239:
URL: https://github.com/apache/commons-release-plugin/pull/239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-release-plugin]

2024-02-09 Thread via GitHub


garydgregory merged PR #238:
URL: https://github.com/apache/commons-release-plugin/pull/238


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [commons-dbutils]

2024-02-09 Thread via GitHub


garydgregory merged PR #238:
URL: https://github.com/apache/commons-dbutils/pull/238


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.23.2 to 3.24.0 [commons-dbutils]

2024-02-09 Thread via GitHub


garydgregory merged PR #239:
URL: https://github.com/apache/commons-dbutils/pull/239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (JEXL-420) Error while comparing float and string value

2024-02-09 Thread Henri Biestro (Jira)


[ 
https://issues.apache.org/jira/browse/JEXL-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815979#comment-17815979
 ] 

Henri Biestro edited comment on JEXL-420 at 2/9/24 9:09 AM:


* Added specific CoercionException (subclass of ArithmeticException) to be 
ignored during comparisons to allow fall through.
 * Throw  CoercionException from parse\{Number*} methods.
 * Added consistency in treating NaN and '' in all cases
 * Avoid going through parse(value.toString()) since type system is (seems) 
stable enough

Commit 
[f5bf27ca|https://github.com/apache/commons-jexl/commit/f5bf27caaf7c577ed039232e5db81bcb835bc228]


was (Author: henrib):
Commit 
[f5bf27ca|https://github.com/apache/commons-jexl/commit/f5bf27caaf7c577ed039232e5db81bcb835bc228]

> Error while comparing float and string value
> 
>
> Key: JEXL-420
> URL: https://issues.apache.org/jira/browse/JEXL-420
> Project: Commons JEXL
>  Issue Type: Bug
>Affects Versions: 3.3
>Reporter: Xu Pengcheng
>Assignee: Henri Biestro
>Priority: Major
> Fix For: 3.3.1
>
>
> code:
> {code:java}
> 1.2 == ''{code}
> returns false
>  
> code:
> {code:java}
> 1.2 == 'a'{code}
> causes exception
> {code:java}
> Caused by: java.lang.ArithmeticException: Double coercion: (a){code}
>  
> Is it possible to check the right side is a number like string and return 
> false if not?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (JEXL-420) Error while comparing float and string value

2024-02-09 Thread Henri Biestro (Jira)


 [ 
https://issues.apache.org/jira/browse/JEXL-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henri Biestro resolved JEXL-420.

Resolution: Fixed

Commit 
[f5bf27ca|https://github.com/apache/commons-jexl/commit/f5bf27caaf7c577ed039232e5db81bcb835bc228]

> Error while comparing float and string value
> 
>
> Key: JEXL-420
> URL: https://issues.apache.org/jira/browse/JEXL-420
> Project: Commons JEXL
>  Issue Type: Bug
>Affects Versions: 3.3
>Reporter: Xu Pengcheng
>Assignee: Henri Biestro
>Priority: Major
> Fix For: 3.3.1
>
>
> code:
> {code:java}
> 1.2 == ''{code}
> returns false
>  
> code:
> {code:java}
> 1.2 == 'a'{code}
> causes exception
> {code:java}
> Caused by: java.lang.ArithmeticException: Double coercion: (a){code}
>  
> Is it possible to check the right side is a number like string and return 
> false if not?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)