[jira] Issue Comment Edited: (CODEC-78) Base64: Improve Code Coverage

2009-07-17 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732741#action_12732741 ] Gary Gregory edited comment on CODEC-78 at 7/17/09 2:16 PM: Patch

[jira] Commented: (CODEC-78) Base64: Improve Code Coverage

2009-07-17 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732746#action_12732746 ] Gary Gregory commented on CODEC-78: --- I usually just do mvn site. I just retired from scatch

[jira] Commented: (CODEC-58) Character set used by Base64 not documented

2009-07-17 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732814#action_12732814 ] Gary Gregory commented on CODEC-58: --- Patch applied with changes and I hope improvements!

[jira] Closed: (CODEC-58) Character set used by Base64 not documented

2009-07-17 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed CODEC-58. - Resolution: Fixed Character set used by Base64 not documented

[jira] Commented: (CODEC-59) Add methods to Base64 which work with String instead of byte[]

2009-07-19 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733013#action_12733013 ] Gary Gregory commented on CODEC-59: --- About the 5 lines fix: can you provide a test that

[jira] Closed: (CODEC-80) Regression: Base64.encode(chunk=true) has bug when input length is multiple of 76

2009-07-23 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed CODEC-80. - Resolution: Fixed Patch committed with small changes. Thank you Julius. Regression:

[jira] Commented: (CODEC-81) Base64's new constructor parameters ignored

2009-07-27 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735485#action_12735485 ] Gary Gregory commented on CODEC-81: --- The patch line: desiredResult =

[jira] Updated: (CODEC-81) Base64's new constructor parameters ignored

2009-07-27 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CODEC-81: -- Affects Version/s: (was: 1.4) Nightly Builds Base64's new constructor

[jira] Resolved: (CODEC-81) Base64's new constructor parameters ignored

2009-07-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved CODEC-81. --- Resolution: Fixed Patch applied and then some. Base64's new constructor parameters ignored

[jira] Resolved: (CODEC-59) Add methods to Base64 which work with String instead of byte[]

2009-07-31 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved CODEC-59. --- Resolution: Fixed Fix Version/s: (was: 1.x) 1.4 Patch applied with one

[jira] Resolved: (CODEC-78) Base64: Improve Code Coverage

2009-08-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved CODEC-78. --- Resolution: Fixed Base64: Improve Code Coverage --

[jira] Closed: (CODEC-78) Base64: Improve Code Coverage

2009-08-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed CODEC-78. - Base64: Improve Code Coverage -- Key: CODEC-78

[jira] Commented: (CODEC-73) Make string2byte conversions indepedent of platform default encoding

2009-08-03 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12738253#action_12738253 ] Gary Gregory commented on CODEC-73: --- Fixed DigestUtils and test case. Make string2byte

[jira] Commented: (CODEC-86) Rename method to Base64.encodeBase64ToString()

2009-08-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12740122#action_12740122 ] Gary Gregory commented on CODEC-86: --- If we do something like this, we should to check all

[jira] Commented: (CODEC-89) new Base64().encode() appends a CRLF, and chunks results into 76 character lines

2009-11-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781274#action_12781274 ] Gary Gregory commented on CODEC-89: --- What a pickle. The current behavior is documented in

[jira] Commented: (CODEC-88) Base32 encoder

2009-11-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781277#action_12781277 ] Gary Gregory commented on CODEC-88: --- Sure, submit a patch! :) Base32 encoder

[jira] Commented: (CODEC-91) Handling of embedded padding in base64 encoded data changed in 1.4

2009-11-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781278#action_12781278 ] Gary Gregory commented on CODEC-91: --- The old behavior was a bug I think. From the spec

[jira] Commented: (CODEC-89) new Base64().encode() appends a CRLF, and chunks results into 76 character lines

2009-11-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781305#action_12781305 ] Gary Gregory commented on CODEC-89: --- I see a change for a 1.4.1 or a 1.5 as the same issue

[jira] Commented: (CODEC-91) Handling of embedded padding in base64 encoded data changed in 1.4

2009-11-23 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781497#action_12781497 ] Gary Gregory commented on CODEC-91: --- Good points, it sounds like the behavior should have a

[jira] Commented: (CODEC-88) Base32 encoder

2009-12-03 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785438#action_12785438 ] Gary Gregory commented on CODEC-88: --- The code comment talk about licenses that are not

[jira] Commented: (POOL-153) Deadlock at GenericObjectPool.addObjectToPool and AbandonedTrace.addTrace

2009-12-15 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/POOL-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12790851#action_12790851 ] Gary Gregory commented on POOL-153: --- Can you test with the latest 1.5.x release? Deadlock

[jira] Commented: (LANG-588) Create a basic PairL, R class

2010-02-12 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12833242#action_12833242 ] Gary Gregory commented on LANG-588: --- In the Smalltalk world, this was called an Association

[jira] Created: (LANG-607) StringUtils.containsAny methods incorrectly matches Unicode 2.0+ supplementary characters.

2010-03-13 Thread Gary Gregory (JIRA)
StringUtils.containsAny methods incorrectly matches Unicode 2.0+ supplementary characters. -- Key: LANG-607 URL: https://issues.apache.org/jira/browse/LANG-607

[jira] Updated: (LANG-607) StringUtils.containsAny methods incorrectly matches Unicode 2.0+ supplementary characters.

2010-03-13 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-607: -- Attachment: LANG-607.diff Attaching patch for the record. StringUtils.containsAny methods incorrectly

[jira] Updated: (LANG-607) StringUtils methods incorrectly matches Unicode 2.0+ supplementary characters.

2010-03-15 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-607: -- Summary: StringUtils methods incorrectly matches Unicode 2.0+ supplementary characters. (was:

[jira] Created: (LANG-608) Some StringUtils methods should take an int character instead of char to use String API features.

2010-03-15 Thread Gary Gregory (JIRA)
Some StringUtils methods should take an int character instead of char to use String API features. - Key: LANG-608 URL: https://issues.apache.org/jira/browse/LANG-608

[jira] Resolved: (LANG-608) Some StringUtils methods should take an int character instead of char to use String API features.

2010-03-15 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LANG-608. --- Resolution: Fixed In SVN. Some StringUtils methods should take an int character instead of char to

[jira] Updated: (LANG-608) Some StringUtils methods should take an int character instead of char to use String API features.

2010-03-15 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-608: -- Environment: java version 1.6.0_16 Java(TM) SE Runtime Environment (build 1.6.0_16-b01) Java HotSpot(TM)

[jira] Commented: (CODEC-98) Base64InputStream causes NullPointerException on some input

2010-03-25 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849773#action_12849773 ] Gary Gregory commented on CODEC-98: --- Thank you for the report. Can you please provide a

[jira] Commented: (CODEC-98) Base64InputStream causes NullPointerException on some input

2010-03-25 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12849800#action_12849800 ] Gary Gregory commented on CODEC-98: --- So what should the behavior be on bad input? Garbage

[jira] Commented: (CODEC-93) Add test(s) to check that encodeBase64() does not chunk output

2010-03-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12850402#action_12850402 ] Gary Gregory commented on CODEC-93: --- Sebb put the unit test in SVN. I then adjusted a new

[jira] Commented: (CODEC-93) Add test(s) to check that encodeBase64() does not chunk output

2010-03-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12850409#action_12850409 ] Gary Gregory commented on CODEC-93: --- It fails for me... Window Vista, Sun Java 1.6, fails

[jira] Issue Comment Edited: (CODEC-93) Add test(s) to check that encodeBase64() does not chunk output

2010-03-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12850409#action_12850409 ] Gary Gregory edited comment on CODEC-93 at 3/26/10 11:51 PM: - It

[jira] Commented: (CODEC-98) Base64InputStream causes NullPointerException on some input

2010-03-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12850411#action_12850411 ] Gary Gregory commented on CODEC-98: --- Julius: Your patch

[jira] Issue Comment Edited: (CODEC-94) unexpected CRLF at end of base64 encoded string

2010-03-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12850467#action_12850467 ] Gary Gregory edited comment on CODEC-94 at 3/27/10 3:49 AM: I

[jira] Commented: (CODEC-99) Base64.encodeBase64String() shouldn't chunk

2010-03-27 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12850602#action_12850602 ] Gary Gregory commented on CODEC-99: --- Applied patch

[jira] Commented: (CODEC-99) Base64.encodeBase64String() shouldn't chunk

2010-03-27 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12850626#action_12850626 ] Gary Gregory commented on CODEC-99: --- IMO, the issue is not chunk vs. not chunk but that the

[jira] Commented: (CODEC-100) Please rename class StringUtils to StringCodec or someting (because there is class with same name in commons-lang)

2010-05-18 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868665#action_12868665 ] Gary Gregory commented on CODEC-100: I am -1 to changing the class name. Almost all open

[jira] Closed: (CODEC-100) Please rename class StringUtils to StringCodec or someting (because there is class with same name in commons-lang)

2010-05-19 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed CODEC-100. -- Resolution: Won't Fix Will not fix. See comments in this ticket. Please rename class StringUtils to

[jira] Commented: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-27 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872367#action_12872367 ] Gary Gregory commented on LANG-624: --- Can you copy a stack trace here please?

[jira] Commented: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-27 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872383#action_12872383 ] Gary Gregory commented on LANG-624: --- Travis, Thank you for the stack trace. Can you give

[jira] Issue Comment Edited: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872383#action_12872383 ] Gary Gregory edited comment on LANG-624 at 5/28/10 5:17 AM: Fixed

[jira] Updated: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-624: -- Fix Version/s: 3.0 Nightly Builds SystemUtils.getJavaVersionAsFloat throws

[jira] Commented: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872917#action_12872917 ] Gary Gregory commented on LANG-624: --- Committed fix to trunk, unit test improvements and

[jira] Issue Comment Edited: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872917#action_12872917 ] Gary Gregory edited comment on LANG-624 at 5/28/10 12:26 PM: -

[jira] Updated: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-624: -- Affects Version/s: Nightly Builds SystemUtils.getJavaVersionAsFloat throws

[jira] Issue Comment Edited: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873041#action_12873041 ] Gary Gregory edited comment on LANG-624 at 5/28/10 12:31 PM: - I

[jira] Commented: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873041#action_12873041 ] Gary Gregory commented on LANG-624: --- I expect this assertion to fail: {quote}

[jira] Issue Comment Edited: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873041#action_12873041 ] Gary Gregory edited comment on LANG-624 at 5/28/10 12:31 PM: - I

[jira] Updated: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM

2010-05-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-624: -- Attachment: AndriodJavaVersion.png Shows that you now get a version number, just not a very useful one:

[jira] Commented: (CODEC-91) Handling of embedded padding in base64 encoded data changed in 1.4

2010-06-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12874386#action_12874386 ] Gary Gregory commented on CODEC-91: --- On a different tack, I think we should offer an

[jira] Updated: (CLI-200) particular spelled wrong in Javadoc

2010-06-02 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CLI-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CLI-200: - Affects Version/s: 1.2 Nightly Builds (was: 1.3)

[jira] [Commented] (CSV-96) CSVRecord does not verify that the length of the header mapping matches the number of values

2013-03-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616224#comment-13616224 ] Gary Gregory commented on CSV-96: - How about this then: {code:java} CSVRecord(final

[jira] [Comment Edited] (CSV-96) CSVRecord does not verify that the length of the header mapping matches the number of values

2013-03-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616224#comment-13616224 ] Gary Gregory edited comment on CSV-96 at 3/28/13 1:07 PM: -- How about

[jira] [Commented] (CSV-96) CSVRecord does not verify that the length of the header mapping matches the number of values

2013-03-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616234#comment-13616234 ] Gary Gregory commented on CSV-96: - @Emmanuel Point taken, but I would be more concerned about

[jira] [Commented] (CSV-96) CSVRecord does not verify that the length of the header mapping matches the number of values

2013-03-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616252#comment-13616252 ] Gary Gregory commented on CSV-96: - So would you have the method return a boolean or throw an

[jira] [Commented] (CSV-96) CSVRecord does not verify that the length of the header mapping matches the number of values

2013-03-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616284#comment-13616284 ] Gary Gregory commented on CSV-96: - I've added EB's suggestion for a CSVRecord#isConsistent()

[jira] [Commented] (CSV-96) CSVRecord does not verify that the length of the header mapping matches the number of values

2013-03-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616288#comment-13616288 ] Gary Gregory commented on CSV-96: - @BR: You have to check each record. How could you not and

[jira] [Commented] (CSV-96) CSVRecord does not verify that the length of the header mapping matches the number of values

2013-03-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616310#comment-13616310 ] Gary Gregory commented on CSV-96: - Right, each record is independent.

[jira] [Updated] (CODEC-168) Add DigestUtils.updateDigest(MessageDigest, InputStream)

2013-03-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CODEC-168: --- Summary: Add DigestUtils.updateDigest(MessageDigest, InputStream) (was: Patch: Add

[jira] [Resolved] (CODEC-168) Add DigestUtils.updateDigest(MessageDigest, InputStream)

2013-03-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved CODEC-168. Resolution: Fixed Fix Version/s: 1.8 Thank you Daniel. Implemented differently from the

[jira] [Commented] (CODEC-159) BaseNCodec uses UTF-8 rather than US_ASCII for byte conversions

2013-03-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618001#comment-13618001 ] Gary Gregory commented on CODEC-159: Thoughts from the community? I am worried about

[jira] [Commented] (LANG-883) StringUtils.containsAny(CharSequence, CharSequence... )

2013-04-05 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623549#comment-13623549 ] Gary Gregory commented on LANG-883: --- Better than using a regular expression?

[jira] [Commented] (CODEC-169) What should StringEncoderComparator do with non-Comparable encoded params?

2013-04-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625602#comment-13625602 ] Gary Gregory commented on CODEC-169: This is obviously broken in concept since you

[jira] [Updated] (CSV-97) Allow the String value for null to be customized for the CSV printer

2013-04-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CSV-97: Summary: Allow the String value for null to be customized for the CSV printer (was: Allow String value for

[jira] [Resolved] (CSV-97) Allow the String value for null to be customized for the CSV printer

2013-04-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved CSV-97. - Resolution: Fixed {noformat} commit -m [CSV-97] Allow the String value for null to be customized for the

[jira] [Commented] (CODEC-169) What should StringEncoderComparator do with non-Comparable encoded params?

2013-04-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626027#comment-13626027 ] Gary Gregory commented on CODEC-169: I'd pick leave as is, but add Javadoc otherwise

[jira] [Commented] (VFS-473) org.apache.commons.vfs2.provider.smb.SmbFileProvider not available in version 2.x

2013-04-10 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/VFS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627962#comment-13627962 ] Gary Gregory commented on VFS-473: -- SmbFileProvider is in the sandbox project. It relies on

[jira] [Commented] (VFS-473) org.apache.commons.vfs2.provider.smb.SmbFileProvider not available in version 2.x

2013-04-10 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/VFS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628679#comment-13628679 ] Gary Gregory commented on VFS-473: -- Hello Ranajyoti, Well, there is a lot to talk about :)

[jira] [Commented] (LOGGING-151) Invalid OSGi bundle id

2013-04-11 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOGGING-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629446#comment-13629446 ] Gary Gregory commented on LOGGING-151: -- I like following in [lang] and

[jira] [Closed] (CODEC-160) Base64.encodeBase64URLSafeString doesn't add padding characters at the end.

2013-04-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed CODEC-160. -- I released version 1.8. Base64.encodeBase64URLSafeString doesn't add padding characters

[jira] [Closed] (CODEC-161) Add Match Rating Approach (MRA) phonetic algorithm encoder

2013-04-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed CODEC-161. -- I released version 1.8. Add Match Rating Approach (MRA) phonetic algorithm encoder

[jira] [Closed] (CODEC-163) ColognePhonetic encoder unneccessarily creates many char arrays on every loop run

2013-04-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed CODEC-163. -- I released version 1.8. ColognePhonetic encoder unneccessarily creates many char arrays

[jira] [Closed] (CODEC-167) Test our decode with pad character in the middle

2013-04-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed CODEC-167. -- I released version 1.8. Test our decode with pad character in the middle

[jira] [Closed] (CODEC-168) Add DigestUtils.updateDigest(MessageDigest, InputStream)

2013-04-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed CODEC-168. -- I released version 1.8. Add DigestUtils.updateDigest(MessageDigest, InputStream)

[jira] [Updated] (CODEC-166) Base64 could be faster

2013-04-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CODEC-166: --- Fix Version/s: (was: 1.8) 2.0 Base64 could be faster

[jira] [Created] (CODEC-170) Link broken in Metaphone Javadoc

2013-04-30 Thread Gary Gregory (JIRA)
Gary Gregory created CODEC-170: -- Summary: Link broken in Metaphone Javadoc Key: CODEC-170 URL: https://issues.apache.org/jira/browse/CODEC-170 Project: Commons Codec Issue Type: Bug

[jira] [Resolved] (CODEC-170) Link broken in Metaphone Javadoc

2013-04-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved CODEC-170. Resolution: Fixed {noformat} commit -m [CODEC-170] Link broken in Metaphone Javadoc.

[jira] [Commented] (IMAGING-103) Update Commons Imaging web page to represent current state of project

2013-05-02 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IMAGING-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647906#comment-13647906 ] Gary Gregory commented on IMAGING-103: -- I updated the site with the latest from

[jira] [Created] (IO-381) Add FileUtils.copyInputStreamToFile API with option to leave the source open

2013-05-08 Thread Gary Gregory (JIRA)
Gary Gregory created IO-381: --- Summary: Add FileUtils.copyInputStreamToFile API with option to leave the source open Key: IO-381 URL: https://issues.apache.org/jira/browse/IO-381 Project: Commons IO

[jira] [Resolved] (IO-380) FileUtils.copyInputStreamToFile should document it closes the input source

2013-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved IO-380. - Resolution: Fixed Fix Version/s: 2.5 See also [IO-381].

[jira] [Resolved] (IO-381) Add FileUtils.copyInputStreamToFile API with option to leave the source open

2013-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved IO-381. - Resolution: Fixed Add FileUtils.copyInputStreamToFile API with option to leave the source open

[jira] [Commented] (IO-381) Add FileUtils.copyInputStreamToFile API with option to leave the source open

2013-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651940#comment-13651940 ] Gary Gregory commented on IO-381: - The style of the class is unfortunate IMO:

[jira] [Commented] (IO-380) FileUtils.copyInputStreamToFile should document it closes the input source

2013-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13652104#comment-13652104 ] Gary Gregory commented on IO-380: - Please take a look at trunk and tell us what you think.

[jira] [Resolved] (BCEL-163) Incorporate patch file from Findbugs?

2013-05-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/BCEL-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved BCEL-163. --- Resolution: Fixed Resolving per

[jira] [Resolved] (BCEL-163) Incorporate patch file from Findbugs?

2013-05-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/BCEL-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved BCEL-163. --- Resolution: Fixed Resolving per

[jira] [Commented] (LANG-893) Default value for StrSubstitutor

2013-05-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657025#comment-13657025 ] Gary Gregory commented on LANG-893: --- How about providing a patch with unit tests?

[jira] [Resolved] (POOL-234) SoftReferenceObjectPool swallows underlying exceptions when activating / validating newly created object

2013-05-15 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/POOL-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved POOL-234. --- Resolution: Fixed Fix Version/s: 1.6.1 Assignee: Gary Gregory {noformat} commit -m

[jira] [Created] (POOL-235) Add missing serialVersionUID fields

2013-05-15 Thread Gary Gregory (JIRA)
Gary Gregory created POOL-235: - Summary: Add missing serialVersionUID fields Key: POOL-235 URL: https://issues.apache.org/jira/browse/POOL-235 Project: Commons Pool Issue Type: Bug

[jira] [Resolved] (POOL-235) Add missing serialVersionUID fields

2013-05-15 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/POOL-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved POOL-235. --- Resolution: Fixed {noformat} commit -m [POOL-235] Add missing serialVersionUID fields.

[jira] [Commented] (DBCP-398) DBCP hangs on common pool borrowObject when PoolableConnection is used and the underlying connection closed unexpectedly (connection resets/timouts)

2013-05-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664140#comment-13664140 ] Gary Gregory commented on DBCP-398: --- Can you provide a unit test that exhibits this

[jira] [Commented] (DBCP-398) DBCP hangs on common pool borrowObject when PoolableConnection is used and the underlying connection closed unexpectedly (connection resets/timouts)

2013-05-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664292#comment-13664292 ] Gary Gregory commented on DBCP-398: --- A seemingly simple change like replacing

[jira] [Comment Edited] (DBCP-398) DBCP hangs on common pool borrowObject when PoolableConnection is used and the underlying connection closed unexpectedly (connection resets/timouts)

2013-05-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664292#comment-13664292 ] Gary Gregory edited comment on DBCP-398 at 5/22/13 5:30 PM: A

[jira] [Commented] (DBCP-398) DBCP hangs on common pool borrowObject when PoolableConnection is used and the underlying connection closed unexpectedly (connection resets/timouts)

2013-05-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664658#comment-13664658 ] Gary Gregory commented on DBCP-398: --- I confirm that the patch applies cleanly and does not

[jira] [Comment Edited] (DBCP-398) DBCP hangs on common pool borrowObject when PoolableConnection is used and the underlying connection closed unexpectedly (connection resets/timouts)

2013-05-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664658#comment-13664658 ] Gary Gregory edited comment on DBCP-398 at 5/22/13 11:14 PM: - I

[jira] [Commented] (DBCP-398) DBCP hangs on common pool borrowObject when PoolableConnection is used and the underlying connection closed unexpectedly (connection resets/timouts)

2013-05-24 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13666463#comment-13666463 ] Gary Gregory commented on DBCP-398: --- WRT (1), looking at the JDBC Javadoc: {code:java}

[jira] [Commented] (IMAGING-103) Update Commons Imaging web page to represent current state of project

2013-05-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IMAGING-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13667410#comment-13667410 ] Gary Gregory commented on IMAGING-103: -- The 1.0 release does not exist yet, hence

[jira] [Commented] (IMAGING-106) JpegImageParser didn't rewrite the writeImage method

2013-05-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IMAGING-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13667412#comment-13667412 ] Gary Gregory commented on IMAGING-106: -- Feel free to provide a patch with unit tests

[jira] [Updated] (NET-494) FTPClient.CSL.cleanUp() fails to restore timeout value on exception

2013-06-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/NET-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated NET-494: - Component/s: FTP FTPClient.CSL.cleanUp() fails to restore timeout value on exception

[jira] [Comment Edited] (LANG-899) StringUtils lastIndexOf(String str, char searchChar, int startPos) not working

2013-06-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683321#comment-13683321 ] Gary Gregory edited comment on LANG-899 at 6/14/13 12:48 PM: -

<    1   2   3   4   5   6   7   8   9   10   >