[jira] [Commented] (BCEL-285) "ClassFormatException: Invalid signature" thrown on generics

[ https://issues.apache.org/jira/browse/BCEL-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841534#comment-17841534 ] Mark Roberts commented on BCEL-285: --- I recommend we close this issue with no repro.  I have tried

[jira] [Created] (BCEL-371) BCELifierTestCase fails if run twice in a row.

Mark Roberts created BCEL-371: - Summary: BCELifierTestCase fails if run twice in a row. Key: BCEL-371 URL: https://issues.apache.org/jira/browse/BCEL-371 Project: Commons BCEL Issue Type: Bug

[jira] [Commented] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805712#comment-17805712 ] Mark Roberts commented on BCEL-279: --- Back in April 2022 I noticed some problems with BCEL signature code.

[jira] [Commented] (BCEL-361) LineNumber.toString() treats code offset as signed

[ https://issues.apache.org/jira/browse/BCEL-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509991#comment-17509991 ] Mark Roberts commented on BCEL-361: --- Fix is [https://github.com/apache/commons-bcel/pull/118.]   >

[jira] [Created] (BCEL-361) LineNumber.toString() treats code offset as signed

Mark Roberts created BCEL-361: - Summary: LineNumber.toString() treats code offset as signed Key: BCEL-361 URL: https://issues.apache.org/jira/browse/BCEL-361 Project: Commons BCEL Issue Type:

[jira] [Commented] (BCEL-307) ClassFormatException thrown in Pass 3A verification

[ https://issues.apache.org/jira/browse/BCEL-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507716#comment-17507716 ] Mark Roberts commented on BCEL-307: --- Fixed with https://github.com/apache/commons-bcel/pull/117 >

[jira] [Commented] (BCEL-303) AssertionViolatedException in Pass 3A Verification of invoke instructions

[ https://issues.apache.org/jira/browse/BCEL-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507717#comment-17507717 ] Mark Roberts commented on BCEL-303: --- Fixed with https://github.com/apache/commons-bcel/pull/117 >

[jira] [Commented] (BCEL-310) ArrayIndexOutOfBounds in Verifier Pass 3A

[ https://issues.apache.org/jira/browse/BCEL-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507713#comment-17507713 ] Mark Roberts commented on BCEL-310: --- Fixed with https://github.com/apache/commons-bcel/pull/117 >

[jira] [Commented] (BCEL-309) NegativeArraySizeException when Code attribute length is negative

[ https://issues.apache.org/jira/browse/BCEL-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507714#comment-17507714 ] Mark Roberts commented on BCEL-309: --- Fixed with https://github.com/apache/commons-bcel/pull/117 >

[jira] [Commented] (BCEL-308) NullPointerException in Verifier Pass 3A

[ https://issues.apache.org/jira/browse/BCEL-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507715#comment-17507715 ] Mark Roberts commented on BCEL-308: --- Fixed with https://github.com/apache/commons-bcel/pull/117 >

[jira] [Commented] (BCEL-337) StringIndexOutOfBounds in Pass 2 Verification of empty method names in the constant pool

[ https://issues.apache.org/jira/browse/BCEL-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507712#comment-17507712 ] Mark Roberts commented on BCEL-337: --- Fixed with https://github.com/apache/commons-bcel/pull/117 >

[jira] [Commented] (BCEL-311) ClassCastException in Verifier Pass 2

[ https://issues.apache.org/jira/browse/BCEL-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507711#comment-17507711 ] Mark Roberts commented on BCEL-311: --- Fixed with https://github.com/apache/commons-bcel/pull/117 >

[jira] [Commented] (BCEL-313) ClassFormatException: Invalid signature: Ljava/lang/String)V in Verifier Pass 3A

[ https://issues.apache.org/jira/browse/BCEL-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507710#comment-17507710 ] Mark Roberts commented on BCEL-313: --- Fixed with https://github.com/apache/commons-bcel/pull/117 >

[jira] [Commented] (BCEL-312) AssertionViolation: INTERNAL ERROR Please adapt StringRepresentation to deal with ConstantPackage in Verifier Pass 2

[ https://issues.apache.org/jira/browse/BCEL-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507709#comment-17507709 ] Mark Roberts commented on BCEL-312: --- Fixed with https://github.com/apache/commons-bcel/pull/117 >

[jira] [Commented] (BCEL-340) Make AnnotationEntry methods public

[ https://issues.apache.org/jira/browse/BCEL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124216#comment-17124216 ] Mark Roberts commented on BCEL-340: --- Thank you for your understanding and prompt response to our

[jira] [Commented] (BCEL-340) Make AnnotationEntry methods public

[ https://issues.apache.org/jira/browse/BCEL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123920#comment-17123920 ] Mark Roberts commented on BCEL-340: --- will look into improving test coverage as time allows > Make

[jira] [Commented] (BCEL-340) Make AnnotationEntry methods public

[ https://issues.apache.org/jira/browse/BCEL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123918#comment-17123918 ] Mark Roberts commented on BCEL-340: --- [https://github.com/apache/commons-bcel/pull/45] > Make

[jira] [Created] (BCEL-340) Make AnnotationEntry methods public

Mark Roberts created BCEL-340: - Summary: Make AnnotationEntry methods public Key: BCEL-340 URL: https://issues.apache.org/jira/browse/BCEL-340 Project: Commons BCEL Issue Type: Improvement

[jira] [Commented] (BCEL-335) fix jdk 11 javadoc error

[ https://issues.apache.org/jira/browse/BCEL-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043831#comment-17043831 ] Mark Roberts commented on BCEL-335: --- https://github.com/apache/commons-bcel/pull/41 > fix jdk 11 javadoc

[jira] [Created] (BCEL-335) fix jdk 11 javadoc error

Mark Roberts created BCEL-335: - Summary: fix jdk 11 javadoc error Key: BCEL-335 URL: https://issues.apache.org/jira/browse/BCEL-335 Project: Commons BCEL Issue Type: Bug Reporter:

[jira] [Commented] (BCEL-334) Add attribute name headings to toString of a Code attribute.

[ https://issues.apache.org/jira/browse/BCEL-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037617#comment-17037617 ] Mark Roberts commented on BCEL-334: --- [https://github.com/apache/commons-bcel/pull/40]   > Add attribute

[jira] [Created] (BCEL-334) Add attribute name headings to toString of a Code attribute.

Mark Roberts created BCEL-334: - Summary: Add attribute name headings to toString of a Code attribute. Key: BCEL-334 URL: https://issues.apache.org/jira/browse/BCEL-334 Project: Commons BCEL

[jira] [Commented] (BCEL-333) InovokeStatic may refer to either a MethodRef or an InterfaceMethodRef

[ https://issues.apache.org/jira/browse/BCEL-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037597#comment-17037597 ] Mark Roberts commented on BCEL-333: --- https://github.com/apache/commons-bcel/pull/39 > InovokeStatic may

[jira] [Created] (BCEL-333) InovokeStatic may refer to either a MethodRef or an InterfaceMethodRef

Mark Roberts created BCEL-333: - Summary: InovokeStatic may refer to either a MethodRef or an InterfaceMethodRef Key: BCEL-333 URL: https://issues.apache.org/jira/browse/BCEL-333 Project: Commons BCEL

[jira] [Commented] (BCEL-330) Remove unnecessary references to Constants

[ https://issues.apache.org/jira/browse/BCEL-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949673#comment-16949673 ] Mark Roberts commented on BCEL-330: --- I have a fix available and will submit a pull request. > Remove

[jira] [Created] (BCEL-330) Remove unnecessary references to Constants

Mark Roberts created BCEL-330: - Summary: Remove unnecessary references to Constants Key: BCEL-330 URL: https://issues.apache.org/jira/browse/BCEL-330 Project: Commons BCEL Issue Type:

[jira] [Commented] (BCEL-329) MethodGen duplicates some attributes

[ https://issues.apache.org/jira/browse/BCEL-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949665#comment-16949665 ] Mark Roberts commented on BCEL-329: --- I have a fix available and will submit a pull request. > MethodGen

[jira] [Created] (BCEL-329) MethodGen duplicates some attributes

Mark Roberts created BCEL-329: - Summary: MethodGen duplicates some attributes Key: BCEL-329 URL: https://issues.apache.org/jira/browse/BCEL-329 Project: Commons BCEL Issue Type: Bug

[jira] [Commented] (BCEL-325) ClassDumper crashes on a module-info.class

[ https://issues.apache.org/jira/browse/BCEL-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915887#comment-16915887 ] Mark Roberts commented on BCEL-325: --- Pull request https://github.com/apache/commons-bcel/pull/33 fixes

[jira] [Commented] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905610#comment-16905610 ] Mark Roberts commented on BCEL-279: --- https://github.com/apache/commons-bcel/pull/32 >

[jira] [Created] (BCEL-325) ClassDump crashes on a module-info.class

Mark Roberts created BCEL-325: - Summary: ClassDump crashes on a module-info.class Key: BCEL-325 URL: https://issues.apache.org/jira/browse/BCEL-325 Project: Commons BCEL Issue Type: Bug

[jira] [Updated] (BCEL-325) ClassDumper crashes on a module-info.class

[ https://issues.apache.org/jira/browse/BCEL-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-325: -- Summary: ClassDumper crashes on a module-info.class (was: ClassDump crashes on a module-info.class) >

[jira] [Comment Edited] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905488#comment-16905488 ] Mark Roberts edited comment on BCEL-279 at 8/12/19 6:54 PM: I created a branch

[jira] [Commented] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905489#comment-16905489 ] Mark Roberts commented on BCEL-279: --- I created a branch (BCEL_279) with the changes for my pull request

[jira] [Issue Comment Deleted] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-279: -- Comment: was deleted (was: I created a branch (BCEL_279) with the changes for my pull request but I

[jira] [Commented] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905488#comment-16905488 ] Mark Roberts commented on BCEL-279: --- I created a branch with the changes for my pull request but I don't

[jira] [Commented] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900345#comment-16900345 ] Mark Roberts commented on BCEL-279: --- I have submitted a patch that adds a lot of the missing features.

[jira] [Commented] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900336#comment-16900336 ] Mark Roberts commented on BCEL-279: --- I have gone over this is some detail and believe that the methods in

[jira] [Updated] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-279: -- Attachment: bcel279.patch > Utility.methodSignature* throw ClassFormatException when converting binary

[jira] [Commented] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893183#comment-16893183 ] Mark Roberts commented on BCEL-279: --- There are still two problems here.  The first is there is no code in

[jira] [Commented] (BCEL-285) "ClassFormatException: Invalid signature" thrown on generics

[ https://issues.apache.org/jira/browse/BCEL-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893157#comment-16893157 ] Mark Roberts commented on BCEL-285: --- No idea.  My comments are based on reading the information in the

[jira] [Commented] (BCEL-296) Incorrect comment in several classes.

[ https://issues.apache.org/jira/browse/BCEL-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199103#comment-16199103 ] Mark Roberts commented on BCEL-296: --- ok - will try to set up a PR next week. > Incorrect comment in

[jira] [Created] (BCEL-297) Incorrect override implementation of Object.equals

Mark Roberts created BCEL-297: - Summary: Incorrect override implementation of Object.equals Key: BCEL-297 URL: https://issues.apache.org/jira/browse/BCEL-297 Project: Commons BCEL Issue Type:

[jira] [Created] (BCEL-296) Incorrect comment in several classes.

Mark Roberts created BCEL-296: - Summary: Incorrect comment in several classes. Key: BCEL-296 URL: https://issues.apache.org/jira/browse/BCEL-296 Project: Commons BCEL Issue Type: Improvement

[jira] [Commented] (BCEL-295) Incorrect live range information in LocalVariableGen

[ https://issues.apache.org/jira/browse/BCEL-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199060#comment-16199060 ] Mark Roberts commented on BCEL-295: --- I might have time to provide a unit test next week. > Incorrect live

[jira] [Updated] (BCEL-295) Incorrect live range information in LocalVariableGen

[ https://issues.apache.org/jira/browse/BCEL-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-295: -- Attachment: LocalVariableGen.diff > Incorrect live range information in LocalVariableGen >

[jira] [Created] (BCEL-295) Incorrect live range information in LocalVariableGen

Mark Roberts created BCEL-295: - Summary: Incorrect live range information in LocalVariableGen Key: BCEL-295 URL: https://issues.apache.org/jira/browse/BCEL-295 Project: Commons BCEL Issue Type:

[jira] [Commented] (BCEL-294) Incorrect comment in StackMap.java

[ https://issues.apache.org/jira/browse/BCEL-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187349#comment-16187349 ] Mark Roberts commented on BCEL-294: --- sorry - yes line 77. > Incorrect comment in StackMap.java >

[jira] [Created] (BCEL-294) Incorrect comment in StackMap.java

Mark Roberts created BCEL-294: - Summary: Incorrect comment in StackMap.java Key: BCEL-294 URL: https://issues.apache.org/jira/browse/BCEL-294 Project: Commons BCEL Issue Type: Improvement

[jira] [Commented] (BCEL-286) signatureToString fails if multiple type arguments

[ https://issues.apache.org/jira/browse/BCEL-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148115#comment-16148115 ] Mark Roberts commented on BCEL-286: --- Sorry about that. There was some duplication in our local tests. I

[jira] [Updated] (BCEL-286) signatureToString fails if multiple type arguments

[ https://issues.apache.org/jira/browse/BCEL-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-286: -- Attachment: Utility.diff > signatureToString fails if multiple type arguments >

[jira] [Updated] (BCEL-286) signatureToString fails if multiple type arguments

[ https://issues.apache.org/jira/browse/BCEL-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-286: -- Attachment: (was: signature2.diff) > signatureToString fails if multiple type arguments >

[jira] [Updated] (BCEL-276) LocalVariableTypeTable is not updated.

[ https://issues.apache.org/jira/browse/BCEL-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-276: -- Attachment: (was: MethodGen.mark.diff) > LocalVariableTypeTable is not updated. >

[jira] [Updated] (BCEL-276) LocalVariableTypeTable is not updated.

[ https://issues.apache.org/jira/browse/BCEL-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-276: -- Attachment: (was: MethodGen.diff) > LocalVariableTypeTable is not updated. >

[jira] [Updated] (BCEL-276) LocalVariableTypeTable is not updated.

[ https://issues.apache.org/jira/browse/BCEL-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-276: -- Attachment: MethodGen.mark.diff2 > LocalVariableTypeTable is not updated. >

[jira] [Commented] (BCEL-276) LocalVariableTypeTable is not updated.

[ https://issues.apache.org/jira/browse/BCEL-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144471#comment-16144471 ] Mark Roberts commented on BCEL-276: --- This does not appear to be corrected in the current sources. I have

[jira] [Comment Edited] (BCEL-286) signatureToString fails if multiple type arguments

[ https://issues.apache.org/jira/browse/BCEL-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883650#comment-15883650 ] Mark Roberts edited comment on BCEL-286 at 2/24/17 10:39 PM: - I found more

[jira] [Updated] (BCEL-286) signatureToString fails if multiple type arguments

[ https://issues.apache.org/jira/browse/BCEL-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-286: -- Attachment: (was: signature.diff) > signatureToString fails if multiple type arguments >

[jira] [Updated] (BCEL-286) signatureToString fails if multiple type arguments

[ https://issues.apache.org/jira/browse/BCEL-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-286: -- Attachment: signature2.diff > signatureToString fails if multiple type arguments >

[jira] [Commented] (BCEL-286) signatureToString fails if multiple type arguments

[ https://issues.apache.org/jira/browse/BCEL-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883650#comment-15883650 ] Mark Roberts commented on BCEL-286: --- I found more problems and have expanded the fix and the test case.

[jira] [Comment Edited] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883626#comment-15883626 ] Mark Roberts edited comment on BCEL-279 at 2/24/17 10:23 PM: - The signature

[jira] [Commented] (BCEL-279) Utility.methodSignature* throw ClassFormatException when converting binary names with generics.

[ https://issues.apache.org/jira/browse/BCEL-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883626#comment-15883626 ] Mark Roberts commented on BCEL-279: --- The signature processing in BCEL has not been updated to support

[jira] [Updated] (BCEL-287) IINC does not handle -128 properly

[ https://issues.apache.org/jira/browse/BCEL-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-287: -- Attachment: IINC.diff > IINC does not handle -128 properly > -- > >

[jira] [Created] (BCEL-287) IINC does not handle -128 properly

Mark Roberts created BCEL-287: - Summary: IINC does not handle -128 properly Key: BCEL-287 URL: https://issues.apache.org/jira/browse/BCEL-287 Project: Commons BCEL Issue Type: Bug

[jira] [Commented] (BCEL-285) "ClassFormatException: Invalid signature" thrown on generics

[ https://issues.apache.org/jira/browse/BCEL-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883584#comment-15883584 ] Mark Roberts commented on BCEL-285: --- This does look like an invalid signature to me. The error message

[jira] [Updated] (BCEL-286) signatureToString fails if multiple type arguments

[ https://issues.apache.org/jira/browse/BCEL-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-286: -- Attachment: signature.diff > signatureToString fails if multiple type arguments >

[jira] [Created] (BCEL-286) signatureToString fails if multiple type arguments

Mark Roberts created BCEL-286: - Summary: signatureToString fails if multiple type arguments Key: BCEL-286 URL: https://issues.apache.org/jira/browse/BCEL-286 Project: Commons BCEL Issue Type:

[jira] [Updated] (BCEL-276) LocalVariableTypeTable is not updated.

[ https://issues.apache.org/jira/browse/BCEL-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-276: -- Attachment: MethodGen.mark.diff LocalVariableGen.mark.diff

[jira] [Commented] (BCEL-276) LocalVariableTypeTable is not updated.

[ https://issues.apache.org/jira/browse/BCEL-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818938#comment-15818938 ] Mark Roberts commented on BCEL-276: --- I was able to get the code working to pass both your tests and my

[jira] [Commented] (BCEL-283) Support for StackMap should be different from StackMapTable

[ https://issues.apache.org/jira/browse/BCEL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761609#comment-15761609 ] Mark Roberts commented on BCEL-283: --- Added comment and diff with suggested change. Mark > Support for

[jira] [Updated] (BCEL-283) Support for StackMap should be different from StackMapTable

[ https://issues.apache.org/jira/browse/BCEL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-283: -- Attachment: Attribute.diff > Support for StackMap should be different from StackMapTable >

[jira] [Commented] (BCEL-283) Support for StackMap should be different from StackMapTable

[ https://issues.apache.org/jira/browse/BCEL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761602#comment-15761602 ] Mark Roberts commented on BCEL-283: --- I have changed my mind on this - we do not need to support - in fact,

[jira] [Commented] (BCEL-276) LocalVariableTypeTable is not updated.

[ https://issues.apache.org/jira/browse/BCEL-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484587#comment-15484587 ] Mark Roberts commented on BCEL-276: --- This issue needs to be reopened as the code is incorrect. It saves a

[jira] [Updated] (BCEL-276) LocalVariableTypeTable is not updated.

[ https://issues.apache.org/jira/browse/BCEL-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-276: -- Attachment: MethodGen.diff > LocalVariableTypeTable is not updated. >

[jira] [Updated] (BCEL-262) InvokeInstruction.getClassName(ConstantPoolGen) should throw an exception when it detects an array

[ https://issues.apache.org/jira/browse/BCEL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-262: -- Attachment: bug262.diff I have attached unit test to demonstrate problem. >

[jira] [Updated] (BCEL-262) InvokeInstruction.getClassName(ConstantPoolGen) should throw an exception when it detects an array

[ https://issues.apache.org/jira/browse/BCEL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-262: -- Attachment: (was: InvokeInstruction.diff) > InvokeInstruction.getClassName(ConstantPoolGen) should

[jira] [Updated] (BCEL-262) InvokeInstruction.getClassName(ConstantPoolGen) should throw an exception when it detects an array

[ https://issues.apache.org/jira/browse/BCEL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-262: -- Attachment: InvokeInstruction.diff > InvokeInstruction.getClassName(ConstantPoolGen) should throw an

[jira] [Updated] (BCEL-262) FieldOrMethod.getClassName(ConstantPoolGen cpg) is deprecated

[ https://issues.apache.org/jira/browse/BCEL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-262: -- Attachment: InvokeInstruction.diff > FieldOrMethod.getClassName(ConstantPoolGen cpg) is deprecated >

[jira] [Commented] (BCEL-262) FieldOrMethod.getClassName(ConstantPoolGen cpg) is deprecated

[ https://issues.apache.org/jira/browse/BCEL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344655#comment-15344655 ] Mark Roberts commented on BCEL-262: --- I don't understand the comment either. It was added via "r190050 |

[jira] [Commented] (BCEL-262) FieldOrMethod.getClassName(ConstantPoolGen cpg) is deprecated

[ https://issues.apache.org/jira/browse/BCEL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088041#comment-15088041 ] Mark Roberts commented on BCEL-262: --- InvokeInstructions can most certainly reference an array. As an

[jira] [Commented] (BCEL-262) FieldOrMethod.getClassName(ConstantPoolGen cpg) is deprecated

[ https://issues.apache.org/jira/browse/BCEL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088142#comment-15088142 ] Mark Roberts commented on BCEL-262: --- It's even more awkward - you must use:

[jira] [Commented] (BCEL-243) Type.getType() needs to understand TypeVariableSignature(s)

[ https://issues.apache.org/jira/browse/BCEL-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731447#comment-14731447 ] Mark Roberts commented on BCEL-243: --- I have attached a test snippet that demonstrates the problem. In

[jira] [Updated] (BCEL-243) Type.getType() needs to understand TypeVariableSignature(s)

[ https://issues.apache.org/jira/browse/BCEL-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-243: -- Attachment: b243test.txt > Type.getType() needs to understand TypeVariableSignature(s) >

[jira] [Commented] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723437#comment-14723437 ] Mark Roberts commented on BCEL-195: --- What remains to be done to close this issue? > addition of

[jira] [Commented] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717224#comment-14717224 ] Mark Roberts commented on BCEL-195: --- I've attached my original suggested fix to the

[jira] [Updated] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-195: -- Attachment: select-init.diff addition of hashCode() to generic/Instruction.java breaks Targeters

[jira] [Created] (BCEL-259) Minor doc error in BranchInstruction,java

Mark Roberts created BCEL-259: - Summary: Minor doc error in BranchInstruction,java Key: BCEL-259 URL: https://issues.apache.org/jira/browse/BCEL-259 Project: Commons BCEL Issue Type: Improvement

[jira] [Updated] (BCEL-260) ClassDumper example duplicates field attribute types

[ https://issues.apache.org/jira/browse/BCEL-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-260: -- Attachment: classdumper.diff ClassDumper example duplicates field attribute types

[jira] [Created] (BCEL-260) ClassDumper example duplicates field attribute types

Mark Roberts created BCEL-260: - Summary: ClassDumper example duplicates field attribute types Key: BCEL-260 URL: https://issues.apache.org/jira/browse/BCEL-260 Project: Commons BCEL Issue Type:

[jira] [Commented] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715438#comment-14715438 ] Mark Roberts commented on BCEL-195: --- So my new patch only fixes a particular problem I

[jira] [Commented] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715743#comment-14715743 ] Mark Roberts commented on BCEL-195: --- Having the comparator return false for both branch

[jira] [Commented] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711725#comment-14711725 ] Mark Roberts commented on BCEL-195: --- This problem is very complicated and there are a

[jira] [Updated] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-195: -- Attachment: (was: targeters.diff) addition of hashCode() to generic/Instruction.java breaks

[jira] [Updated] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-195: -- Attachment: (was: bcel195.diff) addition of hashCode() to generic/Instruction.java breaks Targeters

[jira] [Updated] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-195: -- Attachment: compare.diff addition of hashCode() to generic/Instruction.java breaks Targeters

[jira] [Commented] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711890#comment-14711890 ] Mark Roberts commented on BCEL-195: --- There is no space/performance hit because they were

[jira] [Commented] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712129#comment-14712129 ] Mark Roberts commented on BCEL-195: --- test case; just add the following lines to some

[jira] [Commented] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712122#comment-14712122 ] Mark Roberts commented on BCEL-195: --- I've deleted both of the old patches and attached a

[jira] [Commented] (BCEL-195) addition of hashCode() to generic/Instruction.java breaks Targeters

[ https://issues.apache.org/jira/browse/BCEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712001#comment-14712001 ] Mark Roberts commented on BCEL-195: --- I can still repro the Select problem. I'm working on

[jira] [Updated] (BCEL-254) Two more methods that would be nice to be public.

[ https://issues.apache.org/jira/browse/BCEL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Roberts updated BCEL-254: -- Attachment: dumpClass.java Two more methods that would be nice to be public.

  1   2   3   >