[jira] [Closed] (DBCP-595) Connection pool can be exhausted when connections are killed on the DB side

2024-02-20 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed DBCP-595. Resolution: Not A Problem Don't mean to be blunt / dismissive with the close here.  But this does not look

[jira] [Resolved] (DBCP-590) BasicDataSource#setAbandonedUsageTracking has no effect

2024-02-15 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved DBCP-590. -- Fix Version/s: 2.11.1 Resolution: Fixed I am really sorry it took me so long to figure this out. 

[jira] [Comment Edited] (DBCP-595) Connection pool can be exhausted when connections are killed on the DB side

2024-02-12 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816813#comment-17816813 ] Phil Steitz edited comment on DBCP-595 at 2/12/24 11:28 PM: I just realized

[jira] [Comment Edited] (DBCP-595) Connection pool can be exhausted when connections are killed on the DB side

2024-02-12 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816813#comment-17816813 ] Phil Steitz edited comment on DBCP-595 at 2/12/24 11:27 PM: I just realized

[jira] [Commented] (DBCP-595) Connection pool can be exhausted when connections are killed on the DB side

2024-02-12 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816813#comment-17816813 ] Phil Steitz commented on DBCP-595: -- I just realized there is another scenario that can lead to this, which

[jira] [Commented] (DBCP-595) Connection pool can be exhausted when connections are killed on the DB side

2024-02-12 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816685#comment-17816685 ] Phil Steitz commented on DBCP-595: -- Thanks for the info on validation.  That info and the partial thread

[jira] [Commented] (DBCP-595) Connection pool can be exhausted when connections are killed on the DB side

2024-02-11 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816463#comment-17816463 ] Phil Steitz commented on DBCP-595: -- I am still working through the repro code, but the symptoms don't make

[jira] [Commented] (POOL-413) [GOP] Race condition while returning objects. maxIdle is ignored

2023-10-04 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772042#comment-17772042 ] Phil Steitz commented on POOL-413: -- One option to consider here is to use the native capacity management

[jira] [Commented] (POOL-413) [GOP] Race condition while returning objects. maxIdle is ignored

2023-10-04 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772023#comment-17772023 ] Phil Steitz commented on POOL-413: -- Thanks for reporting this.  The analysis looks correct to me.  It is

[jira] [Closed] (POOL-411) NPE when deregistering key at end of borrow

2023-10-01 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-411. > NPE when deregistering key at end of borrow > --- > >

[jira] [Closed] (POOL-408) A typo of KeyedPooledObjectFactory on the site and Javadoc

2023-10-01 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-408. > A typo of KeyedPooledObjectFactory on the site and Javadoc >

[jira] [Closed] (POOL-409) BasicDataSource should support GenericObjectPool->getStatsString()

2023-10-01 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-409. > BasicDataSource should support GenericObjectPool->getStatsString() >

[jira] [Closed] (POOL-402) Check blockWhenExhausted in hasBorrowWaiters

2023-10-01 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-402. > Check blockWhenExhausted in hasBorrowWaiters > > >

[jira] [Closed] (POOL-394) GenericKeyedObjectPool doesn't have getKeys() implemented

2023-10-01 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-394. > GenericKeyedObjectPool doesn't have getKeys() implemented >

[jira] [Closed] (POOL-405) NullPointerException at org.apache.commons.pool2.impl.GenericKeyedObjectPool.invalidateObject(GenericKeyedObjectPool.java:1343)

2023-10-01 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-405. > NullPointerException at >

[jira] [Closed] (POOL-393) BaseGenericObjectPool.jmxRegister may cost too much time

2023-10-01 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-393. > BaseGenericObjectPool.jmxRegister may cost too much time >

[jira] [Closed] (POOL-391) GenericKeyedObjectPool is not thread safe when invoke method `borrowObject` and `destroy` simultaneously

2023-10-01 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-391. > GenericKeyedObjectPool is not thread safe when invoke method `borrowObject` > and `destroy` simultaneously >

[jira] [Closed] (POOL-242) Set thread name for EvictionTimer

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-242. Resolution: Not A Problem > Set thread name for EvictionTimer > - > >

[jira] [Updated] (POOL-299) testOnBorrow overrides testOnCreate=false, add testOnReuse to complement testOnCreate

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-299: - Fix Version/s: 3.0 > testOnBorrow overrides testOnCreate=false, add testOnReuse to complement >

[jira] [Updated] (POOL-325) testOnReturn() available as asynchronous

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-325: - Fix Version/s: 3.0 > testOnReturn() available as asynchronous > >

[jira] [Closed] (POOL-381) Race condition in the GenericObjectPool in removeAbandoned functionality

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-381. Resolution: Not A Problem > Race condition in the GenericObjectPool in removeAbandoned functionality >

[jira] [Updated] (POOL-238) Improve test generics

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-238: - Fix Version/s: 2.13 > Improve test generics > - > > Key: POOL-238 >

[jira] [Updated] (POOL-353) Return false if current connection count is less then MinIdle in DefaultEvictionPolicy

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-353: - Fix Version/s: (was: 2.12.0) > Return false if current connection count is less then MinIdle in >

[jira] [Closed] (POOL-400) Refactor TestGenericObjectPoolFactoryCreateFailure to improve test design

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-400. Resolution: Fixed I do not see the need to bring in a new dependency for this case. > Refactor

[jira] [Updated] (POOL-282) CLONE - Support AbandonedConfig in SharedPoolDataSource

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-282: - Fix Version/s: 2.13 > CLONE - Support AbandonedConfig in SharedPoolDataSource >

[jira] [Updated] (POOL-290) TestSoftRefOutOfMemory goes into infinite loop

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-290: - Fix Version/s: 2.13 > TestSoftRefOutOfMemory goes into infinite loop >

[jira] [Updated] (POOL-351) Add JMX Notifications for NumActive and NumIdle

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-351: - Fix Version/s: 3.0 > Add JMX Notifications for NumActive and NumIdle >

[jira] [Updated] (POOL-305) Add maxAge to pool config

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-305: - Fix Version/s: 3.0 > Add maxAge to pool config > - > > Key:

[jira] [Updated] (POOL-321) ObjectPool.addObject limiting us to add an object with parameter

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-321: - Fix Version/s: 3.0 (was: 2.12.0) > ObjectPool.addObject limiting us to add an

[jira] [Updated] (POOL-267) Use of AbandonListener instead of PrintWriter when a pool object is detected in an abandon state

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-267: - Fix Version/s: 2.13 (was: 2.12.0) > Use of AbandonListener instead of PrintWriter

[jira] [Updated] (POOL-272) GenericKeyedObjectPool should have a per-key version of numTestsPerEvictionRun

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-272: - Fix Version/s: 2.13 (was: 2.12.0) > GenericKeyedObjectPool should have a per-key

[jira] [Updated] (POOL-406) add support for Micrometer

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-406: - Fix Version/s: 3.0 > add support for Micrometer > --- > > Key:

[jira] [Updated] (POOL-372) CallStackUtils mishandles security manager check part 2

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-372: - Fix Version/s: 3.0 > CallStackUtils mishandles security manager check part 2 >

[jira] [Updated] (POOL-401) GKOP invalidateObject should make capacity available to all keyed pools

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-401: - Fix Version/s: 2.13 > GKOP invalidateObject should make capacity available to all keyed pools >

[jira] [Updated] (POOL-407) Threads get stuck when idleObjects list is empty.

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-407: - Fix Version/s: 3.0 > Threads get stuck when idleObjects list is empty. >

[jira] [Updated] (POOL-410) EHN Max Concurrent Connections in Stats

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-410: - Fix Version/s: 2.13 > EHN Max Concurrent Connections in Stats > --- >

[jira] [Updated] (POOL-350) Add option for not executing "hasBorrowWaiters()" while returning objects

2023-09-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-350: - Fix Version/s: 2.13 > Add option for not executing "hasBorrowWaiters()" while returning objects >

[jira] [Updated] (POOL-269) Use generic exceptions instead of java.lang.Exception

2023-09-17 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-269: - Fix Version/s: 3.0 (was: 2.12.0) > Use generic exceptions instead of

[jira] [Resolved] (POOL-411) NPE when deregistering key at end of borrow

2023-07-31 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved POOL-411. -- Resolution: Fixed > NPE when deregistering key at end of borrow >

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

2023-07-31 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749423#comment-17749423 ] Phil Steitz commented on POOL-411: -- Fully fixed in 980aae56bf732178a9e02a3cb686f0104bffb6d3. The problem

[jira] [Commented] (POOL-410) EHN Max Concurrent Connections in Stats

2023-07-16 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743558#comment-17743558 ] Phil Steitz commented on POOL-410: -- Moving a comment from PR to here.  I think I now understand at least

[jira] [Commented] (POOL-410) EHN Max Concurrent Connections in Stats

2023-07-15 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743460#comment-17743460 ] Phil Steitz commented on POOL-410: -- This looks more like a question for the user list.  For monitoring,

[jira] [Commented] (POOL-407) Threads get stuck when idleObjects list is empty.

2023-07-11 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742216#comment-17742216 ] Phil Steitz commented on POOL-407: -- Looking more carefully at this, the sequence in the description can

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

2023-07-09 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741435#comment-17741435 ] Phil Steitz commented on POOL-411: -- [~sebb] I added sleeps temporarily between the locks in

[jira] [Comment Edited] (POOL-411) NPE when deregistering key at end of borrow

2023-07-08 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741331#comment-17741331 ] Phil Steitz edited comment on POOL-411 at 7/8/23 9:16 PM: -- [~sebb] I am not sure I

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

2023-07-08 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741331#comment-17741331 ] Phil Steitz commented on POOL-411: -- [~sebb] I am not sure I understand your last comment.  With the test

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

2023-07-07 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741220#comment-17741220 ] Phil Steitz commented on POOL-411: -- [~ggregory]  - looks great.  Great idea to use computeIfAbsent and to

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

2023-07-07 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741156#comment-17741156 ] Phil Steitz commented on POOL-411: -- If I make the following changes to testConcurrentBorrowAnd clear, the

[jira] [Comment Edited] (POOL-411) NPE when deregistering key at end of borrow

2023-07-07 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741106#comment-17741106 ] Phil Steitz edited comment on POOL-411 at 7/7/23 3:50 PM: -- [~sebb] - thanks for

[jira] [Commented] (POOL-411) NPE when deregistering key at end of borrow

2023-07-07 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741106#comment-17741106 ] Phil Steitz commented on POOL-411: -- [~sebb] - thanks for looking at this.  You are right - the scenario I

[jira] (POOL-411) NPE when deregistering key at end of borrow

2023-07-07 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411 ] Phil Steitz deleted comment on POOL-411: -- was (Author: psteitz): The added test case has failed at least once now.  I think there is a problem with register/deregister protection of pools.  Very

[jira] [Reopened] (POOL-411) NPE when deregistering key at end of borrow

2023-07-06 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz reopened POOL-411: -- The added test case has failed at least once now.  I think there is a problem with register/deregister

[jira] [Commented] (DBCP-591) Avoid synchronized in PoolableConnection.close

2023-06-28 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738305#comment-17738305 ] Phil Steitz commented on DBCP-591: -- Acknowledged.  It is strange that intrinsic locks work differently,

[jira] [Commented] (IO-802) Restore threadlocal for skipfully() byte buffer

2023-06-13 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/IO-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732273#comment-17732273 ] Phil Steitz commented on IO-802: [~ggregory] Makes sense.  Thanks. > Restore threadlocal for skipfully()

[jira] [Commented] (IO-802) Restore threadlocal for skipfully() byte buffer

2023-06-13 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/IO-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732238#comment-17732238 ] Phil Steitz commented on IO-802: I agree that it would be best to just add back the protection, for the

[jira] [Commented] (POOL-412) [GenericKeyedObjectPool] ensureMinIdle not work if last idle evicted

2023-06-05 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729462#comment-17729462 ] Phil Steitz commented on POOL-412: -- Yes, I would close this. > [GenericKeyedObjectPool] ensureMinIdle not

[jira] [Commented] (POOL-412) [GenericKeyedObjectPool] ensureMinIdle not work if last idle evicted

2023-06-05 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729430#comment-17729430 ] Phil Steitz commented on POOL-412: -- This is an interesting use case.  Honestly, I think GKOP is working as

[jira] [Comment Edited] (DBCP-590) BasicDataSource#setAbandonedUsageTracking has no effect

2023-01-29 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681805#comment-17681805 ] Phil Steitz edited comment on DBCP-590 at 1/30/23 2:18 AM: --- I will look more at

[jira] [Commented] (DBCP-590) BasicDataSource#setAbandonedUsageTracking has no effect

2023-01-29 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681805#comment-17681805 ] Phil Steitz commented on DBCP-590: -- I will look more at this when I have a little more time, but I suspect

[jira] [Commented] (POOL-401) GKOP invalidateObject should make capacity available to all keyed pools

2023-01-02 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653706#comment-17653706 ] Phil Steitz commented on POOL-401: -- It looks to me that at least as of 2.11.1 reuseCapacity is called on

[jira] [Commented] (POOL-407) Threads get stuck when idleObjects list is empty.

2023-01-02 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653705#comment-17653705 ] Phil Steitz commented on POOL-407: -- Thanks for reporting this with the detailed analysis.  It is a

[jira] [Commented] (POOL-350) Add option for not executing "hasBorrowWaiters()" while returning objects

2023-01-02 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653704#comment-17653704 ] Phil Steitz commented on POOL-350: -- Any feedback on the reuseCapacityOnReturn, reuseCapacityOnMaintenance

[jira] [Commented] (POOL-372) CallStackUtils mishandles security manager check part 2

2023-01-02 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653703#comment-17653703 ] Phil Steitz commented on POOL-372: -- I am not a security expert, so I can't comment on the assertion in (b)

[jira] [Commented] (POOL-264) NullPointerException in GKOP.borrowObject()

2023-01-02 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653699#comment-17653699 ] Phil Steitz commented on POOL-264: -- The entire setup was changed in 2.0.  Unless someone wants to take up

[jira] [Commented] (DBCP-587) DBCP and Transparent Application Continuity

2022-10-23 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622847#comment-17622847 ] Phil Steitz commented on DBCP-587: -- Thanks. It was a good question. > DBCP and Transparent

[jira] [Commented] (DBCP-587) DBCP and Transparent Application Continuity

2022-10-18 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619934#comment-17619934 ] Phil Steitz commented on DBCP-587: -- GenericObjectPool has no initialSize parameter.  You need to do what

[jira] [Comment Edited] (POOL-282) CLONE - Support AbandonedConfig in SharedPoolDataSource

2022-05-03 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531339#comment-17531339 ] Phil Steitz edited comment on POOL-282 at 5/3/22 6:08 PM: -- [~ashok2ashok]  First,

[jira] [Commented] (POOL-282) CLONE - Support AbandonedConfig in SharedPoolDataSource

2022-05-03 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531339#comment-17531339 ] Phil Steitz commented on POOL-282: -- [~ashok2ashok]  First, many thanks for stepping up to the challenge

[jira] [Commented] (DBCP-585) Connection level JMX queries result in concurrent access to connection objects, causing errors

2022-05-02 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530947#comment-17530947 ] Phil Steitz commented on DBCP-585: -- [~ggregory]  yes this looks good > Connection level JMX queries

[jira] [Commented] (DBCP-585) Connection level JMX queries result in concurrent access to connection objects, causing errors

2022-04-23 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526928#comment-17526928 ] Phil Steitz commented on DBCP-585: -- [~ggregory] sorry I missed this.  There is a small javadoc error in

[jira] [Commented] (DBCP-585) Connection level JMX queries result in concurrent access to connection objects, causing errors

2022-04-10 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520227#comment-17520227 ] Phil Steitz commented on DBCP-585: -- Nice analysis.  The patch looks reasonable as a way to turn off the

[jira] [Closed] (POOL-404) No way to close evictor thread

2022-01-24 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed POOL-404. Resolution: Not A Problem We can open an enhancement request to add global pool management, but I do not

[jira] [Commented] (POOL-404) No way to close evictor thread

2022-01-24 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481215#comment-17481215 ] Phil Steitz commented on POOL-404: -- [~ggregory]  Can you see a scenario where multiple evictors can be

[jira] [Commented] (POOL-404) No way to close evictor thread

2022-01-23 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480744#comment-17480744 ] Phil Steitz commented on POOL-404: -- [~patrickjamesbarry] That is interesting.  Could be we actually have a

[jira] [Commented] (POOL-404) No way to close evictor thread

2022-01-23 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480706#comment-17480706 ] Phil Steitz commented on POOL-404: -- Yes that is what I meant by the closeAll option.  Still seems a little

[jira] [Comment Edited] (POOL-404) No way to close evictor thread

2022-01-22 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480250#comment-17480250 ] Phil Steitz edited comment on POOL-404 at 1/22/22, 5:26 PM: That would have to

[jira] [Commented] (POOL-404) No way to close evictor thread

2022-01-21 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480250#comment-17480250 ] Phil Steitz commented on POOL-404: -- That would have to be a *global* JVM-level close that would not be

[jira] [Commented] (POOL-403) GenericKeyedObjectPool getNumActive and getNumIdle Javadoc do not match behaviour

2021-12-06 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454139#comment-17454139 ] Phil Steitz commented on POOL-403: -- This is being picked up from the KeyedObjectPool interface javadoc.  I

[jira] [Comment Edited] (POOL-393) BaseGenericObjectPool.jmxRegister may cost too much time

2021-11-14 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443194#comment-17443194 ] Phil Steitz edited comment on POOL-393 at 11/14/21, 4:55 PM: - I verified that

[jira] [Commented] (POOL-393) BaseGenericObjectPool.jmxRegister may cost too much time

2021-11-13 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443194#comment-17443194 ] Phil Steitz commented on POOL-393: -- I verified that with the 2.11.1 code it can take 9+ seconds to

[jira] [Commented] (POOL-394) GenericKeyedObjectPool doesn't have getKeys() implemented

2021-11-13 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443182#comment-17443182 ] Phil Steitz commented on POOL-394: -- I have not run into this requirement in my own apps, but I can see how

[jira] [Created] (POOL-401) GKOP invalidateObject should make capacity available to all keyed pools

2021-11-11 Thread Phil Steitz (Jira)
Phil Steitz created POOL-401: Summary: GKOP invalidateObject should make capacity available to all keyed pools Key: POOL-401 URL: https://issues.apache.org/jira/browse/POOL-401 Project: Commons Pool

[jira] [Commented] (POOL-391) GenericKeyedObjectPool is not thread safe when invoke method `borrowObject` and `destroy` simultaneously

2021-11-11 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442354#comment-17442354 ] Phil Steitz commented on POOL-391: -- A fix for this is in [https://github.com/apache/commons-pool/pull/113]

[jira] [Commented] (POOL-396) Exceptions in validation can cause an object's lifecycle to be stuck in EVICTION state

2021-06-20 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366264#comment-17366264 ] Phil Steitz commented on POOL-396: -- Sorry for the slow response.  Really nice work on this [~jeremyk-91]. 

[jira] [Commented] (POOL-396) Exceptions in validation can cause an object's lifecycle to be stuck in EVICTION state

2021-06-16 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364356#comment-17364356 ] Phil Steitz commented on POOL-396: -- After sleeping on this, I think it is probably better to go ahead and

[jira] [Commented] (POOL-396) Exceptions in validation can cause an object's lifecycle to be stuck in EVICTION state

2021-06-15 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364015#comment-17364015 ] Phil Steitz commented on POOL-396: -- Nice work on the report and patch.   Thanks especially for the unit

[jira] [Updated] (DBCP-572) timed out connections remain active in the pool

2021-02-26 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated DBCP-572: - Assignee: (was: Phil Steitz) > timed out connections remain active in the pool >

[jira] [Commented] (DBCP-572) timed out connections remain active in the pool

2021-02-26 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291763#comment-17291763 ] Phil Steitz commented on DBCP-572: -- This is not a bug.  By default, the pool does not try to keep

[jira] [Updated] (DBCP-572) timed out connections remain active in the pool

2021-02-26 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated DBCP-572: - Assignee: Phil Steitz > timed out connections remain active in the pool >

[jira] [Commented] (POOL-390) Add a max age to pool entries

2020-12-08 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246147#comment-17246147 ] Phil Steitz commented on POOL-390: -- Looks like a useful feature to me .  DBCP does this in its object

[jira] [Created] (DBCP-567) Use abort rather than close to clean up abandoned connections

2020-09-13 Thread Phil Steitz (Jira)
Phil Steitz created DBCP-567: Summary: Use abort rather than close to clean up abandoned connections Key: DBCP-567 URL: https://issues.apache.org/jira/browse/DBCP-567 Project: Commons DBCP

[jira] [Created] (POOL-387) Object factory destroy method should carry information on activation context

2020-09-13 Thread Phil Steitz (Jira)
Phil Steitz created POOL-387: Summary: Object factory destroy method should carry information on activation context Key: POOL-387 URL: https://issues.apache.org/jira/browse/POOL-387 Project: Commons Pool

[jira] [Comment Edited] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭,但该类没有提供open()方法使得新建的数据库连接生效

2020-08-09 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173949#comment-17173949 ] Phil Steitz edited comment on DBCP-559 at 8/9/20, 6:44 PM: --- PR is

[jira] [Commented] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭,但该类没有提供open()方法使得新建的数据库连接生效

2020-08-09 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173949#comment-17173949 ] Phil Steitz commented on DBCP-559: -- PR is [here|https://github.com/apache/commons-dbcp/pull/50]. * One

[jira] [Comment Edited] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭,但该类没有提供open()方法使得新建的数据库连接生效

2020-08-08 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173447#comment-17173447 ] Phil Steitz edited comment on DBCP-559 at 8/8/20, 5:20 PM: --- I am working on a PR

[jira] [Comment Edited] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭,但该类没有提供open()方法使得新建的数据库连接生效

2020-08-08 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173447#comment-17173447 ] Phil Steitz edited comment on DBCP-559 at 8/8/20, 5:15 PM: --- I am working on a PR

[jira] [Commented] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭,但该类没有提供open()方法使得新建的数据库连接生效

2020-08-07 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173447#comment-17173447 ] Phil Steitz commented on DBCP-559: -- I am working on a PR with tests for this, though I will happily review

[jira] [Closed] (DBCP-563) query return previous result when previous request cause MySQLTimeoutException by one connection

2020-07-29 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed DBCP-563. Resolution: Not A Problem This is a driver bug.  I can reproduce using mysql-connector-java-5.x but not

[jira] [Commented] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭,但该类没有提供open()方法使得新建的数据库连接生效

2020-07-28 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166644#comment-17166644 ] Phil Steitz commented on DBCP-559: -- This looks reasonable to me.  The change is just to add an "open"

[jira] [Comment Edited] (POOL-386) Closing a pool can cause Evictor in another pool to be cancelled

2020-07-21 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162100#comment-17162100 ] Phil Steitz edited comment on POOL-386 at 7/21/20, 6:04 PM: A couple things to

  1   2   3   4   5   6   7   8   9   10   >