[GitHub] [commons-configuration] darkma773r commented on a diff in pull request #186: [CONFIGURATION-813]: Support both javax and jakarta namespace in mailapi

2022-06-14 Thread GitBox
darkma773r commented on code in PR #186: URL: https://github.com/apache/commons-configuration/pull/186#discussion_r897508540 ## src/main/java/org/apache/commons/configuration2/convert/PropertyConverter.java: ## @@ -607,12 +612,22 @@ static Object toInternetAddress(final Object

[GitHub] [commons-configuration] darkma773r commented on a diff in pull request #186: [CONFIGURATION-813]: Support both javax and jakarta namespace in mailapi

2022-06-14 Thread GitBox
darkma773r commented on code in PR #186: URL: https://github.com/apache/commons-configuration/pull/186#discussion_r897506536 ## src/test/java/org/apache/commons/configuration2/TestDataConfiguration.java: ## @@ -839,7 +842,7 @@ public void testConversionException() throws

[GitHub] [commons-configuration] darkma773r commented on a diff in pull request #186: [CONFIGURATION-813]: Support both javax and jakarta namespace in mailapi

2022-06-14 Thread GitBox
darkma773r commented on code in PR #186: URL: https://github.com/apache/commons-configuration/pull/186#discussion_r897504422 ## src/test/java/org/apache/commons/configuration2/TestDataConfiguration.java: ## @@ -73,10 +73,13 @@ private static Date expectedDate() throws

[GitHub] [commons-configuration] darkma773r commented on a diff in pull request #186: [CONFIGURATION-813]: Support both javax and jakarta namespace in mailapi

2022-06-14 Thread GitBox
darkma773r commented on code in PR #186: URL: https://github.com/apache/commons-configuration/pull/186#discussion_r897504090 ## src/main/java/org/apache/commons/configuration2/convert/PropertyConverter.java: ## @@ -70,6 +70,9 @@ public final class PropertyConverter { /**