[GitHub] [commons-lang] XenoAmess commented on pull request #533: [LANG-1547] fix code smells; fix typos
XenoAmess commented on pull request #533: URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636686644 @jochenw @kinow Hi. This pr is already splited into several prs. Most of them are small enough that not need to have a jira (IMO). So I will close this pr. Thanks for your help. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #533: [LANG-1547] fix code smells; fix typos
XenoAmess commented on pull request #533: URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636646635 > > I'd find it reasonable to consider your changes in batches of, say, ten apiece. (That would make it possible to carefully inspect one by one.) But that many in one go? Definitely no. > > @XenoAmess it's quite hard to review this PR. It has several commits, and several changes. Committers will have to read and understand your changes, and then be confident that these changes can go in the next release without causing regressions. > > As @jochenw pointed out, instead if you could prepare one pull request for a change, and either include your other changes in another PR, or wait for a review/merge to submit more, that would be much easier to review; at the same time, your PR would be reviewed much faster. > > Bruno OK, you're right, then I will split it into more prs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #533: [LANG-1547] fix code smells; fix typos
XenoAmess commented on pull request #533: URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636512322 the performance refines I said has being splited to [LANG-1548] and [LANG-1549] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #533: [LANG-1547] fix code smells; fix typos; performance refine(trying to)
XenoAmess commented on pull request #533: URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636423277 > I'd find it reasonable to consider your changes in batches of, say, ten apiece. (That would make it possible to carefully inspect one by one.) But that many in one go? Definitely no. do you mean I should split them into several prs？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
