[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-543232040 @garydgregory , after confirming local build with oracle-jdk11 working fine, I kicked in travis again and it seems to build fine now. Regarding the java.lang.ClassCastException from jetty (v6.x), unfortunately JR 1.6.5 is the latest release in 1.x range. However, it seems like not affecting the test running itself; it seems to throw an exception only when initializing JSP engine which is never used in JR webdav server. FYI, JR2.x uses jetty 9.x. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-497156049 On second thought, it seems better to rename "commons-vfs2-jackrabbit2" to "commons-vfs2-jackrabbit", and "commons-vfs2-jackrabbit3" to "commons-vfs2-jackrabbit2" because the former depends on Jackrabbit 1.5.x and the latter on Jackrabbit 2.19.x. I will rename those later this week unless there are better ones. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-488129264 Hi @garydgregory , I don't know, but the patch file downloaded from GitHub seems to make problems. I found an alternative by creating and uploading the patch file to the JIRA ticket: https://issues.apache.org/jira/browse/VFS-686. Could you try with that alternative instead? Thanks, Woonsan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-487989859 Hi @garydgregory , I've just merged mater. It's great to see greens even for JVM11! Great work! Woonsan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-483062377 BTW, I'm open to any better name suggestions. On top off my head, "commons-vfs2-jackrabbit2-hc3" (with updating the version from 1.6.5 to 2.14.x) vs "commons-vfs2-jackrabbit2-hc4" (with 2.19.2) could be too verbose? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest
Jackrabbit 2.x
URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-483057288
Hi @garydgregory ,
Yes, the naming is tricky here. The main reason I mentioned is that
Jackrabbit2 had upgraded its HttpClient from v3 to v4 since v2.16. [1]
Therefore, it is actually okay to use any Jackrabbit 2.x version before 2.16
with the old commons-vfs webdav provider.
As of JR 2.16, it started using HC 4.x, which actually started introducing
backward incompatibility -- e.g, some HC interfaces/classes have been used in
JR webdav API as well, and those had to be changed breaking the compatibility.
Therefore, even if commons-vfs's dependency on JR was set to 1.x, it works
fine with pre-JR 2.16 versions; as a result, JR itself in v2.14 has a
dependency on commons-vfs2 for WebDAV-based DataStore as well, and it works
totally fine. In other words, JR-based CMS systems use commons-vfs2 webdav with
JR 2.14 now.
So, I justified using the old one as jackrabbit2 and the new one as
jackrabbit3 [3] by mentioning that the Jackrabbit3 ("OAK") is still using the
Jackrabbit API in v2.16+. In other words, Jackrabbit API is also used for
"Jackrabbit3" nowadays, and JR itself won't be released in v3 at all since OAK
is to replace it as "Jackrabbit 3".
Yeah, weird, just figured out a justification. ;-)
Regards,
Woonsan
[1]
https://lists.apache.org/thread.html/71dc8ab6526b114fc16f60727ea66ee4c9c4e02dbc10794b5a9477e2@%3Cdev.commons.apache.org%3E
[2]
https://lists.apache.org/thread.html/2632179eab395e25261f8e55bfebd9d6da9bb72b769a0b56c5b6bfd8@%3Cdev.commons.apache.org%3E
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-482395737 Now it's really ready to review. It now depends on the latest JR release: 2.19.2. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479550829 Hi @garydgregory , This PR is now ready to review! This PR includes (a) new `webdav4` provider based on the latest stable Jackrabbit release, **2.18.0** in a separate jar submodule: `commons-vfs2-jackrabbit3`, (b) the old `webdav3` provider based on Jackrabbit 1.x moved to a separate JAR module: `commons-vfs2-jackrabbit2`. Java 9 JPMS and webdav4s (on https) are not included. Those can be done with new tickets. Please note that `commons-vfs2-jackrabbit3` submodule skips both test-compile and tests totally by default because it depends on Jackrabbit 2.19.2-SNAPSHOT at the moment for testing. Ref: JCR-4401. Its testing can be enabled with `mvn clean install -DtestJackrabbit3`, which works fine on env with the snapshot dependency access. Once Jackrabbit 2.19.2 or higher becomes available, we can probably enable the tests by default later. Is this okay? Thanks in advance! Kind regards, Woonsan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479304944 Hi @garydgregory , Yet not ready status because jackrabbit3 submodule depends on the following (in root pom): > 2.19.2-SNAPSHOT I need to get the release out soon but will take some time. Woonsan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479279513 Hi @garydgregory , I think I found the cause. It's all my bad. For some reason -- probably due to my git env setting, some resource files were not committed/pushed. e.g, commons-vfs2-jackrabbit2/src/test/resources/test-data/read-tests/subdir4.jar and its descendants, commons-vfs2-jackrabbit2/src/test/resources/test-data/*.gz, *.jar, *.tar, ... Sorry and thanks for noticing this problem! I'll fix it asap. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-479276504 @garydgregory , just fyi, I'm trying to figure out how to reproduce this locally. Strangely, my local tests were successful... :( > junit.framework.AssertionFailedError: webdav://admin@localhost:36382/repository/default/read-tests/dir1/subdir4.jar > ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-478699483 @garydgregory , when I merged master locally, it started failing like that... Some test env setting might have changed bc26e4b1c0a11b8609cab880b1821d3560f34d06 to 0a1f3f6f38517d5819cda5e6aac33364f39c407c. Will look into it tonight.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-478629869 > I see a merge from trunk but that branch should not exist. Please master. Thank you so much @garydgregory ! I've just reverted. You saved me! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
