[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

2017-09-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/282 I added a test. Thanks for the pull request! :+1: ---

[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

2017-08-13 Thread namannigam
Github user namannigam commented on the issue: https://github.com/apache/commons-lang/pull/282 @kinow @garydgregory Sure would try to come back soon with a unit test for the use-case. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

2017-08-13 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/282 created https://issues.apache.org/jira/browse/LANG-1349 to track this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

2017-08-11 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/282 +1 on the unit test request, we need it to avoid regressions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

2017-08-11 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/282 Makes sense, good catch. However, would be nice to have a unit test at least to cover that case, and make sure we don't have any regression for this behaviour. Would you be able to create one

[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

2017-08-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/282 [![Coverage Status](https://coveralls.io/builds/12772155/badge)](https://coveralls.io/builds/12772155) Coverage increased (+0.03%) to 95.214% when pulling