Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
There is a lot of complexity in commons-parent and commons generally.
Getting a build to work for Joda was hard enough, and there I am willing to
insist on releases being done on Java 9 or
Github user johnou commented on the issue:
https://github.com/apache/commons-lang/pull/299
@jodastephen can you be more specific?
---
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
Its not just compiling, there are issues at runtime still AFAIK, especially
with Java EE and older bytecode libraries.
---
Github user johnou commented on the issue:
https://github.com/apache/commons-lang/pull/299
@jodastephen have you checked out https://github.com/moditect/moditect ?
Moditect uses Objweb-ASM to compile the module-info.class which means you
can support Java 1.7 / 1.8 for
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
Adding `module-info` causes some older/Android projects to fail as they
can't handle the class format. So, projects are left with the choice of moving
forwards or breaking these
Github user sigursoft commented on the issue:
https://github.com/apache/commons-lang/pull/299
Hi guys,
What's the status on this pull request? ð
---
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
@namannigam You need to check it out and run `mvn clean install site` on
Java 9.
---
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/299
[](https://coveralls.io/builds/13963478)
Coverage decreased (-0.02%) to 95.163% when pulling
Github user namannigam commented on the issue:
https://github.com/apache/commons-lang/pull/299
@jodastephen What's the error that you get with site? Any links to the
build?
---
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
`mvn install` works fine on each JDK version AFAICT. `mvn site` still
breaks on cobertura on Java 9 and I'm not sure I can work around it without
removing it from the parent pom.
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/299
I'll bring this up a last time on the ML to make sure nobody has objections
against merging this.
---
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/299
[](https://coveralls.io/builds/13919900)
Coverage decreased (-0.02%) to 95.163% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/299
[](https://coveralls.io/builds/13919900)
Coverage decreased (-0.02%) to 95.163% when pulling
Github user michaelsavich commented on the issue:
https://github.com/apache/commons-lang/pull/299
Ah, gotcha. That makes sense.
---
Github user jodastephen commented on the issue:
https://github.com/apache/commons-lang/pull/299
@michaelsavich , this PR does not create a full dependency on
`java.desktop`. The dependency is expressed as `requires static`, which means
that it will not be pulled in by default. Users
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/299
@michaelsavich I have a proposal in a branch, submitted some months ago
https://github.com/apache/commons-lang/pull/275
Waiting for feedback to prepare deprecated annotations in place,
Github user michaelsavich commented on the issue:
https://github.com/apache/commons-lang/pull/299
Is there any way to rewrite AbstractCircuitBreaker to eliminate the
dependency on java.desktop? Java.desktop is quite a large dependency to have
for the sake of one class.
---
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/299
[](https://coveralls.io/builds/13771842)
Coverage increased (+0.01%) to 95.199% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/299
[](https://coveralls.io/builds/13771246)
Coverage increased (+0.01%) to 95.199% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/299
[](https://coveralls.io/builds/13758874)
Coverage increased (+0.01%) to 95.199% when pulling
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/299
Awesome! Would be create if you could create and reference a JIRA ticket as
described in CONTRIBUTING.md, so this will show up in our release notes.
---
21 matches
Mail list logo
