emopers opened a new pull request #399: Synchronize before looping over 
synchronized collection
URL: https://github.com/apache/commons-lang/pull/399
 
 
   In `CharSet.java`, `set = Collections.synchronizedSet(new HashSet<>())` is 
iterated over
   without synchronization. According to [Java API] 
(https://docs.oracle.com/javase/6/docs/api/java/util/Collections.html#synchronizedCollection%28java.util.Collection%29),
 it is recommended that user manually synchronizes each iteration over the 
synchronized collection to reduce non-determinism. 
   
   This pull request improves the condition by synchronizing a loop which loops 
over the synchronized collection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to