[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-11-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497255#comment-13497255 ] Gary Gregory commented on CSV-68: - Hello Benedikt, I'm playing a bit of the devil's advocate

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-11-14 Thread Benedikt Ritter (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497212#comment-13497212 ] Benedikt Ritter commented on CSV-68: Hi Gary, the problem is, that the user has no possib

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-11-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497178#comment-13497178 ] Gary Gregory commented on CSV-68: - Hm... so why is this: {code:java} CSVFormat format = CSVF

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231930#comment-13231930 ] Sebb commented on CSV-68: - I've just discovered another disadvantage of the current code. Removal of

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-17 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231899#comment-13231899 ] Emmanuel Bourg commented on CSV-68: --- I suggest to remove the validation completely. No other

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231794#comment-13231794 ] Sebb commented on CSV-68: - OK, let's use build, which is only two characters longer. Is it really that

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231522#comment-13231522 ] Emmanuel Bourg commented on CSV-68: --- Ok it's shorter but it doesn't make sense, what is the

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231440#comment-13231440 ] Sebb commented on CSV-68: - How about: {code} CSVFormat.withDelimiter(';').withEncapsulator('"').go();

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231390#comment-13231390 ] Emmanuel Bourg commented on CSV-68: --- This one would satisfy me: {code} new CSVFormat().with

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231369#comment-13231369 ] Sebb commented on CSV-68: - bq. how about renaming init(char) to withDelimiter(char) The delimiter is

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Simone Tripodi (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231157#comment-13231157 ] Simone Tripodi commented on CSV-68: --- FWIW, +1 to builder and fluent APIs >

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Benedikt Ritter (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231116#comment-13231116 ] Benedikt Ritter commented on CSV-68: Hey, how about renaming {{init(char)}} to {{withDeli

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231073#comment-13231073 ] Sebb commented on CSV-68: - The extra verbosity is .init(',') and .build() Not a lot. The gains are: -

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Emmanuel Bourg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230948#comment-13230948 ] Emmanuel Bourg commented on CSV-68: --- As stated on the list I'm -1 on changing CSVFormat to t