[ https://issues.apache.org/jira/browse/CB-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950758#comment-13950758 ]
ASF subversion and git services commented on CB-6373: ----------------------------------------------------- Commit 1fd31480eef4b3ecf28d1ef7bea9acaa1ee45ec0 in cordova-mobile-spec's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=1fd3148 ] CB-6373: Make doNotCallSpies more resilient to errors This ensures that they cause test failures, even when a JSON exception is thrown while logging the error. > Do-not-call spies won't error if an exception is thrown > ------------------------------------------------------- > > Key: CB-6373 > URL: https://issues.apache.org/jira/browse/CB-6373 > Project: Apache Cordova > Issue Type: Bug > Components: mobile-spec > Reporter: Ian Clelland > Assignee: Ian Clelland > > In the mobile spec test runner, the function created by > {{createDoNotCallSpy}} logs an error message containing the JSON > serialization of the function arguments, and then makes a false assertion, to > cause a test to fail. > If the function arguments are not JSON-serializable, then an exception will > be thrown in the spy, and failure will never be asserted. If a test is > counting on a doNotCallSpy to not be called, it may succeed, since the spy > will never cause a test failure. > (This was noticed because one of the File tests, file.spec.9, was failing > unnoticed on iOS until FileEntry objects became serializable with CB-6352) -- This message was sent by Atlassian JIRA (v6.2#6252)