[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165681#comment-14165681 ] ASF subversion and git services commented on CB-6837: - Commit

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163585#comment-14163585 ] ASF GitHub Bot commented on CB-6837: Github user asfgit closed the pull request at:

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159261#comment-14159261 ] ASF subversion and git services commented on CB-6837: - Commit

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159262#comment-14159262 ] ASF subversion and git services commented on CB-6837: - Commit

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159263#comment-14159263 ] ASF GitHub Bot commented on CB-6837: Github user asfgit closed the pull request at:

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157724#comment-14157724 ] Martin Gonzalez commented on CB-6837: - Hi Ian, I've made the required changes to fix

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156967#comment-14156967 ] Ian Clelland commented on CB-6837: -- The code looks pretty clean, and I think it's in the

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156983#comment-14156983 ] Ian Clelland commented on CB-6837: -- I build a small sample like this:

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157025#comment-14157025 ] Ian Clelland commented on CB-6837: -- Same behaviour on 4.4.4 Hitting Back button while

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157035#comment-14157035 ] Martin Gonzalez commented on CB-6837: - Hey Ian, I'm just getting back from lunch, let me

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157056#comment-14157056 ] Martin Gonzalez commented on CB-6837: - Yes, I see what you are saying, the problem is the

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157074#comment-14157074 ] Ian Clelland commented on CB-6837: -- If multiple dialogs are queued, is the intended behavior

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157091#comment-14157091 ] Martin Gonzalez commented on CB-6837: - I would say that if it doesn't cause the window

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143435#comment-14143435 ] Martin Gonzalez commented on CB-6837: - Ok, sounds good. I'll do a rebase with master, in

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143485#comment-14143485 ] ASF GitHub Bot commented on CB-6837: Github user martincgg closed the pull request at:

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143703#comment-14143703 ] ASF GitHub Bot commented on CB-6837: GitHub user martincgg opened a pull request:

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143757#comment-14143757 ] ASF GitHub Bot commented on CB-6837: GitHub user martincgg opened a pull request:

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143770#comment-14143770 ] Martin Gonzalez commented on CB-6837: - Hi [~bowserj], [~iclelland]. I've did a rebase to

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140654#comment-14140654 ] Ian Clelland commented on CB-6837: -- The takeaway seems to be that concrete instances of

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140752#comment-14140752 ] ASF GitHub Bot commented on CB-6837: Github user martincgg commented on a diff in the

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140771#comment-14140771 ] Martin Gonzalez commented on CB-6837: - Hi [~iclelland], I've made some changes, removed:

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140943#comment-14140943 ] Joe Bowser commented on CB-6837: Do you have to use the CordovaChromeClient for this? This

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141032#comment-14141032 ] Ian Clelland commented on CB-6837: -- CordovaChromeClient seems like the right place to put

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139209#comment-14139209 ] Martin Gonzalez commented on CB-6837: - Hey [~bowserj], well the CordovaChromeClient will

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139235#comment-14139235 ] Joe Bowser commented on CB-6837: I think handleDestroy would have to be where this lives, and

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139286#comment-14139286 ] Martin Gonzalez commented on CB-6837: - 1.- I can, just use the CordovaView to call the

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139479#comment-14139479 ] Joe Bowser commented on CB-6837: On Thu, Sep 18, 2014 at 11:22 AM, Martin Gonzalez (JIRA)

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139482#comment-14139482 ] Joe Bowser commented on CB-6837: OK, sorry about the blank message. Here's my comment. On

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139621#comment-14139621 ] Martin Gonzalez commented on CB-6837: - Ok, I'll try to do this in another way.

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138071#comment-14138071 ] Joe Bowser commented on CB-6837: If you want your pull requests reviewed faster, assign to a

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138077#comment-14138077 ] Martin Gonzalez commented on CB-6837: - I'll keep it in mind next time, Thanks. Hitting

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138123#comment-14138123 ] Joe Bowser commented on CB-6837: Can this code not be located in the

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107516#comment-14107516 ] Martin Gonzalez commented on CB-6837: - the Alert dialog, it throws the exception above

[jira] [Commented] (CB-6837) Hitting Back button while alert being rendered causes leaked window

[ https://issues.apache.org/jira/browse/CB-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107638#comment-14107638 ] ASF GitHub Bot commented on CB-6837: GitHub user martincgg opened a pull request: