[jira] [Closed] (CB-12654) Cordova release build blocks ajax requests
[ https://issues.apache.org/jira/browse/CB-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-12654. - Resolution: Not A Problem Ok, closing as not a problem as it was not a Cordova problem, but a webview bug. Thanks for all the research you did on the issue! > Cordova release build blocks ajax requests > -- > > Key: CB-12654 > URL: https://issues.apache.org/jira/browse/CB-12654 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Environment: cordova-android@4.1.1 , Android Version 7.1.1, Nexus 5X >Reporter: Chandra Sekhar Walajapet Sureshbabu > > Android Cordova Debug Build works fine on Nexus 5X, 7.1.1 , However it fails > to make any ajax requests on Release(Signed) Build. > Tried communicating from native code using a plugin, the connection is > successful > The issue occurs only in Nexus 5X, 7.1.1 and doesn't happen on other devices. > Permissions: > > > Whitelist plugin in config.xml: > > value="org.apache.cordova.whitelist.WhitelistPlugin" /> > > > Even tested with logs in ChromeWebViewImpl.java > Returns true when asked for shouldAllow > CSP: > https://ssl.gstatic.com 'unsafe-eval'; style-src 'self' 'unsafe-inline'; > media-src *; connect-src https://mysubdomain.mydomain.com;> > Please note the CSP works for all Android, iOS devices except for Nexus 5X > 7.1.1, i even tried removing connect-src, but same result. > Did anyone come across similar issue ? -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12622) Added support for Android 6 and 7 to the cloudapp CI
[ https://issues.apache.org/jira/browse/CB-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970881#comment-15970881 ] ASF GitHub Bot commented on CB-12622: - GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/151 CB-12622: (android) Adapt Appium tests for Android 6 and 7 ### Platforms affected Android ### What does this PR do? Makes Appium tests honor the selenium quirk which leads to stack overflow on Android 6 and 7. Also, adds a permission dialog buster for Appium tests. ### What testing has been done on this change? Ran tests on Sauce Labs for Android 6 and 7 emulators. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alsorokin/cordova-plugin-contacts CB-12622 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit 25570f1c3b50981ae17fb1110cc1af3b958ee64a Author: Alexander SorokinDate: 2017-04-17T08:58:40Z CB-12622: (android) Adapt Appium tests for Android 6 and 7 > Added support for Android 6 and 7 to the cloudapp CI > > > Key: CB-12622 > URL: https://issues.apache.org/jira/browse/CB-12622 > Project: Apache Cordova > Issue Type: Bug >Reporter: Filip Maj >Assignee: Alexander Sorokin > > Capabilities for Android 6 look like: > {noformat} > deviceName: 'Android Emulator', > platformName: 'Android', > platformVersion: '6.0', > appiumVersion: '1.6.3' > {noformat} > While for 7 you need to specify a different {{deviceName}}: > {noformat} > deviceName: 'Android GoogleAPI Emulator', > platformName: 'Android', > platformVersion: '7.0', > appiumVersion: '1.6.3' > {noformat} > [~alsorokin] is it possible to add these to the cloudapp android environment > matrix? -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12622) Added support for Android 6 and 7 to the cloudapp CI
[ https://issues.apache.org/jira/browse/CB-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970914#comment-15970914 ] ASF GitHub Bot commented on CB-12622: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/151 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/151/commits/25570f1c3b50981ae17fb1110cc1af3b958ee64a) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/94/) 236 tests run, 17 skipped, 5 failed. > Added support for Android 6 and 7 to the cloudapp CI > > > Key: CB-12622 > URL: https://issues.apache.org/jira/browse/CB-12622 > Project: Apache Cordova > Issue Type: Bug >Reporter: Filip Maj >Assignee: Alexander Sorokin > > Capabilities for Android 6 look like: > {noformat} > deviceName: 'Android Emulator', > platformName: 'Android', > platformVersion: '6.0', > appiumVersion: '1.6.3' > {noformat} > While for 7 you need to specify a different {{deviceName}}: > {noformat} > deviceName: 'Android GoogleAPI Emulator', > platformName: 'Android', > platformVersion: '7.0', > appiumVersion: '1.6.3' > {noformat} > [~alsorokin] is it possible to add these to the cloudapp android environment > matrix? -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12622) Added support for Android 6 and 7 to the cloudapp CI
[ https://issues.apache.org/jira/browse/CB-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970932#comment-15970932 ] ASF GitHub Bot commented on CB-12622: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/151 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/151/commits/cb695ce0e31d691848ef8fed499a356dc642ea80) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/95/) 236 tests run, 17 skipped, 0 failed. > Added support for Android 6 and 7 to the cloudapp CI > > > Key: CB-12622 > URL: https://issues.apache.org/jira/browse/CB-12622 > Project: Apache Cordova > Issue Type: Bug >Reporter: Filip Maj >Assignee: Alexander Sorokin > > Capabilities for Android 6 look like: > {noformat} > deviceName: 'Android Emulator', > platformName: 'Android', > platformVersion: '6.0', > appiumVersion: '1.6.3' > {noformat} > While for 7 you need to specify a different {{deviceName}}: > {noformat} > deviceName: 'Android GoogleAPI Emulator', > platformName: 'Android', > platformVersion: '7.0', > appiumVersion: '1.6.3' > {noformat} > [~alsorokin] is it possible to add these to the cloudapp android environment > matrix? -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12663) Cordova with dev version (6.5.1-dev) doesn't install latest version of plugin
Nikita Matrosov created CB-12663: Summary: Cordova with dev version (6.5.1-dev) doesn't install latest version of plugin Key: CB-12663 URL: https://issues.apache.org/jira/browse/CB-12663 Project: Apache Cordova Issue Type: Bug Components: cordova-lib Affects Versions: 6.5.0 Reporter: Nikita Matrosov Assignee: Nikita Matrosov It's about plugin which have engine tag for verifying cordova version (cordova-plugin-inappbrowser, cordova-plugin-ms-adal) -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12663) Cordova with dev version (6.5.1-dev) doesn't install latest version of plugin
[ https://issues.apache.org/jira/browse/CB-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Matrosov updated CB-12663: - Description: It's about plugins which have engine tag for verifying cordova version (cordova-plugin-inappbrowser, cordova-plugin-ms-adal) (was: It's about plugins which have engine tag for verifying cordova version (cordova-plugin-inappbrowser, cordova-plugin-ms-adal) PR: https://github.com/apache/cordova-lib/pull/542) > Cordova with dev version (6.5.1-dev) doesn't install latest version of plugin > - > > Key: CB-12663 > URL: https://issues.apache.org/jira/browse/CB-12663 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 6.5.0 >Reporter: Nikita Matrosov >Assignee: Nikita Matrosov > > It's about plugins which have engine tag for verifying cordova version > (cordova-plugin-inappbrowser, cordova-plugin-ms-adal) -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12663) Cordova with dev version (6.5.1-dev) doesn't install latest version of plugin
[ https://issues.apache.org/jira/browse/CB-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Matrosov updated CB-12663: - Description: It's about plugins which have engine tag for verifying cordova version (cordova-plugin-inappbrowser, cordova-plugin-ms-adal) PR: https://github.com/apache/cordova-lib/pull/542 was:It's about plugins which have engine tag for verifying cordova version (cordova-plugin-inappbrowser, cordova-plugin-ms-adal) > Cordova with dev version (6.5.1-dev) doesn't install latest version of plugin > - > > Key: CB-12663 > URL: https://issues.apache.org/jira/browse/CB-12663 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 6.5.0 >Reporter: Nikita Matrosov >Assignee: Nikita Matrosov > > It's about plugins which have engine tag for verifying cordova version > (cordova-plugin-inappbrowser, cordova-plugin-ms-adal) > PR: https://github.com/apache/cordova-lib/pull/542 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12663) Cordova with dev version (6.5.1-dev) doesn't install latest version of plugin
[ https://issues.apache.org/jira/browse/CB-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Matrosov updated CB-12663: - Description: It's about plugins which have engine tag for verifying cordova version (cordova-plugin-inappbrowser, cordova-plugin-ms-adal) (was: It's about plugin which have engine tag for verifying cordova version (cordova-plugin-inappbrowser, cordova-plugin-ms-adal)) > Cordova with dev version (6.5.1-dev) doesn't install latest version of plugin > - > > Key: CB-12663 > URL: https://issues.apache.org/jira/browse/CB-12663 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 6.5.0 >Reporter: Nikita Matrosov >Assignee: Nikita Matrosov > > It's about plugins which have engine tag for verifying cordova version > (cordova-plugin-inappbrowser, cordova-plugin-ms-adal) -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12622) Added support for Android 6 and 7 to the cloudapp CI
[ https://issues.apache.org/jira/browse/CB-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970958#comment-15970958 ] ASF GitHub Bot commented on CB-12622: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/151 > Added support for Android 6 and 7 to the cloudapp CI > > > Key: CB-12622 > URL: https://issues.apache.org/jira/browse/CB-12622 > Project: Apache Cordova > Issue Type: Bug >Reporter: Filip Maj >Assignee: Alexander Sorokin > > Capabilities for Android 6 look like: > {noformat} > deviceName: 'Android Emulator', > platformName: 'Android', > platformVersion: '6.0', > appiumVersion: '1.6.3' > {noformat} > While for 7 you need to specify a different {{deviceName}}: > {noformat} > deviceName: 'Android GoogleAPI Emulator', > platformName: 'Android', > platformVersion: '7.0', > appiumVersion: '1.6.3' > {noformat} > [~alsorokin] is it possible to add these to the cloudapp android environment > matrix? -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12622) Added support for Android 6 and 7 to the cloudapp CI
[ https://issues.apache.org/jira/browse/CB-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970957#comment-15970957 ] ASF subversion and git services commented on CB-12622: -- Commit cb695ce0e31d691848ef8fed499a356dc642ea80 in cordova-plugin-contacts's branch refs/heads/master from [~alsorokin] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=cb695ce ] CB-12622: (android) Adapt Appium tests for Android 6 and 7 > Added support for Android 6 and 7 to the cloudapp CI > > > Key: CB-12622 > URL: https://issues.apache.org/jira/browse/CB-12622 > Project: Apache Cordova > Issue Type: Bug >Reporter: Filip Maj >Assignee: Alexander Sorokin > > Capabilities for Android 6 look like: > {noformat} > deviceName: 'Android Emulator', > platformName: 'Android', > platformVersion: '6.0', > appiumVersion: '1.6.3' > {noformat} > While for 7 you need to specify a different {{deviceName}}: > {noformat} > deviceName: 'Android GoogleAPI Emulator', > platformName: 'Android', > platformVersion: '7.0', > appiumVersion: '1.6.3' > {noformat} > [~alsorokin] is it possible to add these to the cloudapp android environment > matrix? -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1
[ https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971022#comment-15971022 ] ASF GitHub Bot commented on CB-3232: GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/542 Install latest version of plugin in case of using dev cordova version ### What does this PR do? Semver couldn't verify if cordova version with prerelease tag satisfies to range specified in engine tag. This PR removes prereleased tag for comparing with range. It's about `cordova-plugin-inappbrowser` and `cordova-plugin-ms-adal`. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matrosov-nikita/cordova-lib check-requirements-with-dev-cordova-version Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/542.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #542 commit d70de05ac279255296641693dd19915407b324a2 Author: Nikita MatrosovDate: 2017-04-17T12:31:36Z Install latest version of plugin in case of using dev cordova version Semver couldn't verify if cordova version with prerelease tag satisfies to range specified in engine tag > "cordova platform add blackberry" fails on 2.7.1-rc.1 > - > > Key: CB-3232 > URL: https://issues.apache.org/jira/browse/CB-3232 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry (deprecated), CLI >Affects Versions: 2.7.0 >Reporter: Michael Brooks >Assignee: Michael Brooks > Fix For: 2.7.0 > > > The following error is thrown when running {{$ cordova platform add > blackberry}}: > {code} > [Error: An error occured during creation of blackberry sub-project. Creating > BlackBerry project... > Updating config.xml ... > sed: > /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml: > No such file or directory > Cleaning up ... > Remember to update the project.properties file inside your application > directory! > ] > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12664) iOS 10.3.1 break input file videos with forced multiple select
meir created CB-12664: - Summary: iOS 10.3.1 break input file videos with forced multiple select Key: CB-12664 URL: https://issues.apache.org/jira/browse/CB-12664 Project: Apache Cordova Issue Type: Bug Components: iOS Environment: phonegap build, iOS 10.3.1, iPhone 6S Reporter: meir Priority: Critical Inputs cannot access video files because multiple file select is forced and videos are no longer being compressed before being selected. To test: - put a file input in any cordova demo application, - select a video file (you will see multiple file select is forced) - try access the file to check the size or get the content: size is 0, no content. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12592) Refactor and add delete require.cache to cordova_util and create pkgManager
[ https://issues.apache.org/jira/browse/CB-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-12592. -- Resolution: Fixed > Refactor and add delete require.cache to cordova_util and create pkgManager > --- > > Key: CB-12592 > URL: https://issues.apache.org/jira/browse/CB-12592 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: 7.0.0 > > There are 120 instances of delete require.cache in cordova-lib. It should be > refactored and added to cordova_util so it can be reused when needed. Package > manager should also be created to load and save pkgJson files. Package > manager loads files without require so that there is never a cache and saves > stringified object to file. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12666) Remove node 0.x testing from cordova-create
Shazron Abdullah created CB-12666: - Summary: Remove node 0.x testing from cordova-create Key: CB-12666 URL: https://issues.apache.org/jira/browse/CB-12666 Project: Apache Cordova Issue Type: Bug Components: cordova-create Reporter: Shazron Abdullah Assignee: Shazron Abdullah Remove from travis.yml and appveyor.yml -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12666) Remove node 0.x testing from cordova-create
[ https://issues.apache.org/jira/browse/CB-12666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-12666. --- Resolution: Fixed > Remove node 0.x testing from cordova-create > --- > > Key: CB-12666 > URL: https://issues.apache.org/jira/browse/CB-12666 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-create >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Remove from travis.yml and appveyor.yml -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12662) cordova-common Release April 14, 2017
[ https://issues.apache.org/jira/browse/CB-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972164#comment-15972164 ] ASF subversion and git services commented on CB-12662: -- Commit a20336d975a8e1ea02f182b89bdb606382921b77 in cordova-create's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-create.git;h=a20336d ] CB-12662 - Update cordova-common dependency version to 2.0.2 This closes #4 > cordova-common Release April 14, 2017 > - > > Key: CB-12662 > URL: https://issues.apache.org/jira/browse/CB-12662 > Project: Apache Cordova > Issue Type: Task >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > **NOTE:** > {quote} > Update the cordova-common package.json dependencies in cordova-lib and > cordova-fetch after this cordova-common release has been published to npm > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12666) Remove node 0.x testing from cordova-create
[ https://issues.apache.org/jira/browse/CB-12666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972155#comment-15972155 ] ASF subversion and git services commented on CB-12666: -- Commit 09b8c926cbfcce7f364536cefd8a7bc99a989ea8 in cordova-create's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-create.git;h=09b8c92 ] CB-12666 - Remove node 0.x testing. Cleaned up testing use of v4 and v6 of node This closes #5 > Remove node 0.x testing from cordova-create > --- > > Key: CB-12666 > URL: https://issues.apache.org/jira/browse/CB-12666 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-create >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Remove from travis.yml and appveyor.yml -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12662) cordova-common Release April 14, 2017
[ https://issues.apache.org/jira/browse/CB-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971464#comment-15971464 ] ASF GitHub Bot commented on CB-12662: - GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/543 CB-12662 - update cordova-common dependency to 2.0.2 ### Platforms affected All. ### What does this PR do? Update the cordova-common dep in cordova-lib and cordova-fectch to 2.0.2 ### What testing has been done on this change? CI tests for this PR. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-12662 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/543.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #543 commit a7d3ba4476c4efa654f222a771424b6a92c32e3c Author: Shazron AbdullahDate: 2017-04-17T18:34:27Z CB-12662 - update cordova-common dependency to 2.0.2 > cordova-common Release April 14, 2017 > - > > Key: CB-12662 > URL: https://issues.apache.org/jira/browse/CB-12662 > Project: Apache Cordova > Issue Type: Task >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > **NOTE:** > {quote} > Update the cordova-common package.json dependencies in cordova-lib and > cordova-fetch after this cordova-common release has been published to npm > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8980) Adding resource-file Element to config.xml for iOS
[ https://issues.apache.org/jira/browse/CB-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971484#comment-15971484 ] ASF GitHub Bot commented on CB-8980: Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/304 Closing this. Will open a new PR with cordova-common 2.0.2 > Adding resource-file Element to config.xml for iOS > -- > > Key: CB-8980 > URL: https://issues.apache.org/jira/browse/CB-8980 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI, CordovaLib >Affects Versions: Master > Environment: iOS >Reporter: Karen Tran >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Based on the parent task, create a new resource-file element tag to copy > resource files from src to the correct directory with the given name. > Example: > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8980) Adding resource-file Element to config.xml for iOS
[ https://issues.apache.org/jira/browse/CB-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971486#comment-15971486 ] ASF GitHub Bot commented on CB-8980: Github user shazron closed the pull request at: https://github.com/apache/cordova-ios/pull/304 > Adding resource-file Element to config.xml for iOS > -- > > Key: CB-8980 > URL: https://issues.apache.org/jira/browse/CB-8980 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI, CordovaLib >Affects Versions: Master > Environment: iOS >Reporter: Karen Tran >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Based on the parent task, create a new resource-file element tag to copy > resource files from src to the correct directory with the given name. > Example: > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12617) Remove node 0.x support for platforms
[ https://issues.apache.org/jira/browse/CB-12617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971489#comment-15971489 ] ASF GitHub Bot commented on CB-12617: - Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/301 @audreyso I got this warning now: ``` npm WARN engineStrict Per-package engineStrict (found in this package's package.json) npm WARN engineStrict won't be used in npm 3+. Use the config setting `engine-strict` instead. ``` > Remove node 0.x support for platforms > - > > Key: CB-12617 > URL: https://issues.apache.org/jira/browse/CB-12617 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Browser, iOS, Windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12662) cordova-common Release April 14, 2017
[ https://issues.apache.org/jira/browse/CB-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971472#comment-15971472 ] ASF GitHub Bot commented on CB-12662: - GitHub user shazron opened a pull request: https://github.com/apache/cordova-cli/pull/274 CB-12662 - update cordova-common dependency to 2.0.2 ### Platforms affected All ### What does this PR do? Update cordova-common dependency to 2.0.2 ### What testing has been done on this change? CI tests in this PR. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-cli CB-12662 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #274 commit fcc597b1f6661f778440b1def0b98a30017e677a Author: Shazron AbdullahDate: 2017-04-17T18:38:35Z CB-12662 - update cordova-common dependency to 2.0.2 > cordova-common Release April 14, 2017 > - > > Key: CB-12662 > URL: https://issues.apache.org/jira/browse/CB-12662 > Project: Apache Cordova > Issue Type: Task >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > **NOTE:** > {quote} > Update the cordova-common package.json dependencies in cordova-lib and > cordova-fetch after this cordova-common release has been published to npm > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12662) cordova-common Release April 14, 2017
[ https://issues.apache.org/jira/browse/CB-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971492#comment-15971492 ] ASF GitHub Bot commented on CB-12662: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/543 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/543?src=pr=h1) Report > Merging [#543](https://codecov.io/gh/apache/cordova-lib/pull/543?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/0d637f2d67a95ef709443eaa9d7481eb14f79b8d?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/543/graphs/tree.svg?token=KwBjKMXLqA=pr=650=150)](https://codecov.io/gh/apache/cordova-lib/pull/543?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #543 +/- ## === Coverage 82.42% 82.42% === Files 68 68 Lines5462 5462 Branches 1072 1072 === Hits 4502 4502 Misses960 960 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/543?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/543?src=pr=footer). Last update [0d637f2...a7d3ba4](https://codecov.io/gh/apache/cordova-lib/pull/543?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > cordova-common Release April 14, 2017 > - > > Key: CB-12662 > URL: https://issues.apache.org/jira/browse/CB-12662 > Project: Apache Cordova > Issue Type: Task >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > **NOTE:** > {quote} > Update the cordova-common package.json dependencies in cordova-lib and > cordova-fetch after this cordova-common release has been published to npm > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8980) Adding resource-file Element to config.xml for iOS
[ https://issues.apache.org/jira/browse/CB-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971497#comment-15971497 ] ASF GitHub Bot commented on CB-8980: GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/305 CB-8980 - Support tag in config.xml in iOS platform ### Platforms affected self ### What does this PR do? Support `` tag in config.xml in iOS platform ### What testing has been done on this change? **NONE**. Work In Progress. Will update as I go along. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-8980-b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/305.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #305 commit 9a52b2fbede0f54c0e2209b2d2508108536a5f25 Author: Shazron AbdullahDate: 2017-04-14T00:31:02Z CB-8980 - Adding resource-file element to config.xml for iOS commit 9df5787c3d2763abd348907da15de02594c69dcc Author: Shazron Abdullah Date: 2017-04-17T18:51:32Z CB-8980 - Update bundled cordova-common to version 2.0.2 > Adding resource-file Element to config.xml for iOS > -- > > Key: CB-8980 > URL: https://issues.apache.org/jira/browse/CB-8980 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI, CordovaLib >Affects Versions: Master > Environment: iOS >Reporter: Karen Tran >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Based on the parent task, create a new resource-file element tag to copy > resource files from src to the correct directory with the given name. > Example: > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12542) can’t record to a “wav” file on IOS media plugin
[ https://issues.apache.org/jira/browse/CB-12542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971667#comment-15971667 ] ASF GitHub Bot commented on CB-12542: - Github user dylanvdmerwe commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Please can someone review this PR. This is a very suitable fix for a real problem. > can’t record to a “wav” file on IOS media plugin > > > Key: CB-12542 > URL: https://issues.apache.org/jira/browse/CB-12542 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 3.5.0 > Environment: 9.x Simulator , IOS 8.x device (iPod touch) >Reporter: Leo Schubert >Priority: Critical > Attachments: cdvsound.diff > > > I get “Failed to initialize AVAudioRecorder: (null)” in the error callback of > the startRecordingAudio() exec API. > I see that the AVAudioPlayer settings in CDVAudio.m are > {code} > NSDictionary *audioSettings = @{AVFormatIDKey: @(kAudioFormatMPEG4AAC), > AVSampleRateKey: @(44100), > AVNumberOfChannelsKey: @(1), > AVEncoderAudioQualityKey: > @(AVAudioQualityMedium) > }; > {code} > This is IMHO the reason it doesn’t work. Either one uses the .m4a extension > with {{kAudioFormatMPEG4AAC}} or > .wav with the {{kAudioFormatLinearPCM}} key (the IOS docs are very unclear > about which file extensions are actually supported) > The plugin enforces “wav” but the settings enforce the MPEG4AAC encoder. > Using the attached simple patch and using .m4a at the JS side solves the > problem and records on my iPod touch IOS 8.x. > I stumbled also across > https://github.com/remoorejr/cordova-plugin-media-with-compression where the > exchange wav->m4a is done too. > Strangely I can’t find much problems reported on stackoverflow, but this one > seems to cover it > http://stackoverflow.com/questions/12244111/failed-to-initialize-avaudiorecorder-null > The last poster seem to indicate that the problem sneaked in in IOS 8 > (previously it was probably possible to record to a .wav file but with AAC > content). > Looking at the recordAudio() test for the plugin in tests/tests.js I can’t > see that potential errors are actually causing the test to fail: they are > just logged with console.log , so this may explain why the problem has not > been detected by the tests. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12665) engineStrict no longer supported
[ https://issues.apache.org/jira/browse/CB-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-12665: --- Component/s: cordova-lib > engineStrict no longer supported > > > Key: CB-12665 > URL: https://issues.apache.org/jira/browse/CB-12665 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib, iOS >Affects Versions: cordova-7 >Reporter: Audrey So >Priority: Minor > Fix For: cordova-7 > > > Remove engineStrict from package.json. It is no longer supported. > ```*WARN engineStrict Per-package engineStrict (found in this package's > package.json)` > *npm WARN engineStrict won't be used in npm 3+. Use the config setting > engine-strict instead.``` -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12662) cordova-common Release April 14, 2017
[ https://issues.apache.org/jira/browse/CB-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971787#comment-15971787 ] ASF subversion and git services commented on CB-12662: -- Commit d2b636a98e4d1a8c8f7199897b7ac09b659f in cordova-lib's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=d2b636a ] CB-12662 - update cordova-common dependency to 2.0.2 This closes #543 > cordova-common Release April 14, 2017 > - > > Key: CB-12662 > URL: https://issues.apache.org/jira/browse/CB-12662 > Project: Apache Cordova > Issue Type: Task >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > **NOTE:** > {quote} > Update the cordova-common package.json dependencies in cordova-lib and > cordova-fetch after this cordova-common release has been published to npm > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12662) cordova-common Release April 14, 2017
[ https://issues.apache.org/jira/browse/CB-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971789#comment-15971789 ] ASF subversion and git services commented on CB-12662: -- Commit 72440d140ab1929bac94f5f4dea449e626dade90 in cordova-cli's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=72440d1 ] CB-12662 - update cordova-common dependency to 2.0.2 This closes #274 > cordova-common Release April 14, 2017 > - > > Key: CB-12662 > URL: https://issues.apache.org/jira/browse/CB-12662 > Project: Apache Cordova > Issue Type: Task >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > **NOTE:** > {quote} > Update the cordova-common package.json dependencies in cordova-lib and > cordova-fetch after this cordova-common release has been published to npm > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12662) cordova-common Release April 14, 2017
[ https://issues.apache.org/jira/browse/CB-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971790#comment-15971790 ] ASF GitHub Bot commented on CB-12662: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/274 > cordova-common Release April 14, 2017 > - > > Key: CB-12662 > URL: https://issues.apache.org/jira/browse/CB-12662 > Project: Apache Cordova > Issue Type: Task >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > **NOTE:** > {quote} > Update the cordova-common package.json dependencies in cordova-lib and > cordova-fetch after this cordova-common release has been published to npm > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12662) cordova-common Release April 14, 2017
[ https://issues.apache.org/jira/browse/CB-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-12662. --- Resolution: Done > cordova-common Release April 14, 2017 > - > > Key: CB-12662 > URL: https://issues.apache.org/jira/browse/CB-12662 > Project: Apache Cordova > Issue Type: Task >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > **NOTE:** > {quote} > Update the cordova-common package.json dependencies in cordova-lib and > cordova-fetch after this cordova-common release has been published to npm > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8980) Adding resource-file Element to config.xml for iOS
[ https://issues.apache.org/jira/browse/CB-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971616#comment-15971616 ] ASF GitHub Bot commented on CB-8980: GitHub user shazron reopened a pull request: https://github.com/apache/cordova-ios/pull/305 CB-8980 - Support tag in config.xml in iOS platform ### Platforms affected self ### What does this PR do? Support `` tag in config.xml in iOS platform ### What testing has been done on this change? **NONE**. Work In Progress. Will update as I go along. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-8980-b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/305.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #305 commit 9a52b2fbede0f54c0e2209b2d2508108536a5f25 Author: Shazron AbdullahDate: 2017-04-14T00:31:02Z CB-8980 - Adding resource-file element to config.xml for iOS commit 53f9ac809830296e9b98562900e404ca44096bd8 Author: Shazron Abdullah Date: 2017-04-17T18:51:32Z CB-8980 - Update bundled cordova-common to version 2.0.2 > Adding resource-file Element to config.xml for iOS > -- > > Key: CB-8980 > URL: https://issues.apache.org/jira/browse/CB-8980 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI, CordovaLib >Affects Versions: Master > Environment: iOS >Reporter: Karen Tran >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Based on the parent task, create a new resource-file element tag to copy > resource files from src to the correct directory with the given name. > Example: > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8980) Adding resource-file Element to config.xml for iOS
[ https://issues.apache.org/jira/browse/CB-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971615#comment-15971615 ] ASF GitHub Bot commented on CB-8980: Github user shazron closed the pull request at: https://github.com/apache/cordova-ios/pull/305 > Adding resource-file Element to config.xml for iOS > -- > > Key: CB-8980 > URL: https://issues.apache.org/jira/browse/CB-8980 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI, CordovaLib >Affects Versions: Master > Environment: iOS >Reporter: Karen Tran >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Based on the parent task, create a new resource-file element tag to copy > resource files from src to the correct directory with the given name. > Example: > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12665) engineStrict no longer supported
[ https://issues.apache.org/jira/browse/CB-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-12665: --- Description: Remove engineStrict from package.json. It is no longer supported. Error --> WARN engineStrict Per-package engineStrict (found in this package's package.json) npm WARN engineStrict won't be used in npm 3+. Use the config setting engine-strict instead. was: Remove engineStrict from package.json. It is no longer supported. ```WARN engineStrict Per-package engineStrict (found in this package's package.json)``` ```npm WARN engineStrict won't be used in npm 3+. Use the config setting engine-strict instead.``` > engineStrict no longer supported > > > Key: CB-12665 > URL: https://issues.apache.org/jira/browse/CB-12665 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib, iOS >Affects Versions: cordova-7 >Reporter: Audrey So >Priority: Minor > Fix For: cordova-7 > > > Remove engineStrict from package.json. It is no longer supported. > Error --> > WARN engineStrict Per-package engineStrict (found in this package's > package.json) > npm WARN engineStrict won't be used in npm 3+. Use the config setting > engine-strict instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12665) engineStrict no longer supported
[ https://issues.apache.org/jira/browse/CB-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-12665: --- Description: Remove engineStrict from package.json. It is no longer supported. ```WARN engineStrict Per-package engineStrict (found in this package's package.json)``` ```npm WARN engineStrict won't be used in npm 3+. Use the config setting engine-strict instead.``` was: Remove engineStrict from package.json. It is no longer supported. ```*WARN engineStrict Per-package engineStrict (found in this package's package.json)` *npm WARN engineStrict won't be used in npm 3+. Use the config setting engine-strict instead.``` > engineStrict no longer supported > > > Key: CB-12665 > URL: https://issues.apache.org/jira/browse/CB-12665 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib, iOS >Affects Versions: cordova-7 >Reporter: Audrey So >Priority: Minor > Fix For: cordova-7 > > > Remove engineStrict from package.json. It is no longer supported. > ```WARN engineStrict Per-package engineStrict (found in this package's > package.json)``` > ```npm WARN engineStrict won't be used in npm 3+. Use the config setting > engine-strict instead.``` -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12653) Adding jasmine tests in coho for util files
[ https://issues.apache.org/jira/browse/CB-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-12653: --- Summary: Adding jasmine tests in coho for util files (was: Adding jasmine tests in coho to test version number) > Adding jasmine tests in coho for util files > --- > > Key: CB-12653 > URL: https://issues.apache.org/jira/browse/CB-12653 > Project: Apache Cordova > Issue Type: Test > Components: Coho >Affects Versions: cordova@7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: coho, cordova@7 > Fix For: cordova@7 > > > Adding jasmine tests in coho to test android version number during > prepare-release-branch command. (CB-12498) > Also test ios and windows versions -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12665) engineStrict no longer supported
[ https://issues.apache.org/jira/browse/CB-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-12665: --- Component/s: iOS cordova-cli > engineStrict no longer supported > > > Key: CB-12665 > URL: https://issues.apache.org/jira/browse/CB-12665 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, iOS >Affects Versions: cordova-7 >Reporter: Audrey So >Priority: Minor > Fix For: cordova-7 > > > Remove engineStrict from package.json. It is no longer supported. > ```*WARN engineStrict Per-package engineStrict (found in this package's > package.json)` > *npm WARN engineStrict won't be used in npm 3+. Use the config setting > engine-strict instead.``` -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12665) engineStrict no longer supported
Audrey So created CB-12665: -- Summary: engineStrict no longer supported Key: CB-12665 URL: https://issues.apache.org/jira/browse/CB-12665 Project: Apache Cordova Issue Type: Bug Affects Versions: cordova-7 Reporter: Audrey So Priority: Minor Fix For: cordova-7 Remove engineStrict from package.json. It is no longer supported. ```*WARN engineStrict Per-package engineStrict (found in this package's package.json)` *npm WARN engineStrict won't be used in npm 3+. Use the config setting engine-strict instead.``` -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12665) engineStrict no longer supported
[ https://issues.apache.org/jira/browse/CB-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971783#comment-15971783 ] ASF GitHub Bot commented on CB-12665: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/275 CB-12665 : removed engineStrict as it is no longer supported ### Platforms affected ### What does this PR do? Removed engineStrict as it is no longer supported. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-cli CB-12665 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/275.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #275 commit fc62925212754993c3e76984b9d0620afaa7a149 Author: Audrey SoDate: 2017-04-17T22:58:36Z CB-12665 : removed engineStrict as it is no longer supported > engineStrict no longer supported > > > Key: CB-12665 > URL: https://issues.apache.org/jira/browse/CB-12665 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib, iOS >Affects Versions: cordova-7 >Reporter: Audrey So >Priority: Minor > Fix For: cordova-7 > > > Remove engineStrict from package.json. It is no longer supported. > Error --> > WARN engineStrict Per-package engineStrict (found in this package's > package.json) > npm WARN engineStrict won't be used in npm 3+. Use the config setting > engine-strict instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12665) engineStrict no longer supported
[ https://issues.apache.org/jira/browse/CB-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971823#comment-15971823 ] ASF GitHub Bot commented on CB-12665: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/544 CB-12665 : removed engineStrict as it is no longer supported ### Platforms affected ### What does this PR do? Removed engineStrict as it is no longer supported. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12665 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/544.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #544 commit 9899fa1df5de5ceee1f4c1e031d31e050c69250c Author: Audrey SoDate: 2017-04-17T22:54:11Z CB-12665 : removed engineStrict as it is no longer supported > engineStrict no longer supported > > > Key: CB-12665 > URL: https://issues.apache.org/jira/browse/CB-12665 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib, iOS >Affects Versions: cordova-7 >Reporter: Audrey So >Priority: Minor > Fix For: cordova-7 > > > Remove engineStrict from package.json. It is no longer supported. > Error --> > WARN engineStrict Per-package engineStrict (found in this package's > package.json) > npm WARN engineStrict won't be used in npm 3+. Use the config setting > engine-strict instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8980) Adding resource-file Element to config.xml for iOS
[ https://issues.apache.org/jira/browse/CB-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971613#comment-15971613 ] ASF GitHub Bot commented on CB-8980: Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/305 Bah, objc-tests but seems like it just died when running the Simulator tests, probably a timeout -- flaky. Locally the objc-tests are passing. Running it again by closing and opening the PR. > Adding resource-file Element to config.xml for iOS > -- > > Key: CB-8980 > URL: https://issues.apache.org/jira/browse/CB-8980 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI, CordovaLib >Affects Versions: Master > Environment: iOS >Reporter: Karen Tran >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.0 > > > Based on the parent task, create a new resource-file element tag to copy > resource files from src to the correct directory with the given name. > Example: > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12653) Adding jasmine tests in coho for util files
[ https://issues.apache.org/jira/browse/CB-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-12653: --- Description: Adding jasmine tests in coho to test util files (was: Adding jasmine tests in coho to test android version number during prepare-release-branch command. (CB-12498) Also test ios and windows versions) > Adding jasmine tests in coho for util files > --- > > Key: CB-12653 > URL: https://issues.apache.org/jira/browse/CB-12653 > Project: Apache Cordova > Issue Type: Test > Components: Coho >Affects Versions: cordova@7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: coho, cordova@7 > Fix For: cordova@7 > > > Adding jasmine tests in coho to test util files -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12665) engineStrict no longer supported
[ https://issues.apache.org/jira/browse/CB-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971782#comment-15971782 ] ASF GitHub Bot commented on CB-12665: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-ios/pull/306 CB-12665 : removing engineStrict as it is no longer supported ### Platforms affected ### What does this PR do? Removing engineStrict as it is no longer supported. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-ios CB-12665 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/306.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #306 commit 11d7d4ed67fee982baf0f7e5de8c39613f9db4df Author: Audrey SoDate: 2017-04-17T22:41:19Z CB-12665 : removing engineStrict as it is no longer supported > engineStrict no longer supported > > > Key: CB-12665 > URL: https://issues.apache.org/jira/browse/CB-12665 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib, iOS >Affects Versions: cordova-7 >Reporter: Audrey So >Priority: Minor > Fix For: cordova-7 > > > Remove engineStrict from package.json. It is no longer supported. > Error --> > WARN engineStrict Per-package engineStrict (found in this package's > package.json) > npm WARN engineStrict won't be used in npm 3+. Use the config setting > engine-strict instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12665) engineStrict no longer supported
[ https://issues.apache.org/jira/browse/CB-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971850#comment-15971850 ] ASF GitHub Bot commented on CB-12665: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/544 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr=h1) Report > Merging [#544](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/d2b636a98e4d1a8c8f7199897b7ac09b659f?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/544/graphs/tree.svg?height=150=650=KwBjKMXLqA=pr)](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #544 +/- ## === Coverage 82.42% 82.42% === Files 68 68 Lines5462 5462 Branches 1072 1072 === Hits 4502 4502 Misses960 960 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr=footer). Last update [d2b636a...9899fa1](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > engineStrict no longer supported > > > Key: CB-12665 > URL: https://issues.apache.org/jira/browse/CB-12665 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib, iOS >Affects Versions: cordova-7 >Reporter: Audrey So >Priority: Minor > Fix For: cordova-7 > > > Remove engineStrict from package.json. It is no longer supported. > Error --> > WARN engineStrict Per-package engineStrict (found in this package's > package.json) > npm WARN engineStrict won't be used in npm 3+. Use the config setting > engine-strict instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org