[jira] [Commented] (CB-14112) cordova-common release May 2018
[ https://issues.apache.org/jira/browse/CB-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498905#comment-16498905 ] ASF subversion and git services commented on CB-14112: -- Commit 6530ce7fd48777e91332754019f516ebc232da1d in cordova-common's branch refs/heads/2.2.x from [~dpogue] [ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=6530ce7 ] CB-14112: Updated version and RELEASENOTES.md for release 2.2.3 > cordova-common release May 2018 > --- > > Key: CB-14112 > URL: https://issues.apache.org/jira/browse/CB-14112 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Minor > > Following steps at > [https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14112) cordova-common release May 2018
[ https://issues.apache.org/jira/browse/CB-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498912#comment-16498912 ] ASF GitHub Bot commented on CB-14112: - dpogue opened a new pull request #828: CB-14112: Add cordova-common@2.2.3 blog post URL: https://github.com/apache/cordova-docs/pull/828 Blog post announcing the new release and also the impending drop of Node 4 support This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-common release May 2018 > --- > > Key: CB-14112 > URL: https://issues.apache.org/jira/browse/CB-14112 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Minor > > Following steps at > [https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13379) Cordova build don't recognize jdk9 > jdk 1.8
[ https://issues.apache.org/jira/browse/CB-13379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl Pogue resolved CB-13379. --- Resolution: Won't Fix Assignee: Darryl Pogue As pointed out in the linked issue, the Android tools don't support Java 9 yet and will not run with JDK 9. > Cordova build don't recognize jdk9 > jdk 1.8 > > > Key: CB-13379 > URL: https://issues.apache.org/jira/browse/CB-13379 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-create >Affects Versions: 7.0.1 > Environment: jdk 9 > mac os Sierra 10.12.6 >Reporter: Naihe Feng >Assignee: Darryl Pogue >Priority: Major > > When using codorva build, the following error come out > Requirements check failed for JDK 1.8 or greater > However I have installed the jdk9 > !https://drive.google.com/open?id=0BzrtRLoB2MfSWjdwbmdFTVEyaDg! > check the link below for detail comment if the picture did not show up: > https://drive.google.com/open?id=0BzrtRLoB2MfSWjdwbmdFTVEyaDg > the following post on stack overflow also mentioned it > https://stackoverflow.com/questions/46379406/cordova-error-requirements-check-failed-for-jdk-1-8-or-greater-am-using-java -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499229#comment-16499229
]
Raphael commented on CB-14101:
--
* Yes, only Java 8 is supported right now
* Yes, that should be clearer in the docs
* Yes, the version check is buggy and the error message misleading
I have a proof of concept fix for the version check in my local repo. It still
needs a bit of work but I will try to get a PR for that ready.
Thanks for the detailed bug report.
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Assignee: Raphael
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-6070) Alignment with W3C DeviceOrientation event
[ https://issues.apache.org/jira/browse/CB-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl Pogue resolved CB-6070. -- Resolution: Fixed The Device Orientation plugin has now been deprecated in favour of the DeviceOrientation API available natively in browsers/webviews. > Alignment with W3C DeviceOrientation event > -- > > Key: CB-6070 > URL: https://issues.apache.org/jira/browse/CB-6070 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-device-orientation (DEPRECATED) >Reporter: Dominique Hazael-Massieux >Priority: Major > > The W3C DeviceOrientation event is used by most browsers nowadays to detect > change in orientation: http://dev.w3.org/geo/api/spec-source-orientation.html > As such, it is already pretty stable (although there are some minor fixes and > clarifications expected in the upcoming few months). > It would be nice if the cordova accelerometer plugin would align with it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raphael reassigned CB-14101:
Assignee: Raphael
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Assignee: Raphael
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11985) Cordova hits internet unnecessarily when getting cached platform or plugin
[
https://issues.apache.org/jira/browse/CB-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darryl Pogue resolved CB-11985.
---
Resolution: Fixed
> Cordova hits internet unnecessarily when getting cached platform or plugin
> --
>
> Key: CB-11985
> URL: https://issues.apache.org/jira/browse/CB-11985
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Affects Versions: 6.3.1
>Reporter: Tim Barham
>Assignee: Tim Barham
>Priority: Major
>
> In you are disconnected from the internet and try to add a platform or plugin
> that has previously been cached, Cordova eventually successfully installs the
> platform/plugin, but only after a very long wait.
> We could check for the existence of the cached platform/plugin before calling
> {{npm cache add}}. This would mean an instant return when not connected to
> the internet.
> Note that this will only help if we are adding a specific version - when a
> version range is specified, we need to hit the internet anyway to find the
> matching version.
> Background: First time build failures in Cordova tools in Visual Studio are
> primarily due to {{npm}} failures. Therefore we are working to avoid any
> requirement for {{npm}}} to hit the internet in simple build scenarios. This
> includes pre-installing cached versions of certain platforms and plugins. But
> we only get the full benefit if Cordova uses these cached versions if it
> finds them, without calling {{npm cache add}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raphael updated CB-14101:
-
Component/s: cordova-android
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Assignee: Raphael
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11777) Plugins superseding config.xml
[
https://issues.apache.org/jira/browse/CB-11777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darryl Pogue resolved CB-11777.
---
Resolution: Fixed
> Plugins superseding config.xml
> --
>
> Key: CB-11777
> URL: https://issues.apache.org/jira/browse/CB-11777
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: 6.3.1
>Reporter: Darryl Pogue
>Assignee: Darryl Pogue
>Priority: Major
> Labels: triaged
>
> The ongoing saga of CB-11589 and CB-11698...
> When running {{cordova prepare}} to restore platforms and plugins, the
> platform has prepare called before the plugins are restored. This leads to
> the top-level config.xml data being copied into the platform at prepare time,
> and then plugin config being appended when they are later restored.
> In my case, this was causing the Crosswalk version defined in my top-level
> config.xml to be overwritten by an undefined version when the plugin was
> installed. A workaround is to run {{cordova prepare}} a second time.
> A better fix is probably to restore the platforms, restore the plugins, and
> then run prepare after everything has been restored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11623) --link-to no longer seems to be working
[ https://issues.apache.org/jira/browse/CB-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl Pogue updated CB-11623: -- Component/s: (was: cordova-lib) (was: cordova-cli) cordova-create > --link-to no longer seems to be working > --- > > Key: CB-11623 > URL: https://issues.apache.org/jira/browse/CB-11623 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-create >Affects Versions: 6.3.0 > Environment: Windows 10, Windows Command Prompt >Reporter: Graham Harper >Assignee: Steve Gill >Priority: Major > Labels: triaged > > We have a build script for installing and building Cordova from source > control that begins with the line: > cordova create bin com.example.domain APPNAME --link-to=www > Where www is our existing app code (html, css, js etc.) > We've been running this build script on new deployments just fine for 6 > months or so, and its behaviour until this version has been to create a > simlink in the newly-created 'bin' folder to our existing app in 'www'; > however, as of 6.3.0 this is no longer working. The command creates the bin > folder, but it only contains the default 'Hello Cordova' application. > --copy-from still seems to be working (although is marked as deprecated), so > we can work around this issue, but it's not appropriate for our deployment > and development process. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12944) Platform's spec is ignored in config.xml if package.json doesn't contain dependency for platform
[
https://issues.apache.org/jira/browse/CB-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darryl Pogue resolved CB-12944.
---
Resolution: Fixed
> Platform's spec is ignored in config.xml if package.json doesn't contain
> dependency for platform
>
>
> Key: CB-12944
> URL: https://issues.apache.org/jira/browse/CB-12944
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Nikita Matrosov
>Assignee: Nikita Matrosov
>Priority: Major
>
> Steps to reproduce with cordova@7.0.2-dev:
> 1) Create app with package.json contains empty dependencies object:
> "dependencies": {}
> (e.g. it's default for Visual Studio Cordova template)
> 2) Add entry into config.xml: spec="https://github.com/apache/cordova-windows.git#4.4.x; />
> 3) cordova platform add windows
> So, if package.json dependencies keys don't include windows or
> cordova-windows, we should look for a spec in config.xml.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12916) GradleBuilder.js has hardcoded memory parameter
[ https://issues.apache.org/jira/browse/CB-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl Pogue updated CB-12916: -- Component/s: (was: cordova-lib) > GradleBuilder.js has hardcoded memory parameter > --- > > Key: CB-12916 > URL: https://issues.apache.org/jira/browse/CB-12916 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Reporter: Jan Piotrowski (Sujan) >Priority: Major > Labels: memory > > Ionic users reported having problem with the Android build process when they > have bg projects with the error message "> Java heap space" for a long > time. Recent example: > https://forum.ionicframework.com/t/packagedebug-error-java-heap-space-with-large-sqlite-db/82997 > Fortunately now one user decided to jump in deep enough to figure out the > problem: > https://forum.ionicframework.com/t/packagedebug-error-java-heap-space-with-large-sqlite-db/82997/6 > Seems like GradeBuilder.js hardcodes a memory parameter so that it is > impossible to change the supplied memory any other way. > I think I found the code in `cordova-lib`: > https://github.com/apache/cordova-lib/blob/cef2959c8843074e94448f4bfc7812d0e4748131/spec-plugman/projects/android/cordova/lib/builders/GradleBuilder.js#L59 > It would be great if users could somehow change that value to be bigger that > didn't include having to edit this file (re-adding the platform will lose > these changes for example). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13735) error install Cordova npm ERR! No valid versions available for pinkie-promise
[ https://issues.apache.org/jira/browse/CB-13735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raphael resolved CB-13735. -- Resolution: Cannot Reproduce > error install Cordova npm ERR! No valid versions available for pinkie-promise > - > > Key: CB-13735 > URL: https://issues.apache.org/jira/browse/CB-13735 > Project: Apache Cordova > Issue Type: Bug >Reporter: jose vargas >Priority: Major > > 916 http fetch GET 304 https://registry.npmjs.org/pinkie-promise 116ms (from > cache) > 917 silly fetchPackageMetaData error for pinkie-promise@^2.0.0 No valid > versions available for pinkie-promise -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499251#comment-16499251
]
ASF GitHub Bot commented on CB-14101:
-
raphinesse opened a new pull request #446: CB-14101 Fix Java version check for
Java >= 9
URL: https://github.com/apache/cordova-android/pull/446
### Platforms affected
Android
### What does this PR do?
- Fix Java version check for Java >= 9
- Checks that we have exactly Java 1.8 since nothing else works with the
Android SDK
- Tell the user that we need exactly Java 1.8 if we can't find it
### What testing has been done on this change?
The relevant function was not covered by unit tests to begin with, so I only
tested this manually with the following code:
```js
Promise.resolve(
require('./bin/templates/cordova/lib/check_reqs').check_java()
).then(console.log)
```
Output for Java 8 is `true`, for Java 10 is `false`.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
~~Added automated test coverage as appropriate for this change~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Assignee: Raphael
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499252#comment-16499252
]
ASF GitHub Bot commented on CB-14101:
-
raphinesse commented on issue #446: CB-14101 Fix Java version check for Java >=
9
URL: https://github.com/apache/cordova-android/pull/446#issuecomment-394128195
I actually wanted to use semver for this, but with the dependency bundling
it was too much of a hassle.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Assignee: Raphael
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499261#comment-16499261
]
ASF GitHub Bot commented on CB-14101:
-
codecov-io commented on issue #446: CB-14101 Fix Java version check for Java >=
9
URL: https://github.com/apache/cordova-android/pull/446#issuecomment-394129217
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=h1)
Report
> Merging
[#446](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/02ee92510376b23476039e29e1ec5ffaf2102b83?src=pr=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=tree)
```diff
@@Coverage Diff @@
## master #446 +/- ##
==
+ Coverage 44.16% 44.21% +0.04%
==
Files 17 17
Lines1698 1694 -4
Branches 314 312 -2
==
- Hits 750 749 -1
+ Misses948 945 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/446/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz)
| `48.57% <0%> (+0.44%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=footer).
Last update
[02ee925...3b1bcc9](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Assignee: Raphael
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499260#comment-16499260
]
ASF GitHub Bot commented on CB-14101:
-
raphinesse commented on issue #446: CB-14101 Fix Java version check for Java >=
9
URL: https://github.com/apache/cordova-android/pull/446#issuecomment-394129166
Added node 4 compatibility so we can release this in a patch release
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Assignee: Raphael
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499268#comment-16499268
]
ASF GitHub Bot commented on CB-14101:
-
codecov-io commented on issue #446: CB-14101 Fix Java version check for Java >=
9
URL: https://github.com/apache/cordova-android/pull/446#issuecomment-394129217
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=h1)
Report
> Merging
[#446](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/02ee92510376b23476039e29e1ec5ffaf2102b83?src=pr=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=tree)
```diff
@@Coverage Diff @@
## master #446 +/- ##
==
+ Coverage 44.16% 44.21% +0.04%
==
Files 17 17
Lines1698 1694 -4
Branches 314 312 -2
==
- Hits 750 749 -1
+ Misses948 945 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/446/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz)
| `48.57% <0%> (+0.44%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=footer).
Last update
[02ee925...35ea1a4](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Assignee: Raphael
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14101) check_reqs.js does not recognize java version
[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499271#comment-16499271
]
ASF GitHub Bot commented on CB-14101:
-
codecov-io commented on issue #446: CB-14101 Fix Java version check for Java >=
9
URL: https://github.com/apache/cordova-android/pull/446#issuecomment-394129217
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=h1)
Report
> Merging
[#446](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/02ee92510376b23476039e29e1ec5ffaf2102b83?src=pr=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=tree)
```diff
@@Coverage Diff @@
## master #446 +/- ##
==
+ Coverage 44.16% 44.21% +0.04%
==
Files 17 17
Lines1698 1694 -4
Branches 314 312 -2
==
- Hits 750 749 -1
+ Misses948 945 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/446/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz)
| `48.57% <0%> (+0.44%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=footer).
Last update
[02ee925...35ea1a4](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> check_reqs.js does not recognize java version
> -
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
>Reporter: Arne Simon
>Assignee: Raphael
>Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
