[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[
https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614909#comment-16614909
]
ASF GitHub Bot commented on CB-14192:
-
mlegenhausen edited a comment on issue #378: CB-14192: (ios) Add project
settings to explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421369394
The Xcode 10 GM is avaibable.
The provided pull request does not work with the GM release, but I found
another solution. You can disable the modern buildsystem with `xcodebuild
-UseModernBuildSystem=NO ...`.
After you added the switch get another error that "your project path" is not
a valid command. It seems that in the case of `archive` it is not possible
anymore to supply the project folder as last parameter. So I needed to make
`-workspace` and `-archivePath` an absolute path. The `options` for the
`isDevice` case need to be changed to
```js
options = [
'-UseModernBuildSystem=NO',
'-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-'
+ configuration.toLowerCase() + '.xcconfig'),
'-workspace', customArgs.workspace || path.join(projectPath, projectName
+ '.xcworkspace'),
'-scheme', customArgs.scheme || projectName,
'-configuration', customArgs.configuration || configuration,
'-destination', customArgs.destination || 'generic/platform=iOS',
'-archivePath', customArgs.archivePath || path.join(projectPath,
projectName + '.xcarchive')
];
```
Finally I removed the `projectPath` parameter from `spawn('xcodebuild',
xcodebuildArgs)`.The build should now work as expected.
Are you planing to which with `cordova-ios` to the new build systems? If not
I can provide my fix as pull request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova iOS doesn't build with Xcode 10
> ---
>
> Key: CB-14192
> URL: https://issues.apache.org/jira/browse/CB-14192
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Reporter: Sebastian Grail
>Priority: Minor
>
> Xcode 10 uses the new build system by default. Any project not explicitly
> choosing the legacy build system will build with new system. Currently,
> Cordova iOS fails to build with the new system. The simplest solution is to
> explicitly use the legacy build system.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[ https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614893#comment-16614893 ] ASF GitHub Bot commented on CB-14192: - mlegenhausen commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s… URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421369394 The Xcode 10 GM is avaibable. The provided pull request does not work with the GM release, but I found another solution. You can disable the modern buildsystem with `xcodebuild -UseModernBuildSystem=NO ...`. After you added the switch get another error that "your project path" is not a valid command. It seems that in the case of `archive` it is not possible anymore to supply the project folder as last parameter. So I needed to make `-workspace` and `-archivePath` an absolute path. The `options` for the `isDevice` case need to be changed to ```js options = [ '-UseModernBuildSystem=NO', '-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), '-workspace', customArgs.workspace || path.join(projectPath, projectName + '.xcworkspace'), '-scheme', customArgs.scheme || projectName, '-configuration', customArgs.configuration || configuration, '-destination', customArgs.destination || 'generic/platform=iOS', '-archivePath', customArgs.archivePath || path.join(projectPath, projectName + '.xcarchive') ]; ``` Are you planing to which with `cordova-ios` to the new build systems? If not I can provide my fix as pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova iOS doesn't build with Xcode 10 > --- > > Key: CB-14192 > URL: https://issues.apache.org/jira/browse/CB-14192 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Sebastian Grail >Priority: Minor > > Xcode 10 uses the new build system by default. Any project not explicitly > choosing the legacy build system will build with new system. Currently, > Cordova iOS fails to build with the new system. The simplest solution is to > explicitly use the legacy build system. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[
https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614896#comment-16614896
]
ASF GitHub Bot commented on CB-14192:
-
mlegenhausen edited a comment on issue #378: CB-14192: (ios) Add project
settings to explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421369394
The Xcode 10 GM is avaibable.
The provided pull request does not work with the GM release, but I found
another solution. You can disable the modern buildsystem with `xcodebuild
-UseModernBuildSystem=NO ...`.
After you added the switch get another error that "your project path" is not
a valid command. It seems that in the case of `archive` it is not possible
anymore to supply the project folder as last parameter. So I needed to make
`-workspace` and `-archivePath` an absolute path. The `options` for the
`isDevice` case need to be changed to
```js
options = [
'-UseModernBuildSystem=NO',
'-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-'
+ configuration.toLowerCase() + '.xcconfig'),
'-workspace', customArgs.workspace || path.join(projectPath, projectName
+ '.xcworkspace'),
'-scheme', customArgs.scheme || projectName,
'-configuration', customArgs.configuration || configuration,
'-destination', customArgs.destination || 'generic/platform=iOS',
'-archivePath', customArgs.archivePath || path.join(projectPath,
projectName + '.xcarchive')
];
```
Finally you need to remove the `projectPath` parameter from
`spawn('xcodebuild', xcodebuildArgs)`.
Are you planing to which with `cordova-ios` to the new build systems? If not
I can provide my fix as pull request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova iOS doesn't build with Xcode 10
> ---
>
> Key: CB-14192
> URL: https://issues.apache.org/jira/browse/CB-14192
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Reporter: Sebastian Grail
>Priority: Minor
>
> Xcode 10 uses the new build system by default. Any project not explicitly
> choosing the legacy build system will build with new system. Currently,
> Cordova iOS fails to build with the new system. The simplest solution is to
> explicitly use the legacy build system.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[ https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614933#comment-16614933 ] ASF GitHub Bot commented on CB-14192: - sgoldberg-sfdc commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s… URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421380720 @mlegenhausen unfortunately that won't work with Carthage since you cannot provide parameters to the build command. If the workspace settings no longer work with the GM, we need to fix the root build issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova iOS doesn't build with Xcode 10 > --- > > Key: CB-14192 > URL: https://issues.apache.org/jira/browse/CB-14192 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Sebastian Grail >Priority: Minor > > Xcode 10 uses the new build system by default. Any project not explicitly > choosing the legacy build system will build with new system. Currently, > Cordova iOS fails to build with the new system. The simplest solution is to > explicitly use the legacy build system. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[ https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614954#comment-16614954 ] ASF GitHub Bot commented on CB-14192: - janpio commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s… URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421386927 @mlegenhausen If you have a working solution (even if it's just for you) please do create a PR for others to look at and use please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova iOS doesn't build with Xcode 10 > --- > > Key: CB-14192 > URL: https://issues.apache.org/jira/browse/CB-14192 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Sebastian Grail >Priority: Minor > > Xcode 10 uses the new build system by default. Any project not explicitly > choosing the legacy build system will build with new system. Currently, > Cordova iOS fails to build with the new system. The simplest solution is to > explicitly use the legacy build system. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14260) captureImage: permission denial on android 8.1
[
https://issues.apache.org/jira/browse/CB-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615346#comment-16615346
]
ASF GitHub Bot commented on CB-14260:
-
janpio commented on issue #95: CB-14260: (android) captureImage permission
denial on android 8.1
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421477008
We still need a Cordova maintainer to merge it and cut a release. Commenting
here won't do a thing about that. I requested reviews from 2 people that maybe
could help, but they don't seem to have the time right now. As we are all
volunteers, this is total understandable.
Alternatively you can just install this branch of this PR or fork the plugin
yourself and merge this branch into it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> captureImage: permission denial on android 8.1
> --
>
> Key: CB-14260
> URL: https://issues.apache.org/jira/browse/CB-14260
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
>Affects Versions: 3.0.0
>Reporter: Marco
>Priority: Major
>
> When I call "captureImage" method I accept all permissions but I get:
> {noformat}
> java.lang.SecurityException: Permission Denial: writing
> com.android.providers.media.MediaProvider uri
> content://media/external/images/media from pid=12716, uid=10079 requires
> android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission(){noformat}
> I'm using cordova-plugin-media-capture version 3.0.2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14260) captureImage: permission denial on android 8.1
[
https://issues.apache.org/jira/browse/CB-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615311#comment-16615311
]
ASF GitHub Bot commented on CB-14260:
-
ffMathy commented on issue #95: CB-14260: (android) captureImage permission
denial on android 8.1
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421467092
Works like a charm, tested on brand new Samsung Galaxy S9.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> captureImage: permission denial on android 8.1
> --
>
> Key: CB-14260
> URL: https://issues.apache.org/jira/browse/CB-14260
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
>Affects Versions: 3.0.0
>Reporter: Marco
>Priority: Major
>
> When I call "captureImage" method I accept all permissions but I get:
> {noformat}
> java.lang.SecurityException: Permission Denial: writing
> com.android.providers.media.MediaProvider uri
> content://media/external/images/media from pid=12716, uid=10079 requires
> android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission(){noformat}
> I'm using cordova-plugin-media-capture version 3.0.2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14260) captureImage: permission denial on android 8.1
[
https://issues.apache.org/jira/browse/CB-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615308#comment-16615308
]
ASF GitHub Bot commented on CB-14260:
-
janpio commented on issue #95: CB-14260: (android) captureImage permission
denial on android 8.1
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421466627
I won't as I don't know enough about possible side effects. If you tested
the PR and can confirm that it works, please also approve the PR. Each "vote"
helps a future maintainer to decide if to merge or not.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> captureImage: permission denial on android 8.1
> --
>
> Key: CB-14260
> URL: https://issues.apache.org/jira/browse/CB-14260
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
>Affects Versions: 3.0.0
>Reporter: Marco
>Priority: Major
>
> When I call "captureImage" method I accept all permissions but I get:
> {noformat}
> java.lang.SecurityException: Permission Denial: writing
> com.android.providers.media.MediaProvider uri
> content://media/external/images/media from pid=12716, uid=10079 requires
> android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission(){noformat}
> I'm using cordova-plugin-media-capture version 3.0.2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14260) captureImage: permission denial on android 8.1
[
https://issues.apache.org/jira/browse/CB-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615285#comment-16615285
]
ASF GitHub Bot commented on CB-14260:
-
ffMathy commented on issue #95: CB-14260: (android) captureImage permission
denial on android 8.1
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421461192
Can we merge this? It fixes a critical issue, and it has been quite a few
days since it was approved.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> captureImage: permission denial on android 8.1
> --
>
> Key: CB-14260
> URL: https://issues.apache.org/jira/browse/CB-14260
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
>Affects Versions: 3.0.0
>Reporter: Marco
>Priority: Major
>
> When I call "captureImage" method I accept all permissions but I get:
> {noformat}
> java.lang.SecurityException: Permission Denial: writing
> com.android.providers.media.MediaProvider uri
> content://media/external/images/media from pid=12716, uid=10079 requires
> android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission(){noformat}
> I'm using cordova-plugin-media-capture version 3.0.2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14260) captureImage: permission denial on android 8.1
[
https://issues.apache.org/jira/browse/CB-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615334#comment-16615334
]
ASF GitHub Bot commented on CB-14260:
-
ffMathy commented on issue #95: CB-14260: (android) captureImage permission
denial on android 8.1
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421474355
@janpio so both @mnill and I tested, and this is insanely critical - the
plugin is not working at all for specific target SDKs. Furthermore, per
default, it is not working in Ionic because of this.
How many tests and approvals will it need before we merge it? I can get a
few friends to help as well maybe.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> captureImage: permission denial on android 8.1
> --
>
> Key: CB-14260
> URL: https://issues.apache.org/jira/browse/CB-14260
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
>Affects Versions: 3.0.0
>Reporter: Marco
>Priority: Major
>
> When I call "captureImage" method I accept all permissions but I get:
> {noformat}
> java.lang.SecurityException: Permission Denial: writing
> com.android.providers.media.MediaProvider uri
> content://media/external/images/media from pid=12716, uid=10079 requires
> android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission(){noformat}
> I'm using cordova-plugin-media-capture version 3.0.2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[ https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615518#comment-16615518 ] ASF GitHub Bot commented on CB-14192: - dpogue commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s… URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421512169 @sgoldberg-sfdc I poked around very briefly this afternoon, but you clearly understand the details of the problem better than I do. After telling Xcode to bring both the app project and the CordovaLib project to the recommended build settings, the new build system seemed to work fine. I see that it did change some stuff around Cordova.framework, but I admit to not totally understanding what that entails. The only changes were to xcodeproj files, no changes to source files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova iOS doesn't build with Xcode 10 > --- > > Key: CB-14192 > URL: https://issues.apache.org/jira/browse/CB-14192 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Sebastian Grail >Priority: Minor > > Xcode 10 uses the new build system by default. Any project not explicitly > choosing the legacy build system will build with new system. Currently, > Cordova iOS fails to build with the new system. The simplest solution is to > explicitly use the legacy build system. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[ https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615511#comment-16615511 ] ASF GitHub Bot commented on CB-14192: - sgoldberg-sfdc commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s… URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421510810 @shazron and @dpogue , Here is the issue with the New Build System. The framework target is a wrapper on the static library. The static library has a copy headers build phase that is before the compilation build phase. If you move the copy headers phase to after the compilation phase, the new build system will successfully build the framework target one time (with a clean derived data folder). Unfortunately, subsequent builds will fail because the new build system is getting confused by the header files being in two places in the search path (project folder and CONFIGURATION_BUILD_DIR folder). There are several hacky solutions, but my recommendation is make the framework target a first class citizen, sharing the source files and compiling them as part of the target, rather than depending on the static library target. I can submit a PR on Monday. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova iOS doesn't build with Xcode 10 > --- > > Key: CB-14192 > URL: https://issues.apache.org/jira/browse/CB-14192 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Sebastian Grail >Priority: Minor > > Xcode 10 uses the new build system by default. Any project not explicitly > choosing the legacy build system will build with new system. Currently, > Cordova iOS fails to build with the new system. The simplest solution is to > explicitly use the legacy build system. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[ https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615548#comment-16615548 ] ASF GitHub Bot commented on CB-14192: - sgoldberg-sfdc opened a new pull request #408: CB-14192: (ios) - Xcode 10 Framework Target Fix - Convert Framework to build source rather than wrap static lib URL: https://github.com/apache/cordova-ios/pull/408 - The new build system in Xcode 10 gets confused by the static library header files copied to $CONFIGURATION_BUILD_DIR/include - By making the framework target build the source directly we eliminate this issue - If both targets are built, the issue will still occur ### Platforms affected iOS ### What does this PR do? Modifies the framework target to compile the source directly, rather than wrap the static library target. This avoids the issue where the static library header files are copied to the $CONFIGURATION_BUILD_DIR confusing the new build system (defaulted on in Xcode 10) resulting in duplicate definition errors. ### What testing has been done on this change? Manually verified builds of both targets within xcode and via Carthage. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. (None required) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova iOS doesn't build with Xcode 10 > --- > > Key: CB-14192 > URL: https://issues.apache.org/jira/browse/CB-14192 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Sebastian Grail >Priority: Minor > > Xcode 10 uses the new build system by default. Any project not explicitly > choosing the legacy build system will build with new system. Currently, > Cordova iOS fails to build with the new system. The simplest solution is to > explicitly use the legacy build system. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[
https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1661#comment-1661
]
ASF GitHub Bot commented on CB-14192:
-
sgoldberg-sfdc closed pull request #408: CB-14192: (ios) - Xcode 10 Framework
Target Fix - Convert Framework to build source rather than wrap static lib
URL: https://github.com/apache/cordova-ios/pull/408
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
b/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
index 4df32ce56..cd4ba2383 100644
--- a/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
+++ b/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
@@ -64,7 +64,6 @@
A3B082D41BB15CEA00D8DC35 /* CDVGestureHandler.h in Headers */ =
{isa = PBXBuildFile; fileRef = A3B082D21BB15CEA00D8DC35 /* CDVGestureHandler.h
*/; };
A3B082D51BB15CEA00D8DC35 /* CDVGestureHandler.m in Sources */ =
{isa = PBXBuildFile; fileRef = A3B082D31BB15CEA00D8DC35 /* CDVGestureHandler.m
*/; };
C0C01EB61E3911D50056E6CB /* Cordova.h in Headers */ = {isa =
PBXBuildFile; fileRef = C0C01EB41E3911D50056E6CB /* Cordova.h */; settings =
{ATTRIBUTES = (Public, ); }; };
- C0C01EBA1E39120F0056E6CB /* libCordova.a in Frameworks */ =
{isa = PBXBuildFile; fileRef = 68A32D7114102E1C006B237C /* libCordova.a */; };
C0C01EBB1E39131A0056E6CB /* CDV.h in Headers */ = {isa =
PBXBuildFile; fileRef = 7ED95D0F1AB9029B008C4574 /* CDV.h */; settings =
{ATTRIBUTES = (Public, ); }; };
C0C01EBC1E39131A0056E6CB /* CDVAppDelegate.h in Headers */ =
{isa = PBXBuildFile; fileRef = 7ED95D101AB9029B008C4574 /* CDVAppDelegate.h */;
settings = {ATTRIBUTES = (Public, ); }; };
C0C01EBD1E39131A0056E6CB /* CDVAvailability.h in Headers */ =
{isa = PBXBuildFile; fileRef = 7ED95D121AB9029B008C4574 /* CDVAvailability.h
*/; settings = {ATTRIBUTES = (Public, ); }; };
@@ -86,19 +85,42 @@
C0C01ECD1E39131A0056E6CB /* CDVWhitelist.h in Headers */ = {isa
= PBXBuildFile; fileRef = 7ED95D2D1AB9029B008C4574 /* CDVWhitelist.h */;
settings = {ATTRIBUTES = (Public, ); }; };
C0C01ECE1E39131A0056E6CB /* NSDictionary+CordovaPreferences.h
in Headers */ = {isa = PBXBuildFile; fileRef = 7ED95D311AB9029B008C4574 /*
NSDictionary+CordovaPreferences.h */; settings = {ATTRIBUTES = (Public, ); }; };
C0C01ECF1E39131A0056E6CB /* NSMutableArray+QueueAdditions.h in
Headers */ = {isa = PBXBuildFile; fileRef = 7ED95D331AB9029B008C4574 /*
NSMutableArray+QueueAdditions.h */; settings = {ATTRIBUTES = (Public, ); }; };
- C0C01ED01E3913610056E6CB /* CDVUIWebViewDelegate.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 7ED95CFE1AB9028C008C4574 /*
CDVUIWebViewDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
+ C0D7D0AC214C827F00794B01 /* CDVAppDelegate.m in Sources */ =
{isa = PBXBuildFile; fileRef = 7ED95D111AB9029B008C4574 /* CDVAppDelegate.m */;
};
+ C0D7D0AD214C827F00794B01 /* CDVCommandDelegateImpl.m in Sources
*/ = {isa = PBXBuildFile; fileRef = 7ED95D161AB9029B008C4574 /*
CDVCommandDelegateImpl.m */; };
+ C0D7D0AE214C827F00794B01 /* CDVCommandQueue.m in Sources */ =
{isa = PBXBuildFile; fileRef = 7ED95D181AB9029B008C4574 /* CDVCommandQueue.m
*/; };
+ C0D7D0AF214C827F00794B01 /* CDVConfigParser.m in Sources */ =
{isa = PBXBuildFile; fileRef = 7ED95D1A1AB9029B008C4574 /* CDVConfigParser.m
*/; };
+ C0D7D0B0214C827F00794B01 /* CDVInvokedUrlCommand.m in Sources
*/ = {isa = PBXBuildFile; fileRef = 7ED95D1C1AB9029B008C4574 /*
CDVInvokedUrlCommand.m */; };
+ C0D7D0B1214C827F00794B01 /* CDVPlugin+Resources.m in Sources */
= {isa = PBXBuildFile; fileRef = 7ED95D1E1AB9029B008C4574 /*
CDVPlugin+Resources.m */; };
+ C0D7D0B2214C827F00794B01 /* CDVPlugin.m in Sources */ = {isa =
PBXBuildFile; fileRef = 7ED95D201AB9029B008C4574 /* CDVPlugin.m */; };
+ C0D7D0B3214C827F00794B01 /* CDVPluginResult.m in Sources */ =
{isa = PBXBuildFile; fileRef = 7ED95D221AB9029B008C4574 /* CDVPluginResult.m
*/; };
+ C0D7D0B4214C827F00794B01 /* CDVTimer.m in Sources */ = {isa =
PBXBuildFile; fileRef = 7ED95D251AB9029B008C4574 /* CDVTimer.m */; };
+ C0D7D0B5214C827F00794B01 /* CDVURLProtocol.m in Sources */ =
{isa = PBXBuildFile; fileRef = 7ED95D271AB9029B008C4574 /* CDVURLProtocol.m */;
};
+ C0D7D0B6214C827F00794B01 /* CDVUserAgentUtil.m in Sources */ =
{isa = PBXBuildFile; fileRef = 7ED95D291AB9029B008C4574 /* CDVUserAgentUtil.m
*/; };
+
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[ https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615554#comment-16615554 ] ASF GitHub Bot commented on CB-14192: - sgoldberg-sfdc commented on issue #408: CB-14192: (ios) - Xcode 10 Framework Target Fix - Convert Framework to build source rather than wrap static lib URL: https://github.com/apache/cordova-ios/pull/408#issuecomment-421522469 Closing for now, more at play here than the framework target. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova iOS doesn't build with Xcode 10 > --- > > Key: CB-14192 > URL: https://issues.apache.org/jira/browse/CB-14192 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Sebastian Grail >Priority: Minor > > Xcode 10 uses the new build system by default. Any project not explicitly > choosing the legacy build system will build with new system. Currently, > Cordova iOS fails to build with the new system. The simplest solution is to > explicitly use the legacy build system. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8497) FileEntry.remove() and FileEntry.file() fail if the file has '#' in its name
[
https://issues.apache.org/jira/browse/CB-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614836#comment-16614836
]
ASF GitHub Bot commented on CB-8497:
jasvindersingh-evon commented on issue #149: CB-8497 Fix handling of file paths
with # character
URL:
https://github.com/apache/cordova-plugin-file/pull/149#issuecomment-421357935
What about the file containing % character? it is giving me an Encoding
error.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> FileEntry.remove() and FileEntry.file() fail if the file has '#' in its name
>
>
> Key: CB-8497
> URL: https://issues.apache.org/jira/browse/CB-8497
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
> Environment: iOS 8.1.3 and Android 5.0
>Reporter: Dani Palou
>Assignee: Jason Ginchereau
>Priority: Major
> Labels: Triaged
>
> If I try to delete a file that has the character '#' in its name, the
> 'remove' function always fails, returning FileError.NOT_FOUND_ERR. If the
> file doesn't have the '#' character, the code works fine. This error is
> happening both in Android 5 and iOS 8.1.3.
> The same happens for the 'file' function.
> This is one of the FileEntries that I'm testing with:
> {quote}
> fullPath: "/tmp/test#.txt",
> isDirectory: false,
> isFIle: true,
> name: "test#.txt",
> nativeURL: "file:///storage/emulated/0/tmp/test%23.txt"
> {quote}
> I obtained this FileEntry using a DirectoryReader to read the contents of the
> parent folder.
> I'm testing with PhoneGap CLI 4.2.0, FilePlugin 1.3.3, PhoneGap Android 3.6.4
> and PhoneGap iOS 3.7.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8497) FileEntry.remove() and FileEntry.file() fail if the file has '#' in its name
[
https://issues.apache.org/jira/browse/CB-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614838#comment-16614838
]
ASF GitHub Bot commented on CB-8497:
jasvindersingh-evon edited a comment on issue #149: CB-8497 Fix handling of
file paths with # character
URL:
https://github.com/apache/cordova-plugin-file/pull/149#issuecomment-421357935
What about the file containing % character? it is giving me an Encoding
error on iOS
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> FileEntry.remove() and FileEntry.file() fail if the file has '#' in its name
>
>
> Key: CB-8497
> URL: https://issues.apache.org/jira/browse/CB-8497
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
> Environment: iOS 8.1.3 and Android 5.0
>Reporter: Dani Palou
>Assignee: Jason Ginchereau
>Priority: Major
> Labels: Triaged
>
> If I try to delete a file that has the character '#' in its name, the
> 'remove' function always fails, returning FileError.NOT_FOUND_ERR. If the
> file doesn't have the '#' character, the code works fine. This error is
> happening both in Android 5 and iOS 8.1.3.
> The same happens for the 'file' function.
> This is one of the FileEntries that I'm testing with:
> {quote}
> fullPath: "/tmp/test#.txt",
> isDirectory: false,
> isFIle: true,
> name: "test#.txt",
> nativeURL: "file:///storage/emulated/0/tmp/test%23.txt"
> {quote}
> I obtained this FileEntry using a DirectoryReader to read the contents of the
> parent folder.
> I'm testing with PhoneGap CLI 4.2.0, FilePlugin 1.3.3, PhoneGap Android 3.6.4
> and PhoneGap iOS 3.7.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8497) FileEntry.remove() and FileEntry.file() fail if the file has '#' in its name
[
https://issues.apache.org/jira/browse/CB-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614892#comment-16614892
]
ASF GitHub Bot commented on CB-8497:
brodybits commented on issue #149: CB-8497 Fix handling of file paths with #
character
URL:
https://github.com/apache/cordova-plugin-file/pull/149#issuecomment-421369231
> What about the file containing % character? it is giving me an Encoding
error on iOS
I suggest you file a new issue with this information, along with a simple
but complete reproduction program. Bonus if you add a test case to tests,
bigger bonus if you submit a bug fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> FileEntry.remove() and FileEntry.file() fail if the file has '#' in its name
>
>
> Key: CB-8497
> URL: https://issues.apache.org/jira/browse/CB-8497
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
> Environment: iOS 8.1.3 and Android 5.0
>Reporter: Dani Palou
>Assignee: Jason Ginchereau
>Priority: Major
> Labels: Triaged
>
> If I try to delete a file that has the character '#' in its name, the
> 'remove' function always fails, returning FileError.NOT_FOUND_ERR. If the
> file doesn't have the '#' character, the code works fine. This error is
> happening both in Android 5 and iOS 8.1.3.
> The same happens for the 'file' function.
> This is one of the FileEntries that I'm testing with:
> {quote}
> fullPath: "/tmp/test#.txt",
> isDirectory: false,
> isFIle: true,
> name: "test#.txt",
> nativeURL: "file:///storage/emulated/0/tmp/test%23.txt"
> {quote}
> I obtained this FileEntry using a DirectoryReader to read the contents of the
> parent folder.
> I'm testing with PhoneGap CLI 4.2.0, FilePlugin 1.3.3, PhoneGap Android 3.6.4
> and PhoneGap iOS 3.7.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
