[jira] [Commented] (CB-12834) Opening a link to a file in the inappbrowser on Android crashes the app

2017-07-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086894#comment-16086894
 ] 

ASF GitHub Bot commented on CB-12834:
-

Github user alanhg commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/221
  
Please publish the official version v1.7.2 as soon as possible.
I need to implement download file like pdf or doc .


> Opening a link to a file in the inappbrowser on Android crashes the app
> ---
>
> Key: CB-12834
> URL: https://issues.apache.org/jira/browse/CB-12834
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: Android > 4.4
>Reporter: Mèir Noordermeer
>Priority: Critical
>  Labels: android, cordova, download, inappbrowser
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When opening a link to a a file (a PDF, for example) the inappbrowser 
> crashes, because on Android versions of 4.4 storage permissions are not 
> automatically granted anymore. Thus these should be requested instead of 
> letting the app crash.
> I am creating this issue to follow the guidelines of pull requests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-12996) Android Splashscreen: 9 Patch images not displayed correctly

2017-07-13 Thread Shawn Lan (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-12996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shawn Lan updated CB-12996:
---
Attachment: splash-hdpi.9.png
splash-mdpi.9.png
splash-xhdpi.9.png
splash-xxhdpi.9.png

Please see the attachments. Thanks!

> Android Splashscreen: 9 Patch images not displayed correctly
> 
>
> Key: CB-12996
> URL: https://issues.apache.org/jira/browse/CB-12996
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
>Reporter: Shawn Lan
> Attachments: splash-hdpi.9.png, splash-mdpi.9.png, 
> splash-xhdpi.9.png, splash-xxhdpi.9.png
>
>
> I have something like this for Android:
> {code:java}
> 
> 
> 
> 
> {code}
> Instead of stretching just the stretchable area. the images are just scaled 
> to the entire screen, treated as regular images.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13018) cordova build failed for both android and ios

2017-07-13 Thread oscar peng (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086641#comment-16086641
 ] 

oscar peng commented on CB-13018:
-

[~jcesarmobile] thank you. I install packages without sudo , except this one 
"sudo npm install -g ios-deploy --unsafe-perm=true". How ever , after I rm -rf 
projectfolder, recreate a helloworld project, the same situation. I find a lot 
of EACCES problems on stackoverflow, but seems to be 1~2 years ago. That means 
there is no EACCES error appears recently. I have no idea how to correct it.

> cordova build failed for both android and ios
> -
>
> Key: CB-13018
> URL: https://issues.apache.org/jira/browse/CB-13018
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Affects Versions: cordova-ios@4.4.0, cordova-android@5.2.2, 7.0.1
> Environment: (1)MacOS: 10.12.5
> (2)node: v8.1.4
> (3)cordova: 7.0.1
> (4)*cordova platform ls*
>   android 6.2.3
>   ios 4.4.0
>Reporter: oscar peng
>Assignee: Joe Bowser
>  Labels: starter
>
> Following http://cordova.apache.org/docs/en/latest/guide/cli/index.html, 
> Create your first Cordova app.
> h1. cordova requirements
>  - Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: installed 
> android-26,android-25,android-24,android-N,android-23,Google Inc.:Google 
> APIs:23,android-22,android-21,android-20,android-19,android-18,android-17,android-16,android-15,android-14
> Gradle: installed /Applications/Android Studio 3.0 
> Preview.app/Contents/gradle/gradle-4.1-milestone-1/bin/gradle
>   -  Requirements check results for ios:
> Apple OS X: installed darwin
> Xcode: installed 8.3.3
> ios-deploy: not installed
> ios-deploy was not found. Please download, build and install version 1.9.0 or 
> greater from https://github.com/phonegap/ios-deploy into your path, or do 
> 'npm install -g ios-deploy'
> CocoaPods: installed
> Error: Some of requirements check failed
> h1. sudo npm install -g ios-deploy --unsafe-perm=true
> h1. cordova requirements
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: installed 
> android-26,android-25,android-24,android-N,android-23,Google Inc.:Google 
> APIs:23,android-22,android-21,android-20,android-19,android-18,android-17,android-16,android-15,android-14
> Gradle: installed /Applications/Android Studio 3.0 
> Preview.app/Contents/gradle/gradle-4.1-milestone-1/bin/gradle
> Requirements check results for ios:
> Apple OS X: installed darwin
> Xcode: installed 8.3.3
> ios-deploy: installed 1.9.1
> CocoaPods: installed
> h1. cordova build (or cordova build android)
> ANDROID_HOME=/Users/open/Library/Android/sdk
> JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home
> Error: spawn EACCES
> h1. cordova build ios
> ** BUILD FAILED **
> The following build commands failed:
>   PhaseScriptExecution Copy\ www\ directory 
> /Users/open/Library/Developer/Xcode/DerivedData/HelloWorld-fqxzydxnjuyjjobwofitkplrpyef/Build/Intermediates/HelloWorld.build/Debug-iphonesimulator/HelloWorld.build/Script-304B58A110DAC018002A0835.sh
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args: 
> -xcconfig,/Users/open/NodeProjects/cordova-projects/hello/platforms/ios/cordova/build-debug.xcconfig,-workspace,HelloWorld.xcworkspace,-scheme,HelloWorld,-configuration,Debug,-sdk,iphonesimulator,-destination,platform=iOS
>  Simulator,name=iPhone 
> SE,build,CONFIGURATION_BUILD_DIR=/Users/open/NodeProjects/cordova-projects/hello/platforms/ios/build/emulator,SHARED_PRECOMPS_DIR=/Users/open/NodeProjects/cordova-projects/hello/platforms/ios/build/sharedpch



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12626) Splashscreen crashing on Samsung devices, not rendering on others

2017-07-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086601#comment-16086601
 ] 

ASF GitHub Bot commented on CB-12626:
-

Github user Lazza commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/125
  
Are there any news on this?


> Splashscreen crashing on Samsung devices, not rendering on others
> -
>
> Key: CB-12626
> URL: https://issues.apache.org/jira/browse/CB-12626
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: Crashing devices:
> - Samsung Galaxy 7 Edge, Android 7.0
> - Samsung Galaxy Note 4, Android 6.0.1
> "Not showing" devices:
> - Lenovo/Zuk Z1, Android 5.1.1
> - Official Android Emulator with Nexus S simulated hardware, API 25
>Reporter: Andrea Lazzarotto
>  Labels: android
>
> We tested the plugin on a few Samsung devices and found out that the current 
> version of the splash screen plug-in is completely crashing the app, with an 
> error given by {{AndroidRuntime}} (including the PID of the app) and a 
> warning given by {{ActivityManager}} in the log:
> {{Force finishing activity packagename/.MainActivity}}
> Moreover, we noticed that the splash screen is not showing correctly on some 
> devices. The Samsung crash was initially solved by commenting out this line:
> {{preferences.set("SplashDrawableId", drawableId);}}
> Basically, this means that storing the {{drawableId}} in the preferences is 
> not reliable. This didn't solve the display issue on other devices, which 
> required refactoring the code that reads the resource ID.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

2017-07-13 Thread Steve Gill (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill updated CB-11244:

Labels: CordovaAndroidSix android-next  (was: CordovaAndroidSix)

> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-12976) Error: Cannot read property 'length' of undefined

2017-07-13 Thread jcesarmobile (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile updated CB-12976:
--
Priority: Major  (was: Blocker)

> Error: Cannot read property 'length' of undefined
> -
>
> Key: CB-12976
> URL: https://issues.apache.org/jira/browse/CB-12976
> Project: Apache Cordova
>  Issue Type: Bug
>Affects Versions: 7.0.1
> Environment: Windows, android
>Reporter: gurudatta m
>
> Getting below error when doing a cordova build.
> Error: Cannot read property 'length' of undefined
> Details:
> Environment: cordova version 7.0.1
> java version: jdk1.8.0_60
> npm version: 3.10.10
> node version: v6.11.0
> Build output:
> No scripts found for hook "before_build".
> No scripts found for hook "before_prepare".
> Checking config.xml and package.json for saved platforms that haven't been 
> added to the project
> Config.xml and package.json platforms are the same. No pkg.json modification.
> Package.json and config.xml platforms are different. Updating config.xml with 
> most current list of platforms.
> PlatformApi successfully found for platform android
> Checking config.xml for saved plugins that haven't been added to the project
> Checking for any plugins added to the project that have not been installed in 
> android platform
> No differences found between plugins added to project and installed in 
> android platform. Continuing...
> Generating platform-specific config.xml from defaults for android at 
> C:\Users\username\Documents\mobileapp\MyApp\ionicapp\platforms\android\res\xml\config.xml
> Merging project's config.xml into platform-specific android config.xml
> Merging and updating files from [www, platforms\android\platform_www] to 
> platforms\android\assets\www
> Wrote out android application name "MyApp" to 
> C:\Users\username\Documents\mobileapp\MyApp\ionicapp\platforms\android\res\values\strings.xml
> android-versionCode not found in config.xml. Generating a code based on 
> version in config.xml (0.0.1): 1
> Wrote out Android package name "io.ionic.starter" to 
> C:\Users\username\Documents\mobileapp\MyApp\ionicapp\platforms\android\src\io\ionic\starter\MainActivity.java
> Updating icons at platforms\android\res
> Updating splash screens at platforms\android\res
> This app does not have additional resource files defined
> Prepared android project successfully
> No scripts found for hook "after_prepare".
> No scripts found for hook "before_compile".
> ANDROID_HOME=C:\Users\username\AppData\Local\Android\sdk
> JAVA_HOME=C:\Program Files\Java\jdk1.8.0_60
> Error: Cannot read property 'length' of undefined



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms

2017-07-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086277#comment-16086277
 ] 

ASF GitHub Bot commented on CB-12895:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/327
  
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=h1) 
Report
> Merging 
[#327](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/26beb94e2d454917db0bb024ab75e8dd9759c028?src=pr=desc)
 will **increase** coverage by `0.14%`.
> The diff coverage is `52.39%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/327/graphs/tree.svg?height=150=650=pr=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #327  +/-   ##
==
+ Coverage   63.77%   63.91%   +0.14% 
==
  Files  14   14  
  Lines1623 1671  +48 
  Branches  277  277  
==
+ Hits 1035 1068  +33 
- Misses588  603  +15
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[...mplates/scripts/cordova/lib/copy-www-build-step.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NvcHktd3d3LWJ1aWxkLXN0ZXAuanM=)
 | `0% <0%> (ø)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/clean.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NsZWFuLmpz)
 | `0% <0%> (ø)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=)
 | `84.66% <100%> (+0.06%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZHNKc29uLmpz)
 | `100% <100%> (ø)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3J1bi5qcw==)
 | `25.61% <17.8%> (+3.2%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz)
 | `38.77% <19.78%> (+1.93%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/versions.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ZlcnNpb25zLmpz)
 | `12.35% <27.58%> (+0.45%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=)
 | `42.04% <36.11%> (+2.04%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz)
 | `53.89% <42.85%> (ø)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=)
 | `76.85% <60.41%> (+1.2%)` | :arrow_up: |
| ... and [4 
more](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=footer). 
Last update 
[26beb94...80f4521](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> Replace jshint with eslint in our tools + platforms
> ---
>
> Key: CB-12895
> URL: https://issues.apache.org/jira/browse/CB-12895
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: AllComponents
>Reporter: Steve Gill
>Assignee: Audrey So
>Priority: Minor
>  Labels: cordova-next
>
> Based on this proposal
>

[jira] [Commented] (CB-13020) plugman filters out nohooks option

2017-07-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086247#comment-16086247
 ] 

ASF GitHub Bot commented on CB-13020:
-

GitHub user wildabeast opened a pull request:

https://github.com/apache/cordova-lib/pull/575

CB-13020: (plugman) install filters out nohooks



### Platforms affected

n/a

### What does this PR do?

fixes CB-13020: plugman filters out nohooks opt

### What testing has been done on this change?

manual

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wildabeast/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #575


commit 6234355db76342b6fb3045b9a3b23e08f42a92bd
Author: Ryan Willoughby 
Date:   2017-07-13T19:10:04Z

CB-13020: (plugman) install filters out nohooks




> plugman filters out nohooks option
> --
>
> Key: CB-13020
> URL: https://issues.apache.org/jira/browse/CB-13020
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-lib
>Affects Versions: 7.0.1
>Reporter: Ryan Willoughby
>
> plugman install curates the options object prior to sending it to the install 
> function, and it doesn't support the nohooks option. before_plugin_install 
> and after_plugin_install can get triggered even if nohooks is set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13020) plugman filters out nohooks option

2017-07-13 Thread Ryan Willoughby (JIRA) 
Ryan Willoughby created CB-13020:


 Summary: plugman filters out nohooks option
 Key: CB-13020
 URL: https://issues.apache.org/jira/browse/CB-13020
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-lib
Affects Versions: 7.0.1
Reporter: Ryan Willoughby


plugman install curates the options object prior to sending it to the install 
function, and it doesn't support the nohooks option. before_plugin_install and 
after_plugin_install can get triggered even if nohooks is set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12361) Speed up cordova-lib tests

2017-07-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086120#comment-16086120
 ] 

ASF GitHub Bot commented on CB-12361:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/573


> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12361) Speed up cordova-lib tests

2017-07-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086119#comment-16086119
 ] 

ASF subversion and git services commented on CB-12361:
--

Commit 01ae07220088dd9ec27b5fd76b43a39edd6d2fe3 in cordova-lib's branch 
refs/heads/master from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=01ae072 ]

CB-12361 : made revisions after review and feedback


> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12361) Speed up cordova-lib tests

2017-07-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086116#comment-16086116
 ] 

ASF subversion and git services commented on CB-12361:
--

Commit acda3f4be22c4dbb69bde54adf42ccc185080ba2 in cordova-lib's branch 
refs/heads/master from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=acda3f4 ]

CB-12361 : updated addHelper tests


> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12361) Speed up cordova-lib tests

2017-07-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086118#comment-16086118
 ] 

ASF subversion and git services commented on CB-12361:
--

Commit 7eec3c9ddbf07648fa6cf27ca6aa39b146adeaf2 in cordova-lib's branch 
refs/heads/master from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=7eec3c9 ]

CB-12361 : updated addHelper spec tests


> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms

2017-07-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085978#comment-16085978
 ] 

ASF GitHub Bot commented on CB-12895:
-

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-ios/pull/327

CB-12895: replaced jshint with eslint



### Platforms affected


### What does this PR do?
Replaced jshint with eslint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-ios CB-12895-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/327.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #327


commit f9b046e5fae2f83c7aa9bf20d80a1fcfd09d05f9
Author: Audrey So 
Date:   2017-06-15T17:56:59Z

CB-12895 : removed jshint and added eslint

commit b7b92263af52efd2bad27d5bdba63ee24244e76a
Author: Audrey So 
Date:   2017-06-15T18:02:03Z

CB-12895 : formatted using eslint rules

commit d2fae43e99f2f4da52d3aa13aee309c805964eea
Author: Audrey So 
Date:   2017-07-12T21:47:46Z

CB-12895 : updated indenting with eslint rules




> Replace jshint with eslint in our tools + platforms
> ---
>
> Key: CB-12895
> URL: https://issues.apache.org/jira/browse/CB-12895
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: AllComponents
>Reporter: Steve Gill
>Assignee: Audrey So
>Priority: Minor
>  Labels: cordova-next
>
> Based on this proposal
> https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308
> JSHint does minimal checks and JSCS has been deprecated in favor of ESLint.
>  +
>  +I suggest to replace the current style checkers with ESLint. This allows to 
> set much more strict styling rules than at at this moment.
>  +
>  +I recommend using a popular preset, such as 
> [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). 
> Example configuration:
>  +
>  +```yaml
>  +root: true
>  +
>  +extends: airbnb-base
>  +```
>  +
>  +Many styling issues could be fixed by simply running:
>  +
>  +```
>  +./node_modules/.bin/eslint --fix .
>  +```
>  +
>  +
>  +
>  +Optionally the indent could be set to 4 instead of 2, because that's used 
> in the current code base.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-12838) Order of plugins in config.xml modified during build

2017-07-13 Thread Audrey So (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-12838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Audrey So reassigned CB-12838:
--

Assignee: Audrey So

> Order of plugins in config.xml modified during build
> 
>
> Key: CB-12838
> URL: https://issues.apache.org/jira/browse/CB-12838
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: cordova@7.0.0
> Environment: Mac OS 10.12.4, Cordova 7.0.1
>Reporter: Anton Weber
>Assignee: Audrey So
>Priority: Minor
>  Labels: android, cordova-8.0.0, ios, reproduced, triaged
>
> Running cordova build android or cordova build ios changes the order in which 
> plugins are listed in the config.xml (arranging them alphabetically). 
> This causes problems when manually resolving dependencies, e.g. when 
> installing a specific version of a dependency first by having it higher up in 
> the list.
> Example:
> Original config.xml content:
> ...
> 
> 
> 
> 
> 
> ...
> After cordova build:
> ...
> 
> 
> 
> 
> 
> ...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12838) Order of plugins in config.xml modified during build

2017-07-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085912#comment-16085912
 ] 

ASF GitHub Bot commented on CB-12838:
-

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/574

CB-12838 : prevented sorting and alphabetizing platforms and plugins i…

…n pkgJson and config



### Platforms affected


### What does this PR do?

Prevents modifying/alphabetizing platforms and plugins in config

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12838

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #574


commit 083deef9ce70afe8455a36f49ddccf0b093558f8
Author: Audrey So 
Date:   2017-07-12T00:21:41Z

CB-12838 : prevented sorting and aphabetizing platforms and plugins in 
pkgjson and config




> Order of plugins in config.xml modified during build
> 
>
> Key: CB-12838
> URL: https://issues.apache.org/jira/browse/CB-12838
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: cordova@7.0.0
> Environment: Mac OS 10.12.4, Cordova 7.0.1
>Reporter: Anton Weber
>Priority: Minor
>  Labels: android, cordova-8.0.0, ios, reproduced, triaged
>
> Running cordova build android or cordova build ios changes the order in which 
> plugins are listed in the config.xml (arranging them alphabetically). 
> This causes problems when manually resolving dependencies, e.g. when 
> installing a specific version of a dependency first by having it higher up in 
> the list.
> Example:
> Original config.xml content:
> ...
> 
> 
> 
> 
> 
> ...
> After cordova build:
> ...
> 
> 
> 
> 
> 
> ...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-13007) Run native end-to-end tests in CI for cordova-android

2017-07-13 Thread Filip Maj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Filip Maj resolved CB-13007.

Resolution: Incomplete

Unfortunately, I failed. I was not able to get the emulator running in travis 
consistently. Its flake rate was too high - wouldn't serve us very well.

> Run native end-to-end tests in CI for cordova-android
> -
>
> Key: CB-13007
> URL: https://issues.apache.org/jira/browse/CB-13007
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Filip Maj
>Assignee: Filip Maj
>
> Would require that we start an emulator in both Travis and AppVeyor.
> But then we'd be able to run _all_ the tests we have for cordova-android in 
> CI. That'd be a huge win!
> WIP here: https://github.com/apache/cordova-android/pull/392



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13012) InAppBrowser no focus on input text fields

2017-07-13 Thread Nikita Matrosov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085704#comment-16085704
 ] 

Nikita Matrosov commented on CB-13012:
--

Does not reproduce this bug. [~shuppert], could you please provide more 
information about your case (plugin version, code snippet, device details)

> InAppBrowser no focus on input text fields
> --
>
> Key: CB-13012
> URL: https://issues.apache.org/jira/browse/CB-13012
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: Android
>Reporter: Scott Huppert
>  Labels: android
>
> The same issue from CB-11248 still exists.  The first time accessing the IAB 
> works but after multiple accesses the same issue occurs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12657) android 4.3 exit app, WebView.destroy() called while still attached

2017-07-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085667#comment-16085667
 ] 

ASF GitHub Bot commented on CB-12657:
-

Github user Thomsen closed the pull request at:

https://github.com/apache/cordova-android/pull/375


> android 4.3 exit app, WebView.destroy() called while still attached
> ---
>
> Key: CB-12657
> URL: https://issues.apache.org/jira/browse/CB-12657
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 6.0.0
> Environment: android huawei g620-i75 mobile
>Reporter: Thomsen Wang
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13016) Hooks are not fired from "cordova run" command

2017-07-13 Thread Nikita Matrosov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085585#comment-16085585
 ] 

Nikita Matrosov commented on CB-13016:
--

[~alejandro_liu], seems, that only 'prepare' hooks should be called for both 
the 'cordova build' and 'cordova run' cases (see docs - 
https://cordova.apache.org/docs/en/latest/guide/appdev/hooks/#introduction).
For `cordova run` command you can also use 'before_deploy', 'after_deploy', 
'before_run', 'after_run'.

> Hooks are not fired from "cordova run" command
> --
>
> Key: CB-13016
> URL: https://issues.apache.org/jira/browse/CB-13016
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: 7.0.1
> Environment: I have only tested it on 7.0.1 using the Command Line 
> Interface, under Linux.
>Reporter: Alejandro Liu
>
> I have created hooks in config.xml as this:
> 
> 
> 
> 
> 
> 
> The scripts simply would print 'CORDOVA_HOOK' environment variable.
> If I run: cordova run, that triggers the "build" process but this build 
> process does not call the build or compile hooks.  Only the "prepare" hooks 
> are called.
> I think the build and/or compile hooks should be called.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11881) File transfer download onprogress

2017-07-13 Thread Sadik Yalcin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sadik Yalcin closed CB-11881.
-
Resolution: Unresolved

> File transfer download onprogress
> -
>
> Key: CB-11881
> URL: https://issues.apache.org/jira/browse/CB-11881
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file-transfer
>Affects Versions: 6.3.1
> Environment: iPhone 6s Plus / iOS 9.2 Simulator
>Reporter: Sadik Yalcin
>
> onprogress not triggering. I can't see anything wrong with my code - 
> downloading/deleting success/error are all good.
> {code:title=Code|borderStyle=solid}
> window.requestFileSystem  = window.requestFileSystem || 
> window.webkitRequestFileSystem;
> window.requestFileSystem(LocalFileSystem.PERSISTENT, 0, download, fail);
> function download(fileSystem){
> var path = fileSystem.root.toURL();
> var fileURL = path + config.appDirName + '/' + filename + '.' + extension;
> var localpath = path + config.appDirName + '/' + filename + '.' + 
> extension;
> fileURL = encodeURI(fileURL);
> var fileTransfer = new FileTransfer();
> 
> fileTransfer.onprogress = function(progressEvent) {
> console.log('downloading..');
> if (progressEvent.lengthComputable) {
> var percent = progressEvent.loaded / progressEvent.total * 100;
> percent = Math.round(percent);
> $('#progress-'+documentsArticle.id).val(percent);
>  console.log('Perc: ', percent);
> } else {
> console.log('downloading');
> }
> };
> fileTransfer.download(
> downloadurl,
> fileURL,
> function(entry) {
> console.log('Download complete: ' + entry.toURL());
> ...
> },
> function(failed) {
> console.log('Download failed: ', failed);
> ...
> },
> true
> );
> }}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-13003) Warning build blank project ios

2017-07-13 Thread jcesarmobile (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile updated CB-13003:
--
Component/s: (was: cordova-ios)
 cordova-plugin-file

> Warning build blank project ios
> ---
>
> Key: CB-13003
> URL: https://issues.apache.org/jira/browse/CB-13003
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file
> Environment: Xcode 8.3.2 (8E2002)
> Cordova 7.0.1
> Cordova ios 4.4.0
> Mac OS 10.12.5
>Reporter: Romain Brenet
>Assignee: Shazron Abdullah
>
> Hello, I have lot of warning when I create a project with Cordova 7.0.1 and 
> when I open Project in Xcode.
> I have this without plugin, and no code.
> /Plugins/cordova-plugin-file/CDVAssetLibraryFilesystem.m:193:5: 
> 'ALAssetsLibraryAssetForURLResultBlock' is deprecated: first deprecated in 
> iOS 9.0 - Use fetchAssetsWithLocalIdentifiers:options: on PHAsset to fetch 
> assets by local identifier (or to lookup PHAssets by a previously known 
> ALAssetPropertyAssetURL use fetchAssetsWithALAssetURLs:options:) from the 
> Photos framework instead
> /Plugins/cordova-plugin-file/CDVAssetLibraryFilesystem.m:196:65: 
> 'defaultRepresentation' is deprecated: first deprecated in iOS 9.0 - Use 
> PHImageRequestOptions with the PHImageManager from the Photos framework 
> instead
> Lot and lot Warning, I can build app and send to iPhone, but it not very well.
> With 6.5, I have 0 Warning.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13003) Warning build blank project ios

2017-07-13 Thread jcesarmobile (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085391#comment-16085391
 ] 

jcesarmobile commented on CB-13003:
---

Those are warnings on the cordova-plugin-file.

It happens with CLI 7 because cordova-ios 4.4.0 (pinned by CLI 7), sets the 
deployment target to iOS 9, while the cordova-ios version pinned on CLI 6.5.0 
sets the deployment target to iOS 8.

Xcode only shows deprecate warnings for the current deployment target version 
or lower. As those were deprecated on iOS 9, when the deployment target is set 
to iOS 8 they won't be shown.


> Warning build blank project ios
> ---
>
> Key: CB-13003
> URL: https://issues.apache.org/jira/browse/CB-13003
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
> Environment: Xcode 8.3.2 (8E2002)
> Cordova 7.0.1
> Cordova ios 4.4.0
> Mac OS 10.12.5
>Reporter: Romain Brenet
>Assignee: Shazron Abdullah
>
> Hello, I have lot of warning when I create a project with Cordova 7.0.1 and 
> when I open Project in Xcode.
> I have this without plugin, and no code.
> /Plugins/cordova-plugin-file/CDVAssetLibraryFilesystem.m:193:5: 
> 'ALAssetsLibraryAssetForURLResultBlock' is deprecated: first deprecated in 
> iOS 9.0 - Use fetchAssetsWithLocalIdentifiers:options: on PHAsset to fetch 
> assets by local identifier (or to lookup PHAssets by a previously known 
> ALAssetPropertyAssetURL use fetchAssetsWithALAssetURLs:options:) from the 
> Photos framework instead
> /Plugins/cordova-plugin-file/CDVAssetLibraryFilesystem.m:196:65: 
> 'defaultRepresentation' is deprecated: first deprecated in iOS 9.0 - Use 
> PHImageRequestOptions with the PHImageManager from the Photos framework 
> instead
> Lot and lot Warning, I can build app and send to iPhone, but it not very well.
> With 6.5, I have 0 Warning.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-13003) Warning build blank project ios

2017-07-13 Thread jcesarmobile (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile updated CB-13003:
--
Flags:   (was: Important)

> Warning build blank project ios
> ---
>
> Key: CB-13003
> URL: https://issues.apache.org/jira/browse/CB-13003
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
> Environment: Xcode 8.3.2 (8E2002)
> Cordova 7.0.1
> Cordova ios 4.4.0
> Mac OS 10.12.5
>Reporter: Romain Brenet
>Assignee: Shazron Abdullah
>
> Hello, I have lot of warning when I create a project with Cordova 7.0.1 and 
> when I open Project in Xcode.
> I have this without plugin, and no code.
> /Plugins/cordova-plugin-file/CDVAssetLibraryFilesystem.m:193:5: 
> 'ALAssetsLibraryAssetForURLResultBlock' is deprecated: first deprecated in 
> iOS 9.0 - Use fetchAssetsWithLocalIdentifiers:options: on PHAsset to fetch 
> assets by local identifier (or to lookup PHAssets by a previously known 
> ALAssetPropertyAssetURL use fetchAssetsWithALAssetURLs:options:) from the 
> Photos framework instead
> /Plugins/cordova-plugin-file/CDVAssetLibraryFilesystem.m:196:65: 
> 'defaultRepresentation' is deprecated: first deprecated in iOS 9.0 - Use 
> PHImageRequestOptions with the PHImageManager from the Photos framework 
> instead
> Lot and lot Warning, I can build app and send to iPhone, but it not very well.
> With 6.5, I have 0 Warning.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-13014) cordova in-app-browser doesnt support vimeo videos

2017-07-13 Thread jcesarmobile (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile updated CB-13014:
--
Priority: Major  (was: Critical)

> cordova in-app-browser doesnt support vimeo videos
> --
>
> Key: CB-13014
> URL: https://issues.apache.org/jira/browse/CB-13014
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-plugin-inappbrowser, Ionic
> Environment: Android
>Reporter: nidhi trivedi
>Assignee: Joe Bowser
>
> Hi, 
> We are using* cordova-plugin in-app-browser version ^1.7.1*, as part of* 
> ionic -native* in our project. to open external links in the in-app-browser
> however, whenever the external link contains vimeo video, it doesnt work with 
> the in-app-browser. It behaves weird.
> 1. sometimes the audio for the video loads and plays but video doesnt play
> 2. sometimes the video plays but the play and pause button dissappears
> we raised an issue in *vimeo* and they said we should ask for support to you. 
> can you please help us with it. Its a little urgent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-13015) Cordova InAppBrowser - not able to play Vimeo video in full screen

2017-07-13 Thread jcesarmobile (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-13015.
-
Resolution: Duplicate

This is a duplicate of CB-13014

> Cordova InAppBrowser - not able to play Vimeo video in full screen
> --
>
> Key: CB-13015
> URL: https://issues.apache.org/jira/browse/CB-13015
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-plugin-inappbrowser, Ionic
> Environment: Android
>Reporter: Darshana
>Assignee: Joe Bowser
>
> We have embedded vimeo video to a page. To open this page in our ionic-native 
> app we are using cordova-in-app-browser plugin.
> In android, We do not see play/pause controls once the video starts and not 
> able to play video in full screen either.
> It would be great if you can fix this issue to solve our deadlock. Thanks for 
> your help and support.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-13019) Reduce SplashScreenDelay default value

2017-07-13 Thread jcesarmobile (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-13019.
-
Resolution: Won't Fix

3 seconds seems reasonable to me, also, it's documented and can be changed. 

> Reduce SplashScreenDelay default value
> --
>
> Key: CB-13019
> URL: https://issues.apache.org/jira/browse/CB-13019
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Reporter: Martin Kleinschrodt
>Priority: Minor
>
> I mean 3 seconds, really? Spent like 3 hours trying to figure out why my app 
> was starting up so slowly until I figured out it was because of the splash 
> screen delay. I don't even want to know how many cordova apps are out there 
> that could have a startup time < 2s but take like 5s because the devs never 
> bothered to investigate. Whatever happened to sane defaults?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13018) cordova build failed for both android and ios

2017-07-13 Thread jcesarmobile (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085362#comment-16085362
 ] 

jcesarmobile commented on CB-13018:
---

The android error seems to be a permission problem because you are using sudo 
to install things.
On iOS is not clear, but could be the same problem.

Don't use sudo to install npm packages

> cordova build failed for both android and ios
> -
>
> Key: CB-13018
> URL: https://issues.apache.org/jira/browse/CB-13018
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Affects Versions: cordova-ios@4.4.0, cordova-android@5.2.2, 7.0.1
> Environment: (1)MacOS: 10.12.5
> (2)node: v8.1.4
> (3)cordova: 7.0.1
> (4)*cordova platform ls*
>   android 6.2.3
>   ios 4.4.0
>Reporter: oscar peng
>Assignee: Joe Bowser
>  Labels: starter
>
> Following http://cordova.apache.org/docs/en/latest/guide/cli/index.html, 
> Create your first Cordova app.
> h1. cordova requirements
>  - Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: installed 
> android-26,android-25,android-24,android-N,android-23,Google Inc.:Google 
> APIs:23,android-22,android-21,android-20,android-19,android-18,android-17,android-16,android-15,android-14
> Gradle: installed /Applications/Android Studio 3.0 
> Preview.app/Contents/gradle/gradle-4.1-milestone-1/bin/gradle
>   -  Requirements check results for ios:
> Apple OS X: installed darwin
> Xcode: installed 8.3.3
> ios-deploy: not installed
> ios-deploy was not found. Please download, build and install version 1.9.0 or 
> greater from https://github.com/phonegap/ios-deploy into your path, or do 
> 'npm install -g ios-deploy'
> CocoaPods: installed
> Error: Some of requirements check failed
> h1. sudo npm install -g ios-deploy --unsafe-perm=true
> h1. cordova requirements
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: installed 
> android-26,android-25,android-24,android-N,android-23,Google Inc.:Google 
> APIs:23,android-22,android-21,android-20,android-19,android-18,android-17,android-16,android-15,android-14
> Gradle: installed /Applications/Android Studio 3.0 
> Preview.app/Contents/gradle/gradle-4.1-milestone-1/bin/gradle
> Requirements check results for ios:
> Apple OS X: installed darwin
> Xcode: installed 8.3.3
> ios-deploy: installed 1.9.1
> CocoaPods: installed
> h1. cordova build (or cordova build android)
> ANDROID_HOME=/Users/open/Library/Android/sdk
> JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home
> Error: spawn EACCES
> h1. cordova build ios
> ** BUILD FAILED **
> The following build commands failed:
>   PhaseScriptExecution Copy\ www\ directory 
> /Users/open/Library/Developer/Xcode/DerivedData/HelloWorld-fqxzydxnjuyjjobwofitkplrpyef/Build/Intermediates/HelloWorld.build/Debug-iphonesimulator/HelloWorld.build/Script-304B58A110DAC018002A0835.sh
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args: 
> -xcconfig,/Users/open/NodeProjects/cordova-projects/hello/platforms/ios/cordova/build-debug.xcconfig,-workspace,HelloWorld.xcworkspace,-scheme,HelloWorld,-configuration,Debug,-sdk,iphonesimulator,-destination,platform=iOS
>  Simulator,name=iPhone 
> SE,build,CONFIGURATION_BUILD_DIR=/Users/open/NodeProjects/cordova-projects/hello/platforms/ios/build/emulator,SHARED_PRECOMPS_DIR=/Users/open/NodeProjects/cordova-projects/hello/platforms/ios/build/sharedpch



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13019) Reduce SplashScreenDelay default value

2017-07-13 Thread Martin Kleinschrodt (JIRA) 
Martin Kleinschrodt created CB-13019:


 Summary: Reduce SplashScreenDelay default value
 Key: CB-13019
 URL: https://issues.apache.org/jira/browse/CB-13019
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-plugin-splashscreen
Reporter: Martin Kleinschrodt
Priority: Minor


I mean 3 seconds, really? Spent like 3 hours trying to figure out why my app 
was starting up so slowly until I figured out it was because of the splash 
screen delay. I don't even want to know how many cordova apps are out there 
that could have a startup time < 2s but take like 5s because the devs never 
bothered to investigate. Whatever happened to sane defaults?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-12636) Support of Visual Studio 2017

2017-07-13 Thread Alexander Sorokin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-12636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Sorokin reassigned CB-12636:
--

Assignee: Alexander Sorokin

> Support of Visual Studio 2017
> -
>
> Key: CB-12636
> URL: https://issues.apache.org/jira/browse/CB-12636
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-windows
>Affects Versions: 6.5.0
> Environment: Windows 10
>Reporter: Marco Paland
>Assignee: Alexander Sorokin
>
> Please add support for Visual Studio 2017.
> On a Windows 10 machine I installed VS2017 (no other VS). Upon compiling a 
> cordova project I get:
> {code}
> > cordova build windows --verbose
> No scripts found for hook "before_build".
> No scripts found for hook "before_prepare".
> Checking config.xml for saved platforms that haven't been added to the project
> Checking for any plugins added to the project that have not been installed in 
> windows platform
> No differences found between plugins added to project and installed in 
> windows platform. Continuing...
> Generating platform-specific config.xml from defaults for windows at 
> C:\Users\Marco\Documents\Visual Studio 
> 2017\Projects\BlankCordovaApp1\BlankCordovaApp1\platforms\windows\config.xml
> Merging project's config.xml into platform-specific windows config.xml
> Found "merges/windows" folder. Copying its contents into the windows project.
> Merging and updating files from [www, platforms\windows\platform_www, 
> merges\windows] to platforms\windows\www
>   copy  platforms\windows\platform_www\cordova-js-src\confighelper.js 
> platforms\windows\www\cordova-js-src\confighelper.js (updated file)
>   copy  platforms\windows\platform_www\cordova-js-src\exec.js 
> platforms\windows\www\cordova-js-src\exec.js (updated file)
>   copy  platforms\windows\platform_www\cordova-js-src\platform.js 
> platforms\windows\www\cordova-js-src\platform.js (updated file)
>   copy  platforms\windows\platform_www\cordova-js-src\splashscreen.js 
> platforms\windows\www\cordova-js-src\splashscreen.js (updated file)
>   copy  platforms\windows\platform_www\cordova_plugins.js 
> platforms\windows\www\cordova_plugins.js (updated file)
>   copy  www\css\index.css platforms\windows\www\css\index.css (updated file)
>   copy  www\index.html platforms\windows\www\index.html (updated file)
> Updating icons and splash screens at platforms\windows\images
> Prepared windows project successfully
> No scripts found for hook "pre_package".
> No scripts found for hook "after_prepare".
> Checking config.xml for saved plugins that haven't been added to the project
> No scripts found for hook "before_compile".
> Reading build config file: C:\Users\Marco\Documents\Visual Studio 
> 2017\Projects\BlankCordovaApp1\BlankCordovaApp1\build.json
> Searching for available MSBuild versions...
> Running command: C:\WINDOWS\system32\reg.exe query 
> HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\15.0 /v MSBuildToolsPath
> Running command: C:\WINDOWS\system32\reg.exe query 
> HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\14.0 /v MSBuildToolsPath
> Running command: C:\WINDOWS\system32\reg.exe query 
> HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\12.0 /v MSBuildToolsPath
> Running command: C:\WINDOWS\system32\reg.exe query 
> HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\4.0 /v MSBuildToolsPath
> Command finished with error code 1: C:\WINDOWS\system32\reg.exe 
> query,HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\12.0,/v,MSBuildToolsPath
> Command finished with error code 1: C:\WINDOWS\system32\reg.exe 
> query,HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\14.0,/v,MSBuildToolsPath
> Command finished with error code 1: C:\WINDOWS\system32\reg.exe 
> query,HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\15.0,/v,MSBuildToolsPath
> Command finished with error code 0: C:\WINDOWS\system32\reg.exe 
> query,HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\4.0,/v,MSBuildToolsPath
> Found MSBuild v4.0 at C:\Windows\Microsoft.NET\Framework64\v4.0.30319\
> MSBuild v4.0 is not supported, aborting.
> Error: Package with specified parameters not found in AppPackages folder
> {code}
> The requirement check shows:
> {code}
> > cordova requirements windows
> Requirements check results for windows:
> Windows OS: installed Windows 10
> MSBuild Tools: not installed
> MSBuild tools v.14.0 not found. Please install Visual Studio 2015 Community 
> from https://www.visualstudio.com/downloads/download-visual-studio-vs
> Visual Studio: not installed
> Required version of Visual Studio not found. Please install Visual Studio 
> 2015 Community from 
> https://www.visualstudio.com/downloads/download-visual-studio-vs
> Windows SDK: installed 10.0
> Windows Phone SDK: installed 10.0
> Error: Some of requirements check failed
> {code}
> I don't want to install VS2015 Community Edition

[jira] [Comment Edited] (CB-8401) Android permissions don't merge nicely when maxSdkVersion is set

2017-07-13 Thread Ctibor Laky (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085235#comment-16085235
 ] 

Ctibor Laky edited comment on CB-8401 at 7/13/17 6:05 AM:
--

[~johnvh] How did you fix your issue? I came into same problem. I need solution 
which can be committed to git with project and solved for everyone in a team. 
Thanks


was (Author: luckylooke):
[~johnvh] How did you fix your issue, I came into same problem. I need solution 
which can be committed to git with project and solved for everyone in a team. 
Thanks

> Android permissions don't merge nicely when maxSdkVersion is set
> 
>
> Key: CB-8401
> URL: https://issues.apache.org/jira/browse/CB-8401
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugman
> Environment: Android
>Reporter: Eddy Verbruggen
>
> If two plugins request the same permission they are nicely merged into one 
> line in AndroidManifest.xml.
> However, if one of those two has 'android:maxSdkVersion="18"', both lines 
> show up in the resulting AndroidManifest.xml which is not allowed, so the 
> Android build fails.
> As an example you can create a Cordova CLI project with the core File plugin 
> and SocialSharing (the latter has the maxSdkVersion set):
> cordova create duplicatepermissiontest
> cd duplicatepermissiontest
> cordova platform add android
> cordova plugin add org.apache.cordova.file
> cordova plugin add nl.x-services.plugins.socialsharing
> cordova prepare
> The AndroidManifest.xml now has the duplicate permission.
> I think what you'd want is the broader permission to 'win' this fight, so I'd 
> expect the manifest to contain only ' android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>'.
> Note that I added the maxSdkVersion restriction because according to Google 
> SDK 19+ no longer requires the permission in my case and the permission tends 
> to scare off people using apps with this plugin installed.
> I hope you will consider creating something clever to merge these duplicate 
> permissions.
> This issue was first reported here: 
> https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/295
> Best,
> Eddy



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8401) Android permissions don't merge nicely when maxSdkVersion is set

2017-07-13 Thread Ctibor Laky (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085235#comment-16085235
 ] 

Ctibor Laky commented on CB-8401:
-

[~johnvh] How did you fix your issue, I came into same problem. I need solution 
which can be committed to git with project and solved for everyone in a team. 
Thanks

> Android permissions don't merge nicely when maxSdkVersion is set
> 
>
> Key: CB-8401
> URL: https://issues.apache.org/jira/browse/CB-8401
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugman
> Environment: Android
>Reporter: Eddy Verbruggen
>
> If two plugins request the same permission they are nicely merged into one 
> line in AndroidManifest.xml.
> However, if one of those two has 'android:maxSdkVersion="18"', both lines 
> show up in the resulting AndroidManifest.xml which is not allowed, so the 
> Android build fails.
> As an example you can create a Cordova CLI project with the core File plugin 
> and SocialSharing (the latter has the maxSdkVersion set):
> cordova create duplicatepermissiontest
> cd duplicatepermissiontest
> cordova platform add android
> cordova plugin add org.apache.cordova.file
> cordova plugin add nl.x-services.plugins.socialsharing
> cordova prepare
> The AndroidManifest.xml now has the duplicate permission.
> I think what you'd want is the broader permission to 'win' this fight, so I'd 
> expect the manifest to contain only ' android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>'.
> Note that I added the maxSdkVersion restriction because according to Google 
> SDK 19+ no longer requires the permission in my case and the permission tends 
> to scare off people using apps with this plugin installed.
> I hope you will consider creating something clever to merge these duplicate 
> permissions.
> This issue was first reported here: 
> https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/295
> Best,
> Eddy



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org