[jira] [Created] (CB-13738) Cordova plugin camera error
Adrian Jarc created CB-13738: Summary: Cordova plugin camera error Key: CB-13738 URL: https://issues.apache.org/jira/browse/CB-13738 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-camera Environment: device: Samsung Galaxy XCover 4 Android v7.0 Ionic v1.7.16 Cordova v6.5.0 cordova-plugin-camera v4.0.1 platform added: Creating Cordova project for the Android platform: Android target: android-26 Subproject Path: CordovaLib Android project created with cordova-android@6.4.0 Reporter: Adrian Jarc Attachments: log.txt In a project I am making with cordova-plugin-camera on android 7.0 I get the following error while trying to call camera: android.os.FileUriExposedException: file:///storage/emulated/0/Android/data/com.comland.mightyfields.eg/cache/.Pic.jpg exposed beyond app through ClipData.Item.getUri(). The application has rights to access file storage and camera but once camera is being called nothing happens and android monitor catches this error (full log found in attached file log.txt) Problem doesn't happen if do 'ionic run android' but once I upload and install apk build with ionic build android this problem starts appearing. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315529#comment-16315529 ] Shemrick Flannigan commented on CB-13415: - [~jcesarmobile] If you have an Android device available, it is easier to replicate this issue by directly uploading the corrupt image from Dropbox. If you only have an iPhone available, a robust free utility to transfer the corrupt image file intact to the iOS file system is MobiMover: https://www.easeus.com/phone-transfer/mobimover-free.html > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13583) Gray bar in status area when using inappbrowser
[
https://issues.apache.org/jira/browse/CB-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315510#comment-16315510
]
jcesarmobile commented on CB-13583:
---
I have created a branch without the bar, but I still think this should be a
preference and not the default as it has been like that before, so I haven't
sent the PR yet.
Try it and let me know what do you think
https://github.com/jcesarmobile/cordova-plugin-inappbrowser/tree/removed-bar
> Gray bar in status area when using inappbrowser
> ---
>
> Key: CB-13583
> URL: https://issues.apache.org/jira/browse/CB-13583
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Environment: Mac OS 10.13.1, Xcode 9.1
>Reporter: Jacob Weber
> Attachments: config.xml, landscape-to-portrait-to-landscape.png,
> portrait-to-landscape.png, portrait.png
>
>
> Use the attached config.xml in a new Cordova project. Add viewport-fit=cover
> to index.html, and add Default@2x~universal~anyany.png file for the splash
> image.
> Open the project in an iPhone X simulator, running iOS 11.1.
> In portrait mode, call window.open('https://www.google.com', '_blank').
> You'll see a gray area where the status bar would be on older devices (see
> portrait.png). Rotate to landscape, and it's still there (see
> portrait-to-landscape.png).
> Close the browser. Now in landscape, run the window.open command again.
> Rotate to portrait, then back to landscape. Now you'll see a gray area, but
> it only covers half of the screen (see
> landscape-to-portrait-to-landscape.png).
> (Note that I used the "master" version of cordova-ios and some plugins, since
> it seems like there are some unreleased fixes for the iPhone X, like
> CB-13505).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315496#comment-16315496 ] jcesarmobile commented on CB-13415: --- Any idea about how to use the corrupt image on iOS? Tried downloading it on the computer and sending it to the device via air drop and also downloading using the dropbox app, but once it's stored in the gallery it no longer corrupt, I can see it perfectly and doesn't crash the camera > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13736) Project
[ https://issues.apache.org/jira/browse/CB-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13736. - Resolution: Invalid This issue is invalid, the title doesn't provide any information and there is no description > Project > --- > > Key: CB-13736 > URL: https://issues.apache.org/jira/browse/CB-13736 > Project: Apache Cordova > Issue Type: Bug >Reporter: Mihail Chirkov > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315395#comment-16315395 ] ASF GitHub Bot commented on CB-13396: - Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355837859 > That's why I created the other issue In fact this is great. > My intention is not to pollute this issue with unrelated comments My remarks were obviously addressed to the people leaving comments unrelated to the **white bottom margin problem** that this GitHub comment thread is about. Not to you. > anybody can use whatever they want Fair enough, but generally developers tend to prefer solutions that are: - new and recommended by the core developers - less prone to bugs - more maintainable - easier to use This is why they *"should"* use it, not *"must"* use it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315388#comment-16315388 ] ASF GitHub Bot commented on CB-13396: - jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355837438 > this is a different issue Yes, it's a different issue, but there are a few people in this issue complaining about the other issue that wasn't reported because it's not clear that this PR is for when using storyboard and they are not using storyboard. That's why I created the other issue, fixed it and pointed the people to the other issue instead of complaining here. My intention is not to pollute this issue with unrelated comments, it's the opposite, to point them to the right issue. > the previous method is old anyways and people should just use the storyboard one The old method is still supported and anybody can use whatever they want > Hence this discussion should not be polluted with unrelated topics. The other topic is related, the title says "Fix image sizing on iPhone X", and people enter hopping that it fixes their issues with iPhone X image sizing, but it doesn't, the other issue fixes it. Anyway, no discussion should be polluted in PRs, Apache Cordova uses JIRA for the issues, so all the discussions should be in the related JIRA and not here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315390#comment-16315390 ] ASF GitHub Bot commented on CB-13396: - jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355837438 > this is a different issue Yes, it's a different issue, but there are a few people in this issue complaining about the other issue that wasn't reported because it's not clear that this PR is for when using storyboard and they are not using storyboard. That's why I created the other issue, fixed it and pointed the people to the other issue instead of complaining here. My intention is not to pollute this issue with unrelated comments, it's the opposite, to point them to the right issue. > the previous method is old anyways and people should just use the storyboard one The old method is still supported and anybody can use whatever they want > Hence this discussion should not be polluted with unrelated topics. The other topic is related, the title says "Fix image sizing on iPhone X", and people enter hopping that it fixes their issues with iPhone X image sizing, but it doesn't, the other issue fixes it. Anyway, no discussion should be polluted in PRs, Apache Cordova uses JIRA for the issues, so all the discussions should be in the related JIRA and not here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315381#comment-16315381 ] ASF GitHub Bot commented on CB-13396: - Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355836250 > The other problem is not reported (or I couldn't find it), but splash screen doesn't work fine on iPhone X when NOT using storyboard OK, but: 1. this is a different issue 2. the previous method is old anyways and people should just use the storyboard one Hence this discussion should not be polluted with unrelated topics. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12467) Activity View (Spinner) position iOS
[ https://issues.apache.org/jira/browse/CB-12467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315377#comment-16315377 ] jcesarmobile commented on CB-12467: --- I can't reproduce this, the activity view always appears centered to me. Can you provide more details? device where you tested, config.xml preferences used, etc. With your proposed changes it also works, but look more complex. > Activity View (Spinner) position iOS > > > Key: CB-12467 > URL: https://issues.apache.org/jira/browse/CB-12467 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen >Affects Versions: 4.0.1 >Reporter: Gabriel Fringeli > Labels: easyfix > Original Estimate: 5m > Remaining Estimate: 5m > > On iOS devices the current plugin version does not center the activity view > (Spinner) in its parent view. Instead its center is bound to the upper left > corner. Only after some time (5 seconds) the activity view is centered in its > parent view. > I already have fixed this bug by replacing the current positioning (via > _activityView.center and _activityView.autoresizingMaks) with > NSLayoutConstraint. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315369#comment-16315369 ] ASF GitHub Bot commented on CB-13396: - jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355835035 @Drewster727 @iisdan and any other using the legacy splash screen files instead of the launch storyboard, can you test this PR? it should fix your problems https://github.com/apache/cordova-plugin-splashscreen/pull/146 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13737) Splash screen images are resized incorrectly on iPhone X
[
https://issues.apache.org/jira/browse/CB-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315368#comment-16315368
]
ASF GitHub Bot commented on CB-13737:
-
jcesarmobile opened a new pull request #146: CB-13737 (iOS): fix Splash screen
images for iPhone X
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/146
### Platforms affected
iOS
### What does this PR do?
Takes into account iPhone X sizes for splash screen
### What testing has been done on this change?
Tested on iPhone X
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Splash screen images are resized incorrectly on iPhone X
>
>
> Key: CB-13737
> URL: https://issues.apache.org/jira/browse/CB-13737
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: jcesarmobile
>Assignee: jcesarmobile
> Labels: splashscreen
>
> When not using storyboard, the splash images are not correctly resized for
> iPhone X. So when it switches from the launch image to the splash image there
> is a noticeable change.
> Also, the landscape image is not displayed, it will show the portrait one.
> {code}
> width="1125" />
> src="res/screens/ios/Default-Landscape-2436h.png" width="2436" />
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13737) Splash screen images are resized incorrectly on iPhone X
[
https://issues.apache.org/jira/browse/CB-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile updated CB-13737:
--
Description:
When not using storyboard, the splash images are not correctly resized for
iPhone X. So when it switches from the launch image to the splash image there
is a noticeable change.
Also, the landscape image is not displayed, it will show the portrait one.
{code}
{code}
was:CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into
account, causing the image size to change when CDVLaunchScreen.storyboard
transitions to the CDVSplashScreen image.
> Splash screen images are resized incorrectly on iPhone X
>
>
> Key: CB-13737
> URL: https://issues.apache.org/jira/browse/CB-13737
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: jcesarmobile
> Labels: splashscreen
>
> When not using storyboard, the splash images are not correctly resized for
> iPhone X. So when it switches from the launch image to the splash image there
> is a noticeable change.
> Also, the landscape image is not displayed, it will show the portrait one.
> {code}
> width="1125" />
> src="res/screens/ios/Default-Landscape-2436h.png" width="2436" />
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13737) Splash screen images are resized incorrectly on iPhone X
[
https://issues.apache.org/jira/browse/CB-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile reassigned CB-13737:
-
Assignee: jcesarmobile
> Splash screen images are resized incorrectly on iPhone X
>
>
> Key: CB-13737
> URL: https://issues.apache.org/jira/browse/CB-13737
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: jcesarmobile
>Assignee: jcesarmobile
> Labels: splashscreen
>
> When not using storyboard, the splash images are not correctly resized for
> iPhone X. So when it switches from the launch image to the splash image there
> is a noticeable change.
> Also, the landscape image is not displayed, it will show the portrait one.
> {code}
> width="1125" />
> src="res/screens/ios/Default-Landscape-2436h.png" width="2436" />
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13737) Splash screen images are resized incorrectly on iPhone X
jcesarmobile created CB-13737: - Summary: Splash screen images are resized incorrectly on iPhone X Key: CB-13737 URL: https://issues.apache.org/jira/browse/CB-13737 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-splashscreen Environment: iOS 11 / iPhone X Reporter: jcesarmobile CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into account, causing the image size to change when CDVLaunchScreen.storyboard transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13736) Project
Mihail Chirkov created CB-13736: --- Summary: Project Key: CB-13736 URL: https://issues.apache.org/jira/browse/CB-13736 Project: Apache Cordova Issue Type: Bug Reporter: Mihail Chirkov -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13244) Add LaunchImageFileCustom in .plist for work with multiples splashes in iOS projects
[ https://issues.apache.org/jira/browse/CB-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13244. - Resolution: Invalid There is no enough information to understand what the issue is, and wasn't provided after requesting it. Feel free to reopen if you can provide more details > Add LaunchImageFileCustom in .plist for work with multiples splashes in iOS > projects > > > Key: CB-13244 > URL: https://issues.apache.org/jira/browse/CB-13244 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-splashscreen >Affects Versions: cordova-ios@4.4.0 >Reporter: Adelmo Luiz de Freitas Junior >Priority: Minor > Labels: features > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13557) Not able to set splashscreen image
[
https://issues.apache.org/jira/browse/CB-13557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315247#comment-16315247
]
jcesarmobile commented on CB-13557:
---
Please, if there are 3 different issues, create 3 different issues, don't group
them in one.
Changed from blocker to major, blocker to you doesn't mean blocker for the
project. Most people will use the default storyboard, so it's not a blocker.
> Not able to set splashscreen image
> --
>
> Key: CB-13557
> URL: https://issues.apache.org/jira/browse/CB-13557
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
>Affects Versions: 4.0.0
> Environment: ios ; cordova-plugin-splashscreen-4.0.3;
> CDVSplashScreen.m
>Reporter: Krishna Mohan
> Labels: LaunchStoryboard,, UILaunchStoryboardImage,
> UILaunchStoryboardName, getImageName, ios, isUsingCDVLaunchScreen
> Fix For: 4.0.0
>
> Original Estimate: 9h
> Remaining Estimate: 9h
>
> Please refer:
> Defect: CB-9762 Launch Storyboard
> Issue-1
> getImageName function is checking for : isUsingCDVLaunchScreen.
> issue: it is checking for a string called 'CDVLaunchScreen'. What if i have a
> different storyboard name?
> Fix: read "UILaunchStoryboardName" from plist. Don't* try to validate if the
> value is "CDVLaunchScreen".
> {I can create any text file with name: CDVLaunchScreen & set it in
> UILaunchStoryboardName }
> Issue-2
> in getImageName fucntion, if "isUsingCDVLaunchScreen" is true, you are
> looking for a hardcoded "imageName"
> fix: read it from another flag in plist
> Ex:
> imageName = [[NSBundle mainBundle]
> objectForInfoDictionaryKey:@"UILaunchStoryboardImage"];
> if(!imageName) //if not set in plist
> imageName = @"LaunchStoryboard"; //set the default
> issue-3:
> As a fix for: CB-9762 Launch Storyboard, all that is being done is: reading
> the name from xcassetts.
> -->instead of fixing issue-1 & issue-2, set a flag "StoryboardImage" in
> plist, which is a image name.
> -->read the value, get the imagename from plist vriable. if mistakenly set as
> path in plist, handle it
> -->here u can read/check for default name in case as fallback
> Suggestion:
> If you want to make the system more robust,
> refer the below links.
> //i am android developer, no knowledge about ios coding.
> Basically, read the Storyboardname from plist, create an object from the
> string, then cast it to Storyboard Calss & then, try to get the id of
> resource(s) from storyboard.
> https://stackoverflow.com/questions/1174093/create-objective-c-class-instance-by-name
> id object = [[NSClassFromString(@"NameofClass") alloc] init];
> https://stackoverflow.com/questions/2055940/how-do-i-test-which-class-an-object-is-in-objective-c
> [yourObject isKindOfClass:[a class]]
> Ex:
> [myObject isKindOfClass:[NSString class]]
> [myObject isKindOfClass:[UIImageView class]]
> https://stackoverflow.com/questions/13708660/programmatically-get-a-storyboard-id
> NSString *restorationId = self.restorationIdentifier;
> https://stackoverflow.com/questions/13867565/what-is-a-storyboard-id-and-how-can-i-use-this
>MyCustomViewController *vc = [self.storyboard
> instantiateViewControllerWithIdentifier:@"MyViewController"];
> EX:
> https://stackoverflow.com/questions/24035984/instantiate-and-present-a-viewcontroller-in-swift
> UIStoryboard *storyboard = [UIStoryboard
> storyboardWithName:@"myStoryboardName" bundle:nil];
> UIViewController *vc = [storyboard
> instantiateViewControllerWithIdentifier:@"myVCID"];
> [self presentViewController:vc animated:YES completion:nil];
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13557) Not able to set splashscreen image
[
https://issues.apache.org/jira/browse/CB-13557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile updated CB-13557:
--
Priority: Major (was: Blocker)
> Not able to set splashscreen image
> --
>
> Key: CB-13557
> URL: https://issues.apache.org/jira/browse/CB-13557
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
>Affects Versions: 4.0.0
> Environment: ios ; cordova-plugin-splashscreen-4.0.3;
> CDVSplashScreen.m
>Reporter: Krishna Mohan
> Labels: LaunchStoryboard,, UILaunchStoryboardImage,
> UILaunchStoryboardName, getImageName, ios, isUsingCDVLaunchScreen
> Fix For: 4.0.0
>
> Original Estimate: 9h
> Remaining Estimate: 9h
>
> Please refer:
> Defect: CB-9762 Launch Storyboard
> Issue-1
> getImageName function is checking for : isUsingCDVLaunchScreen.
> issue: it is checking for a string called 'CDVLaunchScreen'. What if i have a
> different storyboard name?
> Fix: read "UILaunchStoryboardName" from plist. Don't* try to validate if the
> value is "CDVLaunchScreen".
> {I can create any text file with name: CDVLaunchScreen & set it in
> UILaunchStoryboardName }
> Issue-2
> in getImageName fucntion, if "isUsingCDVLaunchScreen" is true, you are
> looking for a hardcoded "imageName"
> fix: read it from another flag in plist
> Ex:
> imageName = [[NSBundle mainBundle]
> objectForInfoDictionaryKey:@"UILaunchStoryboardImage"];
> if(!imageName) //if not set in plist
> imageName = @"LaunchStoryboard"; //set the default
> issue-3:
> As a fix for: CB-9762 Launch Storyboard, all that is being done is: reading
> the name from xcassetts.
> -->instead of fixing issue-1 & issue-2, set a flag "StoryboardImage" in
> plist, which is a image name.
> -->read the value, get the imagename from plist vriable. if mistakenly set as
> path in plist, handle it
> -->here u can read/check for default name in case as fallback
> Suggestion:
> If you want to make the system more robust,
> refer the below links.
> //i am android developer, no knowledge about ios coding.
> Basically, read the Storyboardname from plist, create an object from the
> string, then cast it to Storyboard Calss & then, try to get the id of
> resource(s) from storyboard.
> https://stackoverflow.com/questions/1174093/create-objective-c-class-instance-by-name
> id object = [[NSClassFromString(@"NameofClass") alloc] init];
> https://stackoverflow.com/questions/2055940/how-do-i-test-which-class-an-object-is-in-objective-c
> [yourObject isKindOfClass:[a class]]
> Ex:
> [myObject isKindOfClass:[NSString class]]
> [myObject isKindOfClass:[UIImageView class]]
> https://stackoverflow.com/questions/13708660/programmatically-get-a-storyboard-id
> NSString *restorationId = self.restorationIdentifier;
> https://stackoverflow.com/questions/13867565/what-is-a-storyboard-id-and-how-can-i-use-this
>MyCustomViewController *vc = [self.storyboard
> instantiateViewControllerWithIdentifier:@"MyViewController"];
> EX:
> https://stackoverflow.com/questions/24035984/instantiate-and-present-a-viewcontroller-in-swift
> UIStoryboard *storyboard = [UIStoryboard
> storyboardWithName:@"myStoryboardName" bundle:nil];
> UIViewController *vc = [storyboard
> instantiateViewControllerWithIdentifier:@"myVCID"];
> [self presentViewController:vc animated:YES completion:nil];
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13628) Cached iOS LaunchStoryboard image displayed before updated LaunchStoryboard image.
[ https://issues.apache.org/jira/browse/CB-13628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13628. - Resolution: Won't Fix As far as I know this only happens when the apps are installed from Xcode, so it shouldn't happen on production apps. Anyway, the one that caches the image is the device, there is nothing we can do about it, it also happens in native apps. So closing as won't fix. The only workaround is to use a different image name. > Cached iOS LaunchStoryboard image displayed before updated LaunchStoryboard > image. > --- > > Key: CB-13628 > URL: https://issues.apache.org/jira/browse/CB-13628 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen >Affects Versions: cordova-ios 4.5.0 > Environment: iOS >Reporter: Ivy Nye >Priority: Minor > > If an old launch storyboard image is cached on the device, it is displayed on > launch and then fades to the current LaunchStoryboard image. > *Steps:* > 1. Deploy to iOS with LaunchStoryboard set to image1. > 2. Change LaunchStoryboard to image2 and redeploy. > 3. See image1, followed by a quick fade to image2. > _Resetting the device will clear this cache, but we cannot expect this from > users._ > I have found that removing the LaunchStoryboard Image View form > CDVLaunchScreen.storyboard will prevent this image from being cached, and it > will still display after the initial view transition. > Also, a background color can be set on the initial view which will not be > cached. It may be useful to be able to set the backgroundColor of the > storyboard via config.xml. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315242#comment-16315242 ] jcesarmobile commented on CB-13396: --- [~kenmickles] can you provide your config.xml or something helpful to reproduce and see if this is already fixed or not? (as some comments claim in the PR) > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315239#comment-16315239 ] ASF GitHub Bot commented on CB-13396: - jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355820652 People here is talking about 2 different issues, this one is about incorrect sizing when transitioning from the storyboard to the plugin screen and seems to be fixed, so this PR might not be necessary. The other problem is not reported (or I couldn't find it), but splash screen doesn't work fine on iPhone X when NOT using storyboard, I'm about to report it and fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen images are resized incorrectly on iPhone X > > > Key: CB-13396 > URL: https://issues.apache.org/jira/browse/CB-13396 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen > Environment: iOS 11 / iPhone X >Reporter: Ken Mickles > Labels: splashscreen > > CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into > account, causing the image size to change when CDVLaunchScreen.storyboard > transitions to the CDVSplashScreen image. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
