[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326842#comment-16326842 ] ASF GitHub Bot commented on CB-13415: - alpesh12 opened a new pull request #309: CB-13415 (android) Importing corrupt images using the Camera plugin c… URL: https://github.com/apache/cordova-plugin-camera/pull/309 ### Platforms affected Android ### What does this PR do? - Throws an exception which can be caught by the error block in Cordova app which uses the plugin - Does not crash the Cordova app which uses the plugin with corrupted image ### What testing has been done on this change? Tested with cordova-android 7.0.0 ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13773) camera.getPicture returns error code 20
[
https://issues.apache.org/jira/browse/CB-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326791#comment-16326791
]
Bob Myers commented on CB-13773:
[~bowserj] Thanks. This problem magically went away. We'll close it.
> camera.getPicture returns error code 20
> ---
>
> Key: CB-13773
> URL: https://issues.apache.org/jira/browse/CB-13773
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
> Environment: Android platform
>Reporter: Bob Myers
>Priority: Major
>
> A call to `camera.getPicture` returns an error code of "20". This occurs on
> the Android platform. Things work fine on the browser platform.
> This error started suddenly a few days ago, and I cannot identify anything
> specific I did that might have caused it.
> It's very hard for me to present a reproducible case, since this is occurring
> in the context of large app, but I will try to reproduce in a sample app if
> there's no alternative. Meanwhile, I'm posting this issue in the hope that
> someone might know what an error 20 is supposed to mean.
> In case it matters, it strikes me as odd that the device is not asking me for
> access for the camera when I install the app, nor when I try to take the
> first picture.
> This happens on different devices, including Nougat and Oreo. It happens with
> different versions of the camera plugins. What is especially puzzling to me
> is that it happens with a build of my app from a version three months ago,
> even though that application works fine in the field.
> cordova-android version is 6.2.1. Cordova CLI version is 8.0.0.
> Here is some relevant code:
> {code}
> function getPicture(cameraOptions: CameraOptions): Promise {
> const {camera} = navigator;
> if (!camera) throw new Error("missing camera in
> cordova-plugin-camera.util");
> return new Promise((resolve, reject) => camera.getPicture(resolve, reject,
> cameraOptions));
> }
> // Get a picture from the camera, returning a promise for the URL on the
> device.
> private async getPictureCordova(library): Promise {
> const destinationType = isPlatformWindows() ?
> Camera.DestinationType.DATA_URL : Camera.DestinationType.FILE_URI;
> const sourceType = library ? Camera.PictureSourceType.PHOTOLIBRARY :
> Camera.PictureSourceType.CAMERA;
> const cameraOptions: CameraOptions = {
> quality: 50,
> destinationType,
> sourceType,
> allowEdit : false,
> targetWidth: 1280,
> // targetHeight: 960,
> correctOrientation: true,
> saveToPhotoAlbum: false,
> mediaType: Camera.MediaType.PICTURE, // applies only in case of
> library
> };
> this.reset();
> return await getPicture(cameraOptions);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13773) camera.getPicture returns error code 20
[
https://issues.apache.org/jira/browse/CB-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Myers resolved CB-13773.
Resolution: Cannot Reproduce
> camera.getPicture returns error code 20
> ---
>
> Key: CB-13773
> URL: https://issues.apache.org/jira/browse/CB-13773
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
> Environment: Android platform
>Reporter: Bob Myers
>Priority: Major
>
> A call to `camera.getPicture` returns an error code of "20". This occurs on
> the Android platform. Things work fine on the browser platform.
> This error started suddenly a few days ago, and I cannot identify anything
> specific I did that might have caused it.
> It's very hard for me to present a reproducible case, since this is occurring
> in the context of large app, but I will try to reproduce in a sample app if
> there's no alternative. Meanwhile, I'm posting this issue in the hope that
> someone might know what an error 20 is supposed to mean.
> In case it matters, it strikes me as odd that the device is not asking me for
> access for the camera when I install the app, nor when I try to take the
> first picture.
> This happens on different devices, including Nougat and Oreo. It happens with
> different versions of the camera plugins. What is especially puzzling to me
> is that it happens with a build of my app from a version three months ago,
> even though that application works fine in the field.
> cordova-android version is 6.2.1. Cordova CLI version is 8.0.0.
> Here is some relevant code:
> {code}
> function getPicture(cameraOptions: CameraOptions): Promise {
> const {camera} = navigator;
> if (!camera) throw new Error("missing camera in
> cordova-plugin-camera.util");
> return new Promise((resolve, reject) => camera.getPicture(resolve, reject,
> cameraOptions));
> }
> // Get a picture from the camera, returning a promise for the URL on the
> device.
> private async getPictureCordova(library): Promise {
> const destinationType = isPlatformWindows() ?
> Camera.DestinationType.DATA_URL : Camera.DestinationType.FILE_URI;
> const sourceType = library ? Camera.PictureSourceType.PHOTOLIBRARY :
> Camera.PictureSourceType.CAMERA;
> const cameraOptions: CameraOptions = {
> quality: 50,
> destinationType,
> sourceType,
> allowEdit : false,
> targetWidth: 1280,
> // targetHeight: 960,
> correctOrientation: true,
> saveToPhotoAlbum: false,
> mediaType: Camera.MediaType.PICTURE, // applies only in case of
> library
> };
> this.reset();
> return await getPicture(cameraOptions);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13190) Potential unreleased resources (HP Fortify SCA: Unreleased Resource: Streams)
[
https://issues.apache.org/jira/browse/CB-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Bowser updated CB-13190:
Security: (was: Non-Public)
Not all HP Fortify scans are Security errors, some are just bugs. Removing the
private bit from this issue.
> Potential unreleased resources (HP Fortify SCA: Unreleased Resource: Streams)
> -
>
> Key: CB-13190
> URL: https://issues.apache.org/jira/browse/CB-13190
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-plugin-file,
> cordova-plugin-file-transfer (DEPRECATED)
>Reporter: GSS FED
>Assignee: Joe Bowser
>Priority: Major
>
> Similar issue: [https://issues.apache.org/jira/browse/CB-8253]
> There are several places in the File plugin, File Transfer plugin and
> cordova-android where streams do not use try { fis.closed } catch
> (IOException e) {} in a finally block allowing for the possibility they will
> never be closed if an exception occurs at the wrong place.
> Affected files:
> cordova-android/~CordovaResourceApi.java: line: 166, 377
> cordova-plugin-file/~Filesystem.java: line: 253, 286
> cordova-plugin-file-transfer/~FileTransfer.java: line: 665
> cordova-plugin-file/~LocalFilesystem.java: line: 403, 461, 507
> Recommendations of Fortify:
> {code:java}
> public void processFile(String fName) throws FileNotFoundException,
> IOException {
> FileInputStream fis;
> try {
> fis = new FileInputStream(fName);
> int sz;
> byte[] byteArray = new byte[BLOCK_SIZE];
> while ((sz = fis.read(byteArray)) != -1) { processBytes(byteArray, sz); }
> } finally {
> if (fis != null) {
> safeClose(fis);
> }
> }
> }
> public static void safeClose(FileInputStream fis) {
> if (fis != null) {
> try {
> fis.close();
> } catch (IOException e) {
> log(e);
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13772) CLI `cordova requirements` printing out [object Object] in place of some version numbers
[
https://issues.apache.org/jira/browse/CB-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Bowser updated CB-13772:
Component/s: (was: cordova-cli)
cordova-ios
> CLI `cordova requirements` printing out [object Object] in place of some
> version numbers
>
>
> Key: CB-13772
> URL: https://issues.apache.org/jira/browse/CB-13772
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova@8.0.0
> Environment: macOS High Sierra 10.13.2
> npm v5.6.0
> node v9.4.0
> cordova CLI v8.0.0
>Reporter: Darcy Meyer
>Priority: Minor
>
> When `cordova requirements` is executed, the output prints [object Object]
> in place of some of the version numbers.
> e.g.
> {code}
> $ cordova requirements
> Android Studio project detected
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: not installed
> avdmanager: Command failed with exit code 1
> Gradle: not installed
> Could not find an installed version of Gradle either in Android Studio,
> or on your system to install the gradle wrapper. Please include gradle
> in your path, or install Android Studio
> Requirements check results for ios:
> Apple macOS: installed darwin
> Xcode: installed [object Object]
> ios-deploy: installed [object Object]
> CocoaPods: installed [object Object]
> {code}
> Here, the versions of the ios requirements are not displayed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13773) camera.getPicture returns error code 20
[
https://issues.apache.org/jira/browse/CB-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326624#comment-16326624
]
Joe Bowser commented on CB-13773:
-
I would recommend trying it on a standalone Camera app. I don't know what
Error Code 20 means on your device, but if you're not seeing any permission,
maybe the permission was denied too many times and it decided to just give up
and deny it, which is something Android can do. That said, it should handle
that case a lot better than just showing "20".
> camera.getPicture returns error code 20
> ---
>
> Key: CB-13773
> URL: https://issues.apache.org/jira/browse/CB-13773
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
> Environment: Android platform
>Reporter: Bob Myers
>Priority: Major
>
> A call to `camera.getPicture` returns an error code of "20". This occurs on
> the Android platform. Things work fine on the browser platform.
> This error started suddenly a few days ago, and I cannot identify anything
> specific I did that might have caused it.
> It's very hard for me to present a reproducible case, since this is occurring
> in the context of large app, but I will try to reproduce in a sample app if
> there's no alternative. Meanwhile, I'm posting this issue in the hope that
> someone might know what an error 20 is supposed to mean.
> In case it matters, it strikes me as odd that the device is not asking me for
> access for the camera when I install the app, nor when I try to take the
> first picture.
> This happens on different devices, including Nougat and Oreo. It happens with
> different versions of the camera plugins. What is especially puzzling to me
> is that it happens with a build of my app from a version three months ago,
> even though that application works fine in the field.
> cordova-android version is 6.2.1. Cordova CLI version is 8.0.0.
> Here is some relevant code:
> {code}
> function getPicture(cameraOptions: CameraOptions): Promise {
> const {camera} = navigator;
> if (!camera) throw new Error("missing camera in
> cordova-plugin-camera.util");
> return new Promise((resolve, reject) => camera.getPicture(resolve, reject,
> cameraOptions));
> }
> // Get a picture from the camera, returning a promise for the URL on the
> device.
> private async getPictureCordova(library): Promise {
> const destinationType = isPlatformWindows() ?
> Camera.DestinationType.DATA_URL : Camera.DestinationType.FILE_URI;
> const sourceType = library ? Camera.PictureSourceType.PHOTOLIBRARY :
> Camera.PictureSourceType.CAMERA;
> const cameraOptions: CameraOptions = {
> quality: 50,
> destinationType,
> sourceType,
> allowEdit : false,
> targetWidth: 1280,
> // targetHeight: 960,
> correctOrientation: true,
> saveToPhotoAlbum: false,
> mediaType: Camera.MediaType.PICTURE, // applies only in case of
> library
> };
> this.reset();
> return await getPicture(cameraOptions);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13775) cordova-android@6.2.3 failed with android-versionCode="19"
[ https://issues.apache.org/jira/browse/CB-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-13775. - Resolution: Won't Fix This appears to be an issue with the npm modules that you have installed. Try doing an npm install to fix your npm setup. dezalgo is used by node, which is what the installation scripts are all written in. I don't think changing the Android SDK had anything to do with the issue that you're currently getting. > cordova-android@6.2.3 failed with android-versionCode="19" > -- > > Key: CB-13775 > URL: https://issues.apache.org/jira/browse/CB-13775 > Project: Apache Cordova > Issue Type: Bug >Reporter: Barry Fawthrop >Priority: Major > > using cordova-android@6.2.3 > with >"cordova-plugin-device": "2.0.1", > "cordova-plugin-file": "4.3.3", > "cordova-plugin-geolocation": "2.4.3", > "cordova-plugin-media": "2.4.1", > if I set in config.xml > it trys to use Android SDK 19 which is good But failed with > npm ERR! path > /Users/Barry/Desktop/Rolling/rsmobile/node_modules/npm/node_modules/dezalgo > npm ERR! code ENOENT > npm ERR! errno -2 > npm ERR! syscall rename > npm ERR! enoent ENOENT: no such file or directory, rename > '/Users/Barry/demo/node_modules/npm/node_modules/dezalgo' -> > '/Users/Barry/demo/node_modules/npm/node_modules/.dezalgo.DELETE' > npm ERR! enoent This is related to npm not being able to find a file. > npm ERR! enoent > npm ERR! A complete log of this run can be found in: > How is cordova-androidtied to dezalgo ? > Thanks in advance -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-10950) Phonegap app in the background when capture and select image for gallery app stop/restart.
[ https://issues.apache.org/jira/browse/CB-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-10950. - Resolution: Workaround If onResume isn't being fired, that would be a different issue than the previous issue. I'd recommend filing a new issue on this. The main issue is already known, and a work-around has already been written and documented, so I'm going to close thus one off. > Phonegap app in the background when capture and select image for gallery app > stop/restart. > --- > > Key: CB-10950 > URL: https://issues.apache.org/jira/browse/CB-10950 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: 5.0.1 >Reporter: Lokesh Patel >Priority: Major > Labels: android, triaged, wfc > > Hi, > In android application when the user tries for capturing images and select > image from gallery app stop/restart. > I found below details after search lots of google and forums: > " The Phonegap (Cordova) Camera Plugin calls the native camera and this makes > Android Garbage Collector to kill background applications." > Thanks, > Lokesh Patel -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13739) Android build is broken due to libraries with text relocations
[ https://issues.apache.org/jira/browse/CB-13739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326616#comment-16326616 ] Joe Bowser commented on CB-13739: - Have you tested this on any device that's not a Samsung Galaxy Tab? > Android build is broken due to libraries with text relocations > -- > > Key: CB-13739 > URL: https://issues.apache.org/jira/browse/CB-13739 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 > Environment: Build systems: Ubuntu Linux and PhoneGap Build > Android versions: 5.0.2 and 7.1.2 >Reporter: Alexander Tchitchigin >Assignee: Joe Bowser >Priority: Major > Attachments: photo_2018-01-08_12-25-17.jpg > > > When I build an Android app and run it on a device I get the result in the > screenshot: there are a number of libraries with text relocations that > Android refuses to load hence the application is broken and doesn't work. > Release build refuses to start at all. > Before updating Cordova and Android SDK everything worked OK, I was able to > build and run the app and previous version is published to Google Play. But I > didn't memorize the version number when it all worked, unfortunately. App > code was updated either but I don't see how updated JS, CSS and images could > make Cordova link with new libraries with relocations. > Cordova behaves the same to me both locally with the latest version (cordova > 8.0.0, android 7.0.0) and in PhoneGap Build. > I'd like to know the right build settings to produce working build or at > least some workaround. I tried to play with cdvBuildToolsVersion and > cdvCompileSdkVersion but had no success. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13779) Apache Cordova 8.0.0 not building Android Apps but only prints Android and Java Paths
[
https://issues.apache.org/jira/browse/CB-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326614#comment-16326614
]
Joe Bowser commented on CB-13779:
-
What happens when you rip out the third party plugins on your project, like
TTS, Barcode Scanner and Document Viewer?
> Apache Cordova 8.0.0 not building Android Apps but only prints Android and
> Java Paths
> -
>
> Key: CB-13779
> URL: https://issues.apache.org/jira/browse/CB-13779
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Environment: I am trying to build a Cordova app with few plugins
> ([InAppBrowser|https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-inappbrowser/],
> [Barcode
> Scanner|https://github.com/phonegap/phonegap-plugin-barcodescanner], [File
> Transfer|https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-file-transfer/index.html],
> [Text-to-Speech|https://github.com/vilic/cordova-plugin-tts], [Document
> Viewer|https://github.com/sitewaerts/cordova-plugin-document-viewer],
> [GeoLocation|https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-geolocation/index.html]).
>
> OS: MacOS High Sierra (10.13.2)
> Cordova version 8.0.0
> Android {{cordova-android@~7.0.0}}
> Android Studio 3.0.1
>
>Reporter: Sumit Soman
>Assignee: Joe Bowser
>Priority: Major
>
> When I run {{cordova build android}} it only shows the {{ANDROID_HOME}} and
> {{JAVA_HOME}} paths but does not build the Android Studio project.
> [!https://i.stack.imgur.com/l7Qat.png!|https://i.stack.imgur.com/l7Qat.png]
> I am using Cordova version 8.0.0 and Android {{cordova-android@~7.0.0}}
> Building in the verbose mode gives the following messages
> [!https://i.stack.imgur.com/rLMSv.png!|https://i.stack.imgur.com/rLMSv.png]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13781) Error requesting permission on Android 8 - Save on photo album issue
[ https://issues.apache.org/jira/browse/CB-13781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-13781. - Resolution: Fixed Tested, able to reproduce issue. Tested PR, accepted PR as fixing the issue. Will be the next version of the plugin. > Error requesting permission on Android 8 - Save on photo album issue > > > Key: CB-13781 > URL: https://issues.apache.org/jira/browse/CB-13781 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Rubén Panadero >Priority: Critical > > Google has changed how an android application must request permissions on > Android 8. In fact, it is considered as fix by Google due to a wrong behavior > on previous versions. > Related documentation: > [https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp] > This change made by Google has affected the cordova-camera-plugin. To save a > photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE > permission right now, but that is not enough on Android 8 because the plugin > writes the photo file into Pictures folder so it has to request the writing > permission, which is missing, as well. > This is the error that the plugin throws when a photo is tried to be saved > into the photo album on Android 8. > > 01-12 11:38:16.757 W/System.err(22321): java.io.FileNotFoundException: open > > failed: EACCES (Permission denied) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.openInternal(ParcelFileDescriptor.java:313) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.open(ParcelFileDescriptor.java:211) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1242) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:1007) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:983) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:979) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:1015) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.processResultFromCamera(CameraLauncher.java:603) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.onActivityResult(CameraLauncher.java:919) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:152) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:358) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.Activity.dispatchActivityResult(Activity.java:7235) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.deliverResults(ActivityThread.java:4336) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.handleSendResult(ActivityThread.java:4383) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.-wrap19(Unknown Source:0) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread$H.handleMessage(ActivityThread.java:1652) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.Handler.dispatchMessage(Handler.java:105) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.Looper.loop(Looper.java:164) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.main(ActivityThread.java:6600) > > 01-12 11:38:16.758 W/System.err(22321): at > > java.lang.reflect.Method.invoke(Native Method) > > 01-12 11:38:16.758 W/System.err(22321): at > > com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) > > 01-12 11:38:16.758 W/System.err(22321): at > > com.android.internal.os.ZygoteInit.main(ZygoteInit.java:772) > To sum up, if the plugin has to save a photo in the photo album, this one has > to request both READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE permissions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13781) Error requesting permission on Android 8 - Save on photo album issue
[
https://issues.apache.org/jira/browse/CB-13781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326597#comment-16326597
]
ASF GitHub Bot commented on CB-13781:
-
infil00p closed pull request #308: CB-13781: (android) Fixed permissions
request on Android 8 to save a …
URL: https://github.com/apache/cordova-plugin-camera/pull/308
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/android/CameraLauncher.java b/src/android/CameraLauncher.java
index 0f9b4b0c..a8e6fc43 100644
--- a/src/android/CameraLauncher.java
+++ b/src/android/CameraLauncher.java
@@ -113,7 +113,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean orientationCorrected; // Has the picture's orientation
been corrected
private boolean allowEdit; // Should we allow the user to
crop the image.
-protected final static String[] permissions = {
Manifest.permission.CAMERA, Manifest.permission.READ_EXTERNAL_STORAGE };
+protected final static String[] permissions = {
Manifest.permission.CAMERA, Manifest.permission.READ_EXTERNAL_STORAGE,
Manifest.permission.WRITE_EXTERNAL_STORAGE };
public CallbackContext callbackContext;
private int numPics;
@@ -245,7 +245,8 @@ private String getTempDirectoryPath() {
* @param encodingType Compression quality hint (0-100: 0=low
quality & high compression, 100=compress of max quality)
*/
public void callTakePicture(int returnType, int encodingType) {
-boolean saveAlbumPermission = PermissionHelper.hasPermission(this,
Manifest.permission.READ_EXTERNAL_STORAGE);
+boolean saveAlbumPermission = PermissionHelper.hasPermission(this,
Manifest.permission.READ_EXTERNAL_STORAGE)
+&& PermissionHelper.hasPermission(this,
Manifest.permission.WRITE_EXTERNAL_STORAGE);
boolean takePicturePermission = PermissionHelper.hasPermission(this,
Manifest.permission.CAMERA);
// CB-10120: The CAMERA permission does not need to be requested
unless it is declared
@@ -276,7 +277,8 @@ public void callTakePicture(int returnType, int
encodingType) {
} else if (saveAlbumPermission && !takePicturePermission) {
PermissionHelper.requestPermission(this, TAKE_PIC_SEC,
Manifest.permission.CAMERA);
} else if (!saveAlbumPermission && takePicturePermission) {
-PermissionHelper.requestPermission(this, TAKE_PIC_SEC,
Manifest.permission.READ_EXTERNAL_STORAGE);
+PermissionHelper.requestPermissions(this, TAKE_PIC_SEC,
+new String[]{Manifest.permission.READ_EXTERNAL_STORAGE,
Manifest.permission.WRITE_EXTERNAL_STORAGE});
} else {
PermissionHelper.requestPermissions(this, TAKE_PIC_SEC,
permissions);
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Error requesting permission on Android 8 - Save on photo album issue
>
>
> Key: CB-13781
> URL: https://issues.apache.org/jira/browse/CB-13781
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Reporter: Rubén Panadero
>Priority: Critical
>
> Google has changed how an android application must request permissions on
> Android 8. In fact, it is considered as fix by Google due to a wrong behavior
> on previous versions.
> Related documentation:
> [https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp]
> This change made by Google has affected the cordova-camera-plugin. To save a
> photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE
> permission right now, but that is not enough on Android 8 because the plugin
> writes the photo file into Pictures folder so it has to request the writing
> permission, which is missing, as well.
> This is the error that the plugin throws when a photo is tried to be saved
> into the photo album on Android 8.
> > 01-12 11:38:16.757 W/System.err(22321): java.io.FileNotFoundException: open
> > failed: EACCES (Permission denied)
> > 01-12 11:38:16.758 W/System.err(22321): at
> > android.os.ParcelFileDescriptor.openInternal(ParcelFileDescriptor.java:313)
> > 01-12 11:38:16.758 W/System.err(22321): at
> > android.os.ParcelFileDescriptor.open(ParcelFileDescriptor.java:211)
> > 01-12 11:38:16.758 W/System.err(22321): at
>
[jira] [Commented] (CB-13781) Error requesting permission on Android 8 - Save on photo album issue
[ https://issues.apache.org/jira/browse/CB-13781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326599#comment-16326599 ] ASF subversion and git services commented on CB-13781: -- Commit 4b99623edab1ab0cbfc3faa98e5f966fa9b3ca19 in cordova-plugin-camera's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=4b99623 ] Merge pull request #308 from okode/android8_permission_request_fix CB-13781: (android) Fixed permissions request on Android 8 to save a … > Error requesting permission on Android 8 - Save on photo album issue > > > Key: CB-13781 > URL: https://issues.apache.org/jira/browse/CB-13781 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Rubén Panadero >Priority: Critical > > Google has changed how an android application must request permissions on > Android 8. In fact, it is considered as fix by Google due to a wrong behavior > on previous versions. > Related documentation: > [https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp] > This change made by Google has affected the cordova-camera-plugin. To save a > photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE > permission right now, but that is not enough on Android 8 because the plugin > writes the photo file into Pictures folder so it has to request the writing > permission, which is missing, as well. > This is the error that the plugin throws when a photo is tried to be saved > into the photo album on Android 8. > > 01-12 11:38:16.757 W/System.err(22321): java.io.FileNotFoundException: open > > failed: EACCES (Permission denied) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.openInternal(ParcelFileDescriptor.java:313) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.open(ParcelFileDescriptor.java:211) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1242) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:1007) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:983) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:979) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:1015) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.processResultFromCamera(CameraLauncher.java:603) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.onActivityResult(CameraLauncher.java:919) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:152) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:358) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.Activity.dispatchActivityResult(Activity.java:7235) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.deliverResults(ActivityThread.java:4336) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.handleSendResult(ActivityThread.java:4383) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.-wrap19(Unknown Source:0) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread$H.handleMessage(ActivityThread.java:1652) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.Handler.dispatchMessage(Handler.java:105) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.Looper.loop(Looper.java:164) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.main(ActivityThread.java:6600) > > 01-12 11:38:16.758 W/System.err(22321): at > > java.lang.reflect.Method.invoke(Native Method) > > 01-12 11:38:16.758 W/System.err(22321): at > > com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) > > 01-12 11:38:16.758 W/System.err(22321): at > > com.android.internal.os.ZygoteInit.main(ZygoteInit.java:772) > To sum up, if the plugin has to save a photo in the photo album, this one has > to request both READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE permissions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail:
[jira] [Commented] (CB-13781) Error requesting permission on Android 8 - Save on photo album issue
[ https://issues.apache.org/jira/browse/CB-13781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326598#comment-16326598 ] ASF subversion and git services commented on CB-13781: -- Commit 36ea63a60f98a8a93e5277f054fea16a2b676e6a in cordova-plugin-camera's branch refs/heads/master from [~rpanadero] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=36ea63a ] CB-13781: (android) Fixed permissions request on Android 8 to save a photo into the photo album > Error requesting permission on Android 8 - Save on photo album issue > > > Key: CB-13781 > URL: https://issues.apache.org/jira/browse/CB-13781 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Rubén Panadero >Priority: Critical > > Google has changed how an android application must request permissions on > Android 8. In fact, it is considered as fix by Google due to a wrong behavior > on previous versions. > Related documentation: > [https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp] > This change made by Google has affected the cordova-camera-plugin. To save a > photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE > permission right now, but that is not enough on Android 8 because the plugin > writes the photo file into Pictures folder so it has to request the writing > permission, which is missing, as well. > This is the error that the plugin throws when a photo is tried to be saved > into the photo album on Android 8. > > 01-12 11:38:16.757 W/System.err(22321): java.io.FileNotFoundException: open > > failed: EACCES (Permission denied) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.openInternal(ParcelFileDescriptor.java:313) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.open(ParcelFileDescriptor.java:211) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1242) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:1007) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:983) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:979) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:1015) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.processResultFromCamera(CameraLauncher.java:603) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.onActivityResult(CameraLauncher.java:919) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:152) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:358) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.Activity.dispatchActivityResult(Activity.java:7235) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.deliverResults(ActivityThread.java:4336) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.handleSendResult(ActivityThread.java:4383) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.-wrap19(Unknown Source:0) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread$H.handleMessage(ActivityThread.java:1652) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.Handler.dispatchMessage(Handler.java:105) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.Looper.loop(Looper.java:164) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.main(ActivityThread.java:6600) > > 01-12 11:38:16.758 W/System.err(22321): at > > java.lang.reflect.Method.invoke(Native Method) > > 01-12 11:38:16.758 W/System.err(22321): at > > com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) > > 01-12 11:38:16.758 W/System.err(22321): at > > com.android.internal.os.ZygoteInit.main(ZygoteInit.java:772) > To sum up, if the plugin has to save a photo in the photo album, this one has > to request both READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE permissions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13781) Error requesting permission on Android 8 - Save on photo album issue
[ https://issues.apache.org/jira/browse/CB-13781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326587#comment-16326587 ] ASF GitHub Bot commented on CB-13781: - infil00p commented on issue #308: CB-13781: (android) Fixed permissions request on Android 8 to save a … URL: https://github.com/apache/cordova-plugin-camera/pull/308#issuecomment-357795338 Not sure why iOS failed, since you didn't touch it, but yeah, this looks good to me and I can repo the bug, so I'll merge this in once I test locally. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Error requesting permission on Android 8 - Save on photo album issue > > > Key: CB-13781 > URL: https://issues.apache.org/jira/browse/CB-13781 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Rubén Panadero >Priority: Critical > > Google has changed how an android application must request permissions on > Android 8. In fact, it is considered as fix by Google due to a wrong behavior > on previous versions. > Related documentation: > [https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp] > This change made by Google has affected the cordova-camera-plugin. To save a > photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE > permission right now, but that is not enough on Android 8 because the plugin > writes the photo file into Pictures folder so it has to request the writing > permission, which is missing, as well. > This is the error that the plugin throws when a photo is tried to be saved > into the photo album on Android 8. > > 01-12 11:38:16.757 W/System.err(22321): java.io.FileNotFoundException: open > > failed: EACCES (Permission denied) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.openInternal(ParcelFileDescriptor.java:313) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.open(ParcelFileDescriptor.java:211) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1242) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:1007) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:983) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:979) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:1015) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.processResultFromCamera(CameraLauncher.java:603) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.onActivityResult(CameraLauncher.java:919) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:152) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:358) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.Activity.dispatchActivityResult(Activity.java:7235) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.deliverResults(ActivityThread.java:4336) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.handleSendResult(ActivityThread.java:4383) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.-wrap19(Unknown Source:0) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread$H.handleMessage(ActivityThread.java:1652) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.Handler.dispatchMessage(Handler.java:105) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.Looper.loop(Looper.java:164) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.main(ActivityThread.java:6600) > > 01-12 11:38:16.758 W/System.err(22321): at > > java.lang.reflect.Method.invoke(Native Method) > > 01-12 11:38:16.758 W/System.err(22321): at > > com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) > > 01-12 11:38:16.758 W/System.err(22321): at > > com.android.internal.os.ZygoteInit.main(ZygoteInit.java:772) > To sum up, if the plugin has to save a photo in the photo album, this one has > to
[jira] [Closed] (CB-13745) Add build-tools-26.0.2 to travis for Android tests
[ https://issues.apache.org/jira/browse/CB-13745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13745. - Resolution: Fixed All the subtasks are resolved or closed, closing the father issue > Add build-tools-26.0.2 to travis for Android tests > -- > > Key: CB-13745 > URL: https://issues.apache.org/jira/browse/CB-13745 > Project: Apache Cordova > Issue Type: Bug >Reporter: jcesarmobile >Priority: Major > > Android tests are failing in plugins because of unaccepted licenses, to fix > it we have to add build-tools-26.0.2 to the travis.yml for all plugins -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13759) Add build-tools-26.0.2 to travis for cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326499#comment-16326499 ] ASF subversion and git services commented on CB-13759: -- Commit af2a5183684f2d204db951fd65a2f470f7ecfa8e in cordova-plugin-contacts's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=af2a518 ] CB-13759: Add build-tools-26.0.2 to travis > Add build-tools-26.0.2 to travis for cordova-plugin-contacts > > > Key: CB-13759 > URL: https://issues.apache.org/jira/browse/CB-13759 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13759) Add build-tools-26.0.2 to travis for cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326501#comment-16326501 ] ASF subversion and git services commented on CB-13759: -- Commit dd2d29d36dbad9cfb9867102ac62739c6c239e34 in cordova-plugin-contacts's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=dd2d29d ] Merge pull request #164 from jcesarmobile/CB-13759 CB-13759: Add build-tools-26.0.2 to travis > Add build-tools-26.0.2 to travis for cordova-plugin-contacts > > > Key: CB-13759 > URL: https://issues.apache.org/jira/browse/CB-13759 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13759) Add build-tools-26.0.2 to travis for cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile resolved CB-13759. --- Resolution: Fixed Assignee: jcesarmobile > Add build-tools-26.0.2 to travis for cordova-plugin-contacts > > > Key: CB-13759 > URL: https://issues.apache.org/jira/browse/CB-13759 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13759) Add build-tools-26.0.2 to travis for cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326498#comment-16326498 ] ASF GitHub Bot commented on CB-13759: - jcesarmobile closed pull request #164: CB-13759: Add build-tools-26.0.2 to travis URL: https://github.com/apache/cordova-plugin-contacts/pull/164 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 70ebd8d..f49e1c1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,6 +25,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 - env: PLATFORM=android-5.1 os: linux language: android @@ -32,6 +33,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 - env: PLATFORM=android-6.0 os: linux language: android @@ -39,6 +41,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 - env: PLATFORM=android-7.0 os: linux language: android @@ -46,6 +49,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 before_install: - rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build-tools-26.0.2 to travis for cordova-plugin-contacts > > > Key: CB-13759 > URL: https://issues.apache.org/jira/browse/CB-13759 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13759) Add build-tools-26.0.2 to travis for cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326500#comment-16326500 ] ASF subversion and git services commented on CB-13759: -- Commit dd2d29d36dbad9cfb9867102ac62739c6c239e34 in cordova-plugin-contacts's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=dd2d29d ] Merge pull request #164 from jcesarmobile/CB-13759 CB-13759: Add build-tools-26.0.2 to travis > Add build-tools-26.0.2 to travis for cordova-plugin-contacts > > > Key: CB-13759 > URL: https://issues.apache.org/jira/browse/CB-13759 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13784) Broken tests on cordova-plugin-media
[ https://issues.apache.org/jira/browse/CB-13784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13784: -- Component/s: (was: cordova-plugin-file) cordova-plugin-media > Broken tests on cordova-plugin-media > > > Key: CB-13784 > URL: https://issues.apache.org/jira/browse/CB-13784 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic, cordova-plugin-media >Reporter: jcesarmobile >Assignee: Jesse MacFadyen >Priority: Major > > The tests of cordova-plugin-file for browser-safari and android are failing. > Other platforms are ok. > There are multiple specs failing > See > [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711|https://travis-ci.org/apache/cordova-plugin-media/builds/327034161] > for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13784) Broken tests on cordova-plugin-media
[ https://issues.apache.org/jira/browse/CB-13784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13784: -- Description: The tests of cordova-plugin-file for browser-safari and android are failing. Other platforms are ok. There are multiple specs failing See https://travis-ci.org/apache/cordova-plugin-media/builds/327034161 for reference was: The tests of cordova-plugin-file for browser-safari and android are failing. Other platforms are ok. There are multiple specs failing See [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711|https://travis-ci.org/apache/cordova-plugin-media/builds/327034161] for reference > Broken tests on cordova-plugin-media > > > Key: CB-13784 > URL: https://issues.apache.org/jira/browse/CB-13784 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic, cordova-plugin-media >Reporter: jcesarmobile >Assignee: Jesse MacFadyen >Priority: Major > > The tests of cordova-plugin-file for browser-safari and android are failing. > Other platforms are ok. > There are multiple specs failing > See https://travis-ci.org/apache/cordova-plugin-media/builds/327034161 for > reference -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13784) Broken tests on cordova-plugin-media
[ https://issues.apache.org/jira/browse/CB-13784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13784: -- Description: The tests of cordova-plugin-file for browser-safari and android are failing. Other platforms are ok. There are multiple specs failing See [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711|https://travis-ci.org/apache/cordova-plugin-media/builds/327034161] for reference was: The tests of cordova-plugin-file for browser-safari are failing. Other platforms are ok. There are multiple specs failing See [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711] for reference > Broken tests on cordova-plugin-media > > > Key: CB-13784 > URL: https://issues.apache.org/jira/browse/CB-13784 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic, cordova-plugin-file >Reporter: jcesarmobile >Assignee: Jesse MacFadyen >Priority: Major > > The tests of cordova-plugin-file for browser-safari and android are failing. > Other platforms are ok. > There are multiple specs failing > See > [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711|https://travis-ci.org/apache/cordova-plugin-media/builds/327034161] > for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13784) Broken tests on cordova-plugin-media
jcesarmobile created CB-13784: - Summary: Broken tests on cordova-plugin-media Key: CB-13784 URL: https://issues.apache.org/jira/browse/CB-13784 Project: Apache Cordova Issue Type: Bug Components: cordova-paramedic, cordova-plugin-file Reporter: jcesarmobile Assignee: Jesse MacFadyen The tests of cordova-plugin-file for browser-safari are failing. Other platforms are ok. There are multiple specs failing See [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711] for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9704) Apache Cordova 5 does not support using a custom nexus repository for android builds
[ https://issues.apache.org/jira/browse/CB-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326488#comment-16326488 ] Matt Steele commented on CB-9704: - [~ajaygupta0512] I'm running into a similar issue; are you still doing this? Newer versions of cordova-android moved away from mavenCentral() so my regex no longer works. Before I start making it more complex I want to see if there's any better options. I also published a question on StackOverflow: https://stackoverflow.com/questions/48267650/how-do-i-configure-cordova-android-to-use-an-internal-maven-registry-in-its-grad > Apache Cordova 5 does not support using a custom nexus repository for android > builds > > > Key: CB-9704 > URL: https://issues.apache.org/jira/browse/CB-9704 > Project: Apache Cordova > Issue Type: New Feature > Components: Ionic >Reporter: Ajay Gupta >Priority: Major > > We are using AngularJS and Ionic for writing a mobile application supported > both on IOS and Android. When we do "ionic build android --release", it > creates a build.gradle file in both platforms/android directory and > platforms/android/CordovaLib directory. Both of these files point to > mavenCentral() as the repository which tries to download artifacts directly > from the maven central repo (http://repo1.maven.org/maven2). We are trying > to build our mobile apps as part of a Jenkins build behind company proxy and > would like to have gradle reach out to our internal Maven nexus repository > instead of reaching out to the central maven repository directly. Our > internal Neux repository would then proxy everything to the maven central > repository. > We cannot hand edit the build.gradle file as it is a generated file and so > any custom changes made to it would be lost in the next build. Cordova 5 > supports adding custom extensions using build-extras.gradle file but it does > not support overriding repositories. > As a workaround, we have defined a pre-build Cordova hook to search replace > mavenCentral() references to our local maven repository before doing an > android build. It works but is a unnecessary workaround and not a very clean > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13753) Add build-tools-26.0.2 to travis for cordova-plugin-file
[ https://issues.apache.org/jira/browse/CB-13753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326487#comment-16326487 ] ASF subversion and git services commented on CB-13753: -- Commit 5e12b5e9f63b12aef5198e9a72ac8d7b8e834442 in cordova-plugin-file's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file.git;h=5e12b5e ] Merge pull request #228 from jcesarmobile/CB-13753 CB-13753: Add build-tools-26.0.2 to travis > Add build-tools-26.0.2 to travis for cordova-plugin-file > > > Key: CB-13753 > URL: https://issues.apache.org/jira/browse/CB-13753 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13753) Add build-tools-26.0.2 to travis for cordova-plugin-file
[ https://issues.apache.org/jira/browse/CB-13753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326486#comment-16326486 ] ASF subversion and git services commented on CB-13753: -- Commit 5e12b5e9f63b12aef5198e9a72ac8d7b8e834442 in cordova-plugin-file's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file.git;h=5e12b5e ] Merge pull request #228 from jcesarmobile/CB-13753 CB-13753: Add build-tools-26.0.2 to travis > Add build-tools-26.0.2 to travis for cordova-plugin-file > > > Key: CB-13753 > URL: https://issues.apache.org/jira/browse/CB-13753 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13753) Add build-tools-26.0.2 to travis for cordova-plugin-file
[ https://issues.apache.org/jira/browse/CB-13753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326485#comment-16326485 ] ASF subversion and git services commented on CB-13753: -- Commit d8cc0fde2df257a5d6781e78891eddfd1e182f7a in cordova-plugin-file's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file.git;h=d8cc0fd ] CB-13753: Add build-tools-26.0.2 to travis > Add build-tools-26.0.2 to travis for cordova-plugin-file > > > Key: CB-13753 > URL: https://issues.apache.org/jira/browse/CB-13753 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13753) Add build-tools-26.0.2 to travis for cordova-plugin-file
[ https://issues.apache.org/jira/browse/CB-13753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile resolved CB-13753. --- Resolution: Fixed > Add build-tools-26.0.2 to travis for cordova-plugin-file > > > Key: CB-13753 > URL: https://issues.apache.org/jira/browse/CB-13753 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13753) Add build-tools-26.0.2 to travis for cordova-plugin-file
[ https://issues.apache.org/jira/browse/CB-13753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326484#comment-16326484 ] ASF GitHub Bot commented on CB-13753: - jcesarmobile closed pull request #228: CB-13753: Add build-tools-26.0.2 to travis URL: https://github.com/apache/cordova-plugin-file/pull/228 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 77dd88e..86c335c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -37,6 +37,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 - env: PLATFORM=android-5.1 os: linux language: android @@ -44,6 +45,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 - env: PLATFORM=android-6.0 os: linux language: android @@ -51,6 +53,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 - env: PLATFORM=android-7.0 os: linux language: android @@ -58,6 +61,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 before_install: - rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build-tools-26.0.2 to travis for cordova-plugin-file > > > Key: CB-13753 > URL: https://issues.apache.org/jira/browse/CB-13753 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13783) Broken tests on cordova-plugin-file
[ https://issues.apache.org/jira/browse/CB-13783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13783: -- Environment: (was: The tests of cordova-plugin-file for browser-safari are failing. Other platforms are ok. There are multiple specs failing See [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711] for reference) > Broken tests on cordova-plugin-file > --- > > Key: CB-13783 > URL: https://issues.apache.org/jira/browse/CB-13783 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic, cordova-plugin-file >Reporter: jcesarmobile >Assignee: Jesse MacFadyen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13783) Broken tests on cordova-plugin-file
[ https://issues.apache.org/jira/browse/CB-13783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13783: -- Description: The tests of cordova-plugin-file for browser-safari are failing. Other platforms are ok. There are multiple specs failing See [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711] for reference > Broken tests on cordova-plugin-file > --- > > Key: CB-13783 > URL: https://issues.apache.org/jira/browse/CB-13783 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic, cordova-plugin-file >Reporter: jcesarmobile >Assignee: Jesse MacFadyen >Priority: Major > > The tests of cordova-plugin-file for browser-safari are failing. Other > platforms are ok. > There are multiple specs failing > See [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711] for > reference -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13783) Broken tests on cordova-plugin-file
jcesarmobile created CB-13783: - Summary: Broken tests on cordova-plugin-file Key: CB-13783 URL: https://issues.apache.org/jira/browse/CB-13783 Project: Apache Cordova Issue Type: Bug Components: cordova-paramedic, cordova-plugin-file Environment: The tests of cordova-plugin-file for browser-safari are failing. Other platforms are ok. There are multiple specs failing See [https://travis-ci.org/apache/cordova-plugin-file/jobs/327439711] for reference Reporter: jcesarmobile Assignee: Jesse MacFadyen -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13749) Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer
[ https://issues.apache.org/jira/browse/CB-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile reassigned CB-13749: - Assignee: jcesarmobile > Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer > - > > Key: CB-13749 > URL: https://issues.apache.org/jira/browse/CB-13749 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13749) Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer
[ https://issues.apache.org/jira/browse/CB-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile resolved CB-13749. --- Resolution: Fixed > Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer > - > > Key: CB-13749 > URL: https://issues.apache.org/jira/browse/CB-13749 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13749) Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer
[ https://issues.apache.org/jira/browse/CB-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326311#comment-16326311 ] ASF subversion and git services commented on CB-13749: -- Commit 57e01ea2b6ef12883b15d8168534e88e53614546 in cordova-plugin-file-transfer's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=57e01ea ] CB-13749: Add build-tools-26.0.2 to travis > Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer > - > > Key: CB-13749 > URL: https://issues.apache.org/jira/browse/CB-13749 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13749) Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer
[ https://issues.apache.org/jira/browse/CB-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326310#comment-16326310 ] ASF GitHub Bot commented on CB-13749: - jcesarmobile closed pull request #196: CB-13749: Add build-tools-26.0.2 to travis URL: https://github.com/apache/cordova-plugin-file-transfer/pull/196 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index ea50304..08cf033 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,6 +25,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 - env: PLATFORM=android-5.1 os: linux language: android @@ -32,6 +33,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 - env: PLATFORM=android-6.0 os: linux language: android @@ -39,6 +41,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 - env: PLATFORM=android-7.0 os: linux language: android @@ -46,6 +49,7 @@ matrix: android: components: - tools + - build-tools-26.0.2 before_install: - rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer > - > > Key: CB-13749 > URL: https://issues.apache.org/jira/browse/CB-13749 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13782) spec attribute for framework element doens't take into account preferences
[
https://issues.apache.org/jira/browse/CB-13782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah updated CB-13782:
--
Component/s: cordova-lib
> spec attribute for framework element doens't take into account preferences
> --
>
> Key: CB-13782
> URL: https://issues.apache.org/jira/browse/CB-13782
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: cordova@7.1.0
>Reporter: Adriano Di Giovanni
>Priority: Minor
>
> Please,
> consider the following snippet from plugin.xml
> {code:java}
>
>
>
> {code}
> If I install such a plugin I get the following podfile
> {code:java}
> # DO NOT MODIFY -- auto-generated by Apache Cordova platform :ios, '8.0'
> target 'App' do project 'App.xcodeproj' pod 'Google-Mobile-Ads-SDK',
> '$IOS_VERSION' end
> {code}
> I think that, unlikely the src attribute of the framework element, it is not
> possible to use a preference value for the spec attribute.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13780) Should allow preferences having empty default
[
https://issues.apache.org/jira/browse/CB-13780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326203#comment-16326203
]
jcesarmobile commented on CB-13780:
---
As user you can set the preference with an empty value in the config.xml
As plugin developer, if you want to use latest then just don't use a variable
and provide and empty spec.
I don't think it's good to allow users to decide which spec to use as the
plugin code might not work with all versions.
Anyway, keeping it open, emtpy default might be good for some other use cases
> Should allow preferences having empty default
> -
>
> Key: CB-13780
> URL: https://issues.apache.org/jira/browse/CB-13780
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Adriano Di Giovanni
>Priority: Trivial
> Labels: framework, plugin, podspec
>
> Please,
> consider the following snippet from plugin.xml
> {code:java}
> src="Google-Mobile-Ads-SDK" type="podspec" spec="$VERSION" />
> {code}
> It would be useful if preferences having an empty default are considered
> valid instead of missing.
> This new behavior lets you use a preference to specify a podspec version and
> if the preference has empty default, it means the latest version should be
> installed.
> Today, there is no other way to do it unless CocoaPods changes podfile to let
> you specify something like +, * or latest to install the latest version of a
> podspec (instead of omitting the version at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13782) spec attribute for framework element doens't take into account preferences
Adriano Di Giovanni created CB-13782:
Summary: spec attribute for framework element doens't take into
account preferences
Key: CB-13782
URL: https://issues.apache.org/jira/browse/CB-13782
Project: Apache Cordova
Issue Type: Bug
Affects Versions: cordova@7.1.0
Reporter: Adriano Di Giovanni
Please,
consider the following snippet from plugin.xml
{code:java}
{code}
If I install such a plugin I get the following podfile
{code:java}
# DO NOT MODIFY -- auto-generated by Apache Cordova platform :ios, '8.0' target
'App' do project 'App.xcodeproj' pod 'Google-Mobile-Ads-SDK', '$IOS_VERSION' end
{code}
I think that, unlikely the src attribute of the framework element, it is not
possible to use a preference value for the spec attribute.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13749) Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer
[ https://issues.apache.org/jira/browse/CB-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326178#comment-16326178 ] ASF GitHub Bot commented on CB-13749: - jcesarmobile opened a new pull request #196: CB-13749: Add build-tools-26.0.2 to travis URL: https://github.com/apache/cordova-plugin-file-transfer/pull/196 ### Platforms affected Travis ### What does this PR do? ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build-tools-26.0.2 to travis for cordova-plugin-file-transfer > - > > Key: CB-13749 > URL: https://issues.apache.org/jira/browse/CB-13749 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13781) Error requesting permission on Android 8 - Save on photo album issue
[ https://issues.apache.org/jira/browse/CB-13781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326177#comment-16326177 ] ASF GitHub Bot commented on CB-13781: - rpanadero opened a new pull request #308: CB-13781: (android) Fixed permissions request on Android 8 to save a … URL: https://github.com/apache/cordova-plugin-camera/pull/308 …photo into the photo album ### Platforms affected Android ### What does this PR do? It fixes a issue managing permissions when a photo wants to be saved into the photo album. The plugin is requesting both WRITE and READ permissions, if they are not accepted yet, before taking a photo by the device camera. ### What testing has been done on this change? The changed has been tested on multiple Android devices both with Android 8 and with Android 7-. As for example ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Error requesting permission on Android 8 - Save on photo album issue > > > Key: CB-13781 > URL: https://issues.apache.org/jira/browse/CB-13781 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Rubén Panadero >Priority: Critical > > Google has changed how an android application must request permissions on > Android 8. In fact, it is considered as fix by Google due to a wrong behavior > on previous versions. > Related documentation: > [https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp] > This change made by Google has affected the cordova-camera-plugin. To save a > photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE > permission right now, but that is not enough on Android 8 because the plugin > writes the photo file into Pictures folder so it has to request the writing > permission, which is missing, as well. > This is the error that the plugin throws when a photo is tried to be saved > into the photo album on Android 8. > > 01-12 11:38:16.757 W/System.err(22321): java.io.FileNotFoundException: open > > failed: EACCES (Permission denied) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.openInternal(ParcelFileDescriptor.java:313) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.os.ParcelFileDescriptor.open(ParcelFileDescriptor.java:211) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1242) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:1007) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.content.ContentResolver.openOutputStream(ContentResolver.java:983) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:979) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:1015) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.processResultFromCamera(CameraLauncher.java:603) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.camera.CameraLauncher.onActivityResult(CameraLauncher.java:919) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:152) > > 01-12 11:38:16.758 W/System.err(22321): at > > org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:358) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.Activity.dispatchActivityResult(Activity.java:7235) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.deliverResults(ActivityThread.java:4336) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.handleSendResult(ActivityThread.java:4383) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread.-wrap19(Unknown Source:0) > > 01-12 11:38:16.758 W/System.err(22321): at > > android.app.ActivityThread$H.handleMessage(ActivityThread.java:1652) > > 01-12 11:38:16.758
[jira] [Commented] (CB-13759) Add build-tools-26.0.2 to travis for cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326176#comment-16326176 ] ASF GitHub Bot commented on CB-13759: - jcesarmobile opened a new pull request #164: CB-13759: Add build-tools-26.0.2 to travis URL: https://github.com/apache/cordova-plugin-contacts/pull/164 ### Platforms affected Travis ### What does this PR do? ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build-tools-26.0.2 to travis for cordova-plugin-contacts > > > Key: CB-13759 > URL: https://issues.apache.org/jira/browse/CB-13759 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13766) Add build-tools-26.0.2 to travis for cordova-plugin-device-orientation
[ https://issues.apache.org/jira/browse/CB-13766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13766. - Resolution: Won't Do Plugin is deprecated and build is green at the moment, so no point on fixing something that is not broken and deprecated > Add build-tools-26.0.2 to travis for cordova-plugin-device-orientation > -- > > Key: CB-13766 > URL: https://issues.apache.org/jira/browse/CB-13766 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13763) Add build-tools-26.0.2 to travis for cordova-plugin-device-motion
[ https://issues.apache.org/jira/browse/CB-13763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13763. - Resolution: Won't Do Plugin is deprecated and build is green at the moment, so no point on fixing something that is not broken and deprecated > Add build-tools-26.0.2 to travis for cordova-plugin-device-motion > - > > Key: CB-13763 > URL: https://issues.apache.org/jira/browse/CB-13763 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13762) Add build-tools-26.0.2 to travis for cordova-plugin-console
[ https://issues.apache.org/jira/browse/CB-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13762. - Resolution: Won't Do Plugin is deprecated and build is green at the moment, so no point on fixing something that is not broken and deprecated > Add build-tools-26.0.2 to travis for cordova-plugin-console > --- > > Key: CB-13762 > URL: https://issues.apache.org/jira/browse/CB-13762 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13781) Error requesting permission on Android 8 - Save on photo album issue
[ https://issues.apache.org/jira/browse/CB-13781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rubén Panadero updated CB-13781: Description: Google has changed how an android application must request permissions on Android 8. In fact, it is considered as fix by Google due to a wrong behavior on previous versions. Related documentation: [https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp] This change made by Google has affected the cordova-camera-plugin. To save a photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE permission right now, but that is not enough on Android 8 because the plugin writes the photo file into Pictures folder so it has to request the writing permission, which is missing, as well. This is the error that the plugin throws when a photo is tried to be saved into the photo album on Android 8. > 01-12 11:38:16.757 W/System.err(22321): java.io.FileNotFoundException: open > failed: EACCES (Permission denied) > 01-12 11:38:16.758 W/System.err(22321): at > android.os.ParcelFileDescriptor.openInternal(ParcelFileDescriptor.java:313) > 01-12 11:38:16.758 W/System.err(22321): at > android.os.ParcelFileDescriptor.open(ParcelFileDescriptor.java:211) > 01-12 11:38:16.758 W/System.err(22321): at > android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1242) > 01-12 11:38:16.758 W/System.err(22321): at > android.content.ContentResolver.openOutputStream(ContentResolver.java:1007) > 01-12 11:38:16.758 W/System.err(22321): at > android.content.ContentResolver.openOutputStream(ContentResolver.java:983) > 01-12 11:38:16.758 W/System.err(22321): at > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:979) > 01-12 11:38:16.758 W/System.err(22321): at > org.apache.cordova.camera.CameraLauncher.writeUncompressedImage(CameraLauncher.java:1015) > 01-12 11:38:16.758 W/System.err(22321): at > org.apache.cordova.camera.CameraLauncher.processResultFromCamera(CameraLauncher.java:603) > 01-12 11:38:16.758 W/System.err(22321): at > org.apache.cordova.camera.CameraLauncher.onActivityResult(CameraLauncher.java:919) > 01-12 11:38:16.758 W/System.err(22321): at > org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:152) > 01-12 11:38:16.758 W/System.err(22321): at > org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:358) > 01-12 11:38:16.758 W/System.err(22321): at > android.app.Activity.dispatchActivityResult(Activity.java:7235) > 01-12 11:38:16.758 W/System.err(22321): at > android.app.ActivityThread.deliverResults(ActivityThread.java:4336) > 01-12 11:38:16.758 W/System.err(22321): at > android.app.ActivityThread.handleSendResult(ActivityThread.java:4383) > 01-12 11:38:16.758 W/System.err(22321): at > android.app.ActivityThread.-wrap19(Unknown Source:0) > 01-12 11:38:16.758 W/System.err(22321): at > android.app.ActivityThread$H.handleMessage(ActivityThread.java:1652) > 01-12 11:38:16.758 W/System.err(22321): at > android.os.Handler.dispatchMessage(Handler.java:105) > 01-12 11:38:16.758 W/System.err(22321): at > android.os.Looper.loop(Looper.java:164) > 01-12 11:38:16.758 W/System.err(22321): at > android.app.ActivityThread.main(ActivityThread.java:6600) > 01-12 11:38:16.758 W/System.err(22321): at > java.lang.reflect.Method.invoke(Native Method) > 01-12 11:38:16.758 W/System.err(22321): at > com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) > 01-12 11:38:16.758 W/System.err(22321): at > com.android.internal.os.ZygoteInit.main(ZygoteInit.java:772) To sum up, if the plugin has to save a photo in the photo album, this one has to request both READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE permissions. was: Google has changed how an android application must request permissions on Android 8. In fact, it is considered as fix by Google due to a wrong behavior on previous versions. Related documentation: https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp This change made by Google has affected the cordova-camera-plugin. To save a photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE permission right now, but that is not enough on Android 8 because the plugin writes the photo file into Pictures folder so it has to request the writing permission, which is missing, as well. To sum up, if the plugin has to save a photo in the photo album, this one has to request both READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE permissions. > Error requesting permission on Android 8 - Save on photo album issue > > > Key: CB-13781 > URL: https://issues.apache.org/jira/browse/CB-13781 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >
[jira] [Updated] (CB-13781) Error requesting permission on Android 8 - Save on photo album issue
[ https://issues.apache.org/jira/browse/CB-13781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rubén Panadero updated CB-13781: Summary: Error requesting permission on Android 8 - Save on photo album issue (was: Error requesting permission on Android 8) > Error requesting permission on Android 8 - Save on photo album issue > > > Key: CB-13781 > URL: https://issues.apache.org/jira/browse/CB-13781 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Rubén Panadero >Priority: Critical > > Google has changed how an android application must request permissions on > Android 8. In fact, it is considered as fix by Google due to a wrong behavior > on previous versions. > Related documentation: > https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp > This change made by Google has affected the cordova-camera-plugin. To save a > photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE > permission right now, but that is not enough on Android 8 because the plugin > writes the photo file into Pictures folder so it has to request the writing > permission, which is missing, as well. > To sum up, if the plugin has to save a photo in the photo album, this one has > to request both READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE permissions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13781) Error requesting permission on Android 8
Rubén Panadero created CB-13781: --- Summary: Error requesting permission on Android 8 Key: CB-13781 URL: https://issues.apache.org/jira/browse/CB-13781 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-camera Reporter: Rubén Panadero Google has changed how an android application must request permissions on Android 8. In fact, it is considered as fix by Google due to a wrong behavior on previous versions. Related documentation: https://developer.android.com/about/versions/oreo/android-8.0-changes.html#rmp This change made by Google has affected the cordova-camera-plugin. To save a photo in Photo Album, the plugin just requests the READ_EXTERNAL_STORAGE permission right now, but that is not enough on Android 8 because the plugin writes the photo file into Pictures folder so it has to request the writing permission, which is missing, as well. To sum up, if the plugin has to save a photo in the photo album, this one has to request both READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE permissions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13780) Should allow preferences having empty default
[
https://issues.apache.org/jira/browse/CB-13780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adriano Di Giovanni updated CB-13780:
-
Labels: framework plugin podspec (was: )
> Should allow preferences having empty default
> -
>
> Key: CB-13780
> URL: https://issues.apache.org/jira/browse/CB-13780
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Adriano Di Giovanni
>Priority: Trivial
> Labels: framework, plugin, podspec
>
> Please,
> consider the following snippet from plugin.xml
> {code:java}
> src="Google-Mobile-Ads-SDK" type="podspec" spec="$VERSION" />
> {code}
> It would be useful if preferences having an empty default are considered
> valid instead of missing.
> This new behavior lets you use a preference to specify a podspec version and
> if the preference has empty default, it means the latest version should be
> installed.
> Today, there is no other way to do it unless CocoaPods changes podfile to let
> you specify something like +, * or latest to install the latest version of a
> podspec (instead of omitting the version at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13780) Should allow preferences having empty default
Adriano Di Giovanni created CB-13780:
Summary: Should allow preferences having empty default
Key: CB-13780
URL: https://issues.apache.org/jira/browse/CB-13780
Project: Apache Cordova
Issue Type: Improvement
Components: cordova-lib
Reporter: Adriano Di Giovanni
Please,
consider the following snippet from plugin.xml
{code:java}
{code}
It would be useful if preferences having an empty default are considered valid
instead of missing.
This new behavior lets you use a preference to specify a podspec version and if
the preference has empty default, it means the latest version should be
installed.
Today, there is no other way to do it unless CocoaPods changes podfile to let
you specify something like +, * or latest to install the latest version of a
podspec (instead of omitting the version at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13202) iOS builds works only with lowercase directory names
[ https://issues.apache.org/jira/browse/CB-13202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pdc AppDev closed CB-13202. --- Resolution: Fixed Fix Version/s: cordova-ios 4.5.0 > iOS builds works only with lowercase directory names > > > Key: CB-13202 > URL: https://issues.apache.org/jira/browse/CB-13202 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0, cordova@7.0.0 > Environment: Development: Use Windows and Windows zip to create file > for upload to PGB. Browser used for upload=Chrome. > Testing: Error seen on iPod Touch. >Reporter: Pdc AppDev >Priority: Major > Labels: backlog, ios-next > Fix For: cordova-ios 4.5.0 > > > I have an app with an index.html which amongst other things contain lines > like this > > and > > > Now this works like a dream if I build with cli-6.5.0 - both for iOS and > Android. > If I build with cli-7.0.1 it only works for Android, and I can see in iOS > that the files styles.css and custom.js are simply not loaded. > > However, if I change the directory names to lowercase and correspondingly > change to > > and > > > it works also for iOS on cli-7.0.1. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13658) Launching an external app and use the back button - twice
[ https://issues.apache.org/jira/browse/CB-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326003#comment-16326003 ] Rotem Hen commented on CB-13658: Hi, were you able to reproduce it ok? > Launching an external app and use the back button - twice > - > > Key: CB-13658 > URL: https://issues.apache.org/jira/browse/CB-13658 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0, cordova-ios 4.5.0 >Reporter: Rotem Hen >Assignee: Suraj Pindoria >Priority: Minor > > On a new clean Cordova project add a link to an external app (for example > "sms:" to launch messages app). > 1. Click the link. > 2. Click on the small 'back' button in the top left of the screen to return > to the Cordova app. > 3. Click the link again. > In the log you can already see the app is re-loading and failing. > When you go back to the app again, you will be seeing your errorUrl if you > have one. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
