[jira] [Commented] (CB-13513) Fastlane unable to disable automatic signing
[
https://issues.apache.org/jira/browse/CB-13513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330191#comment-16330191
]
ASF GitHub Bot commented on CB-13513:
-
purplecabbage closed pull request #343: CB-13513 (ios) Declare
ProvisioningStyle as Automatic in project.pbxproj template.
URL: https://github.com/apache/cordova-ios/pull/343
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/templates/project/__TEMP__.xcodeproj/project.pbxproj
b/bin/templates/project/__TEMP__.xcodeproj/project.pbxproj
index 46462f4f9..4c3179562 100755
--- a/bin/templates/project/__TEMP__.xcodeproj/project.pbxproj
+++ b/bin/templates/project/__TEMP__.xcodeproj/project.pbxproj
@@ -203,6 +203,11 @@
isa = PBXProject;
attributes = {
LastUpgradeCheck = 0510;
+ TargetAttributes = {
+ 1D6058900D05DD3D006BFB54 = {
+ ProvisioningStyle = Automatic;
+ };
+ };
};
buildConfigurationList = C01FCF4E08A954540054247B /*
Build configuration list for PBXProject "__NON-CLI__" */;
compatibilityVersion = "Xcode 3.2";
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fastlane unable to disable automatic signing
> -
>
> Key: CB-13513
> URL: https://issues.apache.org/jira/browse/CB-13513
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Paul Robinson
>Assignee: Suraj Pindoria
>Priority: Blocker
>
> Running `disable_automatic_code_signing` command in fastlane fails and throw
> an error that the ios project is too old.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13513) Fastlane unable to disable automatic signing
[ https://issues.apache.org/jira/browse/CB-13513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330192#comment-16330192 ] ASF subversion and git services commented on CB-13513: -- Commit fa41ae3915a2246ad6f7dff1a28895c4f760bcdf in cordova-ios's branch refs/heads/master from [~purplecabbage] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=fa41ae3 ] Merge pull request #343 from NextFaze/master CB-13513 (ios) Declare ProvisioningStyle as Automatic in project.pbxproj template. > Fastlane unable to disable automatic signing > - > > Key: CB-13513 > URL: https://issues.apache.org/jira/browse/CB-13513 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 >Reporter: Paul Robinson >Assignee: Suraj Pindoria >Priority: Blocker > > Running `disable_automatic_code_signing` command in fastlane fails and throw > an error that the ios project is too old. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13510) Copy/Paste functionality is not working for iOS native components.
[
https://issues.apache.org/jira/browse/CB-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330178#comment-16330178
]
ASF GitHub Bot commented on CB-13510:
-
shazron commented on issue #352: CB-13510: (iOS) Removed clipboard workaround,
which was braking copy/paste functional iOS 11
URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358559980
You need to do this at runtime. Jesse's check above will omit the code
needed on older iOSes during compile time on Xcode 9, thus break the feature at
runtime for iOS 10 devices.
The pasteboard code above should only be loaded if the iOS version is less
than 11.
```obj-c
if (!IsAtLeastiOSVersion('11.0')) {
// put pasteboard code here
}
```
(IsAtLeastiOSVersion is in CDVAvailability.h)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Copy/Paste functionality is not working for iOS native components.
> --
>
> Key: CB-13510
> URL: https://issues.apache.org/jira/browse/CB-13510
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0, cordova-ios 4.5.0
> Environment: iOS 11 and up... Not reproducible in iOS 10.x
>Reporter: Aqeel Raza Syed
>Assignee: Suraj Pindoria
>Priority: Major
>
> With iOS11 upgrade Cordova-ios library is braking copy/paste functionality
> for consumer apps utilizing both web and native UI.
> *Steps to reproduce :*
> - Copy text to clipboard (e.g. Notes app)
> - Foreground consumer app (app must be running in background)
> - Paste clipboard text to native UI component (i.e. UITextField)
> *Expected:*
> - Text should be pasted on native UI component
> *Actual:*
> - Nothing happens
> *Note:* This only happens with native UI components and works fine with Web
> interface. Also once consumer app goes foreground, after backgrounding that
> app, clipboard text can never be pasted in any other iOS app with native UI.
> *Investigation:*
> Seems like following patch fix is causing this issue in iOS 11:
> https://github.com/apache/cordova-ios/pull/139
> *Potential Fix:* Since above patch has been done a while ago, removing that
> bit of code, doesn't seems to reintroduce original bug (i.e.
> https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13510) Copy/Paste functionality is not working for iOS native components.
[
https://issues.apache.org/jira/browse/CB-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330177#comment-16330177
]
ASF GitHub Bot commented on CB-13510:
-
shazron commented on issue #352: CB-13510: (iOS) Removed clipboard workaround,
which was braking copy/paste functional iOS 11
URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358559980
You need to do this at runtime. Jesse's check above will omit the code
needed on older iOSes, thus break the feature at runtime for iOS 10 devices.
The pasteboard code above should only be loaded if the iOS version is less
than 11.
```obj-c
if (!IsAtLeastiOSVersion('11.0')) {
// put pasteboard code here
}
```
(IsAtLeastiOSVersion is in CDVAvailability.h)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Copy/Paste functionality is not working for iOS native components.
> --
>
> Key: CB-13510
> URL: https://issues.apache.org/jira/browse/CB-13510
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0, cordova-ios 4.5.0
> Environment: iOS 11 and up... Not reproducible in iOS 10.x
>Reporter: Aqeel Raza Syed
>Assignee: Suraj Pindoria
>Priority: Major
>
> With iOS11 upgrade Cordova-ios library is braking copy/paste functionality
> for consumer apps utilizing both web and native UI.
> *Steps to reproduce :*
> - Copy text to clipboard (e.g. Notes app)
> - Foreground consumer app (app must be running in background)
> - Paste clipboard text to native UI component (i.e. UITextField)
> *Expected:*
> - Text should be pasted on native UI component
> *Actual:*
> - Nothing happens
> *Note:* This only happens with native UI components and works fine with Web
> interface. Also once consumer app goes foreground, after backgrounding that
> app, clipboard text can never be pasted in any other iOS app with native UI.
> *Investigation:*
> Seems like following patch fix is causing this issue in iOS 11:
> https://github.com/apache/cordova-ios/pull/139
> *Potential Fix:* Since above patch has been done a while ago, removing that
> bit of code, doesn't seems to reintroduce original bug (i.e.
> https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13510) Copy/Paste functionality is not working for iOS native components.
[ https://issues.apache.org/jira/browse/CB-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329674#comment-16329674 ] ASF GitHub Bot commented on CB-13510: - ssraza commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358483103 Yep, let me try with this check shortly... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Copy/Paste functionality is not working for iOS native components. > -- > > Key: CB-13510 > URL: https://issues.apache.org/jira/browse/CB-13510 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0, cordova-ios 4.5.0 > Environment: iOS 11 and up... Not reproducible in iOS 10.x >Reporter: Aqeel Raza Syed >Assignee: Suraj Pindoria >Priority: Major > > With iOS11 upgrade Cordova-ios library is braking copy/paste functionality > for consumer apps utilizing both web and native UI. > *Steps to reproduce :* > - Copy text to clipboard (e.g. Notes app) > - Foreground consumer app (app must be running in background) > - Paste clipboard text to native UI component (i.e. UITextField) > *Expected:* > - Text should be pasted on native UI component > *Actual:* > - Nothing happens > *Note:* This only happens with native UI components and works fine with Web > interface. Also once consumer app goes foreground, after backgrounding that > app, clipboard text can never be pasted in any other iOS app with native UI. > *Investigation:* > Seems like following patch fix is causing this issue in iOS 11: > https://github.com/apache/cordova-ios/pull/139 > *Potential Fix:* Since above patch has been done a while ago, removing that > bit of code, doesn't seems to reintroduce original bug (i.e. > https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13510) Copy/Paste functionality is not working for iOS native components.
[
https://issues.apache.org/jira/browse/CB-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329670#comment-16329670
]
ASF GitHub Bot commented on CB-13510:
-
purplecabbage commented on issue #352: CB-13510: (iOS) Removed clipboard
workaround, which was braking copy/paste functional iOS 11
URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358482320
```
#if __IPHONE_OS_VERSION_MAX_ALLOWED < 11
/** Clipboard fix **/
UIPasteboard* pasteboard = [UIPasteboard generalPasteboard];
NSString* string = pasteboard.string;
if (string) {
[pasteboard setValue:string forPasteboardType:@"public.text"];
}
#endif
```
Can you try that on iOS 11 ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Copy/Paste functionality is not working for iOS native components.
> --
>
> Key: CB-13510
> URL: https://issues.apache.org/jira/browse/CB-13510
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0, cordova-ios 4.5.0
> Environment: iOS 11 and up... Not reproducible in iOS 10.x
>Reporter: Aqeel Raza Syed
>Assignee: Suraj Pindoria
>Priority: Major
>
> With iOS11 upgrade Cordova-ios library is braking copy/paste functionality
> for consumer apps utilizing both web and native UI.
> *Steps to reproduce :*
> - Copy text to clipboard (e.g. Notes app)
> - Foreground consumer app (app must be running in background)
> - Paste clipboard text to native UI component (i.e. UITextField)
> *Expected:*
> - Text should be pasted on native UI component
> *Actual:*
> - Nothing happens
> *Note:* This only happens with native UI components and works fine with Web
> interface. Also once consumer app goes foreground, after backgrounding that
> app, clipboard text can never be pasted in any other iOS app with native UI.
> *Investigation:*
> Seems like following patch fix is causing this issue in iOS 11:
> https://github.com/apache/cordova-ios/pull/139
> *Potential Fix:* Since above patch has been done a while ago, removing that
> bit of code, doesn't seems to reintroduce original bug (i.e.
> https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13788) Specify the minimum required version of google play services for plugins
[ https://issues.apache.org/jira/browse/CB-13788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329520#comment-16329520 ] ASF GitHub Bot commented on CB-13788: - codecov-io commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins URL: https://github.com/apache/cordova-android/pull/428#issuecomment-358457653 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/428?src=pr=h1) Report > Merging [#428](https://codecov.io/gh/apache/cordova-android/pull/428?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/673a6773b2f78ba76d2144c66ab7a3add78648ae?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/428?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #428 +/- ## === Coverage 43.95% 43.95% === Files 17 17 Lines1711 1711 Branches 318 318 === Hits 752 752 Misses959 959 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/428?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/428?src=pr=footer). Last update [673a677...ffe9ac7](https://codecov.io/gh/apache/cordova-android/pull/428?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Specify the minimum required version of google play services for plugins > > > Key: CB-13788 > URL: https://issues.apache.org/jira/browse/CB-13788 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: cordova-android-7.0.0 >Reporter: Masashi Katsumata >Assignee: Joe Bowser >Priority: Major > Labels: patch > > Many plugins use the Google Play Services SDK, but it is really heavy. > Some developers want to specify particular versions, but not all of plugin > developers. > Some other developers don't want to update their plugin frequently, but want > to specify minimum required version. > I found this code > [https://github.com/apache/cordova-android/blob/673a6773b2f78ba76d2144c66ab7a3add78648ae/bin/templates/cordova/lib/builders/StudioBuilder.js#L177-L201] > This allows us to specify like this > ** > > But the code does not accept particular module. > * versions=">=11.8.0" />* > > In order to specify particular module, we need to change the code. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Alden updated CB-13791: External issue URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/258 > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! > _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! > _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ > > !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329465#comment-16329465 ] ASF GitHub Bot commented on CB-13791: - dpa99c opened a new pull request #258: CB-13791: (android) Add Android support for a footer close button URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/258 ### Platforms affected Android ### What does this PR do? Adds support to Android for a footer close button similar to the "Done" button on iOS. ### What testing has been done on this change? Manual testing as there's no currently no automated tests for platform-specific options. I've tested all the possible combinations of the new `footer` and `footercolor` options with the related `closebuttoncaption` and `closebuttoncolor` options. The screenshots below illustrate the results: `location=yes,footer=yes` https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png"/> `location=no,footer=yes` https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png"/> `location=yes,footer=yes,closebuttoncaption=Done` https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png"/> `location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff` https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png"/> `location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done` https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png"/> `location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff` https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png"/> `location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00` https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png"/> ### Checklist - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! >
[jira] [Commented] (CB-12132) Add hidenotcloseoption
[
https://issues.apache.org/jira/browse/CB-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329373#comment-16329373
]
ASF GitHub Bot commented on CB-12132:
-
infil00p closed pull request #197: CB-12132: (android & ios) implement
hidenotclose feature
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/197
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
old mode 100644
new mode 100755
index 1e0645c4..ffbd9c62
--- a/README.md
+++ b/README.md
@@ -114,6 +114,7 @@ instance, or the system browser.
- __hardwareback__: set to `yes` to use the hardware back button to
navigate backwards through the `InAppBrowser`'s history. If there is no
previous page, the `InAppBrowser` will close. The default value is `yes`, so
you must set it to `no` if you want the back button to simply close the
InAppBrowser.
- __mediaPlaybackRequiresUserAction__: Set to `yes` to prevent HTML5 audio
or video from autoplaying (defaults to `no`).
- __shouldPauseOnSuspend__: Set to `yes` to make InAppBrowser WebView to
pause/resume with the app to stop background audio (this may be required to
avoid Google Play issues like described in
[CB-11013](https://issues.apache.org/jira/browse/CB-11013)).
+- __hidenotclose__: set to 'yes' to make the done/close button hide the
browser window rather than closing the browser (defaults to 'no')
iOS only:
@@ -131,6 +132,7 @@ instance, or the system browser.
- __presentationstyle__: Set to `pagesheet`, `formsheet` or `fullscreen`
to set the [presentation
style](http://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalPresentationStyle)
(defaults to `fullscreen`).
- __transitionstyle__: Set to `fliphorizontal`, `crossdissolve` or
`coververtical` to set the [transition
style](http://developer.apple.com/library/ios/#documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalTransitionStyle)
(defaults to `coververtical`).
- __toolbarposition__: Set to `top` or `bottom` (default is `bottom`).
Causes the toolbar to be at the top or bottom of the window.
+- __hidenotclose__: set to 'yes' to make the done/close button hide the
browser window rather than closing the browser (defaults to 'no')
Windows only:
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index b54c2241..f8ccb9ee 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -77,6 +77,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private static final String SYSTEM = "_system";
private static final String EXIT_EVENT = "exit";
private static final String LOCATION = "location";
+private static final String HIDEWINDOW = "hidenotclose";
private static final String ZOOM = "zoom";
private static final String HIDDEN = "hidden";
private static final String LOAD_START_EVENT = "loadstart";
@@ -94,6 +95,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private EditText edittext;
private CallbackContext callbackContext;
private boolean showLocationBar = true;
+private boolean hideNotClose = false;
private boolean showZoomControls = true;
private boolean openWindowHidden = false;
private boolean clearAllCache = false;
@@ -501,6 +503,15 @@ private boolean getShowLocationBar() {
return this.showLocationBar;
}
+/**
+ * Should we hide instead of closing
+ *
+ * @return boolean
+ */
+private boolean getHideNotClose() {
+return this.hideNotClose;
+}
+
private InAppBrowser getInAppBrowser(){
return this;
}
@@ -517,12 +528,17 @@ public String showWebPage(final String url,
HashMap features) {
showZoomControls = true;
openWindowHidden = false;
mediaPlaybackRequiresUserGesture = false;
+hideNotClose = false;
if (features != null) {
Boolean show = features.get(LOCATION);
if (show != null) {
showLocationBar = show.booleanValue();
}
+Boolean hideWin = features.get(HIDEWINDOW);
+if (hideWin != null) {
+hideNotClose = hideWin.booleanValue();
+}
Boolean zoom = features.get(ZOOM);
if (zoom != null) {
showZoomControls = zoom.booleanValue();
@@ -704,7 +720,10 @@ public boolean onKey(View v, int keyCode, KeyEvent event) {
close.setOnClickListener(new
[jira] [Commented] (CB-12145) Since Android 5 third party cookies cannot be accepted by the browser due to default policy settings
[ https://issues.apache.org/jira/browse/CB-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329371#comment-16329371 ] ASF GitHub Bot commented on CB-12145: - infil00p commented on issue #198: CB-12145: (android) Allow third party cookies if parameter set URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/198#issuecomment-358428208 It looks like accepting another PR caused this to not merge cleanly. Can you update the branch on your end? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Since Android 5 third party cookies cannot be accepted by the browser due to > default policy settings > > > Key: CB-12145 > URL: https://issues.apache.org/jira/browse/CB-12145 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android 5+ >Reporter: Tim Moxon >Priority: Minor > Labels: android, cookies, security > Original Estimate: 2h > Remaining Estimate: 2h > > Since Android Lollipop / version 5 the inappbrowser cannot accept third party > cookies due to changes to the default policy from the OS. The main cordova > platform now accepts them by default to handle various workflows in which > they are necessitated, however the inappbrowser hasn't yet followed suit. > In my particular usage scenario this creates problems with an opened browser > not being able to pass through an oauth flow to another site in the > background. > I have a fix for this which I will commit now in association with this ticket. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12132) Add hidenotcloseoption
[ https://issues.apache.org/jira/browse/CB-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329372#comment-16329372 ] ASF GitHub Bot commented on CB-12132: - infil00p commented on issue #197: CB-12132: (android & ios) implement hidenotclose feature URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#issuecomment-358428376 This hasn't been looked at in over a year and has conflicts, closing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add hidenotcloseoption > -- > > Key: CB-12132 > URL: https://issues.apache.org/jira/browse/CB-12132 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Reporter: Gaven Henry >Priority: Minor > Labels: features > Original Estimate: 24h > Remaining Estimate: 24h > > add a new option for android and ios: > option: hidenotclose=yes > this makes the done button on iOS or the X button android hide the > inappbrowser webview instead of closing and destroying it. > this is useful when doing something like: > load a webview hidden (so it's nice and preloaded for the user) > use the show() method when the user clicks to see it > use the done/X button to hide the window > call the close() method when done to clean up > this allows us to start pre-loading the data, open and close the window > multiple times without having to reload and then to call close when done to > dispose of the view and clean up. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12367) Modernize styling of iOS InAppBrowser view
[
https://issues.apache.org/jira/browse/CB-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329369#comment-16329369
]
ASF GitHub Bot commented on CB-12367:
-
infil00p commented on issue #210: CB-12367: Modernize styling of iOS
InAppBrowser view
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-358427936
I'd love to see this merged, but there's some conflicts that happened when
we merged some new features in. If the conflicts could be fixed, then we can
look at bringing this in.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Modernize styling of iOS InAppBrowser view
> --
>
> Key: CB-12367
> URL: https://issues.apache.org/jira/browse/CB-12367
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-inappbrowser
>Affects Versions: 1.6.1
>Reporter: Reid Beels
>Priority: Major
>
> I've been working on a branch that brings several visual and configuration
> improvements to the iOS InAppBrowser view, along with a little refactoring of
> the view setup code.
> This PR:
> * breaks up the large {{CDVInAppBrowserViewController createView}} method
> into several smaller helper methods to handle the creation of individual
> subviews
> * gives the {{addressLabel}} a wrapping view to provide flexibility of
> background color / padding
> * changes the default toolbar style from {{UIBarStyleBlackOpaque}} to
> {{UIBarStyleDefault}} to match the system default
> * adds a {{toolbarstyle}} configuration option that accepts {{default}} or
> {{black}}
> * sets the status bar style and background color to match the
> {{toolbarstyle}}, so that top toolbars can blend nicely into the status bar
> * replaces the unicode navigation arrows (◄►) with drawn arrows that match
> those used in Safari
> * adds a {{tintcolor}} configuration option that accepts hex strings like
> {{F8A027}}. If not provided, or set to {{default}}, controls will be rendered
> in the default iOS blue, or in white when {{toolbarstyle=black}} is set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Alden updated CB-13791: Description: Extending the work done in [PR #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under CB-13409, this adds support to Android for a footer close button similar to the "Done" button on iOS. The following options are added for Android: * *footer* - set to "yes" to show a close button in the footer similar to the iOS "Done" button. The close button will appear the same as for the header hence use _closebuttoncaption_ and _closebuttoncolor_ to set its properties. * *footercolor* - set to a valid hex color string, for example #00ff00 or #CC00ff00 (#aarrggbb) , and it will change the footer color from default. Only has effect if user has _footer_ set to "yes". Here are some example screenshots with the relevant options: _location=yes,footer=yes_ !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! _location=no,footer=yes_ !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! _location=yes,footer=yes,closebuttoncaption=Done_ !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! was: Extending the work done in [PR #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under CB-13409, this adds support to Android for a footer close button similar to the "Done" button one iOS. The following options are added for Android: * *footer* - set to "yes" to show a close button in the footer similar to the iOS "Done" button. The close button will appear the same as for the header hence use _closebuttoncaption_ and _closebuttoncolor_ to set its properties. * *footercolor* - set to a valid hex color string, for example #00ff00 or #CC00ff00 (#aarrggbb) , and it will change the footer color from default. Only has effect if user has _footer_ set to "yes". Here are some example screenshots with the relevant options: _location=yes,footer=yes_ !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! _location=no,footer=yes_ !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! _location=yes,footer=yes,closebuttoncaption=Done_ !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to >
[jira] [Created] (CB-13791) Add Android support for a footer close button.
Dave Alden created CB-13791: --- Summary: Add Android support for a footer close button. Key: CB-13791 URL: https://issues.apache.org/jira/browse/CB-13791 Project: Apache Cordova Issue Type: Improvement Components: cordova-plugin-inappbrowser Environment: Android Reporter: Dave Alden Extending the work done in [PR #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under CB-13409, this adds support to Android for a footer close button similar to the "Done" button one iOS. The following options are added for Android: * *footer* - set to "yes" to show a close button in the footer similar to the iOS "Done" button. The close button will appear the same as for the header hence use _closebuttoncaption_ and _closebuttoncolor_ to set its properties. * *footercolor* - set to a valid hex color string, for example #00ff00 or #CC00ff00 (#aarrggbb) , and it will change the footer color from default. Only has effect if user has _footer_ set to "yes". Here are some example screenshots with the relevant options: _location=yes,footer=yes_ !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! _location=no,footer=yes_ !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! _location=yes,footer=yes,closebuttoncaption=Done_ !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329366#comment-16329366 ] ASF GitHub Bot commented on CB-12468: - infil00p commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-358427527 We don't merge if it doesn't merge cleanly, that's why it didn't get merged most likely. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser
[
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329359#comment-16329359
]
ASF GitHub Bot commented on CB-12969:
-
infil00p commented on issue #227: CB-12969 android: Added support for data URIs
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227#issuecomment-358426574
It looks like the PR got borked, and we can't accept it as is due to the
conflict., Closing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello',
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g.
> window.open('https://github.com/apache/cordova-plugin-inappbrowser',
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser
[
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329360#comment-16329360
]
ASF GitHub Bot commented on CB-12969:
-
infil00p closed pull request #227: CB-12969 android: Added support for data URIs
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/227
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
index 735b7364..df373722 100644
--- a/README.md
+++ b/README.md
@@ -707,3 +707,18 @@ iab.open('http://url-that-fails-whitelist.com',
'random_string'); // loads in th
iab.open('http://url-that-fails-whitelist.com', 'random_string',
'location=no'); // loads in the InAppBrowser, no location bar
```
+
+### Data Urls (format: data:[][;base64],)
+
+Supported by android, windows and browser platforms
+```
+var iab = cordova.InAppbrowser;
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E');
// loads in the Cordova WebView (android, browser)
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E', '_self');
// loads in the Cordova WebView (android, browser)
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E', '_system');
// loads in the system browser
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E', '_blank');
// loads in the InAppBrowser (android, browser)
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E',
'random_string'); // loads in the InAppBrowser (android, browser)
+iab.open('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E',
'random_string', 'location=no'); // loads in the InAppBrowser, no location bar
(android, browser)
+
+```
+
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index fefbcece..abcc74b2 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -393,22 +393,27 @@ public void run() {
*/
public String openExternal(String url) {
try {
-Intent intent = null;
-intent = new Intent(Intent.ACTION_VIEW);
// Omitting the MIME type for file: URLs causes "No Activity found
to handle Intent".
// Adding the MIME type to http: URLs causes them to not be
handled by the downloader.
Uri uri = Uri.parse(url);
-if ("file".equals(uri.getScheme())) {
+String scheme = uri.getScheme();
+
+Intent intent = "data".equals(scheme)
+? Intent.makeMainSelectorActivity(Intent.ACTION_MAIN,
Intent.CATEGORY_APP_BROWSER)
+: new Intent(Intent.ACTION_VIEW);
+
+if ("file".equals(scheme)) {
intent.setDataAndType(uri,
webView.getResourceApi().getMimeType(uri));
} else {
intent.setData(uri);
}
+
intent.putExtra(Browser.EXTRA_APPLICATION_ID,
cordova.getActivity().getPackageName());
this.cordova.getActivity().startActivity(intent);
return "";
-// not catching FileUriExposedException explicitly because
buildtools<24 doesn't know about it
+// not catching FileUriExposedException explicitly because
buildtools<24 doesn't know about it
} catch (java.lang.RuntimeException e) {
-LOG.d(LOG_TAG, "InAppBrowser: Error loading url "+url+":"+
e.toString());
+LOG.d(LOG_TAG, "InAppBrowser: Error loading url " + url + ":" +
e.toString());
return e.toString();
}
}
diff --git a/src/windows/InAppBrowserProxy.js b/src/windows/InAppBrowserProxy.js
index dec91dba..b03e8206 100644
--- a/src/windows/InAppBrowserProxy.js
+++ b/src/windows/InAppBrowserProxy.js
@@ -135,7 +135,12 @@ var IAB = {
if (target === "_system") {
url = new Windows.Foundation.Uri(strUrl);
-Windows.System.Launcher.launchUriAsync(url);
+var options = new Windows.System.LauncherOptions();
+if (url.schemeName === 'data') {
+options.contentType = "text/html";
+}
+
+Windows.System.Launcher.launchUriAsync(url, options);
} else if (target === "_self" || !target) {
window.location = strUrl;
} else {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> InAppBrowser - Cannot open data URLs in system browser
>
[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance
[ https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329349#comment-16329349 ] ASF GitHub Bot commented on CB-13309: - infil00p commented on issue #242: CB-13309: InAppBrowser as a Library Project URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242#issuecomment-358425257 Actually, I'll keep it open as a reference, but I don't have any time to work on this right now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make InAppBrowser a Library Module for easier maintenance > - > > Key: CB-13309 > URL: https://issues.apache.org/jira/browse/CB-13309 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser >Reporter: Joe Bowser >Priority: Major > > We currently just copy in Java files directly in a project, but that has some > major problems with layouts and resources. Now that Android allows Library > Projects, we can now add modules as plugins and allow for certain plugins > which require layouts (like the InAppBrowser) to define them in XML instead > of programmatically, which will allow for a lot of code to be deleted from > the project, and for the project to be easier to maintain for Android. > Another upshot of this change is that we can then add JUnit and Espresso > Integration Tests to plugins so that we can actually test plugin changes the > same way we run native tests on Android with the Android Test Project. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance
[
https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329346#comment-16329346
]
ASF GitHub Bot commented on CB-13309:
-
infil00p closed pull request #242: CB-13309: InAppBrowser as a Library Project
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/plugin.xml b/plugin.xml
index 5329fdfd..7031c239 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -45,25 +45,7 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
diff --git a/src/android/InAppBrowser/.gitignore
b/src/android/InAppBrowser/.gitignore
new file mode 100644
index ..796b96d1
--- /dev/null
+++ b/src/android/InAppBrowser/.gitignore
@@ -0,0 +1 @@
+/build
diff --git a/src/android/InAppBrowser/InAppBrowser.iml
b/src/android/InAppBrowser/InAppBrowser.iml
new file mode 100644
index ..d545ea40
--- /dev/null
+++ b/src/android/InAppBrowser/InAppBrowser.iml
@@ -0,0 +1,101 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ generateDebugSources
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/src/android/InAppBrowser/build.gradle
b/src/android/InAppBrowser/build.gradle
new file mode 100644
index ..6fc1a36f
--- /dev/null
+++ b/src/android/InAppBrowser/build.gradle
@@ -0,0 +1,40 @@
+buildscript {
+repositories {
+mavenCentral()
+}
+dependencies {
+classpath 'com.android.tools.build:gradle:2.1.0'
+}
+}
+
+apply plugin: 'com.android.library'
+
+android {
+compileSdkVersion 23
+buildToolsVersion "23.0.2"
+
+defaultConfig {
+minSdkVersion 14
+targetSdkVersion 23
+versionCode 1
+versionName "1.0"
+}
+
+
+buildTypes {
+release {
+minifyEnabled false
+proguardFiles getDefaultProguardFile('proguard-android.txt'),
'proguard-rules.pro'
+}
+}
+
+// This is required once you specify debug and non-debug builds
+publishNonDefault true
+
+}
+
+dependencies {
+compile fileTree(include: ['*.jar'], dir: 'libs')
+testCompile 'junit:junit:4.12'
+compile project(':CordovaLib')
+}
diff --git a/src/android/InAppBrowser/proguard-rules.pro
b/src/android/InAppBrowser/proguard-rules.pro
new file mode 100644
index ..73631aff
--- /dev/null
+++ b/src/android/InAppBrowser/proguard-rules.pro
@@ -0,0 +1,17 @@
+# Add project specific ProGuard rules here.
+# By default, the flags in this file are appended to flags specified
+# in /Users/jbowser/Library/Android/sdk/tools/proguard/proguard-android.txt
+# You can edit the include path and order by changing the proguardFiles
+# directive in build.gradle.
+#
+# For more details, see
+# http://developer.android.com/guide/developing/tools/proguard.html
+
+# Add any project specific keep options here:
+
+# If your project uses WebView with JS, uncomment the following
+# and specify the fully qualified class name to the JavaScript interface
+# class:
+#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
+# public *;
+#}
diff --git
a/src/android/InAppBrowser/src/androidTest/java/org/apache/cordova/inappbrowser/ApplicationTest.java
b/src/android/InAppBrowser/src/androidTest/java/org/apache/cordova/inappbrowser/ApplicationTest.java
new file mode 100644
index ..5e52219a
--- /dev/null
+++
b/src/android/InAppBrowser/src/androidTest/java/org/apache/cordova/inappbrowser/ApplicationTest.java
@@ -0,0 +1,13 @@
+package org.apache.cordova.inappbrowser;
+
+import android.app.Application;
+import android.test.ApplicationTestCase;
+
+/**
+ * http://d.android.com/tools/testing/testing_android.html;>Testing
Fundamentals
+ */
+public class ApplicationTest extends ApplicationTestCase {
+public ApplicationTest() {
+super(Application.class);
+}
+}
\ No newline at end of file
[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance
[ https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329347#comment-16329347 ] ASF GitHub Bot commented on CB-13309: - infil00p opened a new pull request #242: CB-13309: InAppBrowser as a Library Project URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242 ### Platforms affected Android ### What does this PR do? This changes the Android code so that the plugin is installed as a Library Project, and the Assets, Code and Layout are managed in their own project instead of copied into the generated project. ### What testing has been done on this change? * Tested against mobilespec * Tested against CI ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make InAppBrowser a Library Module for easier maintenance > - > > Key: CB-13309 > URL: https://issues.apache.org/jira/browse/CB-13309 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser >Reporter: Joe Bowser >Priority: Major > > We currently just copy in Java files directly in a project, but that has some > major problems with layouts and resources. Now that Android allows Library > Projects, we can now add modules as plugins and allow for certain plugins > which require layouts (like the InAppBrowser) to define them in XML instead > of programmatically, which will allow for a lot of code to be deleted from > the project, and for the project to be easier to maintain for Android. > Another upshot of this change is that we can then add JUnit and Espresso > Integration Tests to plugins so that we can actually test plugin changes the > same way we run native tests on Android with the Android Test Project. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance
[ https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329345#comment-16329345 ] ASF GitHub Bot commented on CB-13309: - infil00p commented on issue #242: CB-13309: InAppBrowser as a Library Project URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242#issuecomment-358424993 Sadly, this conflicts hard with the programmatic approach that people want to adopt, so I'm going to close this for now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make InAppBrowser a Library Module for easier maintenance > - > > Key: CB-13309 > URL: https://issues.apache.org/jira/browse/CB-13309 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser >Reporter: Joe Bowser >Priority: Major > > We currently just copy in Java files directly in a project, but that has some > major problems with layouts and resources. Now that Android allows Library > Projects, we can now add modules as plugins and allow for certain plugins > which require layouts (like the InAppBrowser) to define them in XML instead > of programmatically, which will allow for a lot of code to be deleted from > the project, and for the project to be easier to maintain for Android. > Another upshot of this change is that we can then add JUnit and Espresso > Integration Tests to plugins so that we can actually test plugin changes the > same way we run native tests on Android with the Android Test Project. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5758) Give same behavior to InAppBrowser as CordovaWebView for self-signed certs
[ https://issues.apache.org/jira/browse/CB-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329341#comment-16329341 ] ASF GitHub Bot commented on CB-5758: infil00p commented on issue #243: CB-5758: (android/ios) support trusting self-signed certificates URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/243#issuecomment-358424711 Going to close this PR, since it needs a bit of a rethink. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Give same behavior to InAppBrowser as CordovaWebView for self-signed certs > -- > > Key: CB-5758 > URL: https://issues.apache.org/jira/browse/CB-5758 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Reporter: Marcel Kinard >Priority: Minor > > See CB-3576 for history. This is a request that came from there. > At least on the Android platform, the main webview (CordovaWebView) will > silently accept self-signed certs when debuggable="true" in > AndroidManifest.xml. (Hopefully other platforms have a similar behavior in > pre-production.) The goal of this new feature is to get InAppBrowser to have > the same behavior as the main webview in this respect, which is does not have > today. Then both the main webview and InAppBrowser will behave consistently > when they encounter https connections that have a self-signed cert. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13775) cordova-android@6.2.3 failed with android-versionCode="19"
[ https://issues.apache.org/jira/browse/CB-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329321#comment-16329321 ] Barry Fawthrop commented on CB-13775: - Joe Thanks I have tried npm install and it only occurs when I set compileSdkVersion of cdvCompileSdkVersion How do Identify which, module is linked to dezalgo ? Thanks in advance > cordova-android@6.2.3 failed with android-versionCode="19" > -- > > Key: CB-13775 > URL: https://issues.apache.org/jira/browse/CB-13775 > Project: Apache Cordova > Issue Type: Bug >Reporter: Barry Fawthrop >Priority: Major > > using cordova-android@6.2.3 > with >"cordova-plugin-device": "2.0.1", > "cordova-plugin-file": "4.3.3", > "cordova-plugin-geolocation": "2.4.3", > "cordova-plugin-media": "2.4.1", > if I set in config.xml > it trys to use Android SDK 19 which is good But failed with > npm ERR! path > /Users/Barry/Desktop/Rolling/rsmobile/node_modules/npm/node_modules/dezalgo > npm ERR! code ENOENT > npm ERR! errno -2 > npm ERR! syscall rename > npm ERR! enoent ENOENT: no such file or directory, rename > '/Users/Barry/demo/node_modules/npm/node_modules/dezalgo' -> > '/Users/Barry/demo/node_modules/npm/node_modules/.dezalgo.DELETE' > npm ERR! enoent This is related to npm not being able to find a file. > npm ERR! enoent > npm ERR! A complete log of this run can be found in: > How is cordova-androidtied to dezalgo ? > Thanks in advance -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13724) Bump Target SDK to 27
[ https://issues.apache.org/jira/browse/CB-13724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329319#comment-16329319 ] ASF subversion and git services commented on CB-13724: -- Commit 6cc4896690e73503a2281d7b63640f6d4ed5ffaa in cordova-android's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=6cc4896 ] Merge pull request #426 from infil00p/api_level_bump CB-13724: Bump Target SDK to API 27 > Bump Target SDK to 27 > - > > Key: CB-13724 > URL: https://issues.apache.org/jira/browse/CB-13724 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: cordova-android@7.0.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13724) Bump Target SDK to 27
[ https://issues.apache.org/jira/browse/CB-13724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329317#comment-16329317 ] ASF subversion and git services commented on CB-13724: -- Commit 5c93c214b9c13f71703a4bc3b5c55f28031a20f0 in cordova-android's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=5c93c21 ] CB-13724: Bump Target SDK to API 27 > Bump Target SDK to 27 > - > > Key: CB-13724 > URL: https://issues.apache.org/jira/browse/CB-13724 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: cordova-android@7.0.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13724) Bump Target SDK to 27
[ https://issues.apache.org/jira/browse/CB-13724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329318#comment-16329318 ] ASF subversion and git services commented on CB-13724: -- Commit 0d1692681fd2891a2f67f9c5e17c4946446d0d5f in cordova-android's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=0d16926 ] CB-13724: Updated the Android Tooling required for the latest version on both the test project, and the template > Bump Target SDK to 27 > - > > Key: CB-13724 > URL: https://issues.apache.org/jira/browse/CB-13724 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: cordova-android@7.0.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13788) Specify the minimum required version of google play services for plugins
[ https://issues.apache.org/jira/browse/CB-13788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329315#comment-16329315 ] ASF GitHub Bot commented on CB-13788: - infil00p commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins URL: https://github.com/apache/cordova-android/pull/428#issuecomment-358422233 @wf9a5m75 Your PR has failed eslint. You need to fix your eslint errors before I can accept this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Specify the minimum required version of google play services for plugins > > > Key: CB-13788 > URL: https://issues.apache.org/jira/browse/CB-13788 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: cordova-android-7.0.0 >Reporter: Masashi Katsumata >Assignee: Joe Bowser >Priority: Major > Labels: patch > > Many plugins use the Google Play Services SDK, but it is really heavy. > Some developers want to specify particular versions, but not all of plugin > developers. > Some other developers don't want to update their plugin frequently, but want > to specify minimum required version. > I found this code > [https://github.com/apache/cordova-android/blob/673a6773b2f78ba76d2144c66ab7a3add78648ae/bin/templates/cordova/lib/builders/StudioBuilder.js#L177-L201] > This allows us to specify like this > ** > > But the code does not accept particular module. > * versions=">=11.8.0" />* > > In order to specify particular module, we need to change the code. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13724) Bump Target SDK to 27
[
https://issues.apache.org/jira/browse/CB-13724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329316#comment-16329316
]
ASF GitHub Bot commented on CB-13724:
-
infil00p closed pull request #426: CB-13724: Bump Target SDK to API 27
URL: https://github.com/apache/cordova-android/pull/426
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/templates/project/app/build.gradle
b/bin/templates/project/app/build.gradle
index 32e31f6c8..586bcfa46 100644
--- a/bin/templates/project/app/build.gradle
+++ b/bin/templates/project/app/build.gradle
@@ -29,7 +29,7 @@ buildscript {
}
dependencies {
-classpath 'com.android.tools.build:gradle:3.0.0'
+classpath 'com.android.tools.build:gradle:3.0.1'
}
}
diff --git a/bin/templates/project/build.gradle
b/bin/templates/project/build.gradle
index fb8082da2..7b2381545 100644
--- a/bin/templates/project/build.gradle
+++ b/bin/templates/project/build.gradle
@@ -42,10 +42,10 @@ allprojects {
}
//This replaces project.properties w.r.t. build settings
project.ext {
- defaultBuildToolsVersion="25.0.2" //String
+ defaultBuildToolsVersion="27.0.1" //String
defaultMinSdkVersion=19 //Integer - Minimum requirement is Android 4.4
- defaultTargetSdkVersion=26 //Integer - We ALWAYS target the latest by
default
- defaultCompileSdkVersion=26 //Integer - We ALWAYS compile with the
latest by default
+ defaultTargetSdkVersion=27 //Integer - We ALWAYS target the latest by
default
+ defaultCompileSdkVersion=27 //Integer - We ALWAYS compile with the
latest by default
}
}
diff --git a/framework/project.properties b/framework/project.properties
index c48b00b8b..0a372ee40 100644
--- a/framework/project.properties
+++ b/framework/project.properties
@@ -10,7 +10,7 @@
# Indicates whether an apk should be generated for each density.
split.density=false
# Project target.
-target=android-26
+target=android-27
apk-configurations=
renderscript.opt.level=O0
android.library=true
diff --git a/test/app/build.gradle b/test/app/build.gradle
index de5a2a24c..d63d8ff44 100644
--- a/test/app/build.gradle
+++ b/test/app/build.gradle
@@ -19,12 +19,12 @@
apply plugin: 'com.android.application'
android {
-compileSdkVersion 26
-buildToolsVersion "26.0.2"
+compileSdkVersion 27
+buildToolsVersion "27.0.1"
defaultConfig {
applicationId "org.apache.cordova.unittests"
minSdkVersion 19
-targetSdkVersion 26
+targetSdkVersion 27
versionCode 1
versionName "1.0"
testInstrumentationRunner
"android.support.test.runner.AndroidJUnitRunner"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bump Target SDK to 27
> -
>
> Key: CB-13724
> URL: https://issues.apache.org/jira/browse/CB-13724
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-android
>Affects Versions: cordova-android@7.0.0
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13510) Copy/Paste functionality is not working for iOS native components.
[ https://issues.apache.org/jira/browse/CB-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329313#comment-16329313 ] ASF GitHub Bot commented on CB-13510: - ssraza commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358421880 Not that I'm aware of... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Copy/Paste functionality is not working for iOS native components. > -- > > Key: CB-13510 > URL: https://issues.apache.org/jira/browse/CB-13510 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0, cordova-ios 4.5.0 > Environment: iOS 11 and up... Not reproducible in iOS 10.x >Reporter: Aqeel Raza Syed >Assignee: Suraj Pindoria >Priority: Major > > With iOS11 upgrade Cordova-ios library is braking copy/paste functionality > for consumer apps utilizing both web and native UI. > *Steps to reproduce :* > - Copy text to clipboard (e.g. Notes app) > - Foreground consumer app (app must be running in background) > - Paste clipboard text to native UI component (i.e. UITextField) > *Expected:* > - Text should be pasted on native UI component > *Actual:* > - Nothing happens > *Note:* This only happens with native UI components and works fine with Web > interface. Also once consumer app goes foreground, after backgrounding that > app, clipboard text can never be pasted in any other iOS app with native UI. > *Investigation:* > Seems like following patch fix is causing this issue in iOS 11: > https://github.com/apache/cordova-ios/pull/139 > *Potential Fix:* Since above patch has been done a while ago, removing that > bit of code, doesn't seems to reintroduce original bug (i.e. > https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13647) Incomplete plugin restoration
[
https://issues.apache.org/jira/browse/CB-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329302#comment-16329302
]
Michael Goffioul commented on CB-13647:
---
When will plugins be ported to use new paths? I've checked a couple of them and
they're still using legacy paths?
> Incomplete plugin restoration
> -
>
> Key: CB-13647
> URL: https://issues.apache.org/jira/browse/CB-13647
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 7.0.0
>Reporter: Michael Goffioul
>Assignee: Joe Bowser
>Priority: Major
> Labels: android-next
>
> I'm having a problem with plugin restoration since cordova-android 7.0.0,
> when plugins use a mix of config-file and edit-config on the same file (e.g.
> AndroidManifest.xml) and only edit-config uses the real path to the file.
> I've tried both cordova-cli 6.5.0 and 7.1.0 with the same result.
> 1) Create a new corodva project and enter top-level direcotyr
> 2) Create subfolder to contain a local plugin: mkdir -p
> localplugins/testplugin1
> 3) Create the following files to define the local plugin:
> - plugin.xml (adds an attribute to and a category to
> )
> {code}
>
> http://apache.org/cordova/ns/plugins/1.0;
> id="com.example.testplugin1" version="1.0.0">
> Test Plugin 1
>
> parent="/manifest/application/activity/intent-filter">
>
>
> target="/manifest/application" mode="merge">
>
>
>
>
> {code}
> - package.json
> {code}
> {
> "name": "com.example.testplugin1",
> "version": "1.0.0"
> }
> {code}
> 4) Add android platform: cordova platform add android@7.0.0 --save
> 5) Add local plugin: cordova plugin add localplugins/testplugin1 --save
> At this point, if you check
> platforms/android/app/src/main/AndroidManifest.xml, it'll contain the 2
> changes defined in the plugin.
> Now attempt to use platform/plugin restoration with thw following:
> {code}
> cordova platform rm android
> cordova prepare android
> {code}
> If you check again AndroidManifest.xml, it will only contain one of the
> changes defined in the plugin (the attribute to ). The other
> change is missing.
> If you use the real path to AndroidManifest.xml for the definition of
> , then the problem does not occur. BUT, the problem can also
> occur when changes to AndroidManifest.xml are coming from multiple plugins,
> including the standard cordova plugin, most of which do not use the real path
> to AndroidManifest.xml yet.
> The problem can affect other files too. For instance I experienced incomplete
> restoration of plugins trying to register themselves in res/xml/config.xml.
> Only one plugin, out of 7, was using the real path
> app/src/main/res/xml/config.xml and I ended up with only one plugin defined
> in res/xml/config.xml, causing the application to fail to start.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329273#comment-16329273 ] ASF GitHub Bot commented on CB-7179: dpa99c commented on issue #245: CB-7179 (iOS): Finish off WKWebView implementation URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-358416278 @infil00p The [original apache/wkwebview branch](https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview) that I made as the merge target was last updated by @shazron in 2014, so is majorly out of date with respect to [apache/master](https://github.com/apache/cordova-plugin-inappbrowser/tree/master). So my `dpa99c/wkwebview` fork is based on `apache/master` at the time the PR was created. Would you rather I fork the current `apache/master` and apply my WKWebView changes to that? Because applying them to the 2014 `apache/wkwebview` doesn't seem that useful... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13510) Copy/Paste functionality is not working for iOS native components.
[ https://issues.apache.org/jira/browse/CB-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329253#comment-16329253 ] ASF GitHub Bot commented on CB-13510: - purplecabbage commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358413194 Does this re-break iOS 10? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Copy/Paste functionality is not working for iOS native components. > -- > > Key: CB-13510 > URL: https://issues.apache.org/jira/browse/CB-13510 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0, cordova-ios 4.5.0 > Environment: iOS 11 and up... Not reproducible in iOS 10.x >Reporter: Aqeel Raza Syed >Assignee: Suraj Pindoria >Priority: Major > > With iOS11 upgrade Cordova-ios library is braking copy/paste functionality > for consumer apps utilizing both web and native UI. > *Steps to reproduce :* > - Copy text to clipboard (e.g. Notes app) > - Foreground consumer app (app must be running in background) > - Paste clipboard text to native UI component (i.e. UITextField) > *Expected:* > - Text should be pasted on native UI component > *Actual:* > - Nothing happens > *Note:* This only happens with native UI components and works fine with Web > interface. Also once consumer app goes foreground, after backgrounding that > app, clipboard text can never be pasted in any other iOS app with native UI. > *Investigation:* > Seems like following patch fix is causing this issue in iOS 11: > https://github.com/apache/cordova-ios/pull/139 > *Potential Fix:* Since above patch has been done a while ago, removing that > bit of code, doesn't seems to reintroduce original bug (i.e. > https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329219#comment-16329219 ] ASF subversion and git services commented on CB-13409: -- Commit 6c2a8f4576e34ab29ffce102f12efb9c494ba386 in cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=6c2a8f4 ] CB-13409: restore gitignore to default > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329220#comment-16329220 ] ASF subversion and git services commented on CB-13409: -- Commit ec2f12c8728f4ed39244bd6f3ae011e124e1ddce in cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=ec2f12c ] CB-13409: restore gitignore to default > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329223#comment-16329223 ] ASF subversion and git services commented on CB-13409: -- Commit 84a4644cd136df9e1311bce0d1c62cacb1969a7b in cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=84a4644 ] Merge branch 'master' of https://github.com/apache/cordova-plugin-inappbrowser into CB-13409 > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329221#comment-16329221 ] ASF subversion and git services commented on CB-13409: -- Commit ff230d429a3975c670f16e9e8cdf21c6ef874be8 in cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=ff230d4 ] CB-13409: restore gitignore to default > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329217#comment-16329217 ] ASF subversion and git services commented on CB-13409: -- Commit 4af420c5920bd779efd9ab19613e132d51040e2b in cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=4af420c ] CB-13409: change hidetoolbarnavigationbuttons to hidenavigationbuttons in iso > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329222#comment-16329222 ] ASF subversion and git services commented on CB-13409: -- Commit d46f5d45d521eef5faffe0ed71718ddc7c8dfd50 in cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=d46f5d4 ] CB-13409: restore gitignore to default > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329224#comment-16329224 ] ASF subversion and git services commented on CB-13409: -- Commit c80c338e51657da600ee56af5079a125426dd00f in cordova-plugin-inappbrowser's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=c80c338 ] Merge pull request #246 from landsbankinn/CB-13409 Cb 13409 - Add more configurable options for toolbar in android and ios > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329218#comment-16329218 ] ASF subversion and git services commented on CB-13409: -- Commit 55b02285f93515c0f153b0f89366d978192dd900 in cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=55b0228 ] CB-13409: ignore idea folder > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329215#comment-16329215 ] ASF subversion and git services commented on CB-13409: -- Commit 8711ee3f211bf84913ae86f81e5e0e548d1c8015 in cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=8711ee3 ] CB-13409: Lets user adjust color of toolbar, hide navigation buttons and set custom text on close button > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13409) Allow more additional options, for customizing toolbar in cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329216#comment-16329216 ] ASF subversion and git services commented on CB-13409: -- Commit e691212c967fe866551c126e00f4cc7f09c6dfb9 in cordova-plugin-inappbrowser's branch refs/heads/master from [~steinaragust] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=e691212 ] CB-13409: Android works well now, all changes are now documented > Allow more additional options, for customizing toolbar in cordova/inappbrowser > -- > > Key: CB-13409 > URL: https://issues.apache.org/jira/browse/CB-13409 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS, Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: features, newbie > Attachments: Android - 1.png, Android - 2.png, Android - 3.png, > Android - 4.png, Android - 5.png, iOS - 1.PNG > > Original Estimate: 0h > Remaining Estimate: 0h > > I added a couple of customizations to inappbrowser's toolbar: > *Android*: > - Have a custom text for a close button instead of the Default X: > _closebuttoncaption_: "set to a string to use as the close buttons caption > instead of a X. Note that you need to localize this value yourself." > - Change the close button color: > _closebuttoncolor_: "set to a valid hex color string, for example: `#00ff00`, > and it will change the close button color from default, regardless of being a > text or default X. Only has effect if user has location set to `yes`." > - Hide the navigation buttons that go backwards and forwards: > _hidenavigationbuttons_: "set to `yes` to hide the navigation buttons on the > location toolbar, only has effect if user has location set to `yes`. The > default value is `no`." > - Change navigation buttons color: > _navigationbuttoncolor_: "set to a valid hex color string, for example: > `#00ff00`, and it will change the color of both navigation buttons from > default. Only has effect if user has location set to `yes` and not > hidenavigationbuttons set to `yes`." > - Change color of toolbar: > _toolbarcolor_: "set to a valid hex color string, for example: `#00ff00`, and > it will change the color the toolbar from default. Only has effect if user > has location set to `yes`." > *iOS:* > - _closebuttoncolor_ (same as above) > - _hidenavigationbuttons_ (same as above) > - _toolbarcolor_ (same as above) > - Make toolbar non-translucent: > _toolbartranslucent_: "set to `yes` or `no` to make the toolbar > translucent(semi-transparent) (defaults to `yes`). Only applicable if > toolbar is not disabled." > See screenshots in attachments. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329199#comment-16329199 ] ASF GitHub Bot commented on CB-7179: infil00p commented on issue #245: CB-7179 (iOS): Finish off WKWebView implementation URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-358406390 This needs to be cleaned up, since there's too many commits from other people in this PR. Can you do this PR again, this time with just the code that you authored in the PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13790) Prepare www folder without requiring project to be created
[ https://issues.apache.org/jira/browse/CB-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh updated CB-13790: -- Description: With the growing uptake of code pushing software (such as [https://github.com/Microsoft/code-push]), it would be really useful to allow the generation of plugins and the corresponding www folder without needing to create the rest of the project around it. This allows www folder deployments to be packaged without the need for extraneous steps. Is this feasable? was: With the growing uptake of code pushing software (such as [https://github.com/Microsoft/code-push]), it would be really useful to allow the genreation of plugins and the corresponding www folder without needing to create the rest of the project around it. Is this feasable? > Prepare www folder without requiring project to be created > -- > > Key: CB-13790 > URL: https://issues.apache.org/jira/browse/CB-13790 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-ios >Reporter: Josh >Assignee: Joe Bowser >Priority: Major > > With the growing uptake of code pushing software (such as > [https://github.com/Microsoft/code-push]), it would be really useful to allow > the generation of plugins and the corresponding www folder without needing to > create the rest of the project around it. This allows www folder deployments > to be packaged without the need for extraneous steps. > Is this feasable? > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13790) Prepare www folder without requiring project to be created
Josh created CB-13790: - Summary: Prepare www folder without requiring project to be created Key: CB-13790 URL: https://issues.apache.org/jira/browse/CB-13790 Project: Apache Cordova Issue Type: Improvement Components: cordova-android, cordova-ios Reporter: Josh Assignee: Joe Bowser With the growing uptake of code pushing software (such as [https://github.com/Microsoft/code-push]), it would be really useful to allow the genreation of plugins and the corresponding www folder without needing to create the rest of the project around it. Is this feasable? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13259) Crash on Samsung devices with android 6+
[
https://issues.apache.org/jira/browse/CB-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328826#comment-16328826
]
Veniamin Craciun commented on CB-13259:
---
[~reinierpd], I added some checks before dismissing the dialog.
And it looks like this right now.
{code:java|title=InAppBrowser.java|borderStyle=solid}
public void closeDialog() {
...
childView.setWebViewClient(
// NB: wait for about:blank before dismissing
public void onPageFinished(WebView view, String url) {
Context context = view.getContext();
if(dialog == null || !dialog.isShowing()){
return;
}
if(context instanceof Activity) {
if(!((Activity)context).isFinishing()) {
dialog.dismiss();
dialog = null;
}
}else {
dialog.dismiss();
dialog = null;
}
}
});
...
{code}
> Crash on Samsung devices with android 6+
>
>
> Key: CB-13259
> URL: https://issues.apache.org/jira/browse/CB-13259
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova@7.0.0
> Environment: InAppBrowser 1.7.1
> OS: Android 6 and 7
> Samsung and Huawei devices
>Reporter: Veniamin Craciun
>Priority: Major
>
> Using latest version of cordova and InAppBrowser a crash occurs on Samsung
> and Huawei devices that run Android 6 or 7.
> Below is a google crash report from such device:
> {color:red}java.lang.IllegalArgumentException:
> at android.view.WindowManagerGlobal.findViewLocked
> (WindowManagerGlobal.java:473)
> at android.view.WindowManagerGlobal.removeView
> (WindowManagerGlobal.java:382)
> at android.view.WindowManagerImpl.removeViewImmediate
> (WindowManagerImpl.java:128)
> at android.app.Dialog.dismissDialog (Dialog.java:610)
> at android.app.Dialog.dismiss (Dialog.java:593)
> at org.apache.cordova.inappbrowser.InAppBrowser$5$1.onPageFinished
> (InAppBrowser.java:434)
> at com.android.webview.chromium.WebViewContentsClientAdapter.onPageFinished
> (WebViewContentsClientAdapter.java:196)
> at
> org.chromium.android_webview.AwContentsClientCallbackHelper$MyHandler.handleMessage
> (AwContentsClientCallbackHelper.java:65)
> at android.os.Handler.dispatchMessage (Handler.java:102)
> at android.os.Looper.loop (Looper.java:154)
> at android.app.ActivityThread.main (ActivityThread.java:6682)
> at java.lang.reflect.Method.invoke (Native Method)
> at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
> (ZygoteInit.java:1520)
> at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410){color}
> I already searched such crash and I couldn't find any report of this for
> cordova or inappbrowser. The problem seems to be occuring
> [here|https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L434]
> that's because on samsung device it's needed to verify if dialog.isShowing()
> as stated from a StackOverflow
> [answer|https://stackoverflow.com/a/19511069/6723787]. That being said I
> think the bug can be easily solved by changing one line. I also want to
> mention that app only crashes if user has enabled "Don't keep activities" on
> Settings->Developer Options.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13652) Inappbrowser doesn't support 'camera' option when I can 'choose file'
[ https://issues.apache.org/jira/browse/CB-13652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328661#comment-16328661 ] Corneel den Hartogh edited comment on CB-13652 at 1/17/18 12:31 PM: [~jcesarmobile] And are there any plans when this feature will be implemented? Or can we make a small donation or set a put some money on it in order to speed up the process or anything else? Since we would love to see this feature in the coming months. was (Author: corneeldh): [~jcesarmobile] And are there any plans to make this work or is there a FR that I can vote up or something? > Inappbrowser doesn't support 'camera' option when I can 'choose file' > - > > Key: CB-13652 > URL: https://issues.apache.org/jira/browse/CB-13652 > Project: Apache Cordova > Issue Type: New Feature >Affects Versions: cordova-ios 4.5.0 > Environment: Android 5.1 >Reporter: Corneel den Hartogh >Priority: Major > Attachments: Screenshot_2017-12-10-10-01-15.png, > Screenshot_2017-12-10-10-01-25.png, Screenshot_2017-12-10-10-01-45.png, > Screenshot_2017-12-10-10-03-26.png > > > If open an url in Chrome on my Android device and there is a 'choose file' in > the link, clicking on this result in 'choose action' where I have several > options including 'camera' and 'documents'. > Same url in the inappbrowser gives me immediately the 'documents'-selection. > I have added the following lines to the androidmanifest.xml > > > and added the camera plugin (in config.xml): > > I still have to test on iOS, but is this a known bug? And / or is there a > workaround to get the possibility to select camera. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13652) Inappbrowser doesn't support 'camera' option when I can 'choose file'
[ https://issues.apache.org/jira/browse/CB-13652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328661#comment-16328661 ] Corneel den Hartogh commented on CB-13652: -- [~jcesarmobile] And are there any plans to make this work or is there a FR that I can vote up or something? > Inappbrowser doesn't support 'camera' option when I can 'choose file' > - > > Key: CB-13652 > URL: https://issues.apache.org/jira/browse/CB-13652 > Project: Apache Cordova > Issue Type: New Feature >Affects Versions: cordova-ios 4.5.0 > Environment: Android 5.1 >Reporter: Corneel den Hartogh >Priority: Major > Attachments: Screenshot_2017-12-10-10-01-15.png, > Screenshot_2017-12-10-10-01-25.png, Screenshot_2017-12-10-10-01-45.png, > Screenshot_2017-12-10-10-03-26.png > > > If open an url in Chrome on my Android device and there is a 'choose file' in > the link, clicking on this result in 'choose action' where I have several > options including 'camera' and 'documents'. > Same url in the inappbrowser gives me immediately the 'documents'-selection. > I have added the following lines to the androidmanifest.xml > > > and added the camera plugin (in config.xml): > > I still have to test on iOS, but is this a known bug? And / or is there a > workaround to get the possibility to select camera. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13392) Display app version on splashscreen
[
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328593#comment-16328593
]
ASF GitHub Bot commented on CB-13392:
-
jcesarmobile commented on a change in pull request #148: CB-13392(Android &
iOS): Display app version on splashscreen
URL:
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r162008238
##
File path: src/ios/CDVSplashScreen.m
##
@@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath
ofObject:(id)object change:(NS
[self updateImage];
}
+- (UIColor *)colorFromHexString:(NSString *)hexString {
Review comment:
statusbar plugin uses a similar code for this. It's in the plugin, not
provided by Cordova. It also checks that the color is a string (it's not a
problem here as it's a preference, so I think we can be sure that it's a
string. But also checks the length and the #
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
> Labels: beginner, features
> Original Estimate: 14h
> Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's
> bottom.
> You could configure the color, size and position (left, center, right) with
> preferences into config.xml.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13392) Display app version on splashscreen
[
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328574#comment-16328574
]
ASF GitHub Bot commented on CB-13392:
-
johnlejardinnier commented on a change in pull request #148: CB-13392(Android &
iOS): Display app version on splashscreen
URL:
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r162004407
##
File path: src/ios/CDVSplashScreen.m
##
@@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath
ofObject:(id)object change:(NS
[self updateImage];
}
+- (UIColor *)colorFromHexString:(NSString *)hexString {
Review comment:
For the moment i will not change this part because i don't know what is the
better solution.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
> Labels: beginner, features
> Original Estimate: 14h
> Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's
> bottom.
> You could configure the color, size and position (left, center, right) with
> preferences into config.xml.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13392) Display app version on splashscreen
[
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328517#comment-16328517
]
ASF GitHub Bot commented on CB-13392:
-
johnlejardinnier commented on a change in pull request #148: CB-13392(Android &
iOS): Display app version on splashscreen
URL:
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161989736
##
File path: src/ios/CDVSplashScreen.m
##
@@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath
ofObject:(id)object change:(NS
[self updateImage];
}
+- (UIColor *)colorFromHexString:(NSString *)hexString {
+unsigned rgbValue = 0;
+NSScanner *scanner = [NSScanner scannerWithString:hexString];
+[scanner setScanLocation:1]; // bypass '#' character
+[scanner scanHexInt:];
+return [UIColor colorWithRed:((rgbValue & 0xFF) >> 16)/255.0
green:((rgbValue & 0xFF00) >> 8)/255.0 blue:(rgbValue & 0xFF)/255.0 alpha:1.0];
+}
+
+-(UIImage*) drawText:(NSString*) text inImage:(UIImage*) image
gravity:(NSString*) gravity fontSize:(CGFloat) fontSize fontColor:(NSString*)
fontColor
+{
+
+UIFont *font = [UIFont boldSystemFontOfSize:fontSize];
+UIGraphicsBeginImageContext(image.size);
+[image drawInRect:CGRectMake(0,0,image.size.width,image.size.height)];
+
+UIScreen* mainScreen = [UIScreen mainScreen];
+CGFloat mainScreenHeight = mainScreen.bounds.size.height;
+CGFloat mainScreenWidth = mainScreen.bounds.size.width;
+
+CGSize textSize = [text sizeWithFont:font];
+CGFloat padding = 15.0;
+CGFloat position = mainScreenWidth - (textSize.width + padding);
+
+if([gravity isEqualToString:@"left"]) {
+position = padding;
+} else if ([gravity isEqualToString:@"center"]) {
+position = (mainScreenWidth / 2) - padding;
+}
+
+CGRect rect = CGRectMake(position, mainScreenHeight - 30.0,
textSize.width, textSize.height);
+UIColor *color = [self colorFromHexString:fontColor];
+[color set];
+[text drawInRect:CGRectIntegral(rect) withFont:font];
+UIImage *newImage = UIGraphicsGetImageFromCurrentImageContext();
+UIGraphicsEndImageContext();
+
+return newImage;
+}
+
+
+-(NSString*) getAppVersion
+{
+NSString* version = [[[NSBundle mainBundle] infoDictionary]
objectForKey:@"CFBundleShortVersionString"];
+
+if (version == nil) {
+ NSLog(@"CFBundleShortVersionString was nil, attempting CFBundleVersion");
+ version = [[[NSBundle mainBundle] infoDictionary]
objectForKey:@"CFBundleVersion"];
+}
+
+
+if(version != nil) {
+version = [NSString stringWithFormat:@"v%@", version];
Review comment:
Here too, i'll use a preference.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
> Labels: beginner, features
> Original Estimate: 14h
> Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's
> bottom.
> You could configure the color, size and position (left, center, right) with
> preferences into config.xml.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13392) Display app version on splashscreen
[ https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328510#comment-16328510 ] ASF GitHub Bot commented on CB-13392: - johnlejardinnier commented on issue #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-358239026 @kerrishotts Thank you so much for your review. I will make some changes, then i'll push a new commit as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Display app version on splashscreen > --- > > Key: CB-13392 > URL: https://issues.apache.org/jira/browse/CB-13392 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-splashscreen >Affects Versions: Master > Environment: Available on Android and iOS. >Reporter: Jonathan Corral >Priority: Minor > Labels: beginner, features > Original Estimate: 14h > Remaining Estimate: 14h > > This feature allows you to display the app version number at splashscreen's > bottom. > You could configure the color, size and position (left, center, right) with > preferences into config.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13392) Display app version on splashscreen
[
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328506#comment-16328506
]
ASF GitHub Bot commented on CB-13392:
-
johnlejardinnier commented on a change in pull request #148: CB-13392(Android &
iOS): Display app version on splashscreen
URL:
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161987406
##
File path: src/android/SplashScreen.java
##
@@ -410,4 +428,60 @@ public void run() {
}
});
}
+
+private String getAppVersion() {
+
+ String appVersion = null;
+
+ try {
+
+String packageName = cordova.getActivity().getPackageName();
+PackageManager packageManager =
cordova.getActivity().getApplicationContext().getPackageManager();
+PackageInfo pi = packageManager.getPackageInfo(packageName, 0);
+
+appVersion = "v" + pi.versionName;
Review comment:
You're right, i will change that as a preference.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
> Labels: beginner, features
> Original Estimate: 14h
> Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's
> bottom.
> You could configure the color, size and position (left, center, right) with
> preferences into config.xml.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13789) Local plugins cannot be installed after a fresh installation
Olivier Goguel created CB-13789:
---
Summary: Local plugins cannot be installed after a fresh
installation
Key: CB-13789
URL: https://issues.apache.org/jira/browse/CB-13789
Project: Apache Cordova
Issue Type: Bug
Components: cordova-cli
Affects Versions: 7.0.2
Environment: It is in Cordova 8.0.0 (but the interface did not allow
me to select it!)
Reporter: Olivier Goguel
Local plugins fails to install after a fresh installation (from source control
for example)
*Steps:*
{{cordova create sample}}
{{cordova add plugin local/localplugin}}
{{rm -rf plugins # to simulate fresh installation}}
{{cordova platform add ios}}
{color:#FF}*Failed to restore plugin "localplugin" from config.xml. You
might need to try adding it again. Error: Failed to fetch plugin
file:local/localplugin via registry.*{color}
*Hints:*
The plugin does not install as cordova is confused by the "file:" prefix
When adding the plugin, it is referenced in package.json as {{"localplugin":
"file:local/localplugin", but in the config.xml the file: prefix has been
stripped ""}}
However, when restoring the plugin, it uses the file: prefix which is not
supported by the cli as the protocol is not properly handled: the fetch()
function just tries to load the plugin from the path being given, cannot find
it because of the prefix, and then assume it has to be loaded from the
registry, hence the error
cf. https://github.com/apache/cordova-lib/blob/master/src/plugman/fetch.js#L86
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
