[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342002#comment-16342002 ] ASF GitHub Bot commented on CB-13415: - alpesh12 commented on issue #309: CB-13415 (android) Importing corrupt images using the Camera plugin c… URL: https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-360965937 @jcesarmobile When this changes are merged to master? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341894#comment-16341894 ] ASF GitHub Bot commented on CB-13415: - shazron commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-360950863 Looks like the CI failures are paramedic related -- iOS tests pass which is good. I'll have to do a full review based on the new commits and test manually. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13838) Use android-versions in emulator.js for picking AVD
Joe Bowser created CB-13838: --- Summary: Use android-versions in emulator.js for picking AVD Key: CB-13838 URL: https://issues.apache.org/jira/browse/CB-13838 Project: Apache Cordova Issue Type: Improvement Reporter: Joe Bowser Fix For: android-7.2 We should stop doing the same task over and over again. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13838) Use android-versions in emulator.js for picking AVD
[ https://issues.apache.org/jira/browse/CB-13838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-13838: Component/s: cordova-android > Use android-versions in emulator.js for picking AVD > --- > > Key: CB-13838 > URL: https://issues.apache.org/jira/browse/CB-13838 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Reporter: Joe Bowser >Priority: Trivial > Fix For: android-7.2 > > > We should stop doing the same task over and over again. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13818) Need to update android_sdk.js to Support Android 8.0
[
https://issues.apache.org/jira/browse/CB-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Bowser resolved CB-13818.
-
Resolution: Fixed
> Need to update android_sdk.js to Support Android 8.0
> -
>
> Key: CB-13818
> URL: https://issues.apache.org/jira/browse/CB-13818
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Cordova 7.1.0
>
>Reporter: Zhao Bin
>Assignee: Joe Bowser
>Priority: Major
> Labels: easyfix
> Fix For: cordova-android-7.0.0
>
> Attachments: android_sdk.js error.png
>
>
> Currently I am working on a Cordova project and I am migrating to the new
> Android 8.0 emulator.
> Need to update android_sdk.js to add support for Android 8.0 emulator
> cordova-android / bin / templates / cordova / lib / android_sdk.js Line 53:
> module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25
> };
> This causes exception in emulator.js Line 210
> {color:#5fdfff}var{color}{color:#dfdfdf} project_target
> {color}{color:#ff1f7f}={color}{color:#dfdfdf}
> check_reqs.{color}{color:#9fdf2f}get_target{color}{color:#dfdfdf}().{color}{color:#5fdfff}replace{color}{color:#dfdfdf}({color}{color:#dfdf7f}'android-'{color}{color:#dfdfdf},
> {color}{color:#dfdf7f}''{color}{color:#dfdfdf});{color}
>
> {color:#33}I added '8.0': 26 in android_sdk.js and then it works.{color}
> {color:#33}module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25,{color}
> {color:#33} '8.0': 26
> };{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13818) Need to update android_sdk.js to Support Android 8.0
[
https://issues.apache.org/jira/browse/CB-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Bowser updated CB-13818:
Priority: Major (was: Critical)
I'm not going to say this was critical because I couldn't reproduce it, but
yeah, this did need to be done. In the long run, we should use
android-versions for this.
> Need to update android_sdk.js to Support Android 8.0
> -
>
> Key: CB-13818
> URL: https://issues.apache.org/jira/browse/CB-13818
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Cordova 7.1.0
>
>Reporter: Zhao Bin
>Assignee: Joe Bowser
>Priority: Major
> Labels: easyfix
> Fix For: cordova-android-7.0.0
>
> Attachments: android_sdk.js error.png
>
>
> Currently I am working on a Cordova project and I am migrating to the new
> Android 8.0 emulator.
> Need to update android_sdk.js to add support for Android 8.0 emulator
> cordova-android / bin / templates / cordova / lib / android_sdk.js Line 53:
> module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25
> };
> This causes exception in emulator.js Line 210
> {color:#5fdfff}var{color}{color:#dfdfdf} project_target
> {color}{color:#ff1f7f}={color}{color:#dfdfdf}
> check_reqs.{color}{color:#9fdf2f}get_target{color}{color:#dfdfdf}().{color}{color:#5fdfff}replace{color}{color:#dfdfdf}({color}{color:#dfdf7f}'android-'{color}{color:#dfdfdf},
> {color}{color:#dfdf7f}''{color}{color:#dfdfdf});{color}
>
> {color:#33}I added '8.0': 26 in android_sdk.js and then it works.{color}
> {color:#33}module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25,{color}
> {color:#33} '8.0': 26
> };{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13818) Need to update android_sdk.js to Support Android 8.0
[
https://issues.apache.org/jira/browse/CB-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341544#comment-16341544
]
ASF GitHub Bot commented on CB-13818:
-
infil00p closed pull request #431: CB-13818: (android) Update android_sdk.js to
support Android Oreo 8.0 (API 26) emulator
URL: https://github.com/apache/cordova-android/pull/431
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/templates/cordova/lib/android_sdk.js
b/bin/templates/cordova/lib/android_sdk.js
index ca8f9e338..148f9f3db 100755
--- a/bin/templates/cordova/lib/android_sdk.js
+++ b/bin/templates/cordova/lib/android_sdk.js
@@ -62,7 +62,8 @@ module.exports.version_string_to_api_level = {
'5.1': 22,
'6.0': 23,
'7.0': 24,
-'7.1.1': 25
+'7.1.1': 25,
+'8.0': 26
};
function parse_targets (output) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to update android_sdk.js to Support Android 8.0
> -
>
> Key: CB-13818
> URL: https://issues.apache.org/jira/browse/CB-13818
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Cordova 7.1.0
>
>Reporter: Zhao Bin
>Assignee: Joe Bowser
>Priority: Critical
> Labels: easyfix
> Fix For: cordova-android-7.0.0
>
> Attachments: android_sdk.js error.png
>
>
> Currently I am working on a Cordova project and I am migrating to the new
> Android 8.0 emulator.
> Need to update android_sdk.js to add support for Android 8.0 emulator
> cordova-android / bin / templates / cordova / lib / android_sdk.js Line 53:
> module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25
> };
> This causes exception in emulator.js Line 210
> {color:#5fdfff}var{color}{color:#dfdfdf} project_target
> {color}{color:#ff1f7f}={color}{color:#dfdfdf}
> check_reqs.{color}{color:#9fdf2f}get_target{color}{color:#dfdfdf}().{color}{color:#5fdfff}replace{color}{color:#dfdfdf}({color}{color:#dfdf7f}'android-'{color}{color:#dfdfdf},
> {color}{color:#dfdf7f}''{color}{color:#dfdfdf});{color}
>
> {color:#33}I added '8.0': 26 in android_sdk.js and then it works.{color}
> {color:#33}module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25,{color}
> {color:#33} '8.0': 26
> };{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13818) Need to update android_sdk.js to Support Android 8.0
[
https://issues.apache.org/jira/browse/CB-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341546#comment-16341546
]
ASF subversion and git services commented on CB-13818:
--
Commit 3d83fd784b2f796ee629f331b4c48c6ecf5d8d9a in cordova-android's branch
refs/heads/master from [~bowserj]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=3d83fd7 ]
Merge pull request #431 from sunday18/patch-1
CB-13818: (android) Update android_sdk.js to support Android Oreo 8.0 (API 26)
emulator
> Need to update android_sdk.js to Support Android 8.0
> -
>
> Key: CB-13818
> URL: https://issues.apache.org/jira/browse/CB-13818
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Cordova 7.1.0
>
>Reporter: Zhao Bin
>Assignee: Joe Bowser
>Priority: Critical
> Labels: easyfix
> Fix For: cordova-android-7.0.0
>
> Attachments: android_sdk.js error.png
>
>
> Currently I am working on a Cordova project and I am migrating to the new
> Android 8.0 emulator.
> Need to update android_sdk.js to add support for Android 8.0 emulator
> cordova-android / bin / templates / cordova / lib / android_sdk.js Line 53:
> module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25
> };
> This causes exception in emulator.js Line 210
> {color:#5fdfff}var{color}{color:#dfdfdf} project_target
> {color}{color:#ff1f7f}={color}{color:#dfdfdf}
> check_reqs.{color}{color:#9fdf2f}get_target{color}{color:#dfdfdf}().{color}{color:#5fdfff}replace{color}{color:#dfdfdf}({color}{color:#dfdf7f}'android-'{color}{color:#dfdfdf},
> {color}{color:#dfdf7f}''{color}{color:#dfdfdf});{color}
>
> {color:#33}I added '8.0': 26 in android_sdk.js and then it works.{color}
> {color:#33}module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25,{color}
> {color:#33} '8.0': 26
> };{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
***UNCHECKED*** [jira] [Created] (CB-13837) TypeScript Definition for CameraPopoverOptions does not declare class
Ryan Murphy created CB-13837:
Summary: TypeScript Definition for CameraPopoverOptions does not
declare class
Key: CB-13837
URL: https://issues.apache.org/jira/browse/CB-13837
Project: Apache Cordova
Issue Type: Bug
Components: cordova-plugin-camera
Reporter: Ryan Murphy
The docs for CameraPopoverOptions use it as a class.
>From docs:
{code:javascript}
var cameraPopoverOptions = new CameraPopoverOptions(0, 0, 100, 100,
Camera.PopoverArrowDirection.ARROW_ANY);
{code}
But the index.d.ts only define an interface, not declare a class, so using it
as a class in a TypeScript file gives the error:
{color:#ff}[ts] 'CameraPopoverOptions' only refers to a type, but is being
used as a value here.{color}
The fix would be to declare a class and constructor.
{code:java}
declare class CameraPopoverOptions implements CameraPopoverOptions {
constructor(x?: number, y?: number, width?: number, height?: number,
arrowDir?: number);
}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13831) Update `android-versions` npm dependency to support Android API 27.
[
https://issues.apache.org/jira/browse/CB-13831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Bowser closed CB-13831.
---
Resolution: Fixed
> Update `android-versions` npm dependency to support Android API 27.
> ---
>
> Key: CB-13831
> URL: https://issues.apache.org/jira/browse/CB-13831
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-android
>Reporter: Jesse Rosenberger
>Assignee: Joe Bowser
>Priority: Trivial
>
> The current version of {{cordova-android}} currently bundles (via
> {{package.json}}'s {{bundledDependencies}} attribute) a version of the
> [{{android-versions}} npm|https://npm.im/android-versions] which doesn't
> support Android SDK level 27, which was officially released in the last month.
> This omission prevents the use of {{cordova run android --emulator -d}} if
> API level 27 is installed, which is the default SDK for a new installation of
> Android Studio. It also contributed to the error seen in CB-13571, though
> that will prevent the same error from occurring in the future if an
> additional SDK is released and not included in {{android-versions}}.
> While the latest version of {{android-versions}} (currently 1.3.0) does
> support level 27 (now, thanks to [this recent
> commit|https://github.com/dvoiss/android-versions/commit/230957205eeb26e569096251a32179e88a28acfc]),
> the fact that it is a so-called "bundled dependency" means the current
> version (1.2.1) is baked into the {{cordova-android}} installation tarball,
> and won't automatically respect the caret version range (`^1.2.1`) listed in
> {{cordova-android}}`s {{package.json}}, despite the lack of a
> {{package-lock.json}} (or otherwise).
> Bumping the version of {{android-versions}} in {{cordova-android}}'s
> {{package.json}} to 1.3.0 will enable the emulator to work with API level 27
> (even if there _could_ be other reasons that API level 27 causes problems).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
***UNCHECKED*** [jira] [Commented] (CB-13836) Windows phone correct filename
[ https://issues.apache.org/jira/browse/CB-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341210#comment-16341210 ] ASF GitHub Bot commented on CB-13836: - markdegrootnl opened a new pull request #311: CB-13836 Windows phone correct filename URL: https://github.com/apache/cordova-plugin-camera/pull/311 Windows: Change the filename to match Android behaviour. ### Platforms affected Windows ### What does this PR do? All photos are stored as 'photo.jpg' of 'photo.png'. Change the filename to match Android behaviour. ### What testing has been done on this change? Device tested ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Windows phone correct filename > -- > > Key: CB-13836 > URL: https://issues.apache.org/jira/browse/CB-13836 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Reporter: Mark de Groot >Priority: Minor > > All photos are stored as 'photo.jpg' of 'photo.png'. Change the filename to > match Android behaviour. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13836) Windows phone correct filename
Mark de Groot created CB-13836: -- Summary: Windows phone correct filename Key: CB-13836 URL: https://issues.apache.org/jira/browse/CB-13836 Project: Apache Cordova Issue Type: Improvement Components: cordova-plugin-camera Reporter: Mark de Groot All photos are stored as 'photo.jpg' of 'photo.png'. Change the filename to match Android behaviour. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13818) Need to update android_sdk.js to Support Android 8.0
[
https://issues.apache.org/jira/browse/CB-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341203#comment-16341203
]
ASF GitHub Bot commented on CB-13818:
-
infil00p commented on issue #431: CB-13818: (android) Update android_sdk.js to
support Android Oreo 8.0 (API 26) emulator
URL: https://github.com/apache/cordova-android/pull/431#issuecomment-360825816
OK, why does this exist when we're using the android-versions npm package
now? I'm fine with merging this in, but maybe someone should look at replacing
this code?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to update android_sdk.js to Support Android 8.0
> -
>
> Key: CB-13818
> URL: https://issues.apache.org/jira/browse/CB-13818
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Cordova 7.1.0
>
>Reporter: Zhao Bin
>Assignee: Joe Bowser
>Priority: Critical
> Labels: easyfix
> Fix For: cordova-android-7.0.0
>
> Attachments: android_sdk.js error.png
>
>
> Currently I am working on a Cordova project and I am migrating to the new
> Android 8.0 emulator.
> Need to update android_sdk.js to add support for Android 8.0 emulator
> cordova-android / bin / templates / cordova / lib / android_sdk.js Line 53:
> module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25
> };
> This causes exception in emulator.js Line 210
> {color:#5fdfff}var{color}{color:#dfdfdf} project_target
> {color}{color:#ff1f7f}={color}{color:#dfdfdf}
> check_reqs.{color}{color:#9fdf2f}get_target{color}{color:#dfdfdf}().{color}{color:#5fdfff}replace{color}{color:#dfdfdf}({color}{color:#dfdf7f}'android-'{color}{color:#dfdfdf},
> {color}{color:#dfdf7f}''{color}{color:#dfdfdf});{color}
>
> {color:#33}I added '8.0': 26 in android_sdk.js and then it works.{color}
> {color:#33}module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25,{color}
> {color:#33} '8.0': 26
> };{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13831) Update `android-versions` npm dependency to support Android API 27.
[
https://issues.apache.org/jira/browse/CB-13831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341196#comment-16341196
]
ASF GitHub Bot commented on CB-13831:
-
infil00p closed pull request #430: CB-13831: (android) Update
`android-versions` to 1.3.0 to support SDK 27.
URL: https://github.com/apache/cordova-android/pull/430
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/package.json b/package.json
index 16497fc72..58be2aa0d 100644
--- a/package.json
+++ b/package.json
@@ -29,7 +29,7 @@
"author": "Apache Software Foundation",
"license": "Apache-2.0",
"dependencies": {
-"android-versions": "^1.2.1",
+"android-versions": "^1.3.0",
"cordova-common": "^2.2.0",
"elementtree": "0.1.6",
"nopt": "^3.0.1",
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update `android-versions` npm dependency to support Android API 27.
> ---
>
> Key: CB-13831
> URL: https://issues.apache.org/jira/browse/CB-13831
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-android
>Reporter: Jesse Rosenberger
>Assignee: Joe Bowser
>Priority: Trivial
>
> The current version of {{cordova-android}} currently bundles (via
> {{package.json}}'s {{bundledDependencies}} attribute) a version of the
> [{{android-versions}} npm|https://npm.im/android-versions] which doesn't
> support Android SDK level 27, which was officially released in the last month.
> This omission prevents the use of {{cordova run android --emulator -d}} if
> API level 27 is installed, which is the default SDK for a new installation of
> Android Studio. It also contributed to the error seen in CB-13571, though
> that will prevent the same error from occurring in the future if an
> additional SDK is released and not included in {{android-versions}}.
> While the latest version of {{android-versions}} (currently 1.3.0) does
> support level 27 (now, thanks to [this recent
> commit|https://github.com/dvoiss/android-versions/commit/230957205eeb26e569096251a32179e88a28acfc]),
> the fact that it is a so-called "bundled dependency" means the current
> version (1.2.1) is baked into the {{cordova-android}} installation tarball,
> and won't automatically respect the caret version range (`^1.2.1`) listed in
> {{cordova-android}}`s {{package.json}}, despite the lack of a
> {{package-lock.json}} (or otherwise).
> Bumping the version of {{android-versions}} in {{cordova-android}}'s
> {{package.json}} to 1.3.0 will enable the emulator to work with API level 27
> (even if there _could_ be other reasons that API level 27 causes problems).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13831) Update `android-versions` npm dependency to support Android API 27.
[
https://issues.apache.org/jira/browse/CB-13831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341199#comment-16341199
]
ASF subversion and git services commented on CB-13831:
--
Commit f91102ee0707b0d4528cda8967c14810c3b8e16e in cordova-android's branch
refs/heads/master from [~abernix]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=f91102e ]
CB-13831: (android) Update `android-versions` to 1.3.0 to support SDK 27.
The `android-versions@1.3.0` version now has support for Android SDK level
27 thanks to
https://github.com/dvoiss/android-versions/commit/230957205eeb26e569096251a32179e88a28acfc.
As the `android-versions` npm is a "bundled dependency" this will only
take effect when a new version of `cordova-android` is published, since
bundled dependencies are packed within the npm at publish time, not
automatically fetched as dependencies at publish time (which would have
normally been covered for new installations of cordova-android@7.0.0
thanks to semver caret notation).
> Update `android-versions` npm dependency to support Android API 27.
> ---
>
> Key: CB-13831
> URL: https://issues.apache.org/jira/browse/CB-13831
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-android
>Reporter: Jesse Rosenberger
>Assignee: Joe Bowser
>Priority: Trivial
>
> The current version of {{cordova-android}} currently bundles (via
> {{package.json}}'s {{bundledDependencies}} attribute) a version of the
> [{{android-versions}} npm|https://npm.im/android-versions] which doesn't
> support Android SDK level 27, which was officially released in the last month.
> This omission prevents the use of {{cordova run android --emulator -d}} if
> API level 27 is installed, which is the default SDK for a new installation of
> Android Studio. It also contributed to the error seen in CB-13571, though
> that will prevent the same error from occurring in the future if an
> additional SDK is released and not included in {{android-versions}}.
> While the latest version of {{android-versions}} (currently 1.3.0) does
> support level 27 (now, thanks to [this recent
> commit|https://github.com/dvoiss/android-versions/commit/230957205eeb26e569096251a32179e88a28acfc]),
> the fact that it is a so-called "bundled dependency" means the current
> version (1.2.1) is baked into the {{cordova-android}} installation tarball,
> and won't automatically respect the caret version range (`^1.2.1`) listed in
> {{cordova-android}}`s {{package.json}}, despite the lack of a
> {{package-lock.json}} (or otherwise).
> Bumping the version of {{android-versions}} in {{cordova-android}}'s
> {{package.json}} to 1.3.0 will enable the emulator to work with API level 27
> (even if there _could_ be other reasons that API level 27 causes problems).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13818) Need to update android_sdk.js to Support Android 8.0
[
https://issues.apache.org/jira/browse/CB-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341195#comment-16341195
]
ASF GitHub Bot commented on CB-13818:
-
abernix commented on a change in pull request #431: CB-13818: (android) Update
android_sdk.js to support Android Oreo 8.0 (API 26) emulator
URL: https://github.com/apache/cordova-android/pull/431#discussion_r164148661
##
File path: bin/templates/cordova/lib/android_sdk.js
##
@@ -62,7 +62,8 @@ module.exports.version_string_to_api_level = {
'5.1': 22,
'6.0': 23,
'7.0': 24,
-'7.1.1': 25
+'7.1.1': 25,
+'8.0': 26
Review comment:
Correct! That should be added as well, it seems. See also, my #430.
Refs:
https://source.android.com/setup/build-numbers#platform-code-names-versions-api-levels-and-ndk-releases
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to update android_sdk.js to Support Android 8.0
> -
>
> Key: CB-13818
> URL: https://issues.apache.org/jira/browse/CB-13818
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Cordova 7.1.0
>
>Reporter: Zhao Bin
>Assignee: Joe Bowser
>Priority: Critical
> Labels: easyfix
> Fix For: cordova-android-7.0.0
>
> Attachments: android_sdk.js error.png
>
>
> Currently I am working on a Cordova project and I am migrating to the new
> Android 8.0 emulator.
> Need to update android_sdk.js to add support for Android 8.0 emulator
> cordova-android / bin / templates / cordova / lib / android_sdk.js Line 53:
> module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25
> };
> This causes exception in emulator.js Line 210
> {color:#5fdfff}var{color}{color:#dfdfdf} project_target
> {color}{color:#ff1f7f}={color}{color:#dfdfdf}
> check_reqs.{color}{color:#9fdf2f}get_target{color}{color:#dfdfdf}().{color}{color:#5fdfff}replace{color}{color:#dfdfdf}({color}{color:#dfdf7f}'android-'{color}{color:#dfdfdf},
> {color}{color:#dfdf7f}''{color}{color:#dfdfdf});{color}
>
> {color:#33}I added '8.0': 26 in android_sdk.js and then it works.{color}
> {color:#33}module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25,{color}
> {color:#33} '8.0': 26
> };{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13831) Update `android-versions` npm dependency to support Android API 27.
[
https://issues.apache.org/jira/browse/CB-13831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341200#comment-16341200
]
ASF subversion and git services commented on CB-13831:
--
Commit 38a5f891a466d9e56cc032813b4c34dfcc3070d6 in cordova-android's branch
refs/heads/master from [~bowserj]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=38a5f89 ]
Merge pull request #430 from abernix/abernix/bump-android-versions
CB-13831: (android) Update `android-versions` to 1.3.0 to support SDK 27.
> Update `android-versions` npm dependency to support Android API 27.
> ---
>
> Key: CB-13831
> URL: https://issues.apache.org/jira/browse/CB-13831
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-android
>Reporter: Jesse Rosenberger
>Assignee: Joe Bowser
>Priority: Trivial
>
> The current version of {{cordova-android}} currently bundles (via
> {{package.json}}'s {{bundledDependencies}} attribute) a version of the
> [{{android-versions}} npm|https://npm.im/android-versions] which doesn't
> support Android SDK level 27, which was officially released in the last month.
> This omission prevents the use of {{cordova run android --emulator -d}} if
> API level 27 is installed, which is the default SDK for a new installation of
> Android Studio. It also contributed to the error seen in CB-13571, though
> that will prevent the same error from occurring in the future if an
> additional SDK is released and not included in {{android-versions}}.
> While the latest version of {{android-versions}} (currently 1.3.0) does
> support level 27 (now, thanks to [this recent
> commit|https://github.com/dvoiss/android-versions/commit/230957205eeb26e569096251a32179e88a28acfc]),
> the fact that it is a so-called "bundled dependency" means the current
> version (1.2.1) is baked into the {{cordova-android}} installation tarball,
> and won't automatically respect the caret version range (`^1.2.1`) listed in
> {{cordova-android}}`s {{package.json}}, despite the lack of a
> {{package-lock.json}} (or otherwise).
> Bumping the version of {{android-versions}} in {{cordova-android}}'s
> {{package.json}} to 1.3.0 will enable the emulator to work with API level 27
> (even if there _could_ be other reasons that API level 27 causes problems).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13831) Update `android-versions` npm dependency to support Android API 27.
[
https://issues.apache.org/jira/browse/CB-13831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341197#comment-16341197
]
ASF GitHub Bot commented on CB-13831:
-
infil00p commented on issue #430: CB-13831: (android) Update `android-versions`
to 1.3.0 to support SDK 27.
URL: https://github.com/apache/cordova-android/pull/430#issuecomment-360825543
Neat! This must have just happened, since I didn't see this published when
I did the API bump.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update `android-versions` npm dependency to support Android API 27.
> ---
>
> Key: CB-13831
> URL: https://issues.apache.org/jira/browse/CB-13831
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-android
>Reporter: Jesse Rosenberger
>Assignee: Joe Bowser
>Priority: Trivial
>
> The current version of {{cordova-android}} currently bundles (via
> {{package.json}}'s {{bundledDependencies}} attribute) a version of the
> [{{android-versions}} npm|https://npm.im/android-versions] which doesn't
> support Android SDK level 27, which was officially released in the last month.
> This omission prevents the use of {{cordova run android --emulator -d}} if
> API level 27 is installed, which is the default SDK for a new installation of
> Android Studio. It also contributed to the error seen in CB-13571, though
> that will prevent the same error from occurring in the future if an
> additional SDK is released and not included in {{android-versions}}.
> While the latest version of {{android-versions}} (currently 1.3.0) does
> support level 27 (now, thanks to [this recent
> commit|https://github.com/dvoiss/android-versions/commit/230957205eeb26e569096251a32179e88a28acfc]),
> the fact that it is a so-called "bundled dependency" means the current
> version (1.2.1) is baked into the {{cordova-android}} installation tarball,
> and won't automatically respect the caret version range (`^1.2.1`) listed in
> {{cordova-android}}`s {{package.json}}, despite the lack of a
> {{package-lock.json}} (or otherwise).
> Bumping the version of {{android-versions}} in {{cordova-android}}'s
> {{package.json}} to 1.3.0 will enable the emulator to work with API level 27
> (even if there _could_ be other reasons that API level 27 causes problems).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13818) Need to update android_sdk.js to Support Android 8.0
[
https://issues.apache.org/jira/browse/CB-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341192#comment-16341192
]
ASF GitHub Bot commented on CB-13818:
-
abernix commented on a change in pull request #431: CB-13818: (android) Update
android_sdk.js to support Android Oreo 8.0 (API 26) emulator
URL: https://github.com/apache/cordova-android/pull/431#discussion_r164148661
##
File path: bin/templates/cordova/lib/android_sdk.js
##
@@ -62,7 +62,8 @@ module.exports.version_string_to_api_level = {
'5.1': 22,
'6.0': 23,
'7.0': 24,
-'7.1.1': 25
+'7.1.1': 25,
+'8.0': 26
Review comment:
Correct! That should be added as well, it seems. See also, my #430.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to update android_sdk.js to Support Android 8.0
> -
>
> Key: CB-13818
> URL: https://issues.apache.org/jira/browse/CB-13818
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Cordova 7.1.0
>
>Reporter: Zhao Bin
>Assignee: Joe Bowser
>Priority: Critical
> Labels: easyfix
> Fix For: cordova-android-7.0.0
>
> Attachments: android_sdk.js error.png
>
>
> Currently I am working on a Cordova project and I am migrating to the new
> Android 8.0 emulator.
> Need to update android_sdk.js to add support for Android 8.0 emulator
> cordova-android / bin / templates / cordova / lib / android_sdk.js Line 53:
> module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25
> };
> This causes exception in emulator.js Line 210
> {color:#5fdfff}var{color}{color:#dfdfdf} project_target
> {color}{color:#ff1f7f}={color}{color:#dfdfdf}
> check_reqs.{color}{color:#9fdf2f}get_target{color}{color:#dfdfdf}().{color}{color:#5fdfff}replace{color}{color:#dfdfdf}({color}{color:#dfdf7f}'android-'{color}{color:#dfdfdf},
> {color}{color:#dfdf7f}''{color}{color:#dfdfdf});{color}
>
> {color:#33}I added '8.0': 26 in android_sdk.js and then it works.{color}
> {color:#33}module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25,{color}
> {color:#33} '8.0': 26
> };{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13832) IOS app gets logged out when using "_system" as target
[
https://issues.apache.org/jira/browse/CB-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341094#comment-16341094
]
Agnosco edited comment on CB-13832 at 1/26/18 2:34 PM:
---
I'm logged in Cordova ios app and have an external link in the app. So, to open
the link in an external browser I have -"cordova.InAppBrowser.open(url,
'_system', 'location=no');". It opens the url link in the external browser. But
when I hit the link on top of browser(that links back to the app) or open the
app that went in background, I can see that I have been logged out from app.
replacing (void)openInSystem:(NSURL*)url method with the one in older
version(1.4.0) worked
(void)openInSystem:(NSURL*)url
{
if ([[UIApplication sharedApplication] canOpenURL:url]) {
[[UIApplication sharedApplication] openURL:url];
}else {
// handle any custom schemes to plugins
[[NSNotificationCenter defaultCenter]
postNotification:[NSNotification
notificationWithName:CDVPluginHandleOpenURLNotification object:url]]; }
}
was (Author: sajana):
I'm logged in Cordova ios app and have an external link in the app. So, to open
the link in an external browser I have -"cordova.InAppBrowser.open(url,
'_system', 'location=no');". It opens the url link in the external browser. But
when I hit the link on top of browser(that links back to the app) or open the
app that went in background, I can see that I have been logged out from app.
* replacing (void)openInSystem:(NSURL*)url method with the one in older
version(1.4.0) worked
*
* (void)openInSystem:(NSURL*)url \{ if ([[UIApplication sharedApplication]
canOpenURL:url]) \{ [[UIApplication sharedApplication] openURL:url]; }else
{ // handle any custom schemes to plugins [[NSNotificationCenter defaultCenter]
postNotification:[NSNotification
notificationWithName:CDVPluginHandleOpenURLNotification object:url]]; }
}
> IOS app gets logged out when using "_system" as target
> --
>
> Key: CB-13832
> URL: https://issues.apache.org/jira/browse/CB-13832
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Agnosco
>Priority: Major
>
> I have cordova 7.1.0 and IOS 10+
> I'm logged in my ios app and have an external link in the app. So, to open
> the link in safari I have -"cordova.InAppBrowser.open(url, '_system',
> 'location=no');". It opens the url link in safari but I got logged out from
> app when I tried to go back to app.
> It works fine with target '_blank'. Is it a desired behavior? It used to work
> in previous version of cordova-plugin-inappbrowser 1.3.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13832) IOS app gets logged out when using "_system" as target
[ https://issues.apache.org/jira/browse/CB-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341112#comment-16341112 ] Agnosco commented on CB-13832: -- I mean my login session for logged in and out. when I kill the app it destroys the session so no more logged in. So, it's like when the external browser gets opened, app's session in no more persisted. > IOS app gets logged out when using "_system" as target > -- > > Key: CB-13832 > URL: https://issues.apache.org/jira/browse/CB-13832 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Agnosco >Priority: Major > > I have cordova 7.1.0 and IOS 10+ > I'm logged in my ios app and have an external link in the app. So, to open > the link in safari I have -"cordova.InAppBrowser.open(url, '_system', > 'location=no');". It opens the url link in safari but I got logged out from > app when I tried to go back to app. > It works fine with target '_blank'. Is it a desired behavior? It used to work > in previous version of cordova-plugin-inappbrowser 1.3.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13832) IOS app gets logged out when using "_system" as target
[ https://issues.apache.org/jira/browse/CB-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341112#comment-16341112 ] Agnosco edited comment on CB-13832 at 1/26/18 2:32 PM: --- I mean my login session for logged in and out. when I kill the app it destroys the session so no more logged in. So, it's like when the external browser gets opened, app's session is lost and no longer persisted. was (Author: sajana): I mean my login session for logged in and out. when I kill the app it destroys the session so no more logged in. So, it's like when the external browser gets opened, app's session in no more persisted. > IOS app gets logged out when using "_system" as target > -- > > Key: CB-13832 > URL: https://issues.apache.org/jira/browse/CB-13832 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Agnosco >Priority: Major > > I have cordova 7.1.0 and IOS 10+ > I'm logged in my ios app and have an external link in the app. So, to open > the link in safari I have -"cordova.InAppBrowser.open(url, '_system', > 'location=no');". It opens the url link in safari but I got logged out from > app when I tried to go back to app. > It works fine with target '_blank'. Is it a desired behavior? It used to work > in previous version of cordova-plugin-inappbrowser 1.3.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13832) IOS app gets logged out when using "_system" as target
[
https://issues.apache.org/jira/browse/CB-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341094#comment-16341094
]
Agnosco edited comment on CB-13832 at 1/26/18 2:27 PM:
---
I'm logged in Cordova ios app and have an external link in the app. So, to open
the link in an external browser I have -"cordova.InAppBrowser.open(url,
'_system', 'location=no');". It opens the url link in the external browser. But
when I hit the link on top of browser(that links back to the app) or open the
app that went in background, I can see that I have been logged out from app.
* replacing (void)openInSystem:(NSURL*)url method with the one in older
version(1.4.0) worked
*
* (void)openInSystem:(NSURL*)url \{ if ([[UIApplication sharedApplication]
canOpenURL:url]) \{ [[UIApplication sharedApplication] openURL:url]; }else
{ // handle any custom schemes to plugins [[NSNotificationCenter defaultCenter]
postNotification:[NSNotification
notificationWithName:CDVPluginHandleOpenURLNotification object:url]]; }
}
was (Author: sajana):
I'm logged in Cordova ios app and have an external link in the app. So, to open
the link in an external browser I have -"cordova.InAppBrowser.open(url,
'_system', 'location=no');". It opens the url link in the external browser. But
when I hit the link on top of browser(that links back to the app) or open the
app that went in background, I can see that I have been logged out from app.
* replacing (void)openInSystem:(NSURL*)url method with the one in older
version worked
*
* (void)openInSystem:(NSURL*)url
{
if ([[UIApplication sharedApplication] canOpenURL:url]) \{ [[UIApplication
sharedApplication] openURL:url]; }
else
{ // handle any custom schemes to plugins [[NSNotificationCenter defaultCenter]
postNotification:[NSNotification
notificationWithName:CDVPluginHandleOpenURLNotification object:url]]; }
}
> IOS app gets logged out when using "_system" as target
> --
>
> Key: CB-13832
> URL: https://issues.apache.org/jira/browse/CB-13832
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Agnosco
>Priority: Major
>
> I have cordova 7.1.0 and IOS 10+
> I'm logged in my ios app and have an external link in the app. So, to open
> the link in safari I have -"cordova.InAppBrowser.open(url, '_system',
> 'location=no');". It opens the url link in safari but I got logged out from
> app when I tried to go back to app.
> It works fine with target '_blank'. Is it a desired behavior? It used to work
> in previous version of cordova-plugin-inappbrowser 1.3.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13832) IOS app gets logged out when using "_system" as target
[ https://issues.apache.org/jira/browse/CB-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341106#comment-16341106 ] Jan Piotrowski (Sujan) commented on CB-13832: - I still don't know what "I'm logged in Cordova ios app" means. How does the login work? Where is it stored? Are you still logged in if you kill the app and restart it? > IOS app gets logged out when using "_system" as target > -- > > Key: CB-13832 > URL: https://issues.apache.org/jira/browse/CB-13832 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Agnosco >Priority: Major > > I have cordova 7.1.0 and IOS 10+ > I'm logged in my ios app and have an external link in the app. So, to open > the link in safari I have -"cordova.InAppBrowser.open(url, '_system', > 'location=no');". It opens the url link in safari but I got logged out from > app when I tried to go back to app. > It works fine with target '_blank'. Is it a desired behavior? It used to work > in previous version of cordova-plugin-inappbrowser 1.3.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13832) IOS app gets logged out when using "_system" as target
[
https://issues.apache.org/jira/browse/CB-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341094#comment-16341094
]
Agnosco edited comment on CB-13832 at 1/26/18 2:20 PM:
---
I'm logged in Cordova ios app and have an external link in the app. So, to open
the link in an external browser I have -"cordova.InAppBrowser.open(url,
'_system', 'location=no');". It opens the url link in the external browser. But
when I hit the link on top of browser(that links back to the app) or open the
app that went in background, I can see that I have been logged out from app.
* replacing (void)openInSystem:(NSURL*)url method with the one in older
version worked
*
* (void)openInSystem:(NSURL*)url
{
if ([[UIApplication sharedApplication] canOpenURL:url]) \{ [[UIApplication
sharedApplication] openURL:url]; }
else
{ // handle any custom schemes to plugins [[NSNotificationCenter defaultCenter]
postNotification:[NSNotification
notificationWithName:CDVPluginHandleOpenURLNotification object:url]]; }
}
was (Author: sajana):
* replacing (void)openInSystem:(NSURL*)url method with the one in older version
worked
*
* (void)openInSystem:(NSURL*)url
{
if ([[UIApplication sharedApplication] canOpenURL:url]) {
[[UIApplication sharedApplication] openURL:url];
} else { // handle any custom schemes to plugins
[[NSNotificationCenter defaultCenter]
postNotification:[NSNotification
notificationWithName:CDVPluginHandleOpenURLNotification object:url]];
}
}
> IOS app gets logged out when using "_system" as target
> --
>
> Key: CB-13832
> URL: https://issues.apache.org/jira/browse/CB-13832
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Agnosco
>Priority: Major
>
> I have cordova 7.1.0 and IOS 10+
> I'm logged in my ios app and have an external link in the app. So, to open
> the link in safari I have -"cordova.InAppBrowser.open(url, '_system',
> 'location=no');". It opens the url link in safari but I got logged out from
> app when I tried to go back to app.
> It works fine with target '_blank'. Is it a desired behavior? It used to work
> in previous version of cordova-plugin-inappbrowser 1.3.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13832) IOS app gets logged out when using "_system" as target
[
https://issues.apache.org/jira/browse/CB-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341094#comment-16341094
]
Agnosco commented on CB-13832:
--
* replacing (void)openInSystem:(NSURL*)url method with the one in older version
worked
*
* (void)openInSystem:(NSURL*)url
{
if ([[UIApplication sharedApplication] canOpenURL:url]) {
[[UIApplication sharedApplication] openURL:url];
} else { // handle any custom schemes to plugins
[[NSNotificationCenter defaultCenter]
postNotification:[NSNotification
notificationWithName:CDVPluginHandleOpenURLNotification object:url]];
}
}
> IOS app gets logged out when using "_system" as target
> --
>
> Key: CB-13832
> URL: https://issues.apache.org/jira/browse/CB-13832
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Agnosco
>Priority: Major
>
> I have cordova 7.1.0 and IOS 10+
> I'm logged in my ios app and have an external link in the app. So, to open
> the link in safari I have -"cordova.InAppBrowser.open(url, '_system',
> 'location=no');". It opens the url link in safari but I got logged out from
> app when I tried to go back to app.
> It works fine with target '_blank'. Is it a desired behavior? It used to work
> in previous version of cordova-plugin-inappbrowser 1.3.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13835) iOS InAppBrowser changing toolbar position to top doesn't alter position webpage
[ https://issues.apache.org/jira/browse/CB-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340953#comment-16340953 ] Corneel den Hartogh commented on CB-13835: -- Only iOS I tested in simulator AND on real device that wasn't iPhone X so it seems rather general. I also tested it with a completely empty app (except for the inAppBrowser and the visible settings and the url to go). With URL I indeed mean the page. VERSIONS: cordova --v 8.0.0 > iOS InAppBrowser changing toolbar position to top doesn't alter position > webpage > > > Key: CB-13835 > URL: https://issues.apache.org/jira/browse/CB-13835 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Corneel den Hartogh >Priority: Major > Attachments: Screenshot 2018-01-26 11.25.02.jpg, Screenshot > 2018-01-26 11.28.24.jpg > > > Within the InAppBrowser you can set for iOS the toolbarposition on bottom or > top (bottom is default). When I make it top, the position of the loaded url > (a map in my case) isn't changed. The result is that the toolbar is in front > of the url (where the search box is blocked out of view as can be seen in the > screenshots). > I updated Ionic / Cordova / InAppBrowser but it didn't change anything. > I tried some workaround myself but I was unable to figure it out. Any > suggestions here? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed
[
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340928#comment-16340928
]
Jan Piotrowski (Sujan) commented on CB-13830:
-
Thanks for the udpate.
Does this also happen for iOS or only for Android?
Can you check which version of the plugin is being installed?
Does this also happen with other plugins or only this specific one?
Does it also happen if you choose an older cordova-android version?
Does it also happen with an older Cordova CLI?
> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Critical
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
> Path: platforms/android
> Package: io.cordova.hellocordova
> Name: HelloCordova
> Activity: MainActivity
> Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than
> 4.0. If you have a previous platform version, you do *not* need this plugin
> since the whitelist will be built in.
>
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
> at PluginManager.addPlugin
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
> at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
> at _fulfilled
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
> at self.promiseDispatch.done
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
> at Promise.promise.promiseDispatch
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
> at
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
>
[jira] [Commented] (CB-13835) iOS InAppBrowser changing toolbar position to top doesn't alter position webpage
[ https://issues.apache.org/jira/browse/CB-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340922#comment-16340922 ] Jan Piotrowski (Sujan) commented on CB-13835: - Does this only affect iOS? Does this only affect iPhone X? Did you test this on a real device or only in the simulator? When you say "URL", you mean the actual page, not the URL bar or anything, correct? What are the exacty versions of everything (Cordova CLI, cordova-ios, cordova-plugin-inappbrowser) you are using? > iOS InAppBrowser changing toolbar position to top doesn't alter position > webpage > > > Key: CB-13835 > URL: https://issues.apache.org/jira/browse/CB-13835 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Corneel den Hartogh >Priority: Major > Attachments: Screenshot 2018-01-26 11.25.02.jpg, Screenshot > 2018-01-26 11.28.24.jpg > > > Within the InAppBrowser you can set for iOS the toolbarposition on bottom or > top (bottom is default). When I make it top, the position of the loaded url > (a map in my case) isn't changed. The result is that the toolbar is in front > of the url (where the search box is blocked out of view as can be seen in the > screenshots). > I updated Ionic / Cordova / InAppBrowser but it didn't change anything. > I tried some workaround myself but I was unable to figure it out. Any > suggestions here? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed
[
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) updated CB-13830:
Environment:
macOS 10.12.6
node 9.4.0
Cordova CLI 8.0.0
was:
macOS 10.12.6
node 9.4.0
Cordova 8.0.0
> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Critical
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
> Path: platforms/android
> Package: io.cordova.hellocordova
> Name: HelloCordova
> Activity: MainActivity
> Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than
> 4.0. If you have a previous platform version, you do *not* need this plugin
> since the whitelist will be built in.
>
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
> at PluginManager.addPlugin
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
> at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
> at _fulfilled
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
> at self.promiseDispatch.done
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
> at Promise.promise.promiseDispatch
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
> at
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
> at PluginManager.addPlugin
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
>
[jira] [Updated] (CB-13835) iOS InAppBrowser changing toolbar position to top doesn't alter position webpage
[ https://issues.apache.org/jira/browse/CB-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13835: Description: Within the InAppBrowser you can set for iOS the toolbarposition on bottom or top (bottom is default). When I make it top, the position of the loaded url (a map in my case) isn't changed. The result is that the toolbar is in front of the url (where the search box is blocked out of view as can be seen in the screenshots). I updated Ionic / Cordova / InAppBrowser but it didn't change anything. I tried some workaround myself but I was unable to figure it out. Any suggestions here? was: Within the InAppBrowser you can set for iOS the toolbarposition on bottom or top (bottom is default). When I make it top the position of the loaded url (a map in my case) isn't changed. The result is that the toolbar is in front of the url (where the search box is blocked out of view as can be seen in the screenshots). I updated Ionic / Cordova / InAppBrowser but it didn't change anything. I tried some workaround myself but I was unable to figure it out. Any suggestions here? > iOS InAppBrowser changing toolbar position to top doesn't alter position > webpage > > > Key: CB-13835 > URL: https://issues.apache.org/jira/browse/CB-13835 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Corneel den Hartogh >Priority: Major > Attachments: Screenshot 2018-01-26 11.25.02.jpg, Screenshot > 2018-01-26 11.28.24.jpg > > > Within the InAppBrowser you can set for iOS the toolbarposition on bottom or > top (bottom is default). When I make it top, the position of the loaded url > (a map in my case) isn't changed. The result is that the toolbar is in front > of the url (where the search box is blocked out of view as can be seen in the > screenshots). > I updated Ionic / Cordova / InAppBrowser but it didn't change anything. > I tried some workaround myself but I was unable to figure it out. Any > suggestions here? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13835) iOS InAppBrowser changing toolbar position to top doesn't alter position webpage
[ https://issues.apache.org/jira/browse/CB-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13835: Component/s: cordova-plugin-inappbrowser > iOS InAppBrowser changing toolbar position to top doesn't alter position > webpage > > > Key: CB-13835 > URL: https://issues.apache.org/jira/browse/CB-13835 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Corneel den Hartogh >Priority: Major > Attachments: Screenshot 2018-01-26 11.25.02.jpg, Screenshot > 2018-01-26 11.28.24.jpg > > > Within the InAppBrowser you can set for iOS the toolbarposition on bottom or > top (bottom is default). When I make it top the position of the loaded url (a > map in my case) isn't changed. The result is that the toolbar is in front of > the url (where the search box is blocked out of view as can be seen in the > screenshots). > I updated Ionic / Cordova / InAppBrowser but it didn't change anything. > I tried some workaround myself but I was unable to figure it out. Any > suggestions here? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340903#comment-16340903
]
ASF GitHub Bot commented on CB-13415:
-
alpesh12 commented on a change in pull request #310: CB-13415 (iOS) Importing
corrupt images using the Camera plugin crashes the app
URL:
https://github.com/apache/cordova-plugin-camera/pull/310#discussion_r164084053
##
File path: src/ios/CDVCamera.m
##
@@ -360,7 +361,22 @@ - (NSData*)processImage:(UIImage*)image
info:(NSDictionary*)info options:(CDVPic
{
if ((options.allowsEditing == NO) && (options.targetSize.width <=
0) && (options.targetSize.height <= 0) && (options.correctOrientation == NO) &&
(([options.quality integerValue] == 100) || (options.sourceType !=
UIImagePickerControllerSourceTypeCamera))){
// use image unedited as requested , don't resize
-data = UIImageJPEGRepresentation(image, 1.0);
+ if(options.sourceType !=
UIImagePickerControllerSourceTypeCamera){
+NSURL *url = info[UIImagePickerControllerReferenceURL];
+PHFetchResult *result = [PHAsset
fetchAssetsWithALAssetURLs:@[url] options:nil];
+PHAsset *asset = [result firstObject];
+if (asset) {
+PHImageManager *manager = [PHImageManager
defaultManager];
+PHImageRequestOptions *option = [PHImageRequestOptions
alloc];
+option.synchronous = true;
+[manager requestImageDataForAsset:asset options:option
resultHandler:^(NSData *imageData, NSString *dataUTI, UIImageOrientation
orientation, NSDictionary *info) {
+ data = imageData;
Review comment:
@shazron
Its default functionality from `PHFetchResult` lib to return data from block
to function, so it must be synchronous operation.
Let me know if you have other reference or solution to solved this bug.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Importing corrupt images using the Camera plugin crashes the app
>
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
> Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app |
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner
> class to prevent an app crash |
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes]
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13818) Need to update android_sdk.js to Support Android 8.0
[
https://issues.apache.org/jira/browse/CB-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340905#comment-16340905
]
ASF GitHub Bot commented on CB-13818:
-
janpio commented on a change in pull request #431: CB-13818: (android) Update
android_sdk.js to support Android Oreo 8.0 (API 26) emulator
URL: https://github.com/apache/cordova-android/pull/431#discussion_r164084142
##
File path: bin/templates/cordova/lib/android_sdk.js
##
@@ -62,7 +62,8 @@ module.exports.version_string_to_api_level = {
'5.1': 22,
'6.0': 23,
'7.0': 24,
-'7.1.1': 25
+'7.1.1': 25,
+'8.0': 26
Review comment:
API 27 is out as well, right - which one does that correspond to? 8.1?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to update android_sdk.js to Support Android 8.0
> -
>
> Key: CB-13818
> URL: https://issues.apache.org/jira/browse/CB-13818
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Cordova 7.1.0
>
>Reporter: Zhao Bin
>Assignee: Joe Bowser
>Priority: Critical
> Labels: easyfix
> Fix For: cordova-android-7.0.0
>
> Attachments: android_sdk.js error.png
>
>
> Currently I am working on a Cordova project and I am migrating to the new
> Android 8.0 emulator.
> Need to update android_sdk.js to add support for Android 8.0 emulator
> cordova-android / bin / templates / cordova / lib / android_sdk.js Line 53:
> module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25
> };
> This causes exception in emulator.js Line 210
> {color:#5fdfff}var{color}{color:#dfdfdf} project_target
> {color}{color:#ff1f7f}={color}{color:#dfdfdf}
> check_reqs.{color}{color:#9fdf2f}get_target{color}{color:#dfdfdf}().{color}{color:#5fdfff}replace{color}{color:#dfdfdf}({color}{color:#dfdf7f}'android-'{color}{color:#dfdfdf},
> {color}{color:#dfdf7f}''{color}{color:#dfdfdf});{color}
>
> {color:#33}I added '8.0': 26 in android_sdk.js and then it works.{color}
> {color:#33}module.exports.version_string_to_api_level = {
> '4.0': 14,
> '4.0.3': 15,
> '4.1': 16,
> '4.2': 17,
> '4.3': 18,
> '4.4': 19,
> '4.4W': 20,
> '5.0': 21,
> '5.1': 22,
> '6.0': 23,
> '7.0': 24,
> '7.1.1': 25,{color}
> {color:#33} '8.0': 26
> };{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed
[
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340889#comment-16340889
]
Enrico Giordani commented on CB-13830:
--
Hi Jan,
sorry for the faulty copy and paste, I fixed it, the correct sequence is "add
plugin", "remove plugin" and "add plugin" again.
> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova 8.0.0
>
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Critical
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
> Path: platforms/android
> Package: io.cordova.hellocordova
> Name: HelloCordova
> Activity: MainActivity
> Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than
> 4.0. If you have a previous platform version, you do *not* need this plugin
> since the whitelist will be built in.
>
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
> at PluginManager.addPlugin
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
> at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
> at _fulfilled
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
> at self.promiseDispatch.done
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
> at Promise.promise.promiseDispatch
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
> at
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
> at PluginManager.addPlugin
>
[jira] [Updated] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed
[
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enrico Giordani updated CB-13830:
-
Description:
Removing a plugin and than adding it again, causes an error:
{code}
$ cordova create testapp
$ cd testapp
$ cordova platform add android
Using cordova-fetch for cordova-android@~7.0.0
Adding android project...
Creating Cordova project for the Android platform:
Path: platforms/android
Package: io.cordova.hellocordova
Name: HelloCordova
Activity: MainActivity
Android target: android-26
Subproject Path: CordovaLib
Subproject Path: app
Android project created with cordova-android@7.0.0
Android Studio project detected
Android Studio project detected
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for android
This plugin is only applicable for versions of cordova-android greater than
4.0. If you have a previous platform version, you do *not* need this plugin
since the whitelist will be built in.
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving android@~7.0.0 into config.xml file ...
{code}
{code}
$ cordova plugin add cordova-plugin-camera
Installing "cordova-plugin-camera" for android
Android Studio project detected
Subproject Path: CordovaLib
Subproject Path: app
Adding cordova-plugin-camera to package.json
Saved plugin info for "cordova-plugin-camera" to config.xml
{code}
{code}
cordova plugin remove cordova-plugin-camera
Uninstalling cordova-plugin-camera from android
Android Studio project detected
Subproject Path: CordovaLib
Subproject Path: app
Removing "cordova-plugin-camera"
Removing plugin cordova-plugin-camera from config.xml file...
Removing cordova-plugin-camera from package.json
{code}
{code}
$ cordova plugin add cordova-plugin-camera
Installing "cordova-plugin-camera" for android
Android Studio project detected
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
"/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
already exists!
at copyNewFile
(/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
at install
(/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
at ActionStack.process
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
at PluginManager.doOperation
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
at PluginManager.addPlugin
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
at _fulfilled
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
at self.promiseDispatch.done
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
at Promise.promise.promiseDispatch
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
at
/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
(node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
"/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
already exists!
at copyNewFile
(/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
at install
(/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
at ActionStack.process
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
at PluginManager.doOperation
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
at PluginManager.addPlugin
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
at _fulfilled
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
at self.promiseDispatch.done
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
at Promise.promise.promiseDispatch
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
at
/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
(node:5722) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This
error originated either by throwing inside of an async function without a catch
block, or by rejecting a promise which was not handled with .catch().
(rejection id: 1)
(node:5722) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections
[jira] [Updated] (CB-13835) iOS InAppBrowser changing toolbar position to top doesn't alter position webpage
[ https://issues.apache.org/jira/browse/CB-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Corneel den Hartogh updated CB-13835: - Description: Within the InAppBrowser you can set for iOS the toolbarposition on bottom or top (bottom is default). When I make it top the position of the loaded url (a map in my case) isn't changed. The result is that the toolbar is in front of the url (where the search box is blocked out of view as can be seen in the screenshots). I updated Ionic / Cordova / InAppBrowser but it didn't change anything. I tried some workaround myself but I was unable to figure it out. Any suggestions here? was: Within the InAppBrowser you can set for iOS the toolbarposition on bottom or top (bottom is default). When I make it top the position of the loaded url (a map in my case) isn't changed. The result is that the toolbar is in front of the url (where the search box is blocked out of view). I updated Ionic / Cordova / InAppBrowser but it didn't change anything. > iOS InAppBrowser changing toolbar position to top doesn't alter position > webpage > > > Key: CB-13835 > URL: https://issues.apache.org/jira/browse/CB-13835 > Project: Apache Cordova > Issue Type: Bug >Reporter: Corneel den Hartogh >Priority: Major > Attachments: Screenshot 2018-01-26 11.25.02.jpg, Screenshot > 2018-01-26 11.28.24.jpg > > > Within the InAppBrowser you can set for iOS the toolbarposition on bottom or > top (bottom is default). When I make it top the position of the loaded url (a > map in my case) isn't changed. The result is that the toolbar is in front of > the url (where the search box is blocked out of view as can be seen in the > screenshots). > I updated Ionic / Cordova / InAppBrowser but it didn't change anything. > I tried some workaround myself but I was unable to figure it out. Any > suggestions here? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed
[
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enrico Giordani updated CB-13830:
-
Description:
Removing a plugin and than adding it again, causes an error:
{code}
$ cordova create testapp
$ cd testapp
$ cordova platform add android
Using cordova-fetch for cordova-android@~7.0.0
Adding android project...
Creating Cordova project for the Android platform:
Path: platforms/android
Package: io.cordova.hellocordova
Name: HelloCordova
Activity: MainActivity
Android target: android-26
Subproject Path: CordovaLib
Subproject Path: app
Android project created with cordova-android@7.0.0
Android Studio project detected
Android Studio project detected
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for android
This plugin is only applicable for versions of cordova-android greater than
4.0. If you have a previous platform version, you do *not* need this plugin
since the whitelist will be built in.
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving android@~7.0.0 into config.xml file ...
{code}
{code}
$ cordova plugin add cordova-plugin-camera
Installing "cordova-plugin-camera" for android
Android Studio project detected
Subproject Path: CordovaLib
Subproject Path: app
Adding cordova-plugin-camera to package.json
Saved plugin info for "cordova-plugin-camera" to config.xml
{code}
{code}
$ cordova plugin remove cordova-plugin-camera
Uninstalling cordova-plugin-camera from android
Android Studio project detected
Subproject Path: CordovaLib
Subproject Path: app
Removing "cordova-plugin-camera"
Removing plugin cordova-plugin-camera from config.xml file...
Removing cordova-plugin-camera from package.json
{code}
{code}
$ cordova plugin add cordova-plugin-camera
Installing "cordova-plugin-camera" for android
Android Studio project detected
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
"/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
already exists!
at copyNewFile
(/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
at install
(/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
at ActionStack.process
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
at PluginManager.doOperation
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
at PluginManager.addPlugin
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
at _fulfilled
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
at self.promiseDispatch.done
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
at Promise.promise.promiseDispatch
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
at
/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
(node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
"/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
already exists!
at copyNewFile
(/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
at install
(/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
at ActionStack.process
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
at PluginManager.doOperation
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
at PluginManager.addPlugin
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
at _fulfilled
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
at self.promiseDispatch.done
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
at Promise.promise.promiseDispatch
(/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
at
/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
(node:5722) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This
error originated either by throwing inside of an async function without a catch
block, or by rejecting a promise which was not handled with .catch().
(rejection id: 1)
(node:5722) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections
***UNCHECKED*** [jira] [Updated] (CB-13513) Fastlane unable to disable automatic signing
[ https://issues.apache.org/jira/browse/CB-13513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Corneel den Hartogh updated CB-13513: - Attachment: Screenshot 2018-01-26 11.25.02.jpg > Fastlane unable to disable automatic signing > - > > Key: CB-13513 > URL: https://issues.apache.org/jira/browse/CB-13513 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 >Reporter: Paul Robinson >Assignee: Suraj Pindoria >Priority: Blocker > > Running `disable_automatic_code_signing` command in fastlane fails and throw > an error that the ios project is too old. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
***UNCHECKED*** [jira] [Updated] (CB-13513) Fastlane unable to disable automatic signing
[ https://issues.apache.org/jira/browse/CB-13513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Corneel den Hartogh updated CB-13513: - Attachment: (was: Screenshot 2018-01-26 11.25.02.jpg) > Fastlane unable to disable automatic signing > - > > Key: CB-13513 > URL: https://issues.apache.org/jira/browse/CB-13513 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 >Reporter: Paul Robinson >Assignee: Suraj Pindoria >Priority: Blocker > > Running `disable_automatic_code_signing` command in fastlane fails and throw > an error that the ios project is too old. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13835) iOS InAppBrowser changing toolbar position to top doesn't alter position webpage
[ https://issues.apache.org/jira/browse/CB-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Corneel den Hartogh updated CB-13835: - Attachment: Screenshot 2018-01-26 11.25.02.jpg Screenshot 2018-01-26 11.28.24.jpg > iOS InAppBrowser changing toolbar position to top doesn't alter position > webpage > > > Key: CB-13835 > URL: https://issues.apache.org/jira/browse/CB-13835 > Project: Apache Cordova > Issue Type: Bug >Reporter: Corneel den Hartogh >Priority: Major > Attachments: Screenshot 2018-01-26 11.25.02.jpg, Screenshot > 2018-01-26 11.28.24.jpg > > > Within the InAppBrowser you can set for iOS the toolbarposition on bottom or > top (bottom is default). When I make it top the position of the loaded url (a > map in my case) isn't changed. The result is that the toolbar is in front of > the url (where the search box is blocked out of view). > I updated Ionic / Cordova / InAppBrowser but it didn't change anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13513) Fastlane unable to disable automatic signing
[ https://issues.apache.org/jira/browse/CB-13513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Corneel den Hartogh updated CB-13513: - Attachment: Screenshot 2018-01-26 11.28.24.jpg > Fastlane unable to disable automatic signing > - > > Key: CB-13513 > URL: https://issues.apache.org/jira/browse/CB-13513 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 >Reporter: Paul Robinson >Assignee: Suraj Pindoria >Priority: Blocker > > Running `disable_automatic_code_signing` command in fastlane fails and throw > an error that the ios project is too old. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
***UNCHECKED*** [jira] [Created] (CB-13835) iOS InAppBrowser changing toolbar position to top doesn't alter position webpage
Corneel den Hartogh created CB-13835: Summary: iOS InAppBrowser changing toolbar position to top doesn't alter position webpage Key: CB-13835 URL: https://issues.apache.org/jira/browse/CB-13835 Project: Apache Cordova Issue Type: Bug Reporter: Corneel den Hartogh Within the InAppBrowser you can set for iOS the toolbarposition on bottom or top (bottom is default). When I make it top the position of the loaded url (a map in my case) isn't changed. The result is that the toolbar is in front of the url (where the search box is blocked out of view). I updated Ionic / Cordova / InAppBrowser but it didn't change anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13513) Fastlane unable to disable automatic signing
[ https://issues.apache.org/jira/browse/CB-13513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Corneel den Hartogh updated CB-13513: - Attachment: (was: Screenshot 2018-01-26 11.28.24.jpg) > Fastlane unable to disable automatic signing > - > > Key: CB-13513 > URL: https://issues.apache.org/jira/browse/CB-13513 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 >Reporter: Paul Robinson >Assignee: Suraj Pindoria >Priority: Blocker > > Running `disable_automatic_code_signing` command in fastlane fails and throw > an error that the ios project is too old. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340709#comment-16340709 ] ASF GitHub Bot commented on CB-13243: - shazron commented on issue #147: CB-13243: (iOS) Reset default audio session category when release URL: https://github.com/apache/cordova-plugin-media/pull/147#issuecomment-360715223 Look up 'git rebase'. This can't be pulled in unless it has been resolved. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340706#comment-16340706 ] ASF GitHub Bot commented on CB-13243: - hannut91 commented on issue #147: CB-13243: (iOS) Reset default audio session category when release URL: https://github.com/apache/cordova-plugin-media/pull/147#issuecomment-360714974 I don't know about auto testing in project. I did test on my app. Everything was good. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340703#comment-16340703 ] ASF GitHub Bot commented on CB-13243: - shazron commented on issue #147: CB-13243: (iOS) Reset default audio session category when release URL: https://github.com/apache/cordova-plugin-media/pull/147#issuecomment-360714644 Can you rebase this? It has conflicts now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340696#comment-16340696
]
ASF GitHub Bot commented on CB-13415:
-
shazron commented on a change in pull request #310: CB-13415 (iOS) Importing
corrupt images using the Camera plugin crashes the app
URL:
https://github.com/apache/cordova-plugin-camera/pull/310#discussion_r164052640
##
File path: src/ios/CDVCamera.m
##
@@ -360,7 +361,22 @@ - (NSData*)processImage:(UIImage*)image
info:(NSDictionary*)info options:(CDVPic
{
if ((options.allowsEditing == NO) && (options.targetSize.width <=
0) && (options.targetSize.height <= 0) && (options.correctOrientation == NO) &&
(([options.quality integerValue] == 100) || (options.sourceType !=
UIImagePickerControllerSourceTypeCamera))){
// use image unedited as requested , don't resize
-data = UIImageJPEGRepresentation(image, 1.0);
+ if(options.sourceType !=
UIImagePickerControllerSourceTypeCamera){
+NSURL *url = info[UIImagePickerControllerReferenceURL];
+PHFetchResult *result = [PHAsset
fetchAssetsWithALAssetURLs:@[url] options:nil];
+PHAsset *asset = [result firstObject];
+if (asset) {
+PHImageManager *manager = [PHImageManager
defaultManager];
+PHImageRequestOptions *option = [PHImageRequestOptions
alloc];
+option.synchronous = true;
+[manager requestImageDataForAsset:asset options:option
resultHandler:^(NSData *imageData, NSString *dataUTI, UIImageOrientation
orientation, NSDictionary *info) {
+ data = imageData;
Review comment:
This is the error that @alsorokin pointed out. Inherently this whole PR has
to be re-worked since here on this line, this an async block (a callback) that
resides in a synchronous function. For this to work, the processImage function
has to be async, and changing that is not trivial.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Importing corrupt images using the Camera plugin crashes the app
>
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
> Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app |
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner
> class to prevent an app crash |
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes]
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340694#comment-16340694 ] ASF GitHub Bot commented on CB-13243: - hannut91 commented on issue #147: CB-13243: (iOS) Reset default audio session category when release URL: https://github.com/apache/cordova-plugin-media/pull/147#issuecomment-360713239 When recording is released, This plugin don't set category. all audio output in app is not working. So have to set basic category of avsession to AVAudioSessionCategorySoloAmbient. see my commit log I did fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340693#comment-16340693 ] ASF GitHub Bot commented on CB-13243: - applicatteam commented on issue #147: CB-13243: (iOS) Reset default audio session category when release URL: https://github.com/apache/cordova-plugin-media/pull/147#issuecomment-360713047 When recording is released, This plugin don't set category. all audio output in app is not working. So have to set basic category of avsession to AVAudioSessionCategorySoloAmbient. see my commit log I did fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340692#comment-16340692 ] ASF GitHub Bot commented on CB-13243: - applicatteam commented on issue #147: CB-13243: (iOS) Reset default audio session category when release URL: https://github.com/apache/cordova-plugin-media/pull/147#issuecomment-360713047 When recording is released, This plugin don't set category. all audio output in app is not working. So have to set basic category of avsession to AVAudioSessionCategorySoloAmbient. see my commit log I did fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340684#comment-16340684 ] ASF GitHub Bot commented on CB-13243: - roarkmccolgan commented on issue #147: CB-13243: (iOS) Reset default audio session category when release URL: https://github.com/apache/cordova-plugin-media/pull/147#issuecomment-360711996 I believe this is a problem I am getting. Once I record an audio file, I cannot play it or any other audio file on IOS. Is there anything I can do to fix this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340682#comment-16340682 ] ASF GitHub Bot commented on CB-13415: - alsorokin commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-360711036 All the following errors are because of the failed build. Not sure why paramedic continues the test run after a build failure though... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340681#comment-16340681 ] ASF GitHub Bot commented on CB-13415: - alsorokin commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-360711036 All the following errors are from the failed build. Not sure why paramedic continues the test run after a build failure though... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340680#comment-16340680 ] ASF GitHub Bot commented on CB-13415: - alsorokin commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-360711036 All the following errors are from the failed build. Not sure why paramedic continues the test run after build failure though... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340679#comment-16340679 ] ASF GitHub Bot commented on CB-13415: - alsorokin commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-360711036 All the following errors are from the failed build. Not sure why paramedic continues test run after build failure though... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340677#comment-16340677 ] ASF GitHub Bot commented on CB-13415: - alsorokin commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-360710701 @alpesh12 from what I see, `cd tests/ios && npm install && npm test` has failed with the following error: ``` /Users/travis/build/apache/cordova-plugin-camera/src/ios/CDVCamera.m:373:36: error: variable is not assignable (missing __block type specifier) data = imageData; ^ 1 error generated. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
