[jira] [Commented] (CB-13494) cordova-js node_modules is getting removed when running some commands using npm@5
[ https://issues.apache.org/jira/browse/CB-13494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369574#comment-16369574 ] Jan Piotrowski (Sujan) commented on CB-13494: - Just had this exact same problem when running the command :( Switching over to a node with npm4 temporarily via `npm` indeed solved the problem. > cordova-js node_modules is getting removed when running some commands using > npm@5 > - > > Key: CB-13494 > URL: https://issues.apache.org/jira/browse/CB-13494 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-coho >Reporter: Suraj Pindoria >Priority: Major > > This only seems to be an issue when using npm@5. While going through the > platform release process, I was attempting to run "coho > prepare-platform-release-branch ...", but it kept failing with an error > saying it can't find local grunt. After inspecting the cordova-js directory > was able to see that node_modules/ was no longer there, even after explicitly > running "npm install". After downgrading to npm@4 and running > prepare-platform-release-branch it successfully completed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13809) Release, "Prepare release" step doesn't work and description incomplete
[
https://issues.apache.org/jira/browse/CB-13809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) updated CB-13809:
Summary: Release, "Prepare release" step doesn't work and description
incomplete (was: Release, !Prepare release! step doesn't work and description
incomplete)
> Release, "Prepare release" step doesn't work and description incomplete
> ---
>
> Key: CB-13809
> URL: https://issues.apache.org/jira/browse/CB-13809
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#prepare-release
> 1.
> {code}
> sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-repos$ for l in
> cordova-windows; do ( cd $l; v="$(grep '"version"' package.json | cut -d'"'
> -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting version to
> $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json; fi) ;
> done
> cordova-windows: Setting version to 5.1.0
> sed: can't read s/version":.*/version": "5.1.0",/: No such file or directory
> {code}
> 2. Text before headline says "Increase the version within package.json using
> SemVer ...", but the command doesn't really do this if I understood
> correctly. If one should actually change the version somehow manually, this
> could be clearer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13807) `coho repo-update -r android` doesn't work if coho was linked locally
[
https://issues.apache.org/jira/browse/CB-13807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369569#comment-16369569
]
Jan Piotrowski (Sujan) commented on CB-13807:
-
In other words: `coho repo-update` uses the current `coho` installation as base
directory (and goes up one level from there, then into the repo directory) to
do its work.
> `coho repo-update -r android` doesn't work if coho was linked locally
> -
>
> Key: CB-13807
> URL: https://issues.apache.org/jira/browse/CB-13807
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> Following these steps
> 1.
> https://github.com/apache/cordova-coho/blob/master/README.md#alternately-you-could-also-clone--use-coho
> 2.
> https://github.com/apache/cordova-coho/blob/master/README.md#cloningupdating-cordova-repositories
> 3.
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#update-and-pin-dependencies
> doesn't actually work:
> I ran step 1 in `C:\Projects\Cordova`, step 2 created
> `C:\Projects\Cordova\cordova-repos`.
> Step 3 then gives:
> {code}
> C:\Projects\Cordova\cordova-repos
> λ coho repo-update -r windows
> Running from C:\Projects\Cordova
> ./ = Executing: git clone
> https://github.com/apache/cordova-windows.git
> Cloning into 'cordova-windows'...
> remote: Counting objects: 7530, done.
> remote: Compressing objects: 100% (8/8), done.
> remote: Total 7530 (delta 0), reused 3 (delta 0), pack-reused 7522
> Receiving objects: 100% (7530/7530), 37.56 MiB | 2.03 MiB/s, done.
> Resolving deltas: 100% (4087/4087), done.
> ./ = Successfully cloned 1 repositories.
> cordova-windows/ === Executing: git remote update origin
> cordova-windows/ === Executing: git branch -r --list origin/master
> origin/master
> cordova-windows/ === Already up-to-date: cordova-windows
> {code}
> Instead of updating ` C:\Projects\Cordova/cordova-repos/cordova-windows` that
> it created in step 2, this creates another `cordova-windows` clone/checkout
> in `C:\Projects\Cordova`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13809) Release, !Prepare release! step doesn't work and description incomplete
[
https://issues.apache.org/jira/browse/CB-13809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) updated CB-13809:
Summary: Release, !Prepare release! step doesn't work and description
incomplete (was: Release, Prepare release step doesn't work and description
incomplete)
> Release, !Prepare release! step doesn't work and description incomplete
> ---
>
> Key: CB-13809
> URL: https://issues.apache.org/jira/browse/CB-13809
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#prepare-release
> 1.
> {code}
> sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-repos$ for l in
> cordova-windows; do ( cd $l; v="$(grep '"version"' package.json | cut -d'"'
> -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting version to
> $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json; fi) ;
> done
> cordova-windows: Setting version to 5.1.0
> sed: can't read s/version":.*/version": "5.1.0",/: No such file or directory
> {code}
> 2. Text before headline says "Increase the version within package.json using
> SemVer ...", but the command doesn't really do this if I understood
> correctly. If one should actually change the version somehow manually, this
> could be clearer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13903) `coho prepare-platform-release-branch` removes `cordova-js/node_modules` which contains `grunt` that is required for it to run
[
https://issues.apache.org/jira/browse/CB-13903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) updated CB-13903:
Description:
I am at the step in the platform release process where I should run `coho
prepare-platform-release-branch` and it is failing.
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova$ coho prepare-platform-release-branch
--version 6.0.0 -r windows
Running from /mnt/c/Projects/Cordova
cordova-windows/ === Executing: git remote update origin
cordova-windows/ === Executing: git branch -r --list origin/master
origin/master
cordova-windows/ === Already up-to-date: cordova-windows
cordova-windows/ === Executing: git branch -r --list origin/6.0.x
cordova-windows/ === Executing: git checkout 6.0.x
Already on '6.0.x'
cordova-js/ Executing: git stash save --all --quiet coho
stash
cordova-js/ Executing: git remote update origin
cordova-js/ Executing: git branch -r --list origin/master
origin/master
cordova-js/ Already up-to-date: cordova-js
cordova-js/ Executing: grunt compile:windows
--platformVersion=6.0.0
grunt-cli: The grunt command line interface (v1.2.0)
Fatal error: Unable to find local grunt.
If you're seeing this message, grunt hasn't been installed locally to
your project. For more information about installing and configuring grunt,
please see the Getting Started guide:
http://gruntjs.com/getting-started
(node:360) UnhandledPromiseRejectionWarning: Unhandled promise rejection
(rejection id: 13): Error: grunt: Command failed with exit code 99
(node:360) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
{code}
Running the command fails.
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova$ cd cordova-js
sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-js$ npm install
npm WARN deprecated coffee-script@1.12.7: CoffeeScript on NPM has moved to
"coffeescript" (no hyphen)
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or
higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.4.0: Please update to minimatch 3.0.2 or higher
to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher
to avoid a RegExp DoS issue
npm notice created a lockfile as package-lock.json. You should commit this file.
added 479 packages in 196.049s
{code}
So I switch over to install grunt via `npm install`. Then I run the failing
command manually to test:
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-js$ grunt compile:windows
--platformVersion=6.0.0
Running "compile:windows" (compile) task
generated cordova.windows.js @ 4450a4cea50616e080a82e8ede9e3d6a1fe3c3ec in 22ms
Done.
{code}
Works, as it should, so now back to where I was before and run again:
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-js$ cd ..
sujan@LenovoX1:/mnt/c/Projects/Cordova$ coho prepare-platform-release-branch
--version 6.0.0 -r windows
Running from /mnt/c/Projects/Cordova
cordova-windows/ === Executing: git remote update origin
cordova-windows/ === Executing: git branch -r --list origin/master
origin/master
cordova-windows/ === Already up-to-date: cordova-windows
cordova-windows/ === Executing: git branch -r --list origin/6.0.x
cordova-windows/ === Executing: git checkout 6.0.x
Already on '6.0.x'
cordova-js/ Executing: git stash save --all --quiet coho
stash
cordova-js/ Executing: git remote update origin
cordova-js/ Executing: git branch -r --list origin/master
origin/master
cordova-js/ Already up-to-date: cordova-js
cordova-js/ Executing: grunt compile:windows
--platformVersion=6.0.0
grunt-cli: The grunt command line interface (v1.2.0)
Fatal error: Unable to find local grunt.
If you're seeing this message, grunt hasn't been installed locally to
your project. For more information about installing and configuring grunt,
please see the Getting Started guide:
http://gruntjs.com/getting-started
(node:521) UnhandledPromiseRejectionWarning: Unhandled promise rejection
(rejection id: 13): Error: grunt: Command failed with exit code 99
(node:521) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
{code}
And again the same error. When I check back in `cordova-js` the `node_modules`
folder is missing. What!?
Just to check:
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova$ coho repo-update -r js
Running from /mnt/c/Projects/Cordova
[jira] [Created] (CB-13903) `coho prepare-platform-release-branch` removes `cordova-js/node_modules` which contains `grunt` that is required for it to run
Jan Piotrowski (Sujan) created CB-13903:
---
Summary: `coho prepare-platform-release-branch` removes
`cordova-js/node_modules` which contains `grunt` that is required for it to run
Key: CB-13903
URL: https://issues.apache.org/jira/browse/CB-13903
Project: Apache Cordova
Issue Type: Bug
Components: cordova-coho
Reporter: Jan Piotrowski (Sujan)
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-windows$ coho
prepare-platform-release-branch --version 6.0.0 -r windows
Running from /mnt/c/Projects/Cordova
cordova-windows/ === Executing: git remote update origin
cordova-windows/ === Executing: git branch -r --list origin/master
origin/master
cordova-windows/ === Already up-to-date: cordova-windows
cordova-windows/ === Executing: git branch -r --list origin/6.0.x
cordova-windows/ === Executing: git checkout 6.0.x
Already on '6.0.x'
cordova-js/ Executing: git stash save --all --quiet coho
stash
cordova-js/ Executing: git remote update origin
cordova-js/ Executing: git branch -r --list origin/master
origin/master
cordova-js/ Already up-to-date: cordova-js
cordova-js/ Executing: grunt compile:windows
--platformVersion=6.0.0
grunt-cli: The grunt command line interface (v1.2.0)
Fatal error: Unable to find local grunt.
If you're seeing this message, grunt hasn't been installed locally to
your project. For more information about installing and configuring grunt,
please see the Getting Started guide:
http://gruntjs.com/getting-started
(node:360) UnhandledPromiseRejectionWarning: Unhandled promise rejection
(rejection id: 13): Error: grunt: Command failed with exit code 99
(node:360) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
{code}
Running the command fails.
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-windows$ cd ../cordova-js
sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-js$ npm install
npm WARN deprecated coffee-script@1.12.7: CoffeeScript on NPM has moved to
"coffeescript" (no hyphen)
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or
higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.4.0: Please update to minimatch 3.0.2 or higher
to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher
to avoid a RegExp DoS issue
npm notice created a lockfile as package-lock.json. You should commit this file.
added 479 packages in 196.049s
{code}
So I switch over to install grunt via `npm install`. Then I run the failing
command manually to test:
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-js$ grunt compile:windows
--platformVersion=6.0.0
Running "compile:windows" (compile) task
generated cordova.windows.js @ 4450a4cea50616e080a82e8ede9e3d6a1fe3c3ec in 22ms
Done.
{code}
Works, as it should, so now back to where I was before and run again:
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-js$ cd ..
sujan@LenovoX1:/mnt/c/Projects/Cordova$ coho prepare-platform-release-branch
--version 6.0.0 -r windows
Running from /mnt/c/Projects/Cordova
cordova-windows/ === Executing: git remote update origin
cordova-windows/ === Executing: git branch -r --list origin/master
origin/master
cordova-windows/ === Already up-to-date: cordova-windows
cordova-windows/ === Executing: git branch -r --list origin/6.0.x
cordova-windows/ === Executing: git checkout 6.0.x
Already on '6.0.x'
cordova-js/ Executing: git stash save --all --quiet coho
stash
cordova-js/ Executing: git remote update origin
cordova-js/ Executing: git branch -r --list origin/master
origin/master
cordova-js/ Already up-to-date: cordova-js
cordova-js/ Executing: grunt compile:windows
--platformVersion=6.0.0
grunt-cli: The grunt command line interface (v1.2.0)
Fatal error: Unable to find local grunt.
If you're seeing this message, grunt hasn't been installed locally to
your project. For more information about installing and configuring grunt,
please see the Getting Started guide:
http://gruntjs.com/getting-started
(node:521) UnhandledPromiseRejectionWarning: Unhandled promise rejection
(rejection id: 13): Error: grunt: Command failed with exit code 99
(node:521) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
{code}
And again the same error. When I check back in `cordova-js` the
[jira] [Comment Edited] (CB-13902) prepare-platform-release-branch: `grunt` dependency is unclear
[
https://issues.apache.org/jira/browse/CB-13902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369418#comment-16369418
]
Jan Piotrowski (Sujan) edited comment on CB-13902 at 2/19/18 9:58 PM:
--
Even when globally installed I get an error as it also has to be installed
locally in `cordova-js`:
{code}
λ coho prepare-platform-release-branch --version 6.0.0 -r windows
Running from C:\Projects\Cordova
cordova-windows/ === Executing: git remote update origin
cordova-windows/ === Executing: git branch -r --list origin/master
origin/master
cordova-windows/ === Already up-to-date: cordova-windows
cordova-windows/ === Executing: git branch -r --list origin/6.0.x
cordova-windows/ === Executing: git checkout 6.0.x
Already on '6.0.x'
cordova-js/ Executing: git remote update origin
cordova-js/ Executing: git branch -r --list origin/master
origin/master
cordova-js/ Already up-to-date: cordova-js
cordova-js/ Executing: grunt compile:windows
--platformVersion=6.0.0
grunt-cli: The grunt command line interface (v1.2.0)
Fatal error: Unable to find local grunt.
If you're seeing this message, grunt hasn't been installed locally to
your project. For more information about installing and configuring grunt,
please see the Getting Started guide:
http://gruntjs.com/getting-started
(node:12108) UnhandledPromiseRejectionWarning: Error: cmd: Command failed with
exit code 99
at ChildProcess.whenDone
(C:\Projects\Cordova\cordova-coho\src\superspawn.js:144:23)
at ChildProcess.emit (events.js:160:13)
at maybeClose (internal/child_process.js:943:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)
(node:12108) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
This error originated either by throwing inside of an async function without a
catch block, or by rejecting a promise which was not handled with .catch().
(rejection id: 13)
(node:12108) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
{code}
Running `npm install` does not really fix this as `node_modules' gets deleted
when running the command somehow.
was (Author: sujan12):
Even when globally installed I get an error:
{code}
λ coho prepare-platform-release-branch --version 6.0.0 -r windows
Running from C:\Projects\Cordova
cordova-windows/ === Executing: git remote update origin
cordova-windows/ === Executing: git branch -r --list origin/master
origin/master
cordova-windows/ === Already up-to-date: cordova-windows
cordova-windows/ === Executing: git branch -r --list origin/6.0.x
cordova-windows/ === Executing: git checkout 6.0.x
Already on '6.0.x'
cordova-js/ Executing: git remote update origin
cordova-js/ Executing: git branch -r --list origin/master
origin/master
cordova-js/ Already up-to-date: cordova-js
cordova-js/ Executing: grunt compile:windows
--platformVersion=6.0.0
grunt-cli: The grunt command line interface (v1.2.0)
Fatal error: Unable to find local grunt.
If you're seeing this message, grunt hasn't been installed locally to
your project. For more information about installing and configuring grunt,
please see the Getting Started guide:
http://gruntjs.com/getting-started
(node:12108) UnhandledPromiseRejectionWarning: Error: cmd: Command failed with
exit code 99
at ChildProcess.whenDone
(C:\Projects\Cordova\cordova-coho\src\superspawn.js:144:23)
at ChildProcess.emit (events.js:160:13)
at maybeClose (internal/child_process.js:943:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)
(node:12108) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
This error originated either by throwing inside of an async function without a
catch block, or by rejecting a promise which was not handled with .catch().
(rejection id: 13)
(node:12108) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
{code}
> prepare-platform-release-branch: `grunt` dependency is unclear
> --
>
> Key: CB-13902
> URL: https://issues.apache.org/jira/browse/CB-13902
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> Seems `coho prepare-platform-release-branch` needs grunt to be installed
>
[jira] [Updated] (CB-13902) prepare-platform-release-branch: `grunt` dependency is unclear
[
https://issues.apache.org/jira/browse/CB-13902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) updated CB-13902:
Summary: prepare-platform-release-branch: `grunt` dependency is unclear
(was: Dependency on `grunt` isn't mentioned anywhere)
> prepare-platform-release-branch: `grunt` dependency is unclear
> --
>
> Key: CB-13902
> URL: https://issues.apache.org/jira/browse/CB-13902
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> Seems `coho prepare-platform-release-branch` needs grunt to be installed
> globally:
> {code}
> C:\Projects\Cordova\cordova-windows (6.0.x -> origin) (cordova-windows@6.0.0)
> λ coho prepare-platform-release-branch --version 6.0.0 -r windows
> Running from C:\Projects\Cordova
> cordova-windows/ === Executing: git remote update origin
> cordova-windows/ === Executing: git branch -r --list origin/master
> origin/master
> cordova-windows/ === Already up-to-date: cordova-windows
> cordova-windows/ === Executing: git branch -r --list origin/6.0.x
> cordova-windows/ === Executing: git checkout 6.0.x
> Already on '6.0.x'
> cordova-js/ Executing: git remote update origin
> cordova-js/ Executing: git branch -r --list origin/master
> origin/master
> cordova-js/ Already up-to-date: cordova-js
> cordova-js/ Executing: grunt compile:windows
> --platformVersion=6.0.0
> (node:8516) UnhandledPromiseRejectionWarning: Error: grunt: Command failed
> with exit code ENOENT
> at ChildProcess.whenDone
> (C:\Projects\Cordova\cordova-coho\src\superspawn.js:144:23)
> at ChildProcess.emit (events.js:160:13)
> at Process.ChildProcess._handle.onexit (internal/child_process.js:207:12)
> at onErrorNT (internal/child_process.js:389:16)
> at process._tickCallback (internal/process/next_tick.js:152:19)
> (node:8516) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 13)
> (node:8516) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {code}
> This isn't mentioned anywhere or at least I couldn't fint it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13902) Dependency on `grunt` isn't mentioned anywhere
[
https://issues.apache.org/jira/browse/CB-13902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369418#comment-16369418
]
Jan Piotrowski (Sujan) commented on CB-13902:
-
Even when globally installed I get an error:
{code}
λ coho prepare-platform-release-branch --version 6.0.0 -r windows
Running from C:\Projects\Cordova
cordova-windows/ === Executing: git remote update origin
cordova-windows/ === Executing: git branch -r --list origin/master
origin/master
cordova-windows/ === Already up-to-date: cordova-windows
cordova-windows/ === Executing: git branch -r --list origin/6.0.x
cordova-windows/ === Executing: git checkout 6.0.x
Already on '6.0.x'
cordova-js/ Executing: git remote update origin
cordova-js/ Executing: git branch -r --list origin/master
origin/master
cordova-js/ Already up-to-date: cordova-js
cordova-js/ Executing: grunt compile:windows
--platformVersion=6.0.0
grunt-cli: The grunt command line interface (v1.2.0)
Fatal error: Unable to find local grunt.
If you're seeing this message, grunt hasn't been installed locally to
your project. For more information about installing and configuring grunt,
please see the Getting Started guide:
http://gruntjs.com/getting-started
(node:12108) UnhandledPromiseRejectionWarning: Error: cmd: Command failed with
exit code 99
at ChildProcess.whenDone
(C:\Projects\Cordova\cordova-coho\src\superspawn.js:144:23)
at ChildProcess.emit (events.js:160:13)
at maybeClose (internal/child_process.js:943:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)
(node:12108) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
This error originated either by throwing inside of an async function without a
catch block, or by rejecting a promise which was not handled with .catch().
(rejection id: 13)
(node:12108) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
{code}
> Dependency on `grunt` isn't mentioned anywhere
> --
>
> Key: CB-13902
> URL: https://issues.apache.org/jira/browse/CB-13902
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> Seems `coho prepare-platform-release-branch` needs grunt to be installed
> globally:
> {code}
> C:\Projects\Cordova\cordova-windows (6.0.x -> origin) (cordova-windows@6.0.0)
> λ coho prepare-platform-release-branch --version 6.0.0 -r windows
> Running from C:\Projects\Cordova
> cordova-windows/ === Executing: git remote update origin
> cordova-windows/ === Executing: git branch -r --list origin/master
> origin/master
> cordova-windows/ === Already up-to-date: cordova-windows
> cordova-windows/ === Executing: git branch -r --list origin/6.0.x
> cordova-windows/ === Executing: git checkout 6.0.x
> Already on '6.0.x'
> cordova-js/ Executing: git remote update origin
> cordova-js/ Executing: git branch -r --list origin/master
> origin/master
> cordova-js/ Already up-to-date: cordova-js
> cordova-js/ Executing: grunt compile:windows
> --platformVersion=6.0.0
> (node:8516) UnhandledPromiseRejectionWarning: Error: grunt: Command failed
> with exit code ENOENT
> at ChildProcess.whenDone
> (C:\Projects\Cordova\cordova-coho\src\superspawn.js:144:23)
> at ChildProcess.emit (events.js:160:13)
> at Process.ChildProcess._handle.onexit (internal/child_process.js:207:12)
> at onErrorNT (internal/child_process.js:389:16)
> at process._tickCallback (internal/process/next_tick.js:152:19)
> (node:8516) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 13)
> (node:8516) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {code}
> This isn't mentioned anywhere or at least I couldn't fint it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13902) Dependency on `grunt` isn't mentioned anywhere
Jan Piotrowski (Sujan) created CB-13902:
---
Summary: Dependency on `grunt` isn't mentioned anywhere
Key: CB-13902
URL: https://issues.apache.org/jira/browse/CB-13902
Project: Apache Cordova
Issue Type: Bug
Components: cordova-coho
Reporter: Jan Piotrowski (Sujan)
Seems `coho prepare-platform-release-branch` needs grunt to be installed
globally:
{code}
C:\Projects\Cordova\cordova-windows (6.0.x -> origin) (cordova-windows@6.0.0)
λ coho prepare-platform-release-branch --version 6.0.0 -r windows
Running from C:\Projects\Cordova
cordova-windows/ === Executing: git remote update origin
cordova-windows/ === Executing: git branch -r --list origin/master
origin/master
cordova-windows/ === Already up-to-date: cordova-windows
cordova-windows/ === Executing: git branch -r --list origin/6.0.x
cordova-windows/ === Executing: git checkout 6.0.x
Already on '6.0.x'
cordova-js/ Executing: git remote update origin
cordova-js/ Executing: git branch -r --list origin/master
origin/master
cordova-js/ Already up-to-date: cordova-js
cordova-js/ Executing: grunt compile:windows
--platformVersion=6.0.0
(node:8516) UnhandledPromiseRejectionWarning: Error: grunt: Command failed with
exit code ENOENT
at ChildProcess.whenDone
(C:\Projects\Cordova\cordova-coho\src\superspawn.js:144:23)
at ChildProcess.emit (events.js:160:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:207:12)
at onErrorNT (internal/child_process.js:389:16)
at process._tickCallback (internal/process/next_tick.js:152:19)
(node:8516) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This
error originated either by throwing inside of an async function without a catch
block, or by rejecting a promise which was not handled with .catch().
(rejection id: 13)
(node:8516) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
{code}
This isn't mentioned anywhere or at least I couldn't fint it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13901) Platform Release: "View the changes via" doesn't work
Jan Piotrowski (Sujan) created CB-13901:
---
Summary: Platform Release: "View the changes via" doesn't work
Key: CB-13901
URL: https://issues.apache.org/jira/browse/CB-13901
Project: Apache Cordova
Issue Type: Bug
Components: cordova-coho
Reporter: Jan Piotrowski (Sujan)
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#prepare-release
has "View the changes via" as a second step. Executing that command gives me
this though:
{code}
λ git log --pretty=format:'* %s' --topo-order --no-merges $(git describe --tags
$(git rev-list --tags --max-count=1))..master
fatal: ambiguous argument '%s'': unknown revision or path not in the working
tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13809) Release, Prepare release step doesn't work and description incomplete
[
https://issues.apache.org/jira/browse/CB-13809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369383#comment-16369383
]
Jan Piotrowski (Sujan) commented on CB-13809:
-
Re 2: Text was misleading, by comparing it with other release instructions I
found out how this actually works and will rewrite it to match reality.
> Release, Prepare release step doesn't work and description incomplete
> -
>
> Key: CB-13809
> URL: https://issues.apache.org/jira/browse/CB-13809
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#prepare-release
> 1.
> {code}
> sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-repos$ for l in
> cordova-windows; do ( cd $l; v="$(grep '"version"' package.json | cut -d'"'
> -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting version to
> $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json; fi) ;
> done
> cordova-windows: Setting version to 5.1.0
> sed: can't read s/version":.*/version": "5.1.0",/: No such file or directory
> {code}
> 2. Text before headline says "Increase the version within package.json using
> SemVer ...", but the command doesn't really do this if I understood
> correctly. If one should actually change the version somehow manually, this
> could be clearer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13900) Splashscreen get resized on iOS at startup
Thomas Fétiveau created CB-13900: Summary: Splashscreen get resized on iOS at startup Key: CB-13900 URL: https://issues.apache.org/jira/browse/CB-13900 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-splashscreen Reporter: Thomas Fétiveau I'm using the following setting in my config.xml for iOS : At startup, the splashscreen get displayed once with a given size and then right after with a unzoomed size. The effect is not nice. Why is this happening ? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13899) Cannot change status bar background color on android
Thomas Fétiveau created CB-13899: Summary: Cannot change status bar background color on android Key: CB-13899 URL: https://issues.apache.org/jira/browse/CB-13899 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-splashscreen Reporter: Thomas Fétiveau I can't change the color of the splashscreen background on Android 7.0. It's always black. I have set this in my config.xml but it does not have any effect : -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13898) How to handle package-lock.json?
Jan Piotrowski (Sujan) created CB-13898: --- Summary: How to handle package-lock.json? Key: CB-13898 URL: https://issues.apache.org/jira/browse/CB-13898 Project: Apache Cordova Issue Type: Improvement Components: cordova-coho Reporter: Jan Piotrowski (Sujan) https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#update-and-pin-dependencies No mention of `package-lock.json`. How should this be handled here? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13897) Appveyor project does not exist
Jan Piotrowski (Sujan) created CB-13897: --- Summary: Appveyor project does not exist Key: CB-13897 URL: https://issues.apache.org/jira/browse/CB-13897 Project: Apache Cordova Issue Type: Bug Components: cordova-coho Reporter: Jan Piotrowski (Sujan) README of coho links to https://ci.appveyor.com/project/stumped2/cordova-coho which does not exist. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13896) Cordova-Windows Platform Release 6.0.0, February 19/20, 2018
Jan Piotrowski (Sujan) created CB-13896: --- Summary: Cordova-Windows Platform Release 6.0.0, February 19/20, 2018 Key: CB-13896 URL: https://issues.apache.org/jira/browse/CB-13896 Project: Apache Cordova Issue Type: Task Components: cordova-windows Reporter: Jan Piotrowski (Sujan) Assignee: Jesse MacFadyen Following steps at https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13896) Cordova-Windows Platform Release 6.0.0, February 19/20, 2018
[ https://issues.apache.org/jira/browse/CB-13896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13896: --- Assignee: Jan Piotrowski (Sujan) (was: Jesse MacFadyen) > Cordova-Windows Platform Release 6.0.0, February 19/20, 2018 > > > Key: CB-13896 > URL: https://issues.apache.org/jira/browse/CB-13896 > Project: Apache Cordova > Issue Type: Task > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13895) cordova-plugin-camera not working on device
[ https://issues.apache.org/jira/browse/CB-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369089#comment-16369089 ] mahmoud hussein commented on CB-13895: -- [~surajpindoria] can you help? > cordova-plugin-camera not working on device > --- > > Key: CB-13895 > URL: https://issues.apache.org/jira/browse/CB-13895 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: mahmoud hussein >Priority: Major > Attachments: Untitled.png > > > I am trying to use cordova-plugin-camera into my app. > navigator.camera get undefined. > Any help? > (I tried to implement cordova-plugin-device and it is working find) > Please see attached picture. > Thank you, -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13895) cordova-plugin-camera not working on device
mahmoud hussein created CB-13895: Summary: cordova-plugin-camera not working on device Key: CB-13895 URL: https://issues.apache.org/jira/browse/CB-13895 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-camera Reporter: mahmoud hussein Attachments: Untitled.png I am trying to use cordova-plugin-camera into my app. navigator.camera get undefined. Any help? (I tried to implement cordova-plugin-device and it is working find) Please see attached picture. Thank you, -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368914#comment-16368914 ] ASF GitHub Bot commented on CB-13415: - LiDhaval commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-366633300 +1 It will be really helpful if we get this piece of code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
