[jira] [Commented] (CB-13927) Modified xcodeProjDir to filter out files/folders that contain "._"
[ https://issues.apache.org/jira/browse/CB-13927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379856#comment-16379856 ] ASF GitHub Bot commented on CB-13927: - shazron commented on issue #355: CB-13927 - Modified xcodeProjDir to filter out files/folders that contain "._" URL: https://github.com/apache/cordova-ios/pull/355#issuecomment-369138780 Added JIRA issue, modified the title, and commented on the code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Modified xcodeProjDir to filter out files/folders that contain "._" > --- > > Key: CB-13927 > URL: https://issues.apache.org/jira/browse/CB-13927 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > I ran into an issue trying to add an ios plugin using a virtual machine. The > code would return an array for the xcodeProjDir and then of course use the > wrong one. It would use the one starting with "._ProjectName" which I believe > is an MacOS hidden folder. I attempted to install the plugin on OsX but > because it's a virtual machine it still had those hidden folders. I've made > it so that it will filter those out while looking for the proper xCode > project folder. > h3. *Platforms affected* > Windows (host) / OSx (guest) virtual machines > h3. *What does this PR do?* > Fixes a folder issue. Before it would try to use an incorrect folder for the > xCode project. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13927) Modified xcodeProjDir to filter out files/folders that contain "._"
Shazron Abdullah created CB-13927: - Summary: Modified xcodeProjDir to filter out files/folders that contain "._" Key: CB-13927 URL: https://issues.apache.org/jira/browse/CB-13927 Project: Apache Cordova Issue Type: Improvement Components: cordova-ios Reporter: Shazron Abdullah Assignee: Suraj Pindoria I ran into an issue trying to add an ios plugin using a virtual machine. The code would return an array for the xcodeProjDir and then of course use the wrong one. It would use the one starting with "._ProjectName" which I believe is an MacOS hidden folder. I attempted to install the plugin on OsX but because it's a virtual machine it still had those hidden folders. I've made it so that it will filter those out while looking for the proper xCode project folder. h3. *Platforms affected* Windows (host) / OSx (guest) virtual machines h3. *What does this PR do?* Fixes a folder issue. Before it would try to use an incorrect folder for the xCode project. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13922) sim launch force-fully exits process
[
https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379827#comment-16379827
]
ASF GitHub Bot commented on CB-13922:
-
shazron commented on issue #357: CB-13922 - remove exit for start sim
URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369133319
Add a flag here:
https://github.com/apache/cordova-ios/blob/7397337c932e072c0d68e6d1c61e6a5056d4f376/bin/templates/scripts/cordova/run#L50
and handle it in your code, switch on that flag
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> sim launch force-fully exits process
>
>
> Key: CB-13922
> URL: https://issues.apache.org/jira/browse/CB-13922
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Hossein Amin
>Assignee: Shazron Abdullah
>Priority: Trivial
> Labels: pull-request-available
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator.
> I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim
> {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' +
> target, logPath, '--exit');}}
>
> This call is made inside main process, Where request for exit will end main
> process with no chance to catch it.
>
> I assume this call returns a promise for when launch was successful, If that
> can happen.
> Things will go smoothly after that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13922) sim launch force-fully exits process
[
https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379824#comment-16379824
]
ASF GitHub Bot commented on CB-13922:
-
shazron commented on issue #357: CB-13922 - remove exit for start sim
URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369132607
I just tested this. Unfortunately this breaks the expectation that after a
(for example):
```bash
cordova emulate ios --target="iPhone-7, 11.2"
```
... the command exits, and the user gets back a command prompt -- the
current behaviour. I think, what is needed here is a flag called `--no-exit` to
handle your special case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> sim launch force-fully exits process
>
>
> Key: CB-13922
> URL: https://issues.apache.org/jira/browse/CB-13922
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Hossein Amin
>Assignee: Shazron Abdullah
>Priority: Trivial
> Labels: pull-request-available
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator.
> I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim
> {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' +
> target, logPath, '--exit');}}
>
> This call is made inside main process, Where request for exit will end main
> process with no chance to catch it.
>
> I assume this call returns a promise for when launch was successful, If that
> can happen.
> Things will go smoothly after that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13865) Making CameraPopover for imagePicker bigger on Ipad
[
https://issues.apache.org/jira/browse/CB-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379817#comment-16379817
]
ASF GitHub Bot commented on CB-13865:
-
amercode commented on issue #314: CB-13865: (IOS-Ipad) Making popover Window
Size configurable using popoverOptions - imagePicker
URL:
https://github.com/apache/cordova-plugin-camera/pull/314#issuecomment-369130546
Travis Build failed due to timeout on the server and not due to test cases
failing. It failed only for android-6.0 and android-7.0 while passing for all
other platforms including android-4.4 and android-5.1.
We have not made any changes in the Android code and it is clearly a build
server timeout probably due to overload. Is there a way to retrigger the build
or make those test cases pass? Please advise as you can see the logs below for
the failed test case?
...
✗ camera.ui.util determine camera availability
- Error: Timeout - Async callback was not invoked within timeout
specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Making CameraPopover for imagePicker bigger on Ipad
> ---
>
> Key: CB-13865
> URL: https://issues.apache.org/jira/browse/CB-13865
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-camera
>Reporter: Ams
>Priority: Major
> Fix For: Master
>
>
> The popover for imagePicker from gallery is way too small and people complain
> about not being able to see images before selecting them.
>
> The fix is simple:
>
> Adding this line to willShowViewController method will set it to 960 by 960
> or as big as the screen widht/height
> [viewController setPreferredContentSize:CGSizeMake(960,960)];
> It should be added right in the if statement:
> if([navigationController isKindOfClass:[UIImagePickerController class]]){
>
> HOW CAN I COMMIT THIS CHANGE?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-13921. --- Resolution: Fixed Fix Version/s: cordova-ios@4.6.0 > Update Xcode requirement to Xcode 9 > --- > > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > Fix For: cordova-ios@4.6.0 > > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379814#comment-16379814 ] ASF subversion and git services commented on CB-13921: -- Commit 7397337c932e072c0d68e6d1c61e6a5056d4f376 in cordova-ios's branch refs/heads/master from [~shazron] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=7397337 ] CB-13921 - Update Xcode requirement to Xcode 9 (#360) Updated Travis osx_image to Xcode 9.2, updated node versions Node 4 and 6 testing updated to latest versions > Update Xcode requirement to Xcode 9 > --- > > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[
https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379813#comment-16379813
]
ASF GitHub Bot commented on CB-13921:
-
shazron closed pull request #360: CB-13921 - Update Xcode requirement to Xcode 9
URL: https://github.com/apache/cordova-ios/pull/360
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 2866f3527..013df38b7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,10 +1,10 @@
language: objective-c
-osx_image: xcode8.3
+osx_image: xcode9.2
sudo: false
env:
matrix:
- - TRAVIS_NODE_VERSION: '4.2'
- - TRAVIS_NODE_VERSION: '6.11'
+ - TRAVIS_NODE_VERSION: '4.8.7'
+ - TRAVIS_NODE_VERSION: '6.13'
before_install:
- npm cache clean -f
- rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm &&
(cd ~/.nvm
diff --git a/bin/templates/scripts/cordova/lib/check_reqs.js
b/bin/templates/scripts/cordova/lib/check_reqs.js
index 21a220814..0af8ed33f 100644
--- a/bin/templates/scripts/cordova/lib/check_reqs.js
+++ b/bin/templates/scripts/cordova/lib/check_reqs.js
@@ -26,7 +26,7 @@ const versions = require('./versions');
const SUPPORTED_OS_PLATFORMS = [ 'darwin' ];
-const XCODEBUILD_MIN_VERSION = '7.0.0';
+const XCODEBUILD_MIN_VERSION = '9.0.0';
const XCODEBUILD_NOT_FOUND_MESSAGE =
'Please install version ' + XCODEBUILD_MIN_VERSION + ' or greater from App
Store';
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Xcode requirement to Xcode 9
> ---
>
> Key: CB-13921
> URL: https://issues.apache.org/jira/browse/CB-13921
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>Priority: Major
>
> Right now it is Xcode 7.
>
> Update check_reqs.js
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379812#comment-16379812 ] ASF GitHub Bot commented on CB-13921: - codecov-io commented on issue #360: CB-13921 - Update Xcode requirement to Xcode 9 URL: https://github.com/apache/cordova-ios/pull/360#issuecomment-369129824 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=h1) Report > Merging [#360](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e75c38f65d05b8bbca1178d6ace309a2df7844da?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #360 +/- ## === Coverage 63.99% 63.99% === Files 14 14 Lines1697 1697 Branches 286 286 === Hits 1086 1086 Misses611 611 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/360/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=) | `42.04% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=footer). Last update [e75c38f...ec8d451](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Xcode requirement to Xcode 9 > --- > > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379811#comment-16379811 ] ASF GitHub Bot commented on CB-13921: - shazron commented on issue #360: CB-13921 - Update Xcode requirement to Xcode 9 URL: https://github.com/apache/cordova-ios/pull/360#issuecomment-369128535 Testing this locally, and also Travis testing the same commits on my fork worked. Chalking this up to a one-off, closing and re-opening the PR so Travis builds this again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Xcode requirement to Xcode 9 > --- > > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[
https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379808#comment-16379808
]
ASF GitHub Bot commented on CB-13921:
-
shazron closed pull request #360: CB-13921 - Update Xcode requirement to Xcode 9
URL: https://github.com/apache/cordova-ios/pull/360
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 2866f3527..013df38b7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,10 +1,10 @@
language: objective-c
-osx_image: xcode8.3
+osx_image: xcode9.2
sudo: false
env:
matrix:
- - TRAVIS_NODE_VERSION: '4.2'
- - TRAVIS_NODE_VERSION: '6.11'
+ - TRAVIS_NODE_VERSION: '4.8.7'
+ - TRAVIS_NODE_VERSION: '6.13'
before_install:
- npm cache clean -f
- rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm &&
(cd ~/.nvm
diff --git a/bin/templates/scripts/cordova/lib/check_reqs.js
b/bin/templates/scripts/cordova/lib/check_reqs.js
index 21a220814..0af8ed33f 100644
--- a/bin/templates/scripts/cordova/lib/check_reqs.js
+++ b/bin/templates/scripts/cordova/lib/check_reqs.js
@@ -26,7 +26,7 @@ const versions = require('./versions');
const SUPPORTED_OS_PLATFORMS = [ 'darwin' ];
-const XCODEBUILD_MIN_VERSION = '7.0.0';
+const XCODEBUILD_MIN_VERSION = '9.0.0';
const XCODEBUILD_NOT_FOUND_MESSAGE =
'Please install version ' + XCODEBUILD_MIN_VERSION + ' or greater from App
Store';
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Xcode requirement to Xcode 9
> ---
>
> Key: CB-13921
> URL: https://issues.apache.org/jira/browse/CB-13921
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>Priority: Major
>
> Right now it is Xcode 7.
>
> Update check_reqs.js
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379809#comment-16379809 ] ASF GitHub Bot commented on CB-13921: - shazron opened a new pull request #360: CB-13921 - Update Xcode requirement to Xcode 9 URL: https://github.com/apache/cordova-ios/pull/360 > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379797#comment-16379797 ] ASF GitHub Bot commented on CB-13921: - shazron opened a new pull request #360: CB-13921 - Update Xcode requirement to Xcode 9 URL: https://github.com/apache/cordova-ios/pull/360 > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13922) sim launch force-fully exits process
[
https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah reassigned CB-13922:
-
Assignee: Shazron Abdullah (was: Suraj Pindoria)
> sim launch force-fully exits process
>
>
> Key: CB-13922
> URL: https://issues.apache.org/jira/browse/CB-13922
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Hossein Amin
>Assignee: Shazron Abdullah
>Priority: Trivial
> Labels: pull-request-available
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator.
> I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim
> {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' +
> target, logPath, '--exit');}}
>
> This call is made inside main process, Where request for exit will end main
> process with no chance to catch it.
>
> I assume this call returns a promise for when launch was successful, If that
> can happen.
> Things will go smoothly after that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13382) Cordova iOS - Method to correctly destroy CDVViewControllers webView object
[
https://issues.apache.org/jira/browse/CB-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379784#comment-16379784
]
ASF GitHub Bot commented on CB-13382:
-
shazron closed pull request #359: CB-13382 dealloc the webViewEngine
URL: https://github.com/apache/cordova-ios/pull/359
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/CordovaLib/Classes/Public/CDVViewController.m
b/CordovaLib/Classes/Public/CDVViewController.m
index f34b3ddf5..081c9162b 100644
--- a/CordovaLib/Classes/Public/CDVViewController.m
+++ b/CordovaLib/Classes/Public/CDVViewController.m
@@ -782,6 +782,11 @@ - (void)dealloc
[CDVUserAgentUtil releaseLock:&_userAgentLockToken];
[_commandQueue dispose];
[[self.pluginObjects allValues]
makeObjectsPerformSelector:@selector(dispose)];
+
+[self.webViewEngine loadHTMLString:@"about:blank" baseURL:nil];
+[self.pluginObjects removeAllObjects];
+[self.webView removeFromSuperview];
+self.webViewEngine = nil;
}
- (NSInteger*)userAgentLockToken
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova iOS - Method to correctly destroy CDVViewControllers webView object
> ---
>
> Key: CB-13382
> URL: https://issues.apache.org/jira/browse/CB-13382
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Nick Deakin
>Assignee: Suraj Pindoria
>Priority: Minor
>
> We have an app where we are using multi CDVViewController instances where a
> user can switch between hybrid apps within the native app.
> The issue that as been lingering for a couple of years is that even though a
> CDVViewController instance can be set to nil, the webview contained within
> still remains in memory. This can be observed when using the safari debugger.
> This is particularly troublesome when the webview is 'closed', then the
> content files in the webview are updated, and finally the webview is
> recreated, showing the old content. Performing a cmd-r in safari debugger
> refreshes the view and shows the updated content.
> We can also do this a [UIWebView reload], but it is not possible if the app
> changes it's URL to a none physical path, e.g.
> file:///x/myApp/www/index.html becomes file:///x/myApp/www/home, then
> we get a page load error.
> I've been able to get the webview completely removed by doing the following:
> add the following method to CDVViewController:
> {code:java}
> -(void)destroyWebView {
> self.webViewEngine = nil;
> }
> {code}
> then in my view controllers destroy method:
> {code:java}
> [self.webViewEngine loadHTMLString:@"about:blank" baseURL:nil];
> [self.pluginObjects removeAllObjects];
> [self.webView removeFromSuperview];
> [self destroyWebView];
> {code}
> Setting webViewEngine to nil is an unavoidable step to completely destroying
> the webview, but it is readonly.
> Therefore, i would really appreciate this destroyWebView method, or a similar
> cleanup method being added.
> Android has a method to clean up which is CordovaWebViewImpl.handleDestroy().
> This destroys all the plugins, sets the URL to 'about:blank' and then
> executes engine.destroy()
> Many thanks!
> Nick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13382) Cordova iOS - Method to correctly destroy CDVViewControllers webView object
[
https://issues.apache.org/jira/browse/CB-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379786#comment-16379786
]
ASF subversion and git services commented on CB-13382:
--
Commit e75c38f65d05b8bbca1178d6ace309a2df7844da in cordova-ios's branch
refs/heads/master from [~surajpindoria]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=e75c38f ]
CB-13382 dealloc the webViewEngine (#359)
* CB-13382: (ios) Added destroyWebView method for CDVViewController
* CB-13382: (ios) Remove new function and add to delloc method
> Cordova iOS - Method to correctly destroy CDVViewControllers webView object
> ---
>
> Key: CB-13382
> URL: https://issues.apache.org/jira/browse/CB-13382
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Nick Deakin
>Assignee: Suraj Pindoria
>Priority: Minor
>
> We have an app where we are using multi CDVViewController instances where a
> user can switch between hybrid apps within the native app.
> The issue that as been lingering for a couple of years is that even though a
> CDVViewController instance can be set to nil, the webview contained within
> still remains in memory. This can be observed when using the safari debugger.
> This is particularly troublesome when the webview is 'closed', then the
> content files in the webview are updated, and finally the webview is
> recreated, showing the old content. Performing a cmd-r in safari debugger
> refreshes the view and shows the updated content.
> We can also do this a [UIWebView reload], but it is not possible if the app
> changes it's URL to a none physical path, e.g.
> file:///x/myApp/www/index.html becomes file:///x/myApp/www/home, then
> we get a page load error.
> I've been able to get the webview completely removed by doing the following:
> add the following method to CDVViewController:
> {code:java}
> -(void)destroyWebView {
> self.webViewEngine = nil;
> }
> {code}
> then in my view controllers destroy method:
> {code:java}
> [self.webViewEngine loadHTMLString:@"about:blank" baseURL:nil];
> [self.pluginObjects removeAllObjects];
> [self.webView removeFromSuperview];
> [self destroyWebView];
> {code}
> Setting webViewEngine to nil is an unavoidable step to completely destroying
> the webview, but it is readonly.
> Therefore, i would really appreciate this destroyWebView method, or a similar
> cleanup method being added.
> Android has a method to clean up which is CordovaWebViewImpl.handleDestroy().
> This destroys all the plugins, sets the URL to 'about:blank' and then
> executes engine.destroy()
> Many thanks!
> Nick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13382) Cordova iOS - Method to correctly destroy CDVViewControllers webView object
[
https://issues.apache.org/jira/browse/CB-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379787#comment-16379787
]
ASF subversion and git services commented on CB-13382:
--
Commit e75c38f65d05b8bbca1178d6ace309a2df7844da in cordova-ios's branch
refs/heads/master from [~surajpindoria]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=e75c38f ]
CB-13382 dealloc the webViewEngine (#359)
* CB-13382: (ios) Added destroyWebView method for CDVViewController
* CB-13382: (ios) Remove new function and add to delloc method
> Cordova iOS - Method to correctly destroy CDVViewControllers webView object
> ---
>
> Key: CB-13382
> URL: https://issues.apache.org/jira/browse/CB-13382
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Nick Deakin
>Assignee: Suraj Pindoria
>Priority: Minor
>
> We have an app where we are using multi CDVViewController instances where a
> user can switch between hybrid apps within the native app.
> The issue that as been lingering for a couple of years is that even though a
> CDVViewController instance can be set to nil, the webview contained within
> still remains in memory. This can be observed when using the safari debugger.
> This is particularly troublesome when the webview is 'closed', then the
> content files in the webview are updated, and finally the webview is
> recreated, showing the old content. Performing a cmd-r in safari debugger
> refreshes the view and shows the updated content.
> We can also do this a [UIWebView reload], but it is not possible if the app
> changes it's URL to a none physical path, e.g.
> file:///x/myApp/www/index.html becomes file:///x/myApp/www/home, then
> we get a page load error.
> I've been able to get the webview completely removed by doing the following:
> add the following method to CDVViewController:
> {code:java}
> -(void)destroyWebView {
> self.webViewEngine = nil;
> }
> {code}
> then in my view controllers destroy method:
> {code:java}
> [self.webViewEngine loadHTMLString:@"about:blank" baseURL:nil];
> [self.pluginObjects removeAllObjects];
> [self.webView removeFromSuperview];
> [self destroyWebView];
> {code}
> Setting webViewEngine to nil is an unavoidable step to completely destroying
> the webview, but it is readonly.
> Therefore, i would really appreciate this destroyWebView method, or a similar
> cleanup method being added.
> Android has a method to clean up which is CordovaWebViewImpl.handleDestroy().
> This destroys all the plugins, sets the URL to 'about:blank' and then
> executes engine.destroy()
> Many thanks!
> Nick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13382) Cordova iOS - Method to correctly destroy CDVViewControllers webView object
[
https://issues.apache.org/jira/browse/CB-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379785#comment-16379785
]
ASF subversion and git services commented on CB-13382:
--
Commit e75c38f65d05b8bbca1178d6ace309a2df7844da in cordova-ios's branch
refs/heads/master from [~surajpindoria]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=e75c38f ]
CB-13382 dealloc the webViewEngine (#359)
* CB-13382: (ios) Added destroyWebView method for CDVViewController
* CB-13382: (ios) Remove new function and add to delloc method
> Cordova iOS - Method to correctly destroy CDVViewControllers webView object
> ---
>
> Key: CB-13382
> URL: https://issues.apache.org/jira/browse/CB-13382
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Nick Deakin
>Assignee: Suraj Pindoria
>Priority: Minor
>
> We have an app where we are using multi CDVViewController instances where a
> user can switch between hybrid apps within the native app.
> The issue that as been lingering for a couple of years is that even though a
> CDVViewController instance can be set to nil, the webview contained within
> still remains in memory. This can be observed when using the safari debugger.
> This is particularly troublesome when the webview is 'closed', then the
> content files in the webview are updated, and finally the webview is
> recreated, showing the old content. Performing a cmd-r in safari debugger
> refreshes the view and shows the updated content.
> We can also do this a [UIWebView reload], but it is not possible if the app
> changes it's URL to a none physical path, e.g.
> file:///x/myApp/www/index.html becomes file:///x/myApp/www/home, then
> we get a page load error.
> I've been able to get the webview completely removed by doing the following:
> add the following method to CDVViewController:
> {code:java}
> -(void)destroyWebView {
> self.webViewEngine = nil;
> }
> {code}
> then in my view controllers destroy method:
> {code:java}
> [self.webViewEngine loadHTMLString:@"about:blank" baseURL:nil];
> [self.pluginObjects removeAllObjects];
> [self.webView removeFromSuperview];
> [self destroyWebView];
> {code}
> Setting webViewEngine to nil is an unavoidable step to completely destroying
> the webview, but it is readonly.
> Therefore, i would really appreciate this destroyWebView method, or a similar
> cleanup method being added.
> Android has a method to clean up which is CordovaWebViewImpl.handleDestroy().
> This destroys all the plugins, sets the URL to 'about:blank' and then
> executes engine.destroy()
> Many thanks!
> Nick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13865) Making CameraPopover for imagePicker bigger on Ipad
[
https://issues.apache.org/jira/browse/CB-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379768#comment-16379768
]
ASF GitHub Bot commented on CB-13865:
-
amercode opened a new pull request #314: CB-13865: (IOS-Ipad) Making
CameraPopover for imagePicker bigger on Ipad
URL: https://github.com/apache/cordova-plugin-camera/pull/314
### Platforms affected
IOS - Ipad only
### What does this PR do?
Allow the user to set the popover Width and Height on Ipads
### What testing has been done on this change?
Modified the automated test cases to accommodate for the change.
Tested the plugin on the Ipad with different popover height and width as
well as not specifying any.
### Checklist
- [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Making CameraPopover for imagePicker bigger on Ipad
> ---
>
> Key: CB-13865
> URL: https://issues.apache.org/jira/browse/CB-13865
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-camera
>Reporter: Ams
>Priority: Major
> Fix For: Master
>
>
> The popover for imagePicker from gallery is way too small and people complain
> about not being able to see images before selecting them.
>
> The fix is simple:
>
> Adding this line to willShowViewController method will set it to 960 by 960
> or as big as the screen widht/height
> [viewController setPreferredContentSize:CGSizeMake(960,960)];
> It should be added right in the if statement:
> if([navigationController isKindOfClass:[UIImagePickerController class]]){
>
> HOW CAN I COMMIT THIS CHANGE?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13926) Remove old platforms and plugins from cordova docs
Steve Gill created CB-13926: --- Summary: Remove old platforms and plugins from cordova docs Key: CB-13926 URL: https://issues.apache.org/jira/browse/CB-13926 Project: Apache Cordova Issue Type: Task Components: cordova-docs Reporter: Steve Gill Assignee: Steve Gill -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379496#comment-16379496 ] ASF GitHub Bot commented on CB-13924: - stevengill commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369067960 I'm trying to remove the fields from https://github.com/apache/cordova-docs/blob/master/www/_data/fetched-files.yml. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379494#comment-16379494
]
ASF GitHub Bot commented on CB-13925:
-
dblotsky commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369067752
@janpio this change will not retroactively download files for any languages
or versions other than `en/dev`. Is that what you mean?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379488#comment-16379488 ] ASF GitHub Bot commented on CB-13924: - stevengill commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369066927 @janpio I agree we should remove the deprecated platforms and plugins. I'm just struggling figuring out where the removal should happen. The file you commented on is generated. So I don't think removing it from this file is the way to go. It would be better if we removed it from the generation step This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379490#comment-16379490 ] ASF GitHub Bot commented on CB-13924: - stevengill commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369067036 I'm also not sure how removing those fields will affect past versions of the docs. Maybe @dblotsky can chime in This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13382) Cordova iOS - Method to correctly destroy CDVViewControllers webView object
[
https://issues.apache.org/jira/browse/CB-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379459#comment-16379459
]
ASF GitHub Bot commented on CB-13382:
-
codecov-io commented on issue #359: CB-13382 dealloc the webViewEngine
URL: https://github.com/apache/cordova-ios/pull/359#issuecomment-369060697
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/359?src=pr=h1)
Report
> Merging
[#359](https://codecov.io/gh/apache/cordova-ios/pull/359?src=pr=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/28e7ac1474163c8a43e6adf5474da6298a4e0afa?src=pr=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/359?src=pr=tree)
```diff
@@ Coverage Diff @@
## master #359 +/- ##
===
Coverage 63.99% 63.99%
===
Files 14 14
Lines1697 1697
Branches 286 286
===
Hits 1086 1086
Misses611 611
```
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/359?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/359?src=pr=footer).
Last update
[28e7ac1...9307034](https://codecov.io/gh/apache/cordova-ios/pull/359?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova iOS - Method to correctly destroy CDVViewControllers webView object
> ---
>
> Key: CB-13382
> URL: https://issues.apache.org/jira/browse/CB-13382
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Nick Deakin
>Assignee: Suraj Pindoria
>Priority: Minor
>
> We have an app where we are using multi CDVViewController instances where a
> user can switch between hybrid apps within the native app.
> The issue that as been lingering for a couple of years is that even though a
> CDVViewController instance can be set to nil, the webview contained within
> still remains in memory. This can be observed when using the safari debugger.
> This is particularly troublesome when the webview is 'closed', then the
> content files in the webview are updated, and finally the webview is
> recreated, showing the old content. Performing a cmd-r in safari debugger
> refreshes the view and shows the updated content.
> We can also do this a [UIWebView reload], but it is not possible if the app
> changes it's URL to a none physical path, e.g.
> file:///x/myApp/www/index.html becomes file:///x/myApp/www/home, then
> we get a page load error.
> I've been able to get the webview completely removed by doing the following:
> add the following method to CDVViewController:
> {code:java}
> -(void)destroyWebView {
> self.webViewEngine = nil;
> }
> {code}
> then in my view controllers destroy method:
> {code:java}
> [self.webViewEngine loadHTMLString:@"about:blank" baseURL:nil];
> [self.pluginObjects removeAllObjects];
> [self.webView removeFromSuperview];
> [self destroyWebView];
> {code}
> Setting webViewEngine to nil is an unavoidable step to completely destroying
> the webview, but it is readonly.
> Therefore, i would really appreciate this destroyWebView method, or a similar
> cleanup method being added.
> Android has a method to clean up which is CordovaWebViewImpl.handleDestroy().
> This destroys all the plugins, sets the URL to 'about:blank' and then
> executes engine.destroy()
> Many thanks!
> Nick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13382) Cordova iOS - Method to correctly destroy CDVViewControllers webView object
[
https://issues.apache.org/jira/browse/CB-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379438#comment-16379438
]
ASF GitHub Bot commented on CB-13382:
-
surajpindoria opened a new pull request #359: CB-13382 dealloc the webViewEngine
URL: https://github.com/apache/cordova-ios/pull/359
### Platforms affected
iOS
### What does this PR do?
Adds an additional clean up step to dealloc
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova iOS - Method to correctly destroy CDVViewControllers webView object
> ---
>
> Key: CB-13382
> URL: https://issues.apache.org/jira/browse/CB-13382
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Nick Deakin
>Assignee: Suraj Pindoria
>Priority: Minor
>
> We have an app where we are using multi CDVViewController instances where a
> user can switch between hybrid apps within the native app.
> The issue that as been lingering for a couple of years is that even though a
> CDVViewController instance can be set to nil, the webview contained within
> still remains in memory. This can be observed when using the safari debugger.
> This is particularly troublesome when the webview is 'closed', then the
> content files in the webview are updated, and finally the webview is
> recreated, showing the old content. Performing a cmd-r in safari debugger
> refreshes the view and shows the updated content.
> We can also do this a [UIWebView reload], but it is not possible if the app
> changes it's URL to a none physical path, e.g.
> file:///x/myApp/www/index.html becomes file:///x/myApp/www/home, then
> we get a page load error.
> I've been able to get the webview completely removed by doing the following:
> add the following method to CDVViewController:
> {code:java}
> -(void)destroyWebView {
> self.webViewEngine = nil;
> }
> {code}
> then in my view controllers destroy method:
> {code:java}
> [self.webViewEngine loadHTMLString:@"about:blank" baseURL:nil];
> [self.pluginObjects removeAllObjects];
> [self.webView removeFromSuperview];
> [self destroyWebView];
> {code}
> Setting webViewEngine to nil is an unavoidable step to completely destroying
> the webview, but it is readonly.
> Therefore, i would really appreciate this destroyWebView method, or a similar
> cleanup method being added.
> Android has a method to clean up which is CordovaWebViewImpl.handleDestroy().
> This destroys all the plugins, sets the URL to 'about:blank' and then
> executes engine.destroy()
> Many thanks!
> Nick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13382) Cordova iOS - Method to correctly destroy CDVViewControllers webView object
[
https://issues.apache.org/jira/browse/CB-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379429#comment-16379429
]
ASF GitHub Bot commented on CB-13382:
-
surajpindoria closed pull request #342: CB-13382: (ios) Added destroyWebView
method for CDVViewController
URL: https://github.com/apache/cordova-ios/pull/342
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova iOS - Method to correctly destroy CDVViewControllers webView object
> ---
>
> Key: CB-13382
> URL: https://issues.apache.org/jira/browse/CB-13382
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Nick Deakin
>Assignee: Suraj Pindoria
>Priority: Minor
>
> We have an app where we are using multi CDVViewController instances where a
> user can switch between hybrid apps within the native app.
> The issue that as been lingering for a couple of years is that even though a
> CDVViewController instance can be set to nil, the webview contained within
> still remains in memory. This can be observed when using the safari debugger.
> This is particularly troublesome when the webview is 'closed', then the
> content files in the webview are updated, and finally the webview is
> recreated, showing the old content. Performing a cmd-r in safari debugger
> refreshes the view and shows the updated content.
> We can also do this a [UIWebView reload], but it is not possible if the app
> changes it's URL to a none physical path, e.g.
> file:///x/myApp/www/index.html becomes file:///x/myApp/www/home, then
> we get a page load error.
> I've been able to get the webview completely removed by doing the following:
> add the following method to CDVViewController:
> {code:java}
> -(void)destroyWebView {
> self.webViewEngine = nil;
> }
> {code}
> then in my view controllers destroy method:
> {code:java}
> [self.webViewEngine loadHTMLString:@"about:blank" baseURL:nil];
> [self.pluginObjects removeAllObjects];
> [self.webView removeFromSuperview];
> [self destroyWebView];
> {code}
> Setting webViewEngine to nil is an unavoidable step to completely destroying
> the webview, but it is readonly.
> Therefore, i would really appreciate this destroyWebView method, or a similar
> cleanup method being added.
> Android has a method to clean up which is CordovaWebViewImpl.handleDestroy().
> This destroys all the plugins, sets the URL to 'about:blank' and then
> executes engine.destroy()
> Many thanks!
> Nick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379401#comment-16379401
]
ASF subversion and git services commented on CB-13925:
--
Commit 6451c3d5041ebffac5ab73ae46af697aa2393b82 in cordova-docs's branch
refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=6451c3d ]
Merge pull request #793 from dblotsky/CB-13925
[CB-13925] Making file fetch happen on every build.
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379399#comment-16379399
]
ASF subversion and git services commented on CB-13925:
--
Commit 5e2e45996f16f6c3d1006e821738eff2f6df0270 in cordova-docs's branch
refs/heads/master from [~dblotsky]
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=5e2e459 ]
CB-13925: (docs) Adding --nofetch option to Gulp build, and making Gulp always
fetch files on build. Improving error message in augment_toc.js a bit.
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379400#comment-16379400
]
ASF subversion and git services commented on CB-13925:
--
Commit 6451c3d5041ebffac5ab73ae46af697aa2393b82 in cordova-docs's branch
refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=6451c3d ]
Merge pull request #793 from dblotsky/CB-13925
[CB-13925] Making file fetch happen on every build.
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379398#comment-16379398
]
ASF GitHub Bot commented on CB-13925:
-
stevengill closed pull request #793: [CB-13925] Making file fetch happen on
every build.
URL: https://github.com/apache/cordova-docs/pull/793
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/gulpfile.js b/gulpfile.js
index 2f0dbf6a7..f6dd2d5e5 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -313,13 +313,16 @@ gulp.task("regen", ["jekyll"], function () {
});
gulp.task("fetch", function (done) {
-if (!fs.existsSync(FETCH_DIR)) {
-exec("node", [bin("fetch_docs.js"), "--config", FETCH_CONFIG,
'--docsRoot', DOCS_DIR], done);
-} else {
+
+// skip fetching if --nofetch was passed
+if (gutil.env.nofetch) {
gutil.log(gutil.colors.yellow(
-"Skipping fetching external docs. Run 'gulp clean' first to
initiate another fetch."));
+"Skipping fetching external docs."));
done();
+return;
}
+
+exec("node", [bin("fetch_docs.js"), "--config", FETCH_CONFIG,
'--docsRoot', DOCS_DIR], done);
});
gulp.task("reload", function () {
diff --git a/package.json b/package.json
index 5079f1ec6..33cdbee30 100644
--- a/package.json
+++ b/package.json
@@ -22,6 +22,7 @@
"baconjs": "^0.7.70",
"browser-sync": "^2.8.0",
"browserify": "^10.2.4",
+"chalk": "^2.3.1",
"cheerio": "^0.17.0",
"classnames": "^2.1.2",
"envify": "^3.4.0",
diff --git a/tools/bin/augment_toc.js b/tools/bin/augment_toc.js
index 7b12d51fd..b29f19458 100644
--- a/tools/bin/augment_toc.js
+++ b/tools/bin/augment_toc.js
@@ -22,6 +22,7 @@ var path = require('path');
var yaml = require('js-yaml');
var optimist = require('optimist');
+var chalk = require('chalk');
var util = require('./util');
@@ -46,7 +47,7 @@ function augmentEntry (originalEntry, prefix) {
// skip entries that don't point to a valid file
if (!fs.existsSync(filePath)) {
-console.warn('WARNING! Possible 404 in ToC: "' + filePath + '"');
+console.warn(chalk.red('WARNING! Possible 404 in ToC: "' + filePath +
'"; create the file to fix'));
return originalEntry;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379284#comment-16379284
]
ASF GitHub Bot commented on CB-13925:
-
janpio commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369029844
Will this only affect `dev` when run in CI?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379281#comment-16379281 ] ASF GitHub Bot commented on CB-13924: - dblotsky commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369028822 @stevengill then that fetching issue might still be ok, if Travis does a clean build every time. However even for local development, I've made a fix so that you don't have to remember to keep doing this: https://github.com/apache/cordova-docs/pull/793. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379279#comment-16379279 ] ASF GitHub Bot commented on CB-13924: - stevengill commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369028352 @dblotsky i was planning on letting travis do the deploy This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379275#comment-16379275
]
ASF GitHub Bot commented on CB-13925:
-
dblotsky opened a new pull request #793: [CB-13925] Making file fetch happen on
every build.
URL: https://github.com/apache/cordova-docs/pull/793
Adding --nofetch option to Gulp build, and making Gulp always fetch files on
build. Improving error message in augment_toc.js a bit.
### Platforms affected
None. It's a docs change.
### What does this PR do?
Fixes CB-13925.
### What testing has been done on this change?
Built the docs site locally.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
Dmitry Blotsky created CB-13925:
---
Summary: Files in www/docs/en/dev/reference are not fetched on
every build.
Key: CB-13925
URL: https://issues.apache.org/jira/browse/CB-13925
Project: Apache Cordova
Issue Type: Bug
Components: cordova-docs
Reporter: Dmitry Blotsky
Some files in the docs are downloaded from external sources, into
{{www/docs/en/dev/reference}}. The files and their sources are defined in
{{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
fetch}} task, which runs on every build.
Expected behaviour: the files are fetched every time the command runs.
Actual behaviour: the files are only fetched if the
{{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13127) Fix/Update broken build badges in documentation (plugin docs) to reflect new platforms/versions from actual repo readme
[ https://issues.apache.org/jira/browse/CB-13127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13127: Summary: Fix/Update broken build badges in documentation (plugin docs) to reflect new platforms/versions from actual repo readme (was: Fix/Update broken build badges on cordova-docs (plugin docs) to reflect new platforms/versions from actual repo readme) > Fix/Update broken build badges in documentation (plugin docs) to reflect new > platforms/versions from actual repo readme > --- > > Key: CB-13127 > URL: https://issues.apache.org/jira/browse/CB-13127 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Filip Maj >Priority: Major > Labels: backlog > > See the top of e.g. > https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-camera/index.html > We now test on iOS 9.3 and 10, and Android 4.4, 5.1, 6.0 and 7.0, as well as > desktop browsers - let's make that visible on the docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379234#comment-16379234 ] ASF GitHub Bot commented on CB-13924: - dblotsky commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171053326 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html +- url: guide/platforms/ios/index.html +- url: guide/platforms/osx/index.html +- url: guide/platforms/ubuntu/index.html +- url: guide/platforms/win8/index.html Review comment: @janpio we can, but make sure to redirect in `redirects.yml` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379235#comment-16379235 ] ASF GitHub Bot commented on CB-13924: - janpio commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171053441 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html +- url: guide/platforms/ios/index.html +- url: guide/platforms/osx/index.html +- url: guide/platforms/ubuntu/index.html +- url: guide/platforms/win8/index.html +- url: guide/platforms/wp8/home.html +- url: platform_plugin_versioning_ref/index.html +- url: config_ref/images.html +- url: cordova/storage/storage.html +- url: guide/appdev/privacy/index.html +- url: guide/appdev/security/index.html +- url: guide/appdev/whitelist/index.html +- +name: Create plugins +children: +- url: guide/hybrid/plugins/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/plugin.html +- url: guide/platforms/blackberry10/plugin.html +- url: guide/platforms/ios/plugin.html +- url: guide/platforms/win8/plugin.html +- url: guide/platforms/wp8/plugin.html +- url: plugin_ref/plugman.html +- +name: Advanced Topics +children: +- url: guide/hybrid/webviews/index.html +- url: guide/next/index.html +- +name: Reference +children: +- url: config_ref/index.html +- url: cordova/events/events.html +- url: reference/cordova-cli/index.html +- url: guide/appdev/hooks/index.html +- url: plugin_ref/spec.html +- +name: Plugin APIs +children: Review comment: we should probably remove the deprecated plugins here, should we? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379233#comment-16379233 ] ASF GitHub Bot commented on CB-13924: - dblotsky commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171053240 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html Review comment: If you deprecate it, make sure to add it to `redirects.yml`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379231#comment-16379231 ] ASF GitHub Bot commented on CB-13924: - janpio commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171053167 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html +- url: guide/platforms/ios/index.html +- url: guide/platforms/osx/index.html +- url: guide/platforms/ubuntu/index.html +- url: guide/platforms/win8/index.html +- url: guide/platforms/wp8/home.html +- url: platform_plugin_versioning_ref/index.html +- url: config_ref/images.html +- url: cordova/storage/storage.html +- url: guide/appdev/privacy/index.html +- url: guide/appdev/security/index.html +- url: guide/appdev/whitelist/index.html +- +name: Create plugins +children: +- url: guide/hybrid/plugins/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/plugin.html +- url: guide/platforms/blackberry10/plugin.html +- url: guide/platforms/ios/plugin.html +- url: guide/platforms/win8/plugin.html +- url: guide/platforms/wp8/plugin.html Review comment: see above (deprecated platform) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379230#comment-16379230 ] ASF GitHub Bot commented on CB-13924: - janpio commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171053129 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html +- url: guide/platforms/ios/index.html +- url: guide/platforms/osx/index.html +- url: guide/platforms/ubuntu/index.html +- url: guide/platforms/win8/index.html +- url: guide/platforms/wp8/home.html +- url: platform_plugin_versioning_ref/index.html +- url: config_ref/images.html +- url: cordova/storage/storage.html +- url: guide/appdev/privacy/index.html +- url: guide/appdev/security/index.html +- url: guide/appdev/whitelist/index.html +- +name: Create plugins +children: +- url: guide/hybrid/plugins/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/plugin.html +- url: guide/platforms/blackberry10/plugin.html Review comment: see above (deprecated platform) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379232#comment-16379232 ] ASF GitHub Bot commented on CB-13924: - janpio commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171053226 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html +- url: guide/platforms/ios/index.html +- url: guide/platforms/osx/index.html +- url: guide/platforms/ubuntu/index.html +- url: guide/platforms/win8/index.html +- url: guide/platforms/wp8/home.html +- url: platform_plugin_versioning_ref/index.html +- url: config_ref/images.html +- url: cordova/storage/storage.html +- url: guide/appdev/privacy/index.html +- url: guide/appdev/security/index.html +- url: guide/appdev/whitelist/index.html +- +name: Create plugins +children: +- url: guide/hybrid/plugins/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/plugin.html +- url: guide/platforms/blackberry10/plugin.html +- url: guide/platforms/ios/plugin.html +- url: guide/platforms/win8/plugin.html Review comment: see above (rename to `windows`) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379229#comment-16379229 ] ASF GitHub Bot commented on CB-13924: - janpio commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171053079 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html +- url: guide/platforms/ios/index.html +- url: guide/platforms/osx/index.html +- url: guide/platforms/ubuntu/index.html +- url: guide/platforms/win8/index.html Review comment: can we change this URL to `windows` instead of `win8` somehow? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379227#comment-16379227 ] ASF GitHub Bot commented on CB-13924: - janpio commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171052998 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html +- url: guide/platforms/ios/index.html +- url: guide/platforms/osx/index.html +- url: guide/platforms/ubuntu/index.html Review comment: see above (deprecated platform) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379226#comment-16379226 ] ASF GitHub Bot commented on CB-13924: - janpio commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171052974 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html +- url: guide/platforms/ios/index.html +- url: guide/platforms/osx/index.html +- url: guide/platforms/ubuntu/index.html +- url: guide/platforms/win8/index.html +- url: guide/platforms/wp8/home.html Review comment: see above (deprecated platform) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379225#comment-16379225 ] ASF GitHub Bot commented on CB-13924: - janpio commented on a change in pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#discussion_r171052900 ## File path: www/_data/toc/en_8-x-src.yml ## @@ -0,0 +1,76 @@ +- +name: Introduction +children: +- url: guide/overview/index.html +- +name: Create apps +children: +- url: guide/cli/index.html +- url: guide/cli/template.html +- url: guide/support/index.html +- +name: Develop for platforms +children: +- url: guide/platforms/android/index.html +- url: guide/platforms/blackberry10/home.html Review comment: we should probably remove the deprecated platforms here, should we? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13320) Remove outdated /doc/README/ folder
[ https://issues.apache.org/jira/browse/CB-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-13320. - Resolution: Fixed Now removed > Remove outdated /doc/README/ folder > --- > > Key: CB-13320 > URL: https://issues.apache.org/jira/browse/CB-13320 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > At https://github.com/apache/cordova-docs/tree/master/doc/README you find 9 > very outdated translations of > https://github.com/apache/cordova-docs/blob/master/README.md > Are we sure these should be translated at all? > If not, maybe this whole folder should be removed? > (What are the follow up changes needed for this, Crowdin etc?) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13320) Remove outdated /doc/README/ folder
[ https://issues.apache.org/jira/browse/CB-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379219#comment-16379219 ] ASF GitHub Bot commented on CB-13320: - janpio closed pull request #792: CB-13320 remove outdated doc/README folder URL: https://github.com/apache/cordova-docs/pull/792 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove outdated /doc/README/ folder > --- > > Key: CB-13320 > URL: https://issues.apache.org/jira/browse/CB-13320 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > At https://github.com/apache/cordova-docs/tree/master/doc/README you find 9 > very outdated translations of > https://github.com/apache/cordova-docs/blob/master/README.md > Are we sure these should be translated at all? > If not, maybe this whole folder should be removed? > (What are the follow up changes needed for this, Crowdin etc?) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13320) Remove outdated /doc/README/ folder
[ https://issues.apache.org/jira/browse/CB-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379220#comment-16379220 ] ASF subversion and git services commented on CB-13320: -- Commit 01ed8a4fbcba55758bf527b8f67dfc14d2ff8063 in cordova-docs's branch refs/heads/master from Jan Piotrowski [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=01ed8a4 ] CB-13320 remove outdated doc/README folder (#792) > Remove outdated /doc/README/ folder > --- > > Key: CB-13320 > URL: https://issues.apache.org/jira/browse/CB-13320 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > At https://github.com/apache/cordova-docs/tree/master/doc/README you find 9 > very outdated translations of > https://github.com/apache/cordova-docs/blob/master/README.md > Are we sure these should be translated at all? > If not, maybe this whole folder should be removed? > (What are the follow up changes needed for this, Crowdin etc?) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13335) Document autogenerated files better
[
https://issues.apache.org/jira/browse/CB-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379216#comment-16379216
]
Jan Piotrowski (Sujan) commented on CB-13335:
-
Notes now moved to
https://github.com/apache/cordova-docs/blob/master/doc/updating-docs.md#updating-docs
> Document autogenerated files better
> ---
>
> Key: CB-13335
> URL: https://issues.apache.org/jira/browse/CB-13335
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-docs
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> Main README says the following:
> {quote}Note: many changes to the overall documentation come from other repos
> and are simply pulled together by a build. tools/bin/fetch_docs.js has more
> details and www/_data/fetched-files.yml contains an informative list of
> src/dest pairs. Most auto-generated files have a comment tag at the top of
> the file to indicate that they come from elsewhere.{quote}
> This should be documented better with the other information about the docs
> instead of just referring to a file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379209#comment-16379209 ] ASF GitHub Bot commented on CB-13924: - dblotsky commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369008560 @stevengill do you plan to deploy also? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-13543. - Resolution: Fixed This is in production and working right now. > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So >Priority: Major > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13336) Move /doc/README/en/README.md content to better places, remove file
[ https://issues.apache.org/jira/browse/CB-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-13336. - Resolution: Fixed > Move /doc/README/en/README.md content to better places, remove file > --- > > Key: CB-13336 > URL: https://issues.apache.org/jira/browse/CB-13336 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > As I figured out in https://issues.apache.org/jira/browse/CB-13320 the file > is mostly outdated or duplicate. > The still relevant parts should be moved to better places (main readme, files > in /doc) and the file and its translations then be removed via > https://issues.apache.org/jira/browse/CB-13320. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379205#comment-16379205 ] ASF GitHub Bot commented on CB-13924: - stevengill commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369007831 @dblotsky no, but i shall This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379204#comment-16379204 ] ASF GitHub Bot commented on CB-13924: - dblotsky commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369007688 @stevengill did you do a `gulp clean; gulp fetch` to make sure you have the latest version of the plugin docs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13320) Remove outdated /doc/README/ folder
[ https://issues.apache.org/jira/browse/CB-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379198#comment-16379198 ] ASF GitHub Bot commented on CB-13320: - janpio opened a new pull request #792: CB-13320 remove outdated doc/README folder URL: https://github.com/apache/cordova-docs/pull/792 ### What does this PR do? Removed the doc/README folder that contained mostly outdated instructions. As everything relevant is now moved over to other places, it can be removed. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove outdated /doc/README/ folder > --- > > Key: CB-13320 > URL: https://issues.apache.org/jira/browse/CB-13320 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > At https://github.com/apache/cordova-docs/tree/master/doc/README you find 9 > very outdated translations of > https://github.com/apache/cordova-docs/blob/master/README.md > Are we sure these should be translated at all? > If not, maybe this whole folder should be removed? > (What are the follow up changes needed for this, Crowdin etc?) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379195#comment-16379195 ] ASF GitHub Bot commented on CB-13924: - stevengill opened a new pull request #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13896) Cordova-Windows Platform Release 6.0.0, February 19/20, 2018
[ https://issues.apache.org/jira/browse/CB-13896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-13896. - Resolution: Fixed > Cordova-Windows Platform Release 6.0.0, February 19/20, 2018 > > > Key: CB-13896 > URL: https://issues.apache.org/jira/browse/CB-13896 > Project: Apache Cordova > Issue Type: Task > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13924) Create cordova 8 for docs
Steve Gill created CB-13924: --- Summary: Create cordova 8 for docs Key: CB-13924 URL: https://issues.apache.org/jira/browse/CB-13924 Project: Apache Cordova Issue Type: Task Components: cordova-docs Reporter: Steve Gill Assignee: Steve Gill Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13797) Fetch failing to install plugin dependencies
[
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Gill reassigned CB-13797:
---
Assignee: Steve Gill
> Fetch failing to install plugin dependencies
>
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>
>Reporter: Darryl Pogue
>Assignee: Steve Gill
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
> in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100]
> what was just installed. Rather than finding "cordova-plugin-device", it
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-code-push" in config.xml. Adding it to the
> project
> No scripts found for hook "before_plugin_add".
> Calling plugman.fetch on plugin "cordova-plugin-code-push@^1.11.2"
> Running command: npm install cordova-plugin-code-push@^1.11.2 --production
> --no-save
> Command finished with error code 0: npm
> install,cordova-plugin-code-push@^1.11.2,--production,--no-save
> Copying plugin "/PROJECT/node_modules/cordova-plugin-code-push" =>
> "/PROJECT/plugins/cordova-plugin-code-push"
> Calling plugman.install on plugin "/PROJECT/plugins/cordova-plugin-code-push"
> for platform "android
> Installing "cordova-plugin-code-push" for android
> Running command: /PROJECT/platforms/android/cordova/version
> Command finished with error code 0:
> /PROJECT/platforms/android/cordova/version
> Dependencies detected, iterating through them...
> Requesting plugin "code-push@2.0.4".
> Plugin dependency "code-push" not fetched, retrieving then installing.
> Running command: npm install code-push@2.0.4 --production --no-save
> Command finished with error code 0: npm
> install,code-push@2.0.4,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" =>
> "/PROJECT/plugins/code-push"
> Installing "code-push" for android
> Finding scripts for "before_plugin_install" hook from plugin code-push on
> android platform only.
> No scripts found for hook "before_plugin_install".
> Install start for "code-push" on android.
> Beginning processing of action stack for android project...
> Action stack processing complete.
> Install complete for code-push on android.
> Finding scripts for "after_plugin_install" hook from plugin code-push on
> android platform only.
> No scripts found for hook "after_plugin_install".
> Requesting plugin "cordova-plugin-dialogs@>=1.1.1".
> Plugin dependency "cordova-plugin-dialogs" not fetched, retrieving then
> installing.
> Running command: npm install cordova-plugin-dialogs@>=1.1.1 --production
> --no-save
> Command finished with error code 0: npm
> install,cordova-plugin-dialogs@>=1.1.1,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" =>
> "/PROJECT/plugins/code-push"
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have
> ID "cordova-plugin-dialogs" but got "code-push".
> at checkID (/PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:215:15)
> at /PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:199:9
> at _fulfilled (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at /PROJECT/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> Failed to restore plugin "cordova-plugin-code-push" from config.xml. You
> might need to try adding it again. Error: Error: Expected plugin to have ID
> "cordova-plugin-dialogs" but got "code-push".{noformat}
--
This
[jira] [Resolved] (CB-12905) LaunchBrowser promise in linux, not resolved until the browser process terminates.
[ https://issues.apache.org/jira/browse/CB-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-12905. - Resolution: Fixed > LaunchBrowser promise in linux, not resolved until the browser process > terminates. > -- > > Key: CB-12905 > URL: https://issues.apache.org/jira/browse/CB-12905 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-serve >Affects Versions: 6.5.0, 7.0.1 > Environment: OS: Ubuntu 16.04.2 LTS > cordova: 6.5.0 > simulate: 0.3.12 > node: v7.10.0 > npm: 4.6.1 >Reporter: Pavel Yakovlev >Assignee: Steve Gill >Priority: Minor > > LaunchBrowser promise in linux, not resolved until the browser process > terminates. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12110) cordova-plugin-compat@1.1.0 release, Nov 2, 2016
[ https://issues.apache.org/jira/browse/CB-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-12110. - Resolution: Fixed > cordova-plugin-compat@1.1.0 release, Nov 2, 2016 > > > Key: CB-12110 > URL: https://issues.apache.org/jira/browse/CB-12110 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-compat >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > Fix For: cordova-plugin-compat@1.1.0 > > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md; -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13542) Plugins Release, Mon Nov 06 2017
[ https://issues.apache.org/jira/browse/CB-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-13542. - Resolution: Fixed > Plugins Release, Mon Nov 06 2017 > > > Key: CB-13542 > URL: https://issues.apache.org/jira/browse/CB-13542 > Project: Apache Cordova > Issue Type: Task > Components: AllPlugins >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md > Generated automatically using cordova-coho. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13879) Updated Android Gradle plugin to 3.0.1
[ https://issues.apache.org/jira/browse/CB-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-13879. - Resolution: Fixed > Updated Android Gradle plugin to 3.0.1 > -- > > Key: CB-13879 > URL: https://issues.apache.org/jira/browse/CB-13879 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > The current android gradle plugin is set to 3.0.0. Some plugins are seeing > issues with this version and the latest version of playservices. Going to > update this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13912) Cordova-Android Platform Release Feb 20, 2018
[ https://issues.apache.org/jira/browse/CB-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-13912. - Resolution: Fixed > Cordova-Android Platform Release Feb 20, 2018 > - > > Key: CB-13912 > URL: https://issues.apache.org/jira/browse/CB-13912 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Thinking version 7.1.0. > Changes: > * :arrow_up: Bump gradle tools dependency to 3.0.1 for project template > * CB-13879 updated gradle plugin > * Update android_sdk.js > * CB-13831: (android) Update `android-versions` to 1.3.0 to support SDK 27. > * CB-13800: (android) Drop pre-KitKat specific code > * CB-13724: Updated the Android Tooling required for the latest version on > both the test project, and the template > * CB-13724: Bump Target SDK to API 27 > * CB-13646: End of an era. Using the deprecated NDK by default breaks the > build. Crosswalk users need to specify the Gradle parameters to keep it > working. > * CB-12218: (android) Fix consistency of null result message > * CB-13571: (android) Prevent crash with unrecognized android version > * CB-13721 (Android): fix build apps that use cdvHelpers.getConfigPreference > * CB-12914: Test needs SDK bumps > * Forgot to bump AndroidManifest.xml for play store reasons > * CB-13621: eslint error > * CB-13622: Testing commit > * CB-13621: Wrote similar warning to CB-12948 on iOS. We no longer support > update. > * Update JS snapshot to version 7.1.0-dev (via coho) > * Set VERSION to 7.1.0-dev (via coho) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13896) Cordova-Windows Platform Release 6.0.0, February 19/20, 2018
[ https://issues.apache.org/jira/browse/CB-13896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379138#comment-16379138 ] Jan Piotrowski (Sujan) commented on CB-13896: - Now a blog post at https://cordova.apache.org/announcements/2018/02/27/cordova-windows-6.0.0.html > Cordova-Windows Platform Release 6.0.0, February 19/20, 2018 > > > Key: CB-13896 > URL: https://issues.apache.org/jira/browse/CB-13896 > Project: Apache Cordova > Issue Type: Task > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13275) Improve documentation on cordova-docs
[ https://issues.apache.org/jira/browse/CB-13275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13275: --- Assignee: (was: Jan Piotrowski (Sujan)) > Improve documentation on cordova-docs > - > > Key: CB-13275 > URL: https://issues.apache.org/jira/browse/CB-13275 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Minor > > The documentation (README, other .md files) on `cordova-docs` could use some > improvement. > See the subtasks for actual problems and things to be fixed, changed or > improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13151) cordova-ios documentation could use a "supported iOS versions" table like Android has one
[ https://issues.apache.org/jira/browse/CB-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13151: --- Assignee: (was: Jan Piotrowski (Sujan)) > cordova-ios documentation could use a "supported iOS versions" table like > Android has one > - > > Key: CB-13151 > URL: https://issues.apache.org/jira/browse/CB-13151 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs, cordova-ios >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > As cordova-ios support is also changing with newer versions (see > https://issues.apache.org/jira/browse/CB-13150) it would make sense to add a > "supported iOS versions" table to the docs here: > https://cordova.apache.org/docs/en/7.x/guide/platforms/ios/index.html#requirements-and-support > Template for that could be the Android table here: > https://cordova.apache.org/docs/en/7.x/guide/platforms/android/index.html#requirements-and-support -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13339) Improve "Introduction" in README
[
https://issues.apache.org/jira/browse/CB-13339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379118#comment-16379118
]
ASF subversion and git services commented on CB-13339:
--
Commit 4fffa8d9114500f3bc7a6cbc5011aab5b0c9332b in cordova-docs's branch
refs/heads/master from Jan Piotrowski
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=4fffa8d ]
CB-13339 Improve README
> Improve "Introduction" in README
>
>
> Key: CB-13339
> URL: https://issues.apache.org/jira/browse/CB-13339
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-docs
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> Current content:
> {quote}This repository contains the source code for the Cordova website. This
> covers cordova.io (= cordova.apache.org) and its subdomains docs.cordova.io
> (= cordova.apache.org/docs) and plugins.cordova.io (=
> cordova.apache.org/plugins).{quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13339) Improve "Introduction" in README
[
https://issues.apache.org/jira/browse/CB-13339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) resolved CB-13339.
-
Resolution: Fixed
> Improve "Introduction" in README
>
>
> Key: CB-13339
> URL: https://issues.apache.org/jira/browse/CB-13339
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-docs
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> Current content:
> {quote}This repository contains the source code for the Cordova website. This
> covers cordova.io (= cordova.apache.org) and its subdomains docs.cordova.io
> (= cordova.apache.org/docs) and plugins.cordova.io (=
> cordova.apache.org/plugins).{quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13459) Rework headline hierarchy in /doc documents
[ https://issues.apache.org/jira/browse/CB-13459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13459: --- Assignee: (was: Jan Piotrowski (Sujan)) > Rework headline hierarchy in /doc documents > --- > > Key: CB-13459 > URL: https://issues.apache.org/jira/browse/CB-13459 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Minor > > Now that the files are merged, headlines hierarchy can be reworked to start > with h1 for all documents. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13618) cordova compile command fails but cordova build works fine
[
https://issues.apache.org/jira/browse/CB-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) reassigned CB-13618:
---
Assignee: (was: Jan Piotrowski (Sujan))
> cordova compile command fails but cordova build works fine
> --
>
> Key: CB-13618
> URL: https://issues.apache.org/jira/browse/CB-13618
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Environment: {code}
> $ ionic info
> cli packages: (/Users/gianfranco/.config/yarn/global/node_modules)
> @ionic/cli-utils : 1.19.0
> ionic (Ionic CLI) : 3.19.0
> global packages:
> cordova (Cordova CLI) : 7.1.0
> local packages:
> @ionic/app-scripts : 3.1.4
> Cordova Platforms : android 6.2.3 ios 4.5.4
> Ionic Framework: ionic-angular 3.9.2
> System:
> Android SDK Tools : 26.1.1
> ios-deploy: 1.9.2
> Node : v6.11.3
> npm : 5.5.1
> OS: macOS Sierra
> Xcode : Xcode 9.1 Build version 9B55
> Environment Variables:
> ANDROID_HOME : /Users/gianfranco/Library/Android/sdk
> Misc:
> backend : legacy
> {code}
>Reporter: Gianfranco Palumbo
>Priority: Minor
> Attachments: cordova-compile-CB-13618.txt
>
>
> While looking to automate the build process with fastlane and this
> [fastlane-plugin-cordova|https://github.com/bamlab/fastlane-plugin-cordova],
> this issue was discovered:
> {code}
> $ cordova prepare
> Searching for new pods
> Checking branch-cordova-sdk for pods.
> Checking cordova-plugin-camera for pods.
> Checking cordova-plugin-compat for pods.
> Checking cordova-plugin-crop for pods.
> Checking cordova-plugin-device for pods.
> Checking cordova-plugin-facebook4 for pods.
> Checking cordova-plugin-file for pods.
> Checking cordova-plugin-firebase for pods.
> Checking cordova-plugin-geolocation for pods.
> Checking cordova-plugin-globalization for pods.
> Checking cordova-plugin-googleplus for pods.
> Checking cordova-plugin-inappbrowser for pods.
> Checking cordova-plugin-ionic-webview for pods.
> Checking cordova-plugin-mixpanel for pods.
> Checking cordova-plugin-splashscreen for pods.
> Checking cordova-plugin-statusbar for pods.
> Checking cordova-plugin-whitelist for pods.
> Checking cordova-plugin-x-socialsharing for pods.
> Checking es6-promise-plugin for pods.
> Checking ionic-plugin-keyboard for pods.
> Checking config.xml for pods.
> No new pods detects
> $ cordova compile ios --release --device --packageType=app-store
> --developmentTeam=xyz --provisioningProfile=abc
>
> Touch build/device/Givebox.app.dSYM
> cd /Users/gianfranco/givebox/givebox.ui.mobile/platforms/ios
> export
> PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/Users/gianfranco/.yarn/bin:/Users/gianfranco/.rbenv/shims:/usr/local/opt/qt/bin:/Users/gianfranco/google-cloud-sdk/bin:/Users/gianfranco/.fastlane/bin:/usr/local/opt/findutils/libexec/gnubin:/usr/local/sbin:/Users/gianfranco/bin:/usr/local/opt/openssl/bin:/Users/gianfranco/.nvm/versions/node/v6.11.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/opt/ImageMagick/bin:/usr/local/MacGPG2/bin:/Users/gianfranco/.composer/vendor/bin:/Users/gianfranco/Library/Android/sdk/platform-tools:/Users/gianfranco/Library/Android/sdk/tools:/Users/gianfranco/.themekit"
> /usr/bin/touch -c
> /Users/gianfranco/givebox/givebox.ui.mobile/platforms/ios/build/device/Givebox.app.dSYM
> ** ARCHIVE SUCCEEDED **
> Error: ENOENT: no such file or directory, open
> '/Users/gianfranco/givebox/givebox.ui.mobile/platforms/ios/Givebox.xcworkspace/project.pbxproj'
> {code}
> The file {{project.pbxproj}} exists in the {{Givebox.xcodeproj}} folder not
> {{Givebox.xcworkspace}}.
> Since {{cordova compile}} should be the same as {{cordova prepare}} {{cordova
> build}}
> ([link|https://cordova.apache.org/docs/en/latest/reference/cordova-cli/#cordova-build-command])
> This works:
> {code}
> $ cordova build ios --release --device --packageType=app-store
> --developmentTeam=xyz --provisioningProfile=abc
> ...
> Touch build/device/Givebox.app.dSYM
> cd /Users/gianfranco/givebox/givebox.ui.mobile/platforms/ios
> export
>
[jira] [Assigned] (CB-13874) Windows 8.1 builds don't work with Visual Studio 2017
[ https://issues.apache.org/jira/browse/CB-13874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13874: --- Assignee: (was: Jan Piotrowski (Sujan)) > Windows 8.1 builds don't work with Visual Studio 2017 > - > > Key: CB-13874 > URL: https://issues.apache.org/jira/browse/CB-13874 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Building Windows Phone 8.1 is not possible at all because there is no > Emulator for VS2017, > building for Windows 8.1 is not possible because WinJS is missing which is > probably also part of something that is not there any more. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13336) Move /doc/README/en/README.md content to better places, remove file
[ https://issues.apache.org/jira/browse/CB-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13336: --- Assignee: (was: Jan Piotrowski (Sujan)) > Move /doc/README/en/README.md content to better places, remove file > --- > > Key: CB-13336 > URL: https://issues.apache.org/jira/browse/CB-13336 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > As I figured out in https://issues.apache.org/jira/browse/CB-13320 the file > is mostly outdated or duplicate. > The still relevant parts should be moved to better places (main readme, files > in /doc) and the file and its translations then be removed via > https://issues.apache.org/jira/browse/CB-13320. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13327) Clean up and repair documentation translations
[ https://issues.apache.org/jira/browse/CB-13327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13327: --- Assignee: (was: Jan Piotrowski (Sujan)) > Clean up and repair documentation translations > -- > > Key: CB-13327 > URL: https://issues.apache.org/jira/browse/CB-13327 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Translations of documentation seems to be all kinds of broken, outdated, > missing and strange. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13391) Add flags to language dropdown
[ https://issues.apache.org/jira/browse/CB-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13391: Component/s: Translation > Add flags to language dropdown > -- > > Key: CB-13391 > URL: https://issues.apache.org/jira/browse/CB-13391 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Adding flags to the language dropdown could greatly improve the usability of > the language dropdown. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13376) Check if all current files are mapped in Crowdin
[ https://issues.apache.org/jira/browse/CB-13376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13376: Component/s: Translation > Check if all current files are mapped in Crowdin > > > Key: CB-13376 > URL: https://issues.apache.org/jira/browse/CB-13376 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Is everything useful in > https://github.com/apache/cordova-docs/tree/master/www/docs/en/dev/ available > for translation on Crowdin? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13373) Better highlight old and outdated content/translations
[ https://issues.apache.org/jira/browse/CB-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13373: Component/s: Translation > Better highlight old and outdated content/translations > -- > > Key: CB-13373 > URL: https://issues.apache.org/jira/browse/CB-13373 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Having googled for a lot of stuff and getting old versions or wrong/outdated > translations of stuff as results I feel the "you are on and old and maybe > outdated version of this content" notice should be more prominent and simpler > to switch to "latest". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13375) Fix translations
[ https://issues.apache.org/jira/browse/CB-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13375: Component/s: Translation > Fix translations > > > Key: CB-13375 > URL: https://issues.apache.org/jira/browse/CB-13375 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Multiple issues to improve the state of translations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13334) Clean up cordova-docs branches
[ https://issues.apache.org/jira/browse/CB-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-13334. - Resolution: Fixed Assignee: Jan Piotrowski (Sujan) Delete all the outdated ones. > Clean up cordova-docs branches > -- > > Key: CB-13334 > URL: https://issues.apache.org/jira/browse/CB-13334 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > The cordova-docs repo has several branches. Are these useful? still required? > any information in them that should be salvaged? > If not, get rid of them. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13305) Docs can't build because of ES6 code usage (uglify-js error)
[
https://issues.apache.org/jira/browse/CB-13305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) resolved CB-13305.
-
Resolution: Fixed
> Docs can't build because of ES6 code usage (uglify-js error)
>
>
> Key: CB-13305
> URL: https://issues.apache.org/jira/browse/CB-13305
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Shazron Abdullah
>Assignee: Tommy-Carlos Williams
>Priority: Major
>
> Error:
> {code}
> at new JS_Parse_Error (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :1534:18)
> at js_error (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :1542:11)
> at croak (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2089:9)
> at token_error (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2097:9)
> at unexpected (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2103:9)
> at semicolon (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2123:56)
> at simple_statement (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2314:73)
> at eval (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2183:19)
> at eval (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2136:24)
> at block_ (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2429:20)
> message: '/Users/shazron/Documents/git/apache/cordova-docs/plugins.js:
> SyntaxError: Unexpected token: name (cache)',
> fileName: '/Users/shazron/Documents/git/apache/cordova-docs/plugins.js',
> lineNumber: 9393,
> stack: 'Error\nat new JS_Parse_Error (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :1534:18)\nat js_error (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :1542:11)\nat croak (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2089:9)\nat token_error (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2097:9)\nat unexpected (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2103:9)\nat semicolon (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2123:56)\nat simple_statement (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2314:73)\nat eval (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2183:19)\nat eval (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2136:24)\nat block_ (eval at
> (/Users/shazron/Documents/git/apache/cordova-docs/node_modules/gulp-uglify/node_modules/uglify-js/tools/node.js:28:1),
> :2429:20)',
> showStack: false,
> showProperties: true,
> plugin: 'gulp-uglify' }
> {code}
> Cause of the error is usage of ES6 here:
> https://github.com/apache/cordova-docs/blame/43ab873557285a06126f6e3c92ef196ac7fb9c50/www/static/plugins/searchbar.jsx#L11-L14
> Namely the {{let}} and {{arrow function}}. There may be others.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13284) Slack js on cordova-docs fails to load due to insecure response
[
https://issues.apache.org/jira/browse/CB-13284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) resolved CB-13284.
-
Resolution: Fixed
> Slack js on cordova-docs fails to load due to insecure response
> ---
>
> Key: CB-13284
> URL: https://issues.apache.org/jira/browse/CB-13284
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
> Environment: All
>Reporter: Tommy-Carlos Williams
>Priority: Major
>
> The file slackin.js is served from https://slack.cordova.io with an incorrect
> TLS certificate (*herokuapp.com)
> {code:none}
> Failed to load resource: net::ERR_INSECURE_RESPONSE
> {code}
> We cannot just serve it from http as cordova.apache.org is served from https
> and would then have the issue of being mixed.
> Is this slackin.js important? If it is, perhaps its script tag in the docs
> site could use the actual underlying herokuapp.com name instead of
> slack.cordova.io, then the TLS certificate would match.
> However, if it's not that important, it could simply be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13330) Inventory of Google listed docs pages
[ https://issues.apache.org/jira/browse/CB-13330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13330: Component/s: Translation > Inventory of Google listed docs pages > - > > Key: CB-13330 > URL: https://issues.apache.org/jira/browse/CB-13330 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > See what pages Google is listing. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13329) Document translation integration
[ https://issues.apache.org/jira/browse/CB-13329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13329: Component/s: Translation > Document translation integration > > > Key: CB-13329 > URL: https://issues.apache.org/jira/browse/CB-13329 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Translations are in the repo. Find out where they come from and which steps > were used and have to be used in the future to get them there. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13328) Inventory of current state of translations
[ https://issues.apache.org/jira/browse/CB-13328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13328: Component/s: Translation > Inventory of current state of translations > -- > > Key: CB-13328 > URL: https://issues.apache.org/jira/browse/CB-13328 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Find out what translations are there, where they come from, how many are > outdated, wrong or broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13327) Clean up and repair documentation translations
[ https://issues.apache.org/jira/browse/CB-13327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13327: Component/s: Translation > Clean up and repair documentation translations > -- > > Key: CB-13327 > URL: https://issues.apache.org/jira/browse/CB-13327 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Translations of documentation seems to be all kinds of broken, outdated, > missing and strange. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13336) Move /doc/README/en/README.md content to better places, remove file
[ https://issues.apache.org/jira/browse/CB-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13336: Component/s: Translation > Move /doc/README/en/README.md content to better places, remove file > --- > > Key: CB-13336 > URL: https://issues.apache.org/jira/browse/CB-13336 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > As I figured out in https://issues.apache.org/jira/browse/CB-13320 the file > is mostly outdated or duplicate. > The still relevant parts should be moved to better places (main readme, files > in /doc) and the file and its translations then be removed via > https://issues.apache.org/jira/browse/CB-13320. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13320) Remove outdated /doc/README/ folder
[ https://issues.apache.org/jira/browse/CB-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13320: Component/s: Translation > Remove outdated /doc/README/ folder > --- > > Key: CB-13320 > URL: https://issues.apache.org/jira/browse/CB-13320 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > At https://github.com/apache/cordova-docs/tree/master/doc/README you find 9 > very outdated translations of > https://github.com/apache/cordova-docs/blob/master/README.md > Are we sure these should be translated at all? > If not, maybe this whole folder should be removed? > (What are the follow up changes needed for this, Crowdin etc?) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13153) Crowdin: 2 unsued cordova-cli docs files, remove?
[ https://issues.apache.org/jira/browse/CB-13153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13153: Component/s: Translation > Crowdin: 2 unsued cordova-cli docs files, remove? > - > > Key: CB-13153 > URL: https://issues.apache.org/jira/browse/CB-13153 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-cli, cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > The `cordova` project on Crowdin also contains 2 `cordova-cli/docs` files: > https://crowdin.com/translate/cordova/4069/en-de > https://crowdin.com/translate/cordova/4069/en-de > Source file for these are > https://github.com/apache/cordova-cli/blob/master/doc/bash.md > https://github.com/apache/cordova-cli/blob/master/README.md > Am I correct in my research that these are actually not used and displayed > anywhere? > If the answer is yes, it would make sense to remove these files from Crowdin > to avoid unnecessary work from volunteers. Maybe it even makes sense to > remove the source files from the cordova-cli repo. > If the answer is yes, and the answer should actually be no, a new issue > should probably be created to resolve this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13161) Translated docs contain old files that were removed in EN
[ https://issues.apache.org/jira/browse/CB-13161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13161: Component/s: Translation > Translated docs contain old files that were removed in EN > - > > Key: CB-13161 > URL: https://issues.apache.org/jira/browse/CB-13161 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs, Translation >Reporter: Jan Piotrowski (Sujan) >Priority: Minor > > Interesting issue: > https://cordova.apache.org/docs/de/7.x/guide/platforms/android/tools.html > https://cordova.apache.org/docs/en/7.x/guide/platforms/android/tools.html > DE version exists, EN does not > Probably an old translation that didn't get removed while the EN source did > I guess that could be the case in all languages and also all versions... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13109) `cordova prepare` docs don't include what it mainly does
[ https://issues.apache.org/jira/browse/CB-13109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13109: --- Assignee: (was: Jan Piotrowski (Sujan)) > `cordova prepare` docs don't include what it mainly does > > > Key: CB-13109 > URL: https://issues.apache.org/jira/browse/CB-13109 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Minor > > "Synopsis" at > https://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html#cordova-prepare-command > doesn't include what `prepare` actually does: > > Copies files for specified platforms, or all platforms, > > so that the project is ready to build with each SDK. > (From `cordova help prepare` on the CLI) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11414) Blocks of code on docs are being automatically translated
[ https://issues.apache.org/jira/browse/CB-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-11414: Component/s: Translation > Blocks of code on docs are being automatically translated > - > > Key: CB-11414 > URL: https://issues.apache.org/jira/browse/CB-11414 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs, Translation >Reporter: jcesarmobile >Priority: Major > Labels: backlog > > I just saw a tweet "laughing" at the Cordova docs because the code was being > translated (automatically) and obviously made no sense. > On crowdin you can mark some parts of the docs as hidden to not be translated. > Every block of code on the docs should be marked as hidden so it's not > translated. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8324) Translated docs home page has not translated Title
[ https://issues.apache.org/jira/browse/CB-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-8324: --- Component/s: Translation > Translated docs home page has not translated Title > -- > > Key: CB-8324 > URL: https://issues.apache.org/jira/browse/CB-8324 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs, Translation >Reporter: Andrey Kurdyumov >Priority: Major > > Open > http://cordova.apache.org/docs/ru/edge/index.html > You will see Home in the top level section. Should be able to specify that > title in the config.json -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9439) Find deprecated files in CrowdIn
[ https://issues.apache.org/jira/browse/CB-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-9439: --- Component/s: Translation > Find deprecated files in CrowdIn > > > Key: CB-9439 > URL: https://issues.apache.org/jira/browse/CB-9439 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs, Translation >Reporter: Andrey Kurdyumov >Priority: Major > > Create tool which find deprecated files, or some files which don't have to be > in translations, for example other translation files. > That's should allow faster recovery after errors in CrowdIn YAML file -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9852) cordova-plugin-camera file picker does not appear in browser
[
https://issues.apache.org/jira/browse/CB-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378762#comment-16378762
]
ASF GitHub Bot commented on CB-9852:
robertarnesson commented on issue #200: CB-9852: cordova-plugin-camera file
picker does not appear in browser
URL:
https://github.com/apache/cordova-plugin-camera/pull/200#issuecomment-368914926
Yes please merge this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova-plugin-camera file picker does not appear in browser
>
>
> Key: CB-9852
> URL: https://issues.apache.org/jira/browse/CB-9852
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: 1.2.0
> Environment: Windows, Chrome/Firefox
>Reporter: Rob Caldecott
>Priority: Major
> Labels: browser, reproduced, triaged
>
> Using latest (5.3.3) Cordova and cordova-plugin-camera 1.2.0, browser support
> to select an image is not working. Each time you call
> navigator.camera.getPicture with sourceType =
> Camera.PictureSourceType.PHOTOLIBRARY a new file input is appended to the
> document, but nothing actually happens.
> Tested on Chrome 46 and Firefox 40.
> To reproduce, create a basic Cordova project. Add browser as a platform then
> add the cordova-plugin-camera plugin. Then add a button to your document
> which when clicked executes the following:
> navigator.camera.getPicture(success, error, {
> sourceType: Camera.PictureSourceType.PHOTOLIBRARY
> });
> (include a suitable success/error handler).
> Run with cordova emulate browser. When the above is executed, the following
> is inserted into your document:
>
> Successive calls will add more of these. If you actually click on one then
> the file picker will appear. But it seems that whatever simulates this click
> is not working.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7487) Writing a file doesn't show up on android MTP
[ https://issues.apache.org/jira/browse/CB-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378687#comment-16378687 ] ASF GitHub Bot commented on CB-7487: dpeacock commented on issue #81: CB-7487 [Android] Broadcast file write URL: https://github.com/apache/cordova-plugin-file/pull/81#issuecomment-368900560 @tvanesse For a move I'm not sure whether you would need to do it on both the dest and src file, you would have to try I guess or read up on the best practices. But you have the right idea of what's required. The best way to test this would be to 'Fork' the plugin from github, you'll see the icon on the main page. You can then use your favourite Git tool (something like GitKraken for example) to download the source locally and work on it. From your cordova project remove the cordova-plugin-file. You can then either add the plugin specifying your local path, or if you have pushed the changes to your Git repo you can add the plugin using your repo's URL. Each time you make a change you can remove and re-add the plugin. One other thing to note is in some older cordova versions I've had issues where sometimes removing and re-adding the plug-in wasn't working quite right. Doing a cordova platform remove android then re-adding it seemed to solve it. You shouldn't have to do this, but if you run into issues it might be worth trying. Working from Git is best, because once you're satisfied with the changes you can then make a pull request to get your fixes moved into the main plug-in. I would suggest you create a bug on the Cordova Issue tracker for this so you can reference it in your pull request https://issues.apache.org/jira/projects/CB/issues Hopefully that's enough to get you going. I know there were some good blog posts (much more detailed) about this as well that you could probably google if you get stuck. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Writing a file doesn't show up on android MTP > - > > Key: CB-7487 > URL: https://issues.apache.org/jira/browse/CB-7487 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-plugin-file >Affects Versions: 3.4.0 > Environment: Nexus 5 and Windows 7 >Reporter: David Peacock >Assignee: Ian Clelland >Priority: Major > > Using the file plug-in to write out a file works, but when you use MTP to > view the file when connected to USB on Windows the file doesn't show up. > The file shows up on the device or through adb. Rebooting the device or > using things to refresh the MTP will have the file appear. This was tested > on multiple Nexus 5 devices on multiple Windows 7 machines. > Cordova should be broadcasting ACTION_MEDIA_SCANNER_SCAN_FILE on the file to > have it appear immediately. > I will be submitting a pull request on the file plug-in for a fix I've tested > and confirmed that resolves this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7487) Writing a file doesn't show up on android MTP
[ https://issues.apache.org/jira/browse/CB-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378645#comment-16378645 ] ASF GitHub Bot commented on CB-7487: tvanesse commented on issue #81: CB-7487 [Android] Broadcast file write URL: https://github.com/apache/cordova-plugin-file/pull/81#issuecomment-368894647 @dpeacock Thanks for your quick response. Now I am not really familiar with cordova plugins development but I guess adding `broadcastNewFile(srcFs.toNativeUri(srcURL));` at the end of `copyFile` in `LocalFileSystem.java` should do the job (around line 280). As I said, I'm not sure how I should set up my environment so that my application uses my locally modified plugin. I can modify the plugin directly in my Ionic project (yes, I'm using ionic) but I don't know how to force Cordova to re-compile the plugin. Can you help me on this? Cheers. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Writing a file doesn't show up on android MTP > - > > Key: CB-7487 > URL: https://issues.apache.org/jira/browse/CB-7487 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-plugin-file >Affects Versions: 3.4.0 > Environment: Nexus 5 and Windows 7 >Reporter: David Peacock >Assignee: Ian Clelland >Priority: Major > > Using the file plug-in to write out a file works, but when you use MTP to > view the file when connected to USB on Windows the file doesn't show up. > The file shows up on the device or through adb. Rebooting the device or > using things to refresh the MTP will have the file appear. This was tested > on multiple Nexus 5 devices on multiple Windows 7 machines. > Cordova should be broadcasting ACTION_MEDIA_SCANNER_SCAN_FILE on the file to > have it appear immediately. > I will be submitting a pull request on the file plug-in for a fix I've tested > and confirmed that resolves this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7487) Writing a file doesn't show up on android MTP
[ https://issues.apache.org/jira/browse/CB-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378619#comment-16378619 ] ASF GitHub Bot commented on CB-7487: dpeacock commented on issue #81: CB-7487 [Android] Broadcast file write URL: https://github.com/apache/cordova-plugin-file/pull/81#issuecomment-36158 @tvanesse you are correct, my fix was only for writing files as that's all I was using the plug-in for. It would make sense that if you were moving/copying the files the same function I implemented (broadcastNewFile) should be called. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Writing a file doesn't show up on android MTP > - > > Key: CB-7487 > URL: https://issues.apache.org/jira/browse/CB-7487 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-plugin-file >Affects Versions: 3.4.0 > Environment: Nexus 5 and Windows 7 >Reporter: David Peacock >Assignee: Ian Clelland >Priority: Major > > Using the file plug-in to write out a file works, but when you use MTP to > view the file when connected to USB on Windows the file doesn't show up. > The file shows up on the device or through adb. Rebooting the device or > using things to refresh the MTP will have the file appear. This was tested > on multiple Nexus 5 devices on multiple Windows 7 machines. > Cordova should be broadcasting ACTION_MEDIA_SCANNER_SCAN_FILE on the file to > have it appear immediately. > I will be submitting a pull request on the file plug-in for a fix I've tested > and confirmed that resolves this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13923) CordovaResourceApi.java method OpenForReadResult returns a -1 length
[
https://issues.apache.org/jira/browse/CB-13923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378536#comment-16378536
]
ASF GitHub Bot commented on CB-13923:
-
AnthonyWard opened a new pull request #433: CB-13923 (android) fix -1 length
for compressed files
URL: https://github.com/apache/cordova-android/pull/433
*Disclaimer: Please review carefully as i'm not a java developer, I just
squint a bit and pretend it's C#*
### Platforms affected
cordova 8.0.0
cordova-android 7.1.0
cordova-plugin-file 6.0.3
### What does this PR do?
Here are details to recreate the issue:
https://github.com/AnthonyWard/cordova-file-plugin-bug
In `cordova-android` the `CordovaResourceApi.java` > `OpenForReadResult`
method returns a -1 length in for compressed files.
This has a knock on effect to the `cordova-plugin-file` > `Filesystem.java`
> `readFileAtURL` method, causing file corruption as each chunk effectively has
no end.
There is a possible fix in the plugin `cordova-plugin-file` already proposed
https://github.com/apache/cordova-plugin-file/pull/217
https://issues.apache.org/jira/browse/CB-13245?jql=text%20~%20%22CordovaResourceApi%22
Or I propose it could be fixed upstream in `cordova-android`
In the method `OpenForReadResult` there is one path (in the catch) that
leaves the `length` as `-1` causing the defect.
Adding `length = inputStream.available();` in the catch fixes the issue for
me.
### What testing has been done on this change?
Ran unit tests and integration tests locally, which passed.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CordovaResourceApi.java method OpenForReadResult returns a -1 length
>
>
> Key: CB-13923
> URL: https://issues.apache.org/jira/browse/CB-13923
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: cordova 8.0.0
> cordova-android 7.0.0
> cordova-plugin-file 6.0.1
>Reporter: Anthony Ward
>Assignee: Joe Bowser
>Priority: Major
>
> Here are details to recreate:
> [https://github.com/AnthonyWard/cordova-file-plugin-bug]
> In *cordova-android* the CordovaResourceApi.java -> OpenForReadResult method
> returns a -1 length in certain circumstances.
> This has a knock on effect to the *cordova-plugin-file* > Filesystem.java >
> readFileAtURL method, causing file corruption as each chunk effectively has
> no end.
> There is a possible fix in the plugin cordova-plugin-file already proposed
> [https://github.com/apache/cordova-plugin-file/pull/217]
> https://issues.apache.org/jira/browse/CB-13245?jql=text%20~%20%22CordovaResourceApi%22
> Or I propose it could be fixed upstream in cordova-android here:
> [https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaResourceApi.java]
> In the method OpenForReadResult there is one path (in the catch) that leaves
> the length as -1 causing the defect
> try
> {
> assetFd = assetManager.openFd(assetPath);
> inputStream = assetFd.createInputStream(); length = assetFd.getLength();
> }
> catch (FileNotFoundException e)
> {
> // Will occur if the file is compressed.
> inputStream = assetManager.open(assetPath);
> }
> Adding length = inputStream.available(); in the catch fixes the issue for me,
> but I'm not a java developer so can't evaluate if that's a bad idea for
> another reason.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
