[jira] [Commented] (CB-13865) Making CameraPopover for imagePicker bigger on Ipad
[ https://issues.apache.org/jira/browse/CB-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381554#comment-16381554 ] ASF GitHub Bot commented on CB-13865: - alsorokin commented on issue #314: CB-13865: (IOS-Ipad) Making popover Window Size configurable using popoverOptions - imagePicker URL: https://github.com/apache/cordova-plugin-camera/pull/314#issuecomment-369481880 I've restarted the failed jobs and they are green now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Making CameraPopover for imagePicker bigger on Ipad > --- > > Key: CB-13865 > URL: https://issues.apache.org/jira/browse/CB-13865 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Reporter: Ams >Priority: Major > Fix For: Master > > > The popover for imagePicker from gallery is way too small and people complain > about not being able to see images before selecting them. > > The fix is simple: > > Adding this line to willShowViewController method will set it to 960 by 960 > or as big as the screen widht/height > [viewController setPreferredContentSize:CGSizeMake(960,960)]; > It should be added right in the if statement: > if([navigationController isKindOfClass:[UIImagePickerController class]]){ > > HOW CAN I COMMIT THIS CHANGE? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13930) Remove deprecated platforms and plugins from docs
[ https://issues.apache.org/jira/browse/CB-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381368#comment-16381368 ] ASF GitHub Bot commented on CB-13930: - dblotsky commented on a change in pull request #796: CB-13930: removed deprecated platforms and plugins. Removed old apach… URL: https://github.com/apache/cordova-docs/pull/796#discussion_r171435955 ## File path: www/static/plugins/official-plugins.json ## @@ -7,12 +7,11 @@ "cordova-plugin-dialogs", "cordova-plugin-file", "cordova-plugin-geolocation", -"cordova-plugin-globalization", "cordova-plugin-inappbrowser", "cordova-plugin-media", "cordova-plugin-media-capture", -"cordova-plugin-ms-appinsights", "cordova-plugin-network-information", +"cordova-plugin-screen-orientation", "cordova-plugin-splashscreen", "cordova-plugin-statusbar", "cordova-plugin-vibration", Review comment: Should console plugin also be removed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms and plugins from docs > - > > Key: CB-13930 > URL: https://issues.apache.org/jira/browse/CB-13930 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13930) Remove deprecated platforms and plugins from docs
[ https://issues.apache.org/jira/browse/CB-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381371#comment-16381371 ] ASF GitHub Bot commented on CB-13930: - dblotsky commented on a change in pull request #796: CB-13930: removed deprecated platforms and plugins. Removed old apach… URL: https://github.com/apache/cordova-docs/pull/796#discussion_r171435292 ## File path: www/_data/redirects.yml ## @@ -40,6 +40,47 @@ docs: "dev/cordova/plugins/pluginapis.html": "deprecated.html" "latest/cordova/plugins/pluginapis.html": "deprecated.html" +# Removing deprecated platforms and plugins +"dev/guide/platforms/blackberry10/home.html": "deprecated.html" +"latest/guide/platforms/blackberry10/home.html": "deprecated.html" +"dev/guide/platforms/blackberry10/index.html": "deprecated.html" +"latest/guide/platforms/blackberry10/index.html": "deprecated.html" +"dev/guide/platforms/blackberry10/tools.html": "deprecated.html" +"latest/guide/platforms/blackberry10/tools.html": "deprecated.html" +"dev/guide/platforms/blackberry10/config.html": "deprecated.html" +"latest/guide/platforms/blackberry10/config.html": "deprecated.html" +"dev/guide/platforms/blackberry10/plugin.html": "deprecated.html" +"latest/guide/platforms/blackberry10/plugin.html": "deprecated.html" +"dev/guide/platforms/blackberry10/upgrade.html": "deprecated.html" +"latest/guide/platforms/blackberry10/upgrade.html": "deprecated.html" +"dev/guide/platforms/blackberry/upgrade.html": "deprecated.html" +"latest/guide/platforms/blackberry/upgrade.html": "deprecated.html" +"dev/guide/platforms/ubuntu/index.html": "deprecated.html" +"latest/guide/platforms/ubuntu/index.html": "deprecated.html" +"dev/guide/platforms/wp8/home.html": "deprecated.html" +"latest/guide/platforms/wp8/home.html": "deprecated.html" +"dev/guide/platforms/wp8/index.html": "deprecated.html" +"latest/guide/platforms/wp8/index.html": "deprecated.html" +"dev/guide/platforms/wp8/plugin.html": "deprecated.html" +"latest/guide/platforms/wp8/plugin.html": "deprecated.html" +"dev/guide/platforms/wp8/upgrade.html": "deprecated.html" +"latest/guide/platforms/wp8/upgrade.html": "deprecated.html" +"dev/guide/platforms/wp8/parallels.html": "deprecated.html" +"latest/guide/platforms/wp8/parallels.html": "deprecated.html" +"dev/guide/platforms/wp8/vmware.html": "deprecated.html" +"latest/guide/platforms/wp8/vmware.html": "deprecated.html" +"dev/guide/platforms/wp8/webview.html": "deprecated.html" +"latest/guide/platforms/wp8/webview.html": "deprecated.html" + +"latest/reference/cordova-plugin-contacts/index.html": "deprecated.html" +"latest/reference/cordova-plugin-console/index.html": "deprecated.html" +"latest/reference/cordova-plugin-device-motion/index.html": "deprecated.html" +"latest/reference/cordova-plugin-device-orientation/index.html": "deprecated.html" +"latest/reference/cordova-plugin-file-transfer/index.html": "deprecated.html" +"latest/reference/cordova-plugin-globalization/index.html": "deprecated.html" +"latest/reference/cordova-plugin-legacy-whitelist/index.html": "deprecated.html" + + Review comment: Nitpick: extra line. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms and plugins from docs > - > > Key: CB-13930 > URL: https://issues.apache.org/jira/browse/CB-13930 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13930) Remove deprecated platforms and plugins from docs
[ https://issues.apache.org/jira/browse/CB-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381367#comment-16381367 ] ASF GitHub Bot commented on CB-13930: - dblotsky commented on a change in pull request #796: CB-13930: removed deprecated platforms and plugins. Removed old apach… URL: https://github.com/apache/cordova-docs/pull/796#discussion_r171435722 ## File path: www/contribute/index.html ## @@ -55,7 +55,7 @@ {{ projectType.title }} {% for project in projectType.projects %} {% if firstProjectType and forloop.first %} -{% assign itemClass = "first" %} +{% assign itemClass = "" %} Review comment: Why this change? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms and plugins from docs > - > > Key: CB-13930 > URL: https://issues.apache.org/jira/browse/CB-13930 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13930) Remove deprecated platforms and plugins from docs
[ https://issues.apache.org/jira/browse/CB-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381370#comment-16381370 ] ASF GitHub Bot commented on CB-13930: - dblotsky commented on a change in pull request #796: CB-13930: removed deprecated platforms and plugins. Removed old apach… URL: https://github.com/apache/cordova-docs/pull/796#discussion_r171440544 ## File path: www/_data/toc/en_dev-src.yml ## @@ -55,22 +50,16 @@ children: - url: reference/cordova-plugin-battery-status/index.html - url: reference/cordova-plugin-camera/index.html -- url: reference/cordova-plugin-console/index.html Review comment: Should this one also have gotten removed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms and plugins from docs > - > > Key: CB-13930 > URL: https://issues.apache.org/jira/browse/CB-13930 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13930) Remove deprecated platforms and plugins from docs
[ https://issues.apache.org/jira/browse/CB-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381369#comment-16381369 ] ASF GitHub Bot commented on CB-13930: - dblotsky commented on a change in pull request #796: CB-13930: removed deprecated platforms and plugins. Removed old apach… URL: https://github.com/apache/cordova-docs/pull/796#discussion_r171440372 ## File path: www/_data/fetched-files.yml ## @@ -29,41 +29,13 @@ commit: "master" dest: path: "reference/cordova-plugin-camera/index.md" -- -src: -repoName: "apache/cordova-plugin-console" -packageName: "cordova-plugin-console" -commit: "master" -dest: -path: "reference/cordova-plugin-console/index.md" Review comment: Should this one have gotten removed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms and plugins from docs > - > > Key: CB-13930 > URL: https://issues.apache.org/jira/browse/CB-13930 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13927) Modified xcodeProjDir to filter out files/folders that contain "._"
[ https://issues.apache.org/jira/browse/CB-13927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381338#comment-16381338 ] ASF GitHub Bot commented on CB-13927: - shazron commented on a change in pull request #355: CB-13927 - Modified xcodeProjDir to filter out files/folders that contain "._" URL: https://github.com/apache/cordova-ios/pull/355#discussion_r171154623 ## File path: bin/templates/scripts/cordova/Api.js ## @@ -64,7 +64,17 @@ function Api (platform, platformRootDir, events) { var xcodeCordovaProj; try { -xcodeProjDir = fs.readdirSync(this.root).filter(function (e) { return e.match(/\.xcodeproj$/i); })[0]; + +var xcodeProjDir_array = fs.readdirSync(this.root).filter(function (e) { return e.match(/\.xcodeproj$/i); }); +if (xcodeProjDir_array.length > 1) { +for (var x = 0; x < xcodeProjDir_array.length; x++) { +if (xcodeProjDir_array[x].substring(0, 2) === '._') { +xcodeProjDir_array.splice(x, 1); +} +} +} +xcodeProjDir = xcodeProjDir_array[0]; + Review comment: Thanks! I think this would be more efficient and clearer, what do you think? ```javascript var xcodeProjDir_array = fs .readdirSync(this.root) .filter(function (elem) { // match .xcodeproj, and not start with '._' return elem.match(/\.xcodeproj$/i) && (elem.substring(0, 2) !== '._'); }) xcodeProjDir = xcodeProjDir_array[0]; ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Modified xcodeProjDir to filter out files/folders that contain "._" > --- > > Key: CB-13927 > URL: https://issues.apache.org/jira/browse/CB-13927 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > I ran into an issue trying to add an ios plugin using a virtual machine. The > code would return an array for the xcodeProjDir and then of course use the > wrong one. It would use the one starting with "._ProjectName" which I believe > is an MacOS hidden folder. I attempted to install the plugin on OsX but > because it's a virtual machine it still had those hidden folders. I've made > it so that it will filter those out while looking for the proper xCode > project folder. > h3. *Platforms affected* > Windows (host) / OSx (guest) virtual machines > h3. *What does this PR do?* > Fixes a folder issue. Before it would try to use an incorrect folder for the > xCode project. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13927) Modified xcodeProjDir to filter out files/folders that contain "._"
[ https://issues.apache.org/jira/browse/CB-13927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381337#comment-16381337 ] ASF GitHub Bot commented on CB-13927: - shazron commented on a change in pull request #355: CB-13927 - Modified xcodeProjDir to filter out files/folders that contain "._" URL: https://github.com/apache/cordova-ios/pull/355#discussion_r171154623 ## File path: bin/templates/scripts/cordova/Api.js ## @@ -64,7 +64,17 @@ function Api (platform, platformRootDir, events) { var xcodeCordovaProj; try { -xcodeProjDir = fs.readdirSync(this.root).filter(function (e) { return e.match(/\.xcodeproj$/i); })[0]; + +var xcodeProjDir_array = fs.readdirSync(this.root).filter(function (e) { return e.match(/\.xcodeproj$/i); }); +if (xcodeProjDir_array.length > 1) { +for (var x = 0; x < xcodeProjDir_array.length; x++) { +if (xcodeProjDir_array[x].substring(0, 2) === '._') { +xcodeProjDir_array.splice(x, 1); +} +} +} +xcodeProjDir = xcodeProjDir_array[0]; + Review comment: Thanks! I think this would be more efficient and clearer, what do you think?: ```javascript var xcodeProjDir_array = fs .readdirSync(this.root) .filter(function (elem) { // match .xcodeproj, and not start with '._' return elem.match(/\.xcodeproj$/i) && (elem.substring(0, 2) !== '._'); }) xcodeProjDir = xcodeProjDir_array[0]; ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Modified xcodeProjDir to filter out files/folders that contain "._" > --- > > Key: CB-13927 > URL: https://issues.apache.org/jira/browse/CB-13927 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > I ran into an issue trying to add an ios plugin using a virtual machine. The > code would return an array for the xcodeProjDir and then of course use the > wrong one. It would use the one starting with "._ProjectName" which I believe > is an MacOS hidden folder. I attempted to install the plugin on OsX but > because it's a virtual machine it still had those hidden folders. I've made > it so that it will filter those out while looking for the proper xCode > project folder. > h3. *Platforms affected* > Windows (host) / OSx (guest) virtual machines > h3. *What does this PR do?* > Fixes a folder issue. Before it would try to use an incorrect folder for the > xCode project. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13930) Remove deprecated platforms and plugins from docs
[ https://issues.apache.org/jira/browse/CB-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381335#comment-16381335 ] ASF GitHub Bot commented on CB-13930: - stevengill opened a new pull request #796: CB-13930: removed deprecated platforms and plugins. Removed old apach… URL: https://github.com/apache/cordova-docs/pull/796 …e links ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove deprecated platforms and plugins from docs > - > > Key: CB-13930 > URL: https://issues.apache.org/jira/browse/CB-13930 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381242#comment-16381242 ] ASF GitHub Bot commented on CB-13924: - dblotsky commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369422687 I kind of assumed that people would run `gulp` and `gulp --tasks`, or read `gulpfile.js` to see what controls what in the build. However, I agree that a text-based or graphical explanation might be useful as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381239#comment-16381239 ] ASF GitHub Bot commented on CB-13924: - dblotsky commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369422254 @janpio @stevengill that's the correct file: https://github.com/apache/cordova-docs/blob/master/www/_data/fetched-files.yml. When you run `gulp fetch`, the files listed in that file get downloaded to `dev/en/{file dest}`. You can see more of this by running `node ./tools/bin/fetch_docs.js`. Maybe we can put together a flowchart of the build process as it is right now. Would that help you guys? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[ https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381225#comment-16381225 ] ASF GitHub Bot commented on CB-13925: - dblotsky commented on issue #793: [CB-13925] Making file fetch happen on every build. URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369420298 @janpio got it. In general, it's unlikely that details like these will ever be documented because they're in code, and they change. I can e-meet with you to give you a full exposé of the codebase (it's not that much, actually). Might you find that helpful? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Files in www/docs/en/dev/reference are not fetched on every build. > -- > > Key: CB-13925 > URL: https://issues.apache.org/jira/browse/CB-13925 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Dmitry Blotsky >Priority: Major > > Some files in the docs are downloaded from external sources, into > {{www/docs/en/dev/reference}}. The files and their sources are defined in > {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp > fetch}} task, which runs on every build. > Expected behaviour: the files are fetched every time the command runs. > Actual behaviour: the files are only fetched if the > {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is > skipped every time after the first time. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13931) Remove translations from cordova docs site
Steve Gill created CB-13931: --- Summary: Remove translations from cordova docs site Key: CB-13931 URL: https://issues.apache.org/jira/browse/CB-13931 Project: Apache Cordova Issue Type: Task Components: cordova-docs Reporter: Steve Gill -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13930) Remove deprecated platforms and plugins from docs
Steve Gill created CB-13930: --- Summary: Remove deprecated platforms and plugins from docs Key: CB-13930 URL: https://issues.apache.org/jira/browse/CB-13930 Project: Apache Cordova Issue Type: Task Components: cordova-docs Reporter: Steve Gill Assignee: Steve Gill -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380609#comment-16380609 ] ASF GitHub Bot commented on CB-13415: - ShemrickFlannigan commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-369295275 @shazron +1 For this fix; it solves several issues that we're experiencing with corrupt and/or large images. Requesting a review of this Pull Request for a merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380536#comment-16380536 ] Gandhirajan commented on CB-13400: -- Correctness of "installing-a-development-environment.md" is taken care for windows. > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13718) element scrolling in ios
[ https://issues.apache.org/jira/browse/CB-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13718. - Resolution: Invalid The issue looks like WebView issues and it's not very clear what the problems are. Asked for sample project and wasn't provided after two months, so closing. Feel free to reopen if you can provide examples. > element scrolling in ios > > > Key: CB-13718 > URL: https://issues.apache.org/jira/browse/CB-13718 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 > Environment: cordova-ios 4.4 > ios 10.3 >Reporter: Crab >Priority: Major > > for add scroll momentum effect , i add "-webkit-overflow-scrolling:touch;" > to style. > but the scroll also added scroll over the boundery. so i googled and tried > add preference to config.xm. like. > webviewbounce = false , UIWebViewBounce=false , is only effect to the whole > document , not the element. > It also had color #00 background and i can't change the color anywhere. > The second bug is , when i add "-webkit-overflow-scrolling:touch;" the > element receive the touch event above this element. top element have hider > z-index , and have opacity , can see the scroll element below it. where i > touch top element and scroll , the scroll element below it , can scroll by > the touchmove event, and i can not prevent this event anywhere. > the third bug is , when i touch the scroll element , the touch point is that > the scroll started , not correct moving point . -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13436) [ERROR] An error occurred while running cordova plugin add cordova-plugin-statusbar --save (exit code 1)
[ https://issues.apache.org/jira/browse/CB-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13436. - Resolution: Cannot Reproduce I can't reproduce with current tooling. Might be an npm issue or Ionic issue. Closing. > [ERROR] An error occurred while running cordova plugin add > cordova-plugin-statusbar --save (exit code 1) > > > Key: CB-13436 > URL: https://issues.apache.org/jira/browse/CB-13436 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-statusbar > Environment: OSX, Bash, Ionic CLI >Reporter: Daniel Benton >Priority: Major > Original Estimate: 24h > Remaining Estimate: 24h > > [ERROR] An error occurred while running cordova plugin add > cordova-plugin-statusbar --save (exit code 1): > > Error: Failed to fetch plugin > git+https://github.com/apache/cordova-plugin-statusbar.git via > registry. > Probably this is either a connection problem, or plugin spec is > incorrect. > Check your connection and plugin name/version/URL. > Failed to get absolute path to installed module -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12448) Can't use plugins when running on OSX
[ https://issues.apache.org/jira/browse/CB-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-12448. - Resolution: Fixed see last comment > Can't use plugins when running on OSX > - > > Key: CB-12448 > URL: https://issues.apache.org/jira/browse/CB-12448 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins, cordova-osx >Affects Versions: 4.0.1 > Environment: OSX 10.10.5 >Reporter: Dave Murray-Rust >Assignee: Kerri Shotts >Priority: Blocker > > I can't use any plugins so far when I deploy on OSX. I have tried > cordova-plugin-file, cordova-plugin-camera and cordova-plugin-bluetoothle. > In each case, it works fine on Android, but fails on OSX with a message like > "10/02/2017 15:03:28.056 HelloWorld[15580]: ERROR: Plugin 'File' not found, > or is not a CDVPlugin. Check your plugin mapping in config.xml." > I'm using the command line. I have tried removing all the platforms and > adding them again. I am running with "cordova run osx". > I'm not sure what version of cordova I have - I installed using 'npm install > -g cordova'. 'cordova version' reports 6.5.0, but that version does not seem > to exist in the dropdown above. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13596) Installation of scoped plugin also installs conflicting unscoped plugin with same name
[ https://issues.apache.org/jira/browse/CB-13596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13596: Component/s: (was: AllPlugins) cordova-cli > Installation of scoped plugin also installs conflicting unscoped plugin with > same name > -- > > Key: CB-13596 > URL: https://issues.apache.org/jira/browse/CB-13596 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli >Affects Versions: cordova@7.1.0 >Reporter: Marian Hello >Priority: Major > > if there is unscoped package with same name as scoped package, both will be > installed. > As result you will end up with two (potentially conflicting) packages. > How to reproduce: > 1. create new cordova project: > cordova create myApp org.apache.cordova.myApp myApp > 2. add plaftofm > cordova platform add android > 3. install scoped package: > cordova plugin add > @mauron85/cordova-plugin-background-geolocation@3.0.0-alpha.4 > Expected Behavior > Only single package @mauron85/cordova-plugin-background-geolocation will be > installed > Actual Behaviour > Two packages will get installed: > 1. @mauron85/cordova-plugin-background-geolocation - > https://www.npmjs.com/package/@mauron85/cordova-plugin-background-geolocation > 2. cordova-plugin-background-geolocation - > https://www.npmjs.com/package/cordova-plugin-background-geolocation > They are completely different and incompatible. As result cordova project > won't compile. > Console output: > Installing "cordova-plugin-background-geolocation" for android > Installing "cordova-plugin-geolocation" for android > Installing "cordova-plugin-dialogs" for android > Adding @mauron85/cordova-plugin-background-geolocation to package.json > Saved plugin info for "@mauron85/cordova-plugin-background-geolocation" to > config.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13683) cordova-plugin-media-capture: Rotates pictures in android devices
[ https://issues.apache.org/jira/browse/CB-13683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13683: Component/s: (was: AllPlugins) cordova-plugin-media-capture > cordova-plugin-media-capture: Rotates pictures in android devices > -- > > Key: CB-13683 > URL: https://issues.apache.org/jira/browse/CB-13683 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media-capture > Environment: Plugin name: cordova-plugin-media-capture > Version: 2.0.0 > Used in: Ionic project > Device: Samsung Galaxy J3 >Reporter: hsob >Priority: Critical > > When I take picture using device camera (cordova-plugin-media-capture), the > result is a rotated picture in all tested devices using android. But in iOS > devices these is not issue. > How can I fixe this? > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13718) element scrolling in ios
[ https://issues.apache.org/jira/browse/CB-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13718: Component/s: (was: AllComponents) cordova-ios > element scrolling in ios > > > Key: CB-13718 > URL: https://issues.apache.org/jira/browse/CB-13718 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 > Environment: cordova-ios 4.4 > ios 10.3 >Reporter: Crab >Priority: Major > > for add scroll momentum effect , i add "-webkit-overflow-scrolling:touch;" > to style. > but the scroll also added scroll over the boundery. so i googled and tried > add preference to config.xm. like. > webviewbounce = false , UIWebViewBounce=false , is only effect to the whole > document , not the element. > It also had color #00 background and i can't change the color anywhere. > The second bug is , when i add "-webkit-overflow-scrolling:touch;" the > element receive the touch event above this element. top element have hider > z-index , and have opacity , can see the scroll element below it. where i > touch top element and scroll , the scroll element below it , can scroll by > the touchmove event, and i can not prevent this event anywhere. > the third bug is , when i touch the scroll element , the touch point is that > the scroll started , not correct moving point . -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13194) Http Requests and Same Origin Policy Problems on mobile devices
[ https://issues.apache.org/jira/browse/CB-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13194: Component/s: (was: AllComponents) cordova-android > Http Requests and Same Origin Policy Problems on mobile devices > --- > > Key: CB-13194 > URL: https://issues.apache.org/jira/browse/CB-13194 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 >Reporter: Michael Burger >Priority: Major > Labels: security > > As so many others I have the problem with a RESTful service we are calling. > This service as so many others has an ORIGIN check. Using Cordova & Ionic > doing the request from android app set the origin to file:// which is good > for browser cors check but not good for the service, they doesn't allow this > schema for origin. As others the allow only empty origin or the same origin. > On many posts I read the wrote you can handle this with whitelist plugin or > with CSP. But I think this absolutly incorrect. With whitelist you can not > work on the origin header and CSP has nothing to do with it. > So the last few days I spend hundreds of hours and googled and tested > different solutions and different plugins. But the solution is not there and > not simple. > At the moment I'm testing cordova plugins for http and websocket requests, to > do native http and websocket calls, this is working great for the SOP problem > but there are some problems with cookies. > I tryied to found a solution on a Custom WebView where we can elimante the > Origin header from request but this was to difficult for us. > Can someone help on this problem? > I'm not the only guy which has to call a SOP protected resource over the > internet from a mobile hybrid app. Why there is no simple solution for it? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13436) [ERROR] An error occurred while running cordova plugin add cordova-plugin-statusbar --save (exit code 1)
[ https://issues.apache.org/jira/browse/CB-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13436: Component/s: (was: AllPlatforms) (was: AllComponents) > [ERROR] An error occurred while running cordova plugin add > cordova-plugin-statusbar --save (exit code 1) > > > Key: CB-13436 > URL: https://issues.apache.org/jira/browse/CB-13436 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-statusbar > Environment: OSX, Bash, Ionic CLI >Reporter: Daniel Benton >Priority: Major > Original Estimate: 24h > Remaining Estimate: 24h > > [ERROR] An error occurred while running cordova plugin add > cordova-plugin-statusbar --save (exit code 1): > > Error: Failed to fetch plugin > git+https://github.com/apache/cordova-plugin-statusbar.git via > registry. > Probably this is either a connection problem, or plugin spec is > incorrect. > Check your connection and plugin name/version/URL. > Failed to get absolute path to installed module -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13436) [ERROR] An error occurred while running cordova plugin add cordova-plugin-statusbar --save (exit code 1)
[ https://issues.apache.org/jira/browse/CB-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13436: Component/s: cordova-plugin-statusbar > [ERROR] An error occurred while running cordova plugin add > cordova-plugin-statusbar --save (exit code 1) > > > Key: CB-13436 > URL: https://issues.apache.org/jira/browse/CB-13436 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-statusbar > Environment: OSX, Bash, Ionic CLI >Reporter: Daniel Benton >Priority: Major > Original Estimate: 24h > Remaining Estimate: 24h > > [ERROR] An error occurred while running cordova plugin add > cordova-plugin-statusbar --save (exit code 1): > > Error: Failed to fetch plugin > git+https://github.com/apache/cordova-plugin-statusbar.git via > registry. > Probably this is either a connection problem, or plugin spec is > incorrect. > Check your connection and plugin name/version/URL. > Failed to get absolute path to installed module -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12670) Clean up Apache Cordova JIRA
[ https://issues.apache.org/jira/browse/CB-12670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) closed CB-12670. --- Resolution: Fixed > Clean up Apache Cordova JIRA > > > Key: CB-12670 > URL: https://issues.apache.org/jira/browse/CB-12670 > Project: Apache Cordova > Issue Type: Wish > Components: AllComponents >Reporter: Jan Piotrowski (Sujan) >Priority: Minor > Labels: jira > > or: Make Apache Cordova JIRA usable again! > I was complaining about the Cordova JIRA on Slack today, wondering how great > the world would be if Cordova used GitHub issues. Then I noticed that this > was not very productive as it seems there is no way to achieve this. > So I actually looked at the Cordova JIRA a bit and tried to find ways how it > could actually be improved: > *Speed* > - Why is everything so slow? Any way to speed it up? > *Menu: Summary* > https://issues.apache.org/jira/browse/CB/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel > - Remove or update versions if not used > *Menu: Issues* > https://issues.apache.org/jira/browse/CB/?selectedItem=com.atlassian.jirafisheyeplugin:fisheye-projectpanel=statistics=com.atlassian.jira.jira-projects-plugin:issues-panel > - Declutter "Unresolved: By Assignee" by unassigning Issues with no updates > in last 6 months > - "Unresolved: By Version" is pretty useless because of plugin versions > (1.4.0 of what?) > *Menu: Roadmap* > https://issues.apache.org/jira/browse/CB/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel > https://issues.apache.org/jira/browse > Menu: Changelogs > /CB/?selectedTab=com.atlassian.jira.jira-projects-plugin:changelog-panel > - Remove or update versions > - If versions, roadmap or changelogs are not used, remove menu link > completely (Same for Component overview pages) > *Menu: Versions* > https://issues.apache.org/jira/browse/CB?selectedTab=com.atlassian.jira.jira-projects-plugin:versions-panel=-1 > - Sorting? > - Missing descriptions > - Missing release dates for so many versions > - Unclear names > *Menu: Components* > https://issues.apache.org/jira/browse/CB/?selectedTab=com.atlassian.jira.jira-projects-plugin:components-panel=-1 > - Missing descriptions > *Header* > - Why all this unrelevant (to Cordova) stuff? > - Getting from an issue to the Project summary is... "easy" but unexpected if > you don't know yet. > Any way to help? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13440) Improve "Using Flags" for iOS
[ https://issues.apache.org/jira/browse/CB-13440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380485#comment-16380485 ] Jan Piotrowski (Sujan) commented on CB-13440: - I have to close a few tabs, so here are the ones I think were related to this: https://dpogue.ca/articles/cordova-xcode8.html https://pewpewthespells.com/blog/migrating_code_signing.html#signing-in-xcode-8 > Improve "Using Flags" for iOS > - > > Key: CB-13440 > URL: https://issues.apache.org/jira/browse/CB-13440 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Table could use some improvement: > - Formatting of descriptions > - Order of lines -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13922) sim launch force-fully exits process
[ https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380475#comment-16380475 ] ASF GitHub Bot commented on CB-13922: - shazron commented on issue #357: CB-13922 - remove exit for start sim URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369276355 @hosseinamin as I already said, this PR will not get in because it changes the default behaviour, which is to exit after running the simulator. If you want it to not exit per your requirements, you have to add the flag as a feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > sim launch force-fully exits process > > > Key: CB-13922 > URL: https://issues.apache.org/jira/browse/CB-13922 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 >Reporter: Hossein Amin >Assignee: Shazron Abdullah >Priority: Trivial > Labels: pull-request-available > Original Estimate: 2h > Remaining Estimate: 2h > > Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator. > I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim > {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' + > target, logPath, '--exit');}} > > This call is made inside main process, Where request for exit will end main > process with no chance to catch it. > > I assume this call returns a promise for when launch was successful, If that > can happen. > Things will go smoothly after that. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380336#comment-16380336 ] ASF GitHub Bot commented on CB-13415: - LiDhaval commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-369246465 @jcesarmobile Please check if you got some free time this weekend. I have tested this and working fine for me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13929) duplicate entry: android/support/v13/view/DragStartHelper$OnDragStartListener.class
[ https://issues.apache.org/jira/browse/CB-13929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Ramos updated CB-13929: -- Description: Hello Cordova team. Today I've launched my app build in Jenkins as always, and it gives me the following error: {code:java} ... Note: Recompile with -Xlint:unchecked for details. :compileArmv7DebugNdk UP-TO-DATE :compileArmv7DebugSources :transformClassesWithJarMergingForArmv7Debug FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':transformClassesWithJarMergingForArmv7Debug'. > com.android.build.api.transform.TransformException: > java.util.zip.ZipException: duplicate entry: > android/support/v13/view/DragStartHelper$OnDragStartListener.class {code} I've been investigating what could have caused this issue, and the only thing that I can find that is different from previous builds, is an update that Cordova did over support-v4. Here is the log diff: [https://gist.github.com/DanielRamosAcosta/29f3223c3b8f96447814122bfc193f08] Cordova version & plugins: {code} "dependencies": { "cordova": "^7.1.0", "cordova-android": "^6.4.0", "cordova-plugin-android-permissions": "^1.0.0", "cordova-plugin-crosswalk-webview": "^2.3.0", "cordova-plugin-dbmeter": "^2.1.0", "cordova-plugin-screen-orientation": "^3.0.1", "cordova-plugin-statusbar": "^2.4.1", "cordova-plugin-whitelist": "^1.3.3", "cordova-plugin-x-socialsharing": "^5.2.1", "es6-promise-plugin": "^4.1.1" }, {code} was: Hello Cordova team. Today I've launched my app build in Jenkins as always, and it gives me the following error: {code} ... Note: Recompile with -Xlint:unchecked for details. :compileArmv7DebugNdk UP-TO-DATE :compileArmv7DebugSources :transformClassesWithJarMergingForArmv7Debug FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':transformClassesWithJarMergingForArmv7Debug'. > com.android.build.api.transform.TransformException: > java.util.zip.ZipException: duplicate entry: > android/support/v13/view/DragStartHelper$OnDragStartListener.class {code} I've been investigating what could have caused this issue, and the only thing that I can find that is different from previous builds, is an update that Cordova did over support-v4. Here is the log diff: [https://gist.github.com/DanielRamosAcosta/29f3223c3b8f96447814122bfc193f08] > duplicate entry: > android/support/v13/view/DragStartHelper$OnDragStartListener.class > --- > > Key: CB-13929 > URL: https://issues.apache.org/jira/browse/CB-13929 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 >Reporter: Daniel Ramos >Assignee: Joe Bowser >Priority: Major > > Hello Cordova team. > > Today I've launched my app build in Jenkins as always, and it gives me the > following error: > > {code:java} > ... > Note: Recompile with -Xlint:unchecked for details. > :compileArmv7DebugNdk UP-TO-DATE > :compileArmv7DebugSources > :transformClassesWithJarMergingForArmv7Debug FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':transformClassesWithJarMergingForArmv7Debug'. > > com.android.build.api.transform.TransformException: > java.util.zip.ZipException: duplicate entry: > android/support/v13/view/DragStartHelper$OnDragStartListener.class > {code} > I've been investigating what could have caused this issue, and the only thing > that I can find that is different from previous builds, is an update that > Cordova did over support-v4. > Here is the log diff: > [https://gist.github.com/DanielRamosAcosta/29f3223c3b8f96447814122bfc193f08] > Cordova version & plugins: > {code} > "dependencies": { > "cordova": "^7.1.0", > "cordova-android": "^6.4.0", > "cordova-plugin-android-permissions": "^1.0.0", > "cordova-plugin-crosswalk-webview": "^2.3.0", > "cordova-plugin-dbmeter": "^2.1.0", > "cordova-plugin-screen-orientation": "^3.0.1", > "cordova-plugin-statusbar": "^2.4.1", > "cordova-plugin-whitelist": "^1.3.3", > "cordova-plugin-x-socialsharing": "^5.2.1", > "es6-promise-plugin": "^4.1.1" > }, > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13929) duplicate entry: android/support/v13/view/DragStartHelper$OnDragStartListener.class
Daniel Ramos created CB-13929: - Summary: duplicate entry: android/support/v13/view/DragStartHelper$OnDragStartListener.class Key: CB-13929 URL: https://issues.apache.org/jira/browse/CB-13929 Project: Apache Cordova Issue Type: Bug Components: cordova-android Affects Versions: cordova@7.0.0 Reporter: Daniel Ramos Assignee: Joe Bowser Hello Cordova team. Today I've launched my app build in Jenkins as always, and it gives me the following error: {code} ... Note: Recompile with -Xlint:unchecked for details. :compileArmv7DebugNdk UP-TO-DATE :compileArmv7DebugSources :transformClassesWithJarMergingForArmv7Debug FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':transformClassesWithJarMergingForArmv7Debug'. > com.android.build.api.transform.TransformException: > java.util.zip.ZipException: duplicate entry: > android/support/v13/view/DragStartHelper$OnDragStartListener.class {code} I've been investigating what could have caused this issue, and the only thing that I can find that is different from previous builds, is an update that Cordova did over support-v4. Here is the log diff: [https://gist.github.com/DanielRamosAcosta/29f3223c3b8f96447814122bfc193f08] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13922) sim launch force-fully exits process
[ https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380182#comment-16380182 ] ASF GitHub Bot commented on CB-13922: - hosseinamin commented on issue #357: CB-13922 - remove exit for start sim URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369218465 @shazron i don't know much about it. In my view this command exits after running simulator is ok. Unless cordova-plugin-browsersync is installed and has `-- --live-reload` ``` cordova emulate ios --target="iPhone-7, 11.2" ``` If this exists i don't see in issue with it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > sim launch force-fully exits process > > > Key: CB-13922 > URL: https://issues.apache.org/jira/browse/CB-13922 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 >Reporter: Hossein Amin >Assignee: Shazron Abdullah >Priority: Trivial > Labels: pull-request-available > Original Estimate: 2h > Remaining Estimate: 2h > > Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator. > I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim > {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' + > target, logPath, '--exit');}} > > This call is made inside main process, Where request for exit will end main > process with no chance to catch it. > > I assume this call returns a promise for when launch was successful, If that > can happen. > Things will go smoothly after that. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13922) sim launch force-fully exits process
[ https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380181#comment-16380181 ] ASF GitHub Bot commented on CB-13922: - hosseinamin commented on issue #357: CB-13922 - remove exit for start sim URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369218465 i don't know much about it. In my view this command exits after running simulator is ok. Unless cordova-plugin-browsersync is installed and has `-- --live-reload` ``` cordova emulate ios --target="iPhone-7, 11.2" ``` If this exists i don't see in issue with it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > sim launch force-fully exits process > > > Key: CB-13922 > URL: https://issues.apache.org/jira/browse/CB-13922 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 >Reporter: Hossein Amin >Assignee: Shazron Abdullah >Priority: Trivial > Labels: pull-request-available > Original Estimate: 2h > Remaining Estimate: 2h > > Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator. > I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim > {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' + > target, logPath, '--exit');}} > > This call is made inside main process, Where request for exit will end main > process with no chance to catch it. > > I assume this call returns a promise for when launch was successful, If that > can happen. > Things will go smoothly after that. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[ https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380092#comment-16380092 ] ASF GitHub Bot commented on CB-13925: - janpio commented on issue #793: [CB-13925] Making file fetch happen on every build. URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369191892 Yes, just tried to understand on what "scope" this change affects the docs (as it is all undocumented). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Files in www/docs/en/dev/reference are not fetched on every build. > -- > > Key: CB-13925 > URL: https://issues.apache.org/jira/browse/CB-13925 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Dmitry Blotsky >Priority: Major > > Some files in the docs are downloaded from external sources, into > {{www/docs/en/dev/reference}}. The files and their sources are defined in > {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp > fetch}} task, which runs on every build. > Expected behaviour: the files are fetched every time the command runs. > Actual behaviour: the files are only fetched if the > {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is > skipped every time after the first time. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13928) Clean up /tools/bin and /tools/lib
[ https://issues.apache.org/jira/browse/CB-13928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13928: Summary: Clean up /tools/bin and /tools/lib (was: Clean up /tools/bin) > Clean up /tools/bin and /tools/lib > -- > > Key: CB-13928 > URL: https://issues.apache.org/jira/browse/CB-13928 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > There seem to be quite some tools and scripts that are not in use anymore: > https://github.com/apache/cordova-docs/tree/master/tools/bin -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13928) Clean up /tools/bin and /tools/lib
[ https://issues.apache.org/jira/browse/CB-13928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13928: Description: There seem to be quite some tools and scripts that are not in use anymore: https://github.com/apache/cordova-docs/tree/master/tools/bin https://github.com/apache/cordova-docs/tree/master/tools/lib Removing the unused stuff could greatly reduce the complexity there. was: There seem to be quite some tools and scripts that are not in use anymore: https://github.com/apache/cordova-docs/tree/master/tools/bin > Clean up /tools/bin and /tools/lib > -- > > Key: CB-13928 > URL: https://issues.apache.org/jira/browse/CB-13928 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > There seem to be quite some tools and scripts that are not in use anymore: > https://github.com/apache/cordova-docs/tree/master/tools/bin > https://github.com/apache/cordova-docs/tree/master/tools/lib > Removing the unused stuff could greatly reduce the complexity there. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13928) Clean up /tools/bin
Jan Piotrowski (Sujan) created CB-13928: --- Summary: Clean up /tools/bin Key: CB-13928 URL: https://issues.apache.org/jira/browse/CB-13928 Project: Apache Cordova Issue Type: Improvement Components: cordova-docs Reporter: Jan Piotrowski (Sujan) There seem to be quite some tools and scripts that are not in use anymore: https://github.com/apache/cordova-docs/tree/master/tools/bin -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13924) Create cordova 8 for docs
[ https://issues.apache.org/jira/browse/CB-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380074#comment-16380074 ] ASF GitHub Bot commented on CB-13924: - janpio commented on issue #791: CB-13924: added version 8 of docs URL: https://github.com/apache/cordova-docs/pull/791#issuecomment-369188310 Yeah, I thought so as well but couldn't figure out in a few minutes how to do this - so I commented on the first appearance of the "wrong" files/links. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create cordova 8 for docs > - > > Key: CB-13924 > URL: https://issues.apache.org/jira/browse/CB-13924 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Cordova docs is still set to 7. I'm going to upgrade it to 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380044#comment-16380044 ] Marc Bornträger commented on CB-12242: -- Is there an update on this? I would love to see the mentioned cordova plugins using yarn as well! At the moment it is always a package-lock.json file generated for me when I do something with these cordava plugins. It's really annoying... > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org